Bitcoin Forum

Bitcoin => Armory => Topic started by: etotheipi on October 29, 2015, 04:53:17 PM



Title: Armory 0.93.3 with BIP62 compliance
Post by: etotheipi on October 29, 2015, 04:53:17 PM
Armory 0.93.3 with BIP62 Released

Download links below, but as always, please use the secure downloader within Armory under "Help"-->"Update Software" or on the Announcements tab on the main screen.



Implemented low S-value signatures to work with Core 0.11+:
Armory now implements all components of BIP62 compliance in its signing code. Also includes a correction path to fix non-compliant signatures when broadcasting transactions signed by older versions of Armory. Thus, offline systems do not need to be updated, as long as the online system is.

Critical Bug Fix: "bitcoin:" URI handling of Multisig/P2SH addresses:
The code that handles clicking on a "bitcoin:" link outside Armory was improperly handling Multisig/P2SH addresses, and would prefill a valid but incorrect address.

Transaction confirmation fix:
The number of confirmations was not being calculated properly for fee estimation in some contexts.

No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.

(OSX support re-added)





  Armory 0.93.3 for Windows XP, Vista, 7, 8+ (64-bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_winAll.exe)

  Armory 0.93.3 for MacOSX 10.7+ (64bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_osx.tar.gz)
  
  Armory 0.93.3 for Ubuntu 12.04+ (32bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_ubuntu-32bit.deb)
  Armory 0.93.3 for Ubuntu 12.04+ (64bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_ubuntu-64bit.deb)

  Armory 0.93.3 for RaspberryPi  (armhf) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_raspbian-armhf.tar.gz)
  
  Armory 0.93.3 Offline Bundle for Ubuntu 12.04 exact (32bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_offline_ubuntu_12.04-32.tar.gz)
  Armory 0.93.3 Offline Bundle for Ubuntu 12.04 exact (64bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_offline_ubuntu_12.04-64.tar.gz)
  Armory 0.93.3 Offline Bundle for RaspberryPi  (armhf) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_rpi_bundle.tar.gz)
  Armory 0.93.3: Signed hashes of all installers  (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_sha256sum.txt.asc)




Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: cypherdoc on October 29, 2015, 05:16:50 PM
ty

hope you're okay


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: pf on October 29, 2015, 06:25:34 PM
No more support for Mac/OSX:
That's pity. This begs the question:

Can I copy my existing 56 GB data for Bitcoin Core and 49 GB data for Armory from my Mac to Linux and continue using it seamlessly? Downloading the whole thing again just because I moved to Linux would be very painful for me.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on October 29, 2015, 06:31:51 PM
That's pity. This begs the question:

Can I copy my existing 56 GB data for Bitcoin Core and 49 GB data for Armory from my Mac to Linux and continue using it seamlessly? Downloading the whole thing again just because I moved to Linux would be very painful for me.

You should be able to.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitpop on October 29, 2015, 11:02:08 PM
Thank you


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Plento on October 30, 2015, 04:25:32 AM
Fan-freaking-tastic.

Thank you!


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: picobit on October 30, 2015, 06:53:56 PM
No more support for Mac/OSX:
That's pity. This begs the question:

Can I copy my existing 56 GB data for Bitcoin Core and 49 GB data for Armory from my Mac to Linux and continue using it seamlessly? Downloading the whole thing again just because I moved to Linux would be very painful for me.
I am trying to do just that.  Copied Bitcoin Core's stuff onto a virtual Linux machine on my Mac, and started bitcoin-qt on the virtual machine yesterday evening.  It does not redownload the blockchain, but it does reverify it.  Has been running for 11 hours so far, judging from the rate it crunches blocks according to the log file, it will finish within 12-24 hours :(

I am not going to move Armory's stuff over to the VM, instead I plan on letting it rescan the blockchain.  It would probably to that anyway, and it did not use to be too slow.  I will report back tomorrow.

It is disappointing that Mac support has been dropped, but considering how badly Qt is supported on Mac, it is not surprising.  Pulling 0.94 is far worse, since that was going to only store one copy of the blockchain (Bitcoin Core's).  Having two blockchain on my laptop is no longer viable, within a few month I need to find an alternative.  Getting rid of one of them would have postponed that for a year or so.

Edit: spelling.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: unamis76 on October 30, 2015, 07:39:01 PM
Thank you! A great update to one of my favorite clients :) And this:

Also includes a correction path to fix non-compliant signatures when broadcasting transactions signed by older versions of Armory. Thus, offline systems do not need to be updated, as long as the online system is.

Great! No need to remake my offline environment ;D


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: picobit on October 30, 2015, 07:41:32 PM
Great! No need to remake my offline environment ;D

Yes, that is really a good thing!   :D


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: jammers on October 30, 2015, 07:49:42 PM
Cool. I could download it from this post, but when offered it in armory and trying to download it via there, it's just giving me the error

There was a failure downloading this file: 0


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitpop on October 30, 2015, 09:01:15 PM
Cool. I could download it from this post, but when offered it in armory and trying to download it via there, it's just giving me the error

There was a failure downloading this file: 0

Both worked for me, maybe the server was down temporarily


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on October 31, 2015, 12:45:09 AM
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?

Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: pf on October 31, 2015, 07:28:02 AM
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?

Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
Any chance you can write out the steps I can use to compile it myself for OS X? Thanks.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on October 31, 2015, 07:38:24 AM
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?

Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
Any chance you can write out the steps I can use to compile it myself for OS X? Thanks.
Just follow the instructions here (https://github.com/etotheipi/BitcoinArmory/blob/master/osxbuild/osx_build_notes.txt) with pull request #315.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: pf on October 31, 2015, 10:59:08 AM
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?

Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
Any chance you can write out the steps I can use to compile it myself for OS X? Thanks.
Just follow the instructions here (https://github.com/etotheipi/BitcoinArmory/blob/master/osxbuild/osx_build_notes.txt) with pull request #315.
Thanks, I'll try. A few questions:
  • If it's so easy to make the OS X build, why didn't they just do it?
  • Have you tested your OS X compiled Armory 0.93.3 with Bitcoin Core 0.11.1? Is everything working? Are transactions getting broadcast, and so on?
  • Let's say I upgrade to Bitcoin Core 0.11.1 and run it, and then run the older Armory 0.93.2. Will anything break? Or will Armory tell me something is wrong right away? Or will Armory just fail to broadcast transactions? What exactly could go wrong?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: unamis76 on October 31, 2015, 03:58:13 PM
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?

Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
Any chance you can write out the steps I can use to compile it myself for OS X? Thanks.
Just follow the instructions here (https://github.com/etotheipi/BitcoinArmory/blob/master/osxbuild/osx_build_notes.txt) with pull request #315.
Thanks, I'll try. A few questions:
  • If it's so easy to make the OS X build, why didn't they just do it?
  • Have you tested your OS X compiled Armory 0.93.3 with Bitcoin Core 0.11.1? Is everything working? Are transactions getting broadcast, and so on?
  • Let's say I upgrade to Bitcoin Core 0.11.1 and run it, and then run the older Armory 0.93.2. Will anything break? Or will Armory tell me something is wrong right away? Or will Armory just fail to broadcast transactions? What exactly could go wrong?

From the OP, I can just guess that they cannot provide Armory on OSX with the same quality standards that they provide on Windows and Linux.

As for 0.93.2 + Core 0.11.1, I don't see why would there be any issue.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: achow101 on October 31, 2015, 04:26:53 PM

As for 0.93.2 + Core 0.11.1, I don't see why would there be any issue.
The issue is that 0.93.2 and older does not enforce using low s signatures. They sometimes produce high s sigs, which are no longer relayed by core 0.11.1. The fix fixes that issue so that armory only produced low s sigs.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: unamis76 on October 31, 2015, 05:02:57 PM

As for 0.93.2 + Core 0.11.1, I don't see why would there be any issue.
The issue is that 0.93.2 and older does not enforce using low s signatures. They sometimes produce high s sigs, which are no longer relayed by core 0.11.1. The fix fixes that issue so that armory only produced low s sigs.

Thank you for the clarification.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: PRab on October 31, 2015, 05:58:07 PM
As always, thanks for the updated version!


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on October 31, 2015, 07:26:04 PM
Thanks, I'll try. A few questions:
  • If it's so easy to make the OS X build, why didn't they just do it?
  • Have you tested your OS X compiled Armory 0.93.3 with Bitcoin Core 0.11.1? Is everything working? Are transactions getting broadcast, and so on?
  • Let's say I upgrade to Bitcoin Core 0.11.1 and run it, and then run the older Armory 0.93.2. Will anything break? Or will Armory tell me something is wrong right away? Or will Armory just fail to broadcast transactions? What exactly could go wrong?
Not sure why they didn't just do it, best guess is they were too busy or didn't have a mac available, it took me a few hours to get working but most of that was just getting familiar with the build system, the changes they made didn't really touch the build system as far as I could tell but they hadn't updated Qt in a while so some links/paths were broken.
Seems to work fine with Bitcoin Core 0.11.1.
Armory 0.93.2 fails to broadcast transactions with Bitcoin Core 0.11.1.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: coinbtm on October 31, 2015, 09:01:52 PM
First off, thanks for all your work, past and hopefully future, on this wonderful project.

Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?

...otherwise it requires lot of jumping through VM hoops.
Thanks!


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on October 31, 2015, 09:35:08 PM
First off, thanks for all your work, past and hopefully future, on this wonderful project.

Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?

...otherwise it requires lot of jumping through VM hoops.
Thanks!
Yeah, I think they should try and do that soon before someone else releases a potentially backdoored binary. If you happen to trust me I can PM you the one I built but it's bad practice to trust binary files from random people on the internet.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Carlton Banks on October 31, 2015, 10:38:37 PM
First off, thanks for all your work, past and hopefully future, on this wonderful project.

Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?

...otherwise it requires lot of jumping through VM hoops.
Thanks!
Yeah, I think they should try and do that soon before someone else releases a potentially backdoored binary. If you happen to trust me I can PM you the one I built but it's bad practice to trust binary files from random people on the internet.

A pull request with the changes needed to get the build working could be submitted to the Armory github. It can only be rejected, so not much to lose in trying.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on October 31, 2015, 10:43:03 PM
A pull request with the changes needed to get the build working could be submitted to the Armory github. It can only be rejected, so not much to lose in trying.
As I mentioned earlier in this thread I've already done that, it is #315.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Carlton Banks on October 31, 2015, 10:54:00 PM
A pull request with the changes needed to get the build working could be submitted to the Armory github. It can only be rejected, so not much to lose in trying.
As I mentioned earlier in this thread I've already done that, it is #315.

My apologies, I do that sort of thing sometimes. I'll try to keep the noise down :)


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on October 31, 2015, 11:01:38 PM
I've reviewed the code. Looks kosher (I'm no OSX specialist). I'll drop a word to etotheipi. I won't merge it in myself, because chain of command.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: picobit on November 01, 2015, 07:42:37 AM
It would be nice to see this version appear on the Armory home page, since it is a very important compatibility fix.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on November 03, 2015, 09:08:13 AM
Since this seems to be taking a while I'm going to post my OSX build here before someone tries to release something with a backdoor.

Edit: Download removed since there is an official release.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Plento on November 04, 2015, 05:33:29 AM
Since this seems to be taking a while I'm going to post my OSX build here before someone tries to release something with a backdoor.

Download armory_0.93.3_osx.tar.gz (https://drive.google.com/file/d/0B8wo2LvbF4S8RF90MTNIMUxhZ0U/view?pli=1)
MD5: a086fb85547eecc0369d9d2f2fd67b6c
SHA1: ef3f6692b8eaa2132d678592de729850a7e39c4d
SHA256: f227d7d54971ba2747dce4a0722774d48f905c7eba74c74bc7a3bff5726b09e7

No offence if you're a dev, but how can we be sure you didn't just post a malcious file?
Can someone run something?

If it's clean, which it probably is, thank you.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: coinbtm on November 04, 2015, 03:33:42 PM
I've reviewed the code. Looks kosher (I'm no OSX specialist). I'll drop a word to etotheipi. I won't merge it in myself, because chain of command.

With respect for chain of command, it's been quite a few days now.... Mac users everywhere would be very much appreciated if there was at least one last officially compiled binary update to take care of the high/low-S patch

...Please consider elevating the priority of this request...


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Roy Badami on November 04, 2015, 11:56:13 PM
Dumb github question, but is there as easy way to apply a pull request to a local clone of the git repo?  I can't even figure out how to download a pull request as a unified diff, let alone how to pull it properly with git.

The github help tells me to browse to the pull request and click "command line" but I don't see such a link.

EDIT: And many thanks to bitsolutions for doing (and sharing) the necessary work - and of course to Alan and goatpig and all at ATI for their continuing work on Armory!

EDIT^2: I'm also being dumb as there's no way (I think) to download the actual pull request that goatpig reviewed, since pull requests are mutable (for obvious reasons).  The change is small enough it's easy enough to review, though, so if you posted a diff that would be just as good.  I'm still curious as to the answer to my question, though.

EDIT^3: nm, I found a (good enough) answer that at least allows me to download the diff: browse to the pull request and then edit the URL to add ".patch" or ".diff" to the end of the URL   Ugh! Did I tell you I hate github?   EDIT^4: But .patch and .diff give different results  though (I don't think they're substantively different but am failing to see why both exist).  BTW, did I tell you I hate github?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: achow101 on November 05, 2015, 02:05:46 AM
Dumb github question, but is there as easy way to apply a pull request to a local clone of the git repo?  I can't even figure out how to download a pull request as a unified diff, let alone how to pull it properly with git.

The github help tells me to browse to the pull request and click "command line" but I don't see such a link.

EDIT: And many thanks to bitsolutions for doing (and sharing) the necessary work - and of course to Alan and goatpig and all at ATI for their continuing work on Armory!

EDIT^2: I'm also being dumb as there's no way (I think) to download the actual pull request that goatpig reviewed, since pull requests are mutable (for obvious reasons).  The change is small enough it's easy enough to review, though, so if you posted a diff that would be just as good.  I'm still curious as to the answer to my question, though.

EDIT^3: nm, I found a (good enough) answer that at least allows me to download the diff: browse to the pull request and then edit the URL to add ".patch" or ".diff" to the end of the URL   Ugh! Did I tell you I hate github?   EDIT^4: But .patch and .diff give different results  though (I don't think they're substantively different but am failing to see why both exist).  BTW, did I tell you I hate github?
Create a local branch which tracks the branch which is being merged in the pull request. At the top it will say something like "merge <branch 1> from <branch 2>". You want to clone and track branch 2 locally. Then you can merge it locally into your master.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on November 05, 2015, 06:34:42 AM
No offence if you're a dev, but how can we be sure you didn't just post a malcious file?
Can someone run something?

If it's clean, which it probably is, thank you.
I'm not part of the Armory development team but I am a developer/sysadmin. Yeah, there isn't really a way to know other than analyzing it I guess, that's why you should ideally compile it yourself. I built it from source though so it shouldn't have anything malicious.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Carlton Banks on November 05, 2015, 10:18:14 AM
No offence if you're a dev, but how can we be sure you didn't just post a malcious file?
Can someone run something?

If it's clean, which it probably is, thank you.
I'm not part of the Armory development team but I am a developer/sysadmin. Yeah, there isn't really a way to know other than analyzing it I guess, that's why you should ideally compile it yourself. I built it from source though so it shouldn't have anything malicious.

If Armory continued the Gitian development they were doing, this would be an ideal showcase for the power of that technology.

Temporarily dropping support for OS X is something I suggested once in the past, on the grounds that it seemed to hold ATI devs back when on the verge of an official version release, so I totally understand this decision. On the other hand, that leaves Mac users with the decision to aquire either new hardware or some virtulaisation software to run Armory on Linux. Not so great.

But Gitian support could've made this a sort of win-win. ATI could've dropped official builds for 0.93.3, and a whole load of users could (and demonstrably would) take on all the responsibility for building, signing and distributing an unofficial build fix. Depending on the source and/or who signs/public feedback, the typical user can feel confident that they're getting something they can use, and it's all the product of spontaneous self organisation.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: pf on November 05, 2015, 10:08:02 PM
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?

Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
Any chance you can write out the steps I can use to compile it myself for OS X? Thanks.
Just follow the instructions here (https://github.com/etotheipi/BitcoinArmory/blob/master/osxbuild/osx_build_notes.txt) with pull request #315.
Thanks, that worked like a charm to compile Armory 0.93.3 on OS X El Capitan. And sending transactions with Bitcoin Core 0.11.1 worked fine too. For those who are still a bit unsure, here are more detailed steps:

  • Run "git clone git@github.com:jameshilliard/BitcoinArmory.git". Note this is not the official Armory repo. It contains the commit for the pull request #315 in the official repo. This commit has the needed fixes for making OS X building work.
  • Checkout the commit cad8d2d39b11cbbe1c728bcd7895620eedb90141 from this repository.
  • Follow these instructions to build it: https://github.com/etotheipi/BitcoinArmory/blob/master/osxbuild/osx_build_notes.txt

That's it. Worked great. Thanks again!


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Roy Badami on November 06, 2015, 12:33:44 AM
Ok, so just reviewing bitsolution's changes, my one question for bitsolution (or anyone else who is Qt-savvy) is:

This change introduces a new dependency on qt-project.org.  I presume this is a trustworthy source, since there are existing references to qt-project.org in upstream - but they all seem to be commented out AFAICS, so it seems this change does involve trusting a new domain.

Could someone explain to me the relationship between qt-project.org and the Qt project/qt.io, as my Google fu is failing me?

Thanks,

roy

EDIT TO ADD: I'm absolutely not suggesting there is anything untoward going on here - I'm sure there isn't.  I'm just doing my due diligence and as Qt is not my area of expertese, I'm just trying to understand the provenance of the Qt code that bitsolutions is using.  As there are (currently usused) references to this source in the official Armory code, I expect this source is trustworthy, but I just want to understand why it's there before I run this.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Roy Badami on November 06, 2015, 01:04:53 AM
At the top it will say something like "merge <branch 1> from <branch 2>"

Thanks, knightdk, that's obvous now you explain it.  I was just looking for an obvious clickable link, I guess.

Although I also realise that if I just check out bitsoultions's branch, and also review the pull request on github at the time I do the checkout that tells me what changes I'm running - modulo the race condition that the branch (and pull request) could change as I'm checking it out.  But it is good enough for me.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on November 06, 2015, 04:37:53 AM
Ok, so just reviewing bitsolution's changes, my one question for bitsolution (or anyone else who is Qt-savvy) is:

This change introduces a new dependency on qt-project.org.  I presume this is a trustworthy source, since there are existing references to qt-project.org in upstream - but they all seem to be commented out AFAICS, so it seems this change does involve trusting a new domain.

Could someone explain to me the relationship between qt-project.org and the Qt project/qt.io, as my Google fu is failing me?

Thanks,

roy

EDIT TO ADD: I'm absolutely not suggesting there is anything untoward going on here - I'm sure there isn't.  I'm just doing my due diligence and as Qt is not my area of expertese, I'm just trying to understand the provenance of the Qt code that bitsolutions is using.  As there are (currently usused) references to this source in the official Armory code, I expect this source is trustworthy, but I just want to understand why it's there before I run this.
All I did there was fix a dead link, the URL pointed to a snapshot which didn't exist anymore so I just changed it to the regular release version(which is newer than the snapshot and is unlikely to be deleted anytime soon). The url (https://github.com/etotheipi/BitcoinArmory/blob/master/osxbuild/build-app.py#L357) was in the main repo, I just uncommented it and commented out the line that points to the snapshot(which was dead).
At the top it will say something like "merge <branch 1> from <branch 2>"

Thanks, knightdk, that's obvous now you explain it.  I was just looking for an obvious clickable link, I guess.

Although I also realise that if I just check out bitsoultions's branch, and also review the pull request on github at the time I do the checkout that tells me what changes I'm running - modulo the race condition that the branch (and pull request) could change as I'm checking it out.  But it is good enough for me.
Just check the commit hash, you can't change git history without changing the commit hash.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Roy Badami on November 06, 2015, 08:48:52 PM
All I did there was fix a dead link, the URL pointed to a snapshot which didn't exist anymore so I just changed it to the regular release version(which is newer than the snapshot and is unlikely to be deleted anytime soon). The url (https://github.com/etotheipi/BitcoinArmory/blob/master/osxbuild/build-app.py#L357) was in the main repo, I just uncommented it and commented out the line that points to the snapshot(which was dead).

Ok, just wondering why it's at qt-project.org.  If I google Qt, the main page is at qt.io, as are the download links I could find.

EDIT: Actually, I think download.qt-project.org and download.qt.io seem to take you to the same downloads; I think maybe they just changed the project's domain?

EDIT^2: Confirmed: http://download.qt-project.org/official_releases/qt/4.8/4.8.7/qt-everywhere-opensource-src-4.8.7.tar.gz and http://download.qt.io/official_releases/qt/4.8/4.8.7/qt-everywhere-opensource-src-4.8.7.tar.gz are binary identical.  Sorry for the noise.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Roy Badami on November 07, 2015, 12:41:57 AM
Just check the commit hash, you can't change git history without changing the commit hash.

True.  Though goatpig didn't quote the hash of the changeset they reviewed - and although pf quoted the hash, they didn't say whether they'd reviewed the changes.

Anyway, FWIW, I've briefly reviewed cad8d2d39b11cbbe1c728bcd7895620eedb90141 and all the changes seem fairly self-evidently benign.  (But of course, you shouldn't take my word for it unless you know/trust me.)

Just built it, and it seems to work.  (Not used it for any transactions yet, but it successfully built and scanned the databases and displays the correct balances...)

Thanks, bitsolutions, for your work on this - it's particularly valuable to me since I've just bought a new Mac laptop - mainly because two blockchains are now too large for my old one - and so would have found it incredibly frustrating if I could no longer use it for Armory anyway!  I'd tip you but you I don't know where to send the coins :-)

roy


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 07, 2015, 01:14:30 AM
With respect for chain of command, it's been quite a few days now.... Mac users everywhere would be very much appreciated if there was at least one last officially compiled binary update to take care of the high/low-S patch

...Please consider elevating the priority of this request...

No. I will not escalate anything because even though I reviewed the code, I do not build on Macs thus I cannot test the code at all. My review was merely to make sure nothing was fishy with the change.

I informed etotheipi of my opinion on the content of this PR, but I won't press that matter any further because I do not have experience with OSX builds, so I cannot make an informed decision. If I could say "I tested it, it works and I approve of this change", things would be different, but I can't. Development is a lot simpler when people stick to their specialty.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: armedmilitia on November 09, 2015, 07:08:00 PM
Heya there everyone,
I'm wondering what the system requirements for armory are, both for offline and online? I remember the online version being very resource intensive a while back, but have there been improvements?

Thanks guys!


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: philipma1957 on November 10, 2015, 02:09:43 PM
Heya there everyone,
I'm wondering what the system requirements for armory are, both for offline and online? I remember the online version being very resource intensive a while back, but have there been improvements?

Thanks guys!

I would like to know how does this work on windows 10?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: bitsolutions on November 11, 2015, 01:22:48 AM
Looks like my pull request was merged, hopefully there will be an official release soon.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: etotheipi on November 11, 2015, 09:32:20 PM
Yes, I just pulled the changes and successfully built 0.93.3 for OSX.

It's now available via secure-downloader, and the link copied here:

Armory 0.93.3 for MacOSX 10.7+ (64bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_osx.tar.gz)



Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: coinbtm on November 12, 2015, 03:53:04 PM
Yes, I just pulled the changes and successfully built 0.93.3 for OSX.

It's now available via secure-downloader, and the link copied here:

Armory 0.93.3 for MacOSX 10.7+ (64bit) (https://s3.amazonaws.com/bitcoinarmory-releases/armory_0.93.3_osx.tar.gz)



Thank you very much as always alan, you are a true gentleman and a scholar!


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Carlton Banks on November 12, 2015, 05:00:20 PM
Heya there everyone,
I'm wondering what the system requirements for armory are, both for offline and online? I remember the online version being very resource intensive a while back, but have there been improvements?

Thanks guys!

Can't give you official figures from the Armory devs, but my own recommendations for the pre-built 0.93.3 would be....

Online:
2GB RAM minimum
Any Intel/x86 CPU from the past 5-7 years will be good enough, but older/slower means more time sync'ing up to set up the databases.
100GB spare HDD space. High performance/solid state disk recommended.

Offline:
512 MB RAM minimum
Any Intel/x86 CPU from the past 10 years will do it. Almost doesn't matter how underpowered the CPU is, an Atom/Eeee PC could probably deal with it.
Negligible diskspace (a few dozen MB for the installation)


OS wise, I think you're still OK with something as outdated as Windows XP (can anyone confirm this? goatpig?), but I can't help you with the newer Windows versions. I think people have had it working with Windows 8.

For Linux, you need anything with dpkg packaging (Ubuntu, Debian etc), and anything that uses Debian 8 as a base (Ubuntu 15.04+) .


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 12, 2015, 05:55:10 PM
OS wise, I think you're still OK with something as outdated as Windows XP (can anyone confirm this? goatpig?)

For 0.92.x you can use WinXP.

For 0.93+ you need at least Vista x64.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Carlton Banks on November 12, 2015, 07:10:10 PM
OS wise, I think you're still OK with something as outdated as Windows XP (can anyone confirm this? goatpig?)

For 0.92.x you can use WinXP.

For 0.93+ you need at least Vista x64.

0.93.3 corrects any High-S sigs generated offline, no? I'm thinking of the Atom/Netbook owners, Offline Armory could be a great way to re-purpose those devices now. IIRC, 0.92.3 uses the same format for offline transactions...


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 12, 2015, 11:16:29 PM
0.93.3 corrects any High-S sigs generated offline, no? I'm thinking of the Atom/Netbook owners, Offline Armory could be a great way to re-purpose those devices now. IIRC, 0.92.3 uses the same format for offline transactions...

Yes but 0.93.3 online will fix highS in sigs at broadcast too, so you can sign with an older version as long as you broadcast with 0.93.3


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: twebit on November 14, 2015, 12:14:08 PM
Anybody having problems with connecting to the new Armory? I use custom startup options in the shortcut like this --satoshi-datadir="D:\Bitcoin" --datadir="D:\armoryW" but it won't connect with bitcoin core running and windows 10 firewall allowing connections. Settings in armory are unchecked for "Let armory run Bitcoin/QT in the background"

I can usually get this to work but I'm at a loss here.
edit: I tried the checkmark Let armory run Bitcoin/QT in the background too and specified the directories.
Thanks



Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 14, 2015, 06:29:11 PM
Look at the end of armorylog.txt, should have some clue.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: twebit on November 14, 2015, 06:47:37 PM
Look at the end of armorylog.txt, should have some clue.

Looked and it says "2015-11-14 13:41 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss"

I've also tried copying all data to my OS's default data directories and checking let armory start bitcoind/qt but it doesn't start bitcoind/qt
Everything works when loading linux mint from live cd with the same parameters so I'm assuming something to do with win10.

Any other tips?
Thanks



Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 14, 2015, 06:50:39 PM
I would need more than just the last line. Either give me more here or post your log file in a support ticket.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: twebit on November 14, 2015, 06:53:38 PM
I would need more than just the last line. Either give me more here or post your log file in a support ticket.

2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1076 - C++ block utilities loaded successfully
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1186 -
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1187 -
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1188 -
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1189 - ************************************************************
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1190 - Invoked: C:\Program Files\Armory\ArmoryQt.exe --satoshi-datadir=F:\Bitcoin --datadir=D:\armoryW
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1191 - ************************************************************
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1192 - Loading Armory Engine:
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1193 -    Armory Version        : 0.93.3
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1194 -    Armory Build:         : e59e10d38c
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1195 -    PyBtcWallet  Version  : 1.35
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1196 - Detected Operating system: Windows
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1197 -    OS Variant            : 8-6.2.9200--Multiprocessor Free
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1198 -    User home-directory   : C:\Users\twebit\AppData\Roaming
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1199 -    Satoshi BTC directory : F:\Bitcoin
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1200 -    Armory home dir       : D:\armoryW
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1201 - Detected System Specs    :
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1202 -    Total Available RAM   : 15.98 GB
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1203 -    CPU ID string         : Intel64 Family 6 Model 42 Stepping 7, GenuineIntel
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1204 -    Number of CPU cores   : 8 cores
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1205 -    System is 64-bit      : True
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1206 -    Preferred Encoding    : cp1252
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1207 -    Machine Arch          : amd64
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1208 -    Available HDD (ARM)   : 151 GB
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1209 -    Available HDD (BTC)   : 242 GB
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1210 -
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1211 - Network Name: Main Network
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1212 - Satoshi Port: 8333
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1213 - Do wlt check: True
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1214 - Named options/arguments to armoryengine.py:
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     nettimeout      : 2
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     rescan          : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     ignoreAllZC     : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     enableSupernode : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     disableModules  : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     port            : None
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     interport       : 8223
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     skipStatsReport : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     forceWalletCheck: False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     rebuild         : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     datadir         : D:\armoryW
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     clearMempool    : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     offline         : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     coverageOutputDir: None
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     armoryDBDir     : DEFAULT
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     satoshiPort     : DEFAULT
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     useTorSettings  : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     netlog          : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     keypool         : 100
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     coverageInclude : None
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     forceOnline     : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     skipAnnounceCheck: False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     redownload      : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     multisigFile    : DEFAULT
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     disableTorrent  : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     testAnnounceCode: False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     mtdebug         : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     logDisable      : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     settingsPath    : D:\armoryW\ArmorySettings.txt
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     verbosity       : None
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     doDebug         : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     enableDetSign   : True
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     testnet         : False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     rpcport         : DEFAULT
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     satoshiHome     : F:\Bitcoin
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     satoshiRpcport  : DEFAULT
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     logFile         : D:\armoryW\ArmoryQt.exe.log.txt
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1216 -     disableConfPermis: False
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1217 - Other arguments:
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1220 - ************************************************************
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:1620 - C++ block utilities loaded successfully
2015-11-14 13:50 (INFO) -- BDM.pyc:418 - Using the asynchronous/multi-threaded BlockDataManager.
2015-11-14 13:50 (INFO) -- BDM.pyc:419 - Blockchain operations will happen in the background. 
2015-11-14 13:50 (INFO) -- BDM.pyc:420 - Devs: check TheBDM.getState() before asking for data.
2015-11-14 13:50 (INFO) -- BDM.pyc:421 - Registering addresses during rescans will queue them for
2015-11-14 13:50 (INFO) -- BDM.pyc:422 - inclusion after the current scan is completed.
2015-11-14 13:50 (INFO) -- ArmoryUtils.pyc:3531 - Using settings file: D:\armoryW\ArmorySettings.txt
2015-11-14 13:50 (INFO) -- announcefetch.pyc:95 - Reading files in fetcher directory:
2015-11-14 13:50 (INFO) -- announcefetch.pyc:104 -    announce         : 96f5d5f4253bac5528333c4fef3afd5fa0e931816bfd4c4c8b43d85cee002bb9
2015-11-14 13:50 (INFO) -- announcefetch.pyc:104 -    bootstrap        : b62c08932668ce162d51226135940724e90f4c71704ac936f74cc153b34cc251
2015-11-14 13:50 (INFO) -- announcefetch.pyc:104 -    changelog        : 1c01304b876de3e75672c8b13d9a00157556b86612afac1c88ffc40a8d7dfb90
2015-11-14 13:50 (INFO) -- announcefetch.pyc:104 -    downloads        : 28efee8047ee0a2c26ac9f785d93566fb5a45c20a794da6f972aa48db50ec35a
2015-11-14 13:50 (INFO) -- announcefetch.pyc:104 -    notify           : 87fa1adcd555be83a71b4f5935a6d4f85178ccbf5043531fdd71432b57d127ca
2015-11-14 13:50 (INFO) -- announcefetch.pyc:271 - Fetching: https://bitcoinarmory.com/announce.txt?osvar=8&os=win&ver=0.93.3&id=9b0e52bc
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2736 - loadWalletsAndSettings
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2790 - Loading wallets...
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2849 - Number of wallets read in: 1
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2854 -    Wallet removed for privacy                      "   (Encrypted)
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2863 - Loading Multisig Lockboxes
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2298 - Setting up networking...
2015-11-14 13:50 (ERROR) -- announcefetch.pyc:283 - Specified URL was inaccessible
2015-11-14 13:50 (ERROR) -- announcefetch.pyc:284 - Tried: https://bitcoinarmory.com/announce.txt?osvar=8&os=win&ver=0.93.3&id=9b0e52bc
2015-11-14 13:50 (INFO) -- announcefetch.pyc:271 - Fetching: https://s3.amazonaws.com/bitcoinarmory-media/announce.txt
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2327 - Internet status: 0
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2525 - loadBlockchainIfNecessary
2015-11-14 13:50 (INFO) -- ArmoryQt.py:2546 - Setting netmode: 0
2015-11-14 13:50 (INFO) -- ArmoryQt.py:1514 - setupUriRegistration
2015-11-14 13:50 (INFO) -- ArmoryQt.py:1632 - URL-register action: AskUser
2015-11-14 13:50 (INFO) -- ArmoryQt.py:664 - Usermode: Expert
2015-11-14 13:50 (INFO) -- ArmoryQt.py:1810 - Changing usermode:
2015-11-14 13:50 (INFO) -- ArmoryQt.py:1811 -    From: Expert
2015-11-14 13:50 (INFO) -- ArmoryQt.py:1819 -      To: Expert
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:50 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:5962 - Dashboard switched to user-OfflineOnlinePoss
2015-11-14 13:51 (INFO) -- ArmoryQt.py:6763 - BDM is safe for clean shutdown
2015-11-14 13:51 (INFO) -- ArmoryQt.py:6805 - Attempting to close the main window!


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 14, 2015, 07:21:37 PM
Let's see armorycpplog.txt


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: twebit on November 14, 2015, 07:26:47 PM
Let's see armorycpplog.txt

It only says...

Log file opened at 1447528977: D:\armoryW\armorycpplog.txt

And ArmorySetting.txt is this...

ManageSatoshi                        | False
NotifyMinPriority                    | 2048
MainWalletCols                       | ff0500003c0078005000a502
Wallet_removed for privacy_DNAA_RecvOther      | False
NotifyBlkFinish                      | False
MainGeometry                         | 01d9d0cb000100000000014c000001030000063e000003ee000001540000012200000636000003e 6000000000000
SkipStatsReport                      | False
SendBtcGeometry                      | 01d9d0cb0001000000000204000000f9000005690000032e0000020e0000011b0000055f0000032 4000000000000
LastBlkRecvTime                      | 1447513708.15
LastDirectory                        | D:\armoryW
Agreed_to_EULA                       | True
MonthlyID                            | 1115_9b0e52bc
NotifyBtcIn                          | True
SyncSuccessCount                     | 10
MainLedgerCols                       | ff0d14000000ad004800700096007000000000000000000000000000
DonateAlready                        | False
UseTorSettings                       | False
DNAA_UnlockTimeout                   | False
WltPropAddrCols                      | ff052200bd00d8004000ae00
AlwaysArmoryURI                      | 0
PrefEndian                           | >
NotifyDiscon                         | True
SkipAnnounceCheck                    | False
KeybdOSD                             | False
NotifyIgnore                         |
DNAA_IntroDialog                     | True
SatoshiDatadir                       | F:\Bitcoin
DateFormat                           | 25592d25622d25642025493a254d2570
DNAA_AllBackupWarn                   | False
DonateFreq                           | 20
DisableUpgradeNotify                 | False
ScrambleDefault                      | 0
AdvFeature_UseCt                     | 0
UnlockTimeout                        | 10
Default_Fee                          | 10000
LastFilterState                      | 0
MinimizeOrClose                      | Close
SkipVersionCheck                     | False
User_Mode                            | Expert
Load_Count                           | 52
First_Load_Date                      | 1446854151
Wallet_removed for privacy_DNAA_RemindBackup   | True
NotifyBtcOut                         | True
DNAA_DeleteLevelDB                   | False
SkipOnlineCheck                      | False
MinimizeOnOpen                       | False
FailedLoadCount                      | 0
First_Load                           | False
Wallet_removed for privacy_ChangeBehavior      | NewAddr
Wallet_removed for privacy_LedgerShow          | True
IgnoreAlerts                         |
DisableTorrent                       | True
LastBlkRecv                          | 383544
DonateLastPester                     | 0
DonateDNAA                           | False
NotifyReconn                         | True
SatoshiExe                           | C:\Program Files\Bitcoin
DNAA_DefaultApp                      | True
WltPropGeometry                      | 01d9d0cb00010000000001a700000086000005830000039b000001b1000000a8000005790000039 1000000000000
LastVersionLoad                      | v0.93.3


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: twebit on November 14, 2015, 07:29:42 PM
One other thing I noticed is that while in this offline state if I click on wallet properties I hear a system ding and then the interface is locked and just ding ding everywhere I click on the armory interface till I end task.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 15, 2015, 11:12:56 AM
I don't have much to go on here. It definitely fails to either connect or recognize the blockchain data path. You should turn off auto bitcoind, start BitcoinQt manually and look at the peers, see if Armory managed to connect at some point (or check Core's debug.log)

If there is no trace of Armory connecting as a peer in Core's log, it ought to be a Windows firewall/Bit Defender/anti virus rule. If it does connect, then it's a pathing and/or permission issue on the blockchain data folder.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: twebit on November 15, 2015, 12:15:21 PM
Ah ha! I found it looking in the bitcoin log there's an issue with it accepting connection here's the error that led me to check out the bitcoin.conf
"ERROR: CScriptCheck(): ca0ee950fb4c1092d5b8e91b236db50b541a1eb13f8de26f7334cb7f259b6f6d:0 VerifySignature failed: Non-canonical signature: S value is unnecessarily high"

I switched the bitcoin.conf off and it didn't work so I turned my old p2pool conf on and it connected.

So that's fixed for me but wonder why it would work in linux and not in windows?

Also I'm a billionaire according to my wallet I have 184467440736.77636719 BTC more than there is in existance... When I do a repair wallet it goes away.

Thanks for your help your last comment is what got me thinking about antivirus, firewall then bitcoin log was the hint I needed.




Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: twebit on November 15, 2015, 12:34:12 PM
It won't load with the armory generated bitcoin.conf only with the p2pool config that I have.

I had in the armory generated config
rpcuser=generated_by_armory
rpcpassword=long password

but it won't load with that
but it will load with this...

listen=1
gen=0
server=1
daemon=1
rpcport=8332
rpcconnect=127.0.0.1
rpcallowip=192.168.1.12
rpcuser=bitcoinrpc
rpcpassword=AJacKm5v8MHFBU1vvHjznhAiy3MckM8jPMDiX3grbpc5
maxconnections=30
upnp=0
mintxfee=0.00005
minrelaytxfee=0.00005
disablewallet=1

Something has changed somewhere.

How do I get armory to generate that secure bitcoin.conf like it did originally?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 15, 2015, 12:49:39 PM
So that's fixed for me but wonder why it would work in linux and not in windows?

Every issues I have seen on Win10 had something to do with permissions. I guess they tightened the user isolation. I should upgrade to 10 at some point...

Quote
How do I get armory to generate that secure bitcoin.conf like it did originally?

That's a feature for auto bitcoind only. Armory only uses the RPC to recover status data from bitcoind when it manages it. It won't bother if you manage Qt yourself.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: trev on November 22, 2015, 04:44:24 AM
Critical Bug Fix: "bitcoin:" URI handling of Multisig/P2SH addresses:
The code that handles clicking on a "bitcoin:" link outside Armory was improperly handling Multisig/P2SH addresses, and would prefill a valid but incorrect address.

I diff'd the 93.2 v.s. 93.3 source code to find the bug fix for the URI issue.
I can't see any change that is obviously related to it.

There is a change in jsonrpc_listunspent() at armoryd.py:462 where ".getOutPoint()" has been removed.
462c461
<             curUTXODict['txid'] = binary_to_hex(u.getOutPoint().getTxHash(), \
---
>             curUTXODict['txid'] = binary_to_hex(u.getTxHash(), \

Is this the fix for the URI bug?

In jsonrpc_listaddrunspent() the identical code is used at line 556.
Should that line be patched in the same way as line 462 ?



Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 22, 2015, 01:12:57 PM
Is this the fix for the URI bug?

No

Quote
In jsonrpc_listaddrunspent() the identical code is used at line 556.
Should that line be patched in the same way as line 462 ?

No


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Roy Badami on November 30, 2015, 08:08:10 PM
Is 0.93.3 going to be put up on the website?  Currently the downloads link still seems to point to 0.93.2.

roy


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on November 30, 2015, 09:12:02 PM
Is 0.93.3 going to be put up on the website?  Currently the downloads link still seems to point to 0.93.2.

roy

Not sure about that, I'll ask around.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Roy Badami on December 03, 2015, 09:54:22 PM
Armory 0.93.3 with BIP62 Released

Download links below, but as always, please use the secure downloader within Armory under "Help"-->"Update Software" or on the Announcements tab on the main screen.

More out of curiosity than anything else, but is the secure downloader actually working at the moment?  For me, it complains that it hasn't seen an update in months, and won't show me anything recent.  But I self-built, so maybe something broke.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Stroto on December 04, 2015, 10:08:20 AM
Well I have an issue with the new armory.

Sometimes when I make a tx and get change back in the same wallet the change appears as separate tx between the transactions. Not a real problem ofcourse, however the change is also not subtracted from the address so it shows as double. This prevents to make further transactions until the tx are confirmed. In those cases the change address is the same as the output address.

Probably an example makes it clearer:

Wallet A has 0.10 BTC which is bought of 1 transaction

A transaction is made of 0.02

Now the wallet shows two transactions:

tx1 -0.02 BTC
tx2 +0.0799 BTC

total value 0.16998

It shows like that until all tx have confirmed and before confirmation when you try to make a transaction (of the 0.0799 that should be able to spend) it can't broadcast the transaction. When the tx get confirmed the tx (tx2 +0.0799 BTC) disappears from the list.

It does not happen with all the tx just some.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on December 04, 2015, 03:06:35 PM
More out of curiosity than anything else, but is the secure downloader actually working at the moment?  For me, it complains that it hasn't seen an update in months, and won't show me anything recent.  But I self-built, so maybe something broke.

I don't think it is.

Quote
Sometimes when I make a tx and get change back in the same wallet the change appears as separate tx between the transactions. Not a real problem ofcourse, however the change is also not subtracted from the address so it shows as double. This prevents to make further transactions until the tx are confirmed. In those cases the change address is the same as the output address.

Armory won't let you spend incoming ZC, only ZC change. I'm aware of the ZC parsing bug (where it sometimes fail to figure out an output is actually change) and I have fixed that in the soon to come release, so you'll have to be patient.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: lemipawa on December 07, 2015, 09:52:37 AM
For some reason, I cant download the 0.93 version last night, but instead I downloaded 0.92 version, would there be a problem with that in the future?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: achow101 on December 07, 2015, 12:46:46 PM
For some reason, I cant download the 0.93 version last night, but instead I downloaded 0.92 version, would there be a problem with that in the future?
Yes. It would produce high s signatures which would be rejected by the network.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: lemipawa on December 07, 2015, 03:16:04 PM
For some reason, I cant download the 0.93 version last night, but instead I downloaded 0.92 version, would there be a problem with that in the future?
Yes. It would produce high s signatures which would be rejected by the network.

I'm using a netbook Samsung n150 but I tried to download the 0.93 version, it's not allowing me
Is there any work around on that?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Newar on December 09, 2015, 02:44:53 PM

I'm already in contact with support, but I'm wondering if other people experience Armory crashes too, shortly after "Organizing Blockchain" starts?
(Lubuntu 14.04)


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: j1pvt on December 15, 2015, 05:44:50 PM
Im on Core 0.10.0  and Armoury 0.93.2,
Mac OSX 10.10.5
Everything working fine,
Why would I need to update ? ?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on December 15, 2015, 06:01:06 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: cypherdoc on December 15, 2015, 06:39:36 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.

what version of Core should we be on now?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Holliday on December 15, 2015, 06:50:28 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.

what version of Core should we be on now?

Err... uhh, don't you run XT or Unlimited?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on December 15, 2015, 07:11:36 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.

what version of Core should we be on now?

CLTV is activated (or should be soon, not sure), so 11.2 at least.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: cypherdoc on December 15, 2015, 07:14:59 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.

what version of Core should we be on now?

Err... uhh, don't you run XT or Unlimited?

sure, all but one to run Armory.  you have a problem with that?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Holliday on December 15, 2015, 07:22:07 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.

what version of Core should we be on now?

Err... uhh, don't you run XT or Unlimited?

sure, all but one to run Armory.  you have a problem with that?

So you run a different client to make a statement but when it comes to actually using Bitcoin, you use Core.

I don't have a problem with that, I just think it's hilarious.

Edit: Oh... and to answer your question, you should use the latest version of Core and Armory.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: cypherdoc on December 15, 2015, 07:28:08 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.

what version of Core should we be on now?

Err... uhh, don't you run XT or Unlimited?

sure, all but one to run Armory.  you have a problem with that?

So you run a different client to make a statement but when it comes to actually using Bitcoin, you use Core.

I don't have a problem with that, I just think it's hilarious.

Edit: Oh... and to answer your question, you should use the latest version of Core and Armory.

whatever amuses you.

i don't even bother to "use" it.  just for monitoring as i'm not sure of XT's compatibility.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: j1pvt on December 19, 2015, 08:41:20 AM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.
thanks, short story doesnt work for me,
As I said everything is working fine ie deposits payments balances etc etc.
I need to understand why it wont work
As a layman I dont even know what a build is , or how to use that 'build' with my existing Armory
And this bothers me bcos I have mining funds coming in every day.
So do I just transfer all funds back to Core and uninstall Armory and carry on like before without all the hassle ?
Or ?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: achow101 on December 19, 2015, 02:51:20 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.
thanks, short story doesnt work for me,
As I said everything is working fine ie deposits payments balances etc etc.
I need to understand why it wont work
As a layman I dont even know what a build is , or how to use that 'build' with my existing Armory
And this bothers me bcos I have mining funds coming in every day.
So do I just transfer all funds back to Core and uninstall Armory and carry on like before without all the hassle ?
Or ?
Are you saying that something is broken or are you just wondering why you should upgrade when nothing is broken?

If it is the latter, the reason you should upgrade is because the latest versions have bug fixes that fix some important issues and they implement new BIPs. The latest version fixes a vulnerability in UPnP which made it possible to crash a node with a malicious UPnP server on the network. There are fixes to reduce the effects of spam attacks on the network so that your node doesn't crash from an overload of transactions. There are fixes to optimize memory and reduce memory leaks. Lastly there are additions to support BIP65 and BIP113. BIP65 support means that a soft fork will happen which enables OP_CHECKLOCKTIMEVERIFY. Although soft forks are backwards compatible, sometimes soft forks can be problematic like the issue that happened with a soft fork back in July. However those running the latest version will not be affected by most forking issues, especially those like the one in July.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: j1pvt on December 21, 2015, 01:41:30 PM
Long story short, you should update Core because you just should, and you should update Armory or you'll have trouble spending coins.
thanks, short story doesnt work for me,
As I said everything is working fine ie deposits payments balances etc etc.
I need to understand why it wont work
As a layman I dont even know what a build is , or how to use that 'build' with my existing Armory
And this bothers me bcos I have mining funds coming in every day.
So do I just transfer all funds back to Core and uninstall Armory and carry on like before without all the hassle ?
Or ?
Are you saying that something is broken or are you just wondering why you should upgrade when nothing is broken?

If it is the latter, the reason you should upgrade is because the latest versions have bug fixes that fix some important issues and they implement new BIPs. The latest version fixes a vulnerability in UPnP which made it possible to crash a node with a malicious UPnP server on the network. There are fixes to reduce the effects of spam attacks on the network so that your node doesn't crash from an overload of transactions. There are fixes to optimize memory and reduce memory leaks. Lastly there are additions to support BIP65 and BIP113. BIP65 support means that a soft fork will happen which enables OP_CHECKLOCKTIMEVERIFY. Although soft forks are backwards compatible, sometimes soft forks can be problematic like the issue that happened with a soft fork back in July. However those running the latest version will not be affected by most forking issues, especially those like the one in July.

No nothing is broken, all is working 100%
Thats my point.
But it doesnt make sense to buy a new laptop bcos Armory discontinues Mac support.
Im really not sure I have the abilities to make this 'build" work on my current Armory.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: achow101 on December 21, 2015, 08:10:31 PM

No nothing is broken, all is working 100%
Thats my point.
But it doesnt make sense to buy a new laptop bcos Armory discontinues Mac support.
Im really not sure I have the abilities to make this 'build" work on my current Armory.
Yeah, Mac probably changed a lot of things so that the building it might not work with your version.

P.S. This is why you should use Linux  ;)


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: Mythoughts on December 22, 2015, 02:17:10 AM
Does Armory work with Bitcoin XT 0.11.0D when BIP62 is active ?

I used to run it with BitcoinXT 0.11.0A and B and that worked just fine (both on- and offline use of transactions).


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: j1pvt on December 28, 2015, 03:37:05 PM

No nothing is broken, all is working 100%
Thats my point.
But it doesnt make sense to buy a new laptop bcos Armory discontinues Mac support.
Im really not sure I have the abilities to make this 'build" work on my current Armory.
Yeah, Mac probably changed a lot of things so that the building it might not work with your version.

P.S. This is why you should use Linux  ;)

Armory updated 0.93.3
Core updated 0.11.2
Mac 10.10.5
All working 100%


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: enhu on January 11, 2016, 05:09:05 AM
this isnt for 32 bit?


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: goatpig on January 12, 2016, 05:28:55 AM
We do no support x86 with 0.93, that's for the next version. You can try to build it from source in x86 but that won't get you anywhere really.


Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: visdude on January 12, 2016, 07:12:42 PM
It would be nice to see this version appear on the Armory home page, since it is a very important compatibility fix.

...and it still hasn't to date. I wonder why. Is this version 0.93.3 posted in the OP identical to version 0.93.2 offered on the official Armory homepage (https://bitcoinarmory.com/) then albeit with a different label?



Title: Re: Armory 0.93.3 with BIP62 compliance
Post by: achow101 on January 12, 2016, 07:20:21 PM
It would be nice to see this version appear on the Armory home page, since it is a very important compatibility fix.

...and it still hasn't to date. I wonder why. Is this version 0.93.3 posted in the OP identical to version 0.93.2 offered on the official Armory homepage (https://bitcoinarmory.com/) then albeit with a different label?


IIRC they are not the same. You can check the hashes to make sure.