Bitcoin Forum

Bitcoin => Electrum => Topic started by: jonald_fyookball on August 20, 2017, 05:26:02 AM



Title: Terrible decision by Electrum Devs to remove Bip39 Checksum
Post by: jonald_fyookball on August 20, 2017, 05:26:02 AM
The latest codebase does not enforce bip39 checksum.  I think this is a really bad decision.

What this means:

If you import a seed from another wallet like jaxx, Electrum used to not let you import
it unless it was a valid bip39 seed.  Now, they simply give you a warning.

That means people can think they are importing the right seed and get different
addresses.  Really bad, someone is going to lose money.  I strongly recommend
going back to the old way.

They have their reasons for this but i dont agree. 


Title: Re: Terrible decision by Electrum Devs to remove Bip39 Checksum
Post by: pooya87 on August 21, 2017, 04:30:23 AM
you don't need to copy paste what you have already said on github here too. and it is already answered there by ecdsa https://github.com/spesmilo/electrum/commit/8b194cd409a1a79e616578a5eaf91cba68b36dab#commitcomment-23752528

and i think he is pointing to this commit: https://github.com/spesmilo/electrum/commit/c6e09a60388325050410101e78fb72f43aaa525b