Bitcoin Forum

Bitcoin => Development & Technical Discussion => Topic started by: Argon2 on September 17, 2017, 11:44:02 PM



Title: BIP0151 nodes detected on mainnet
Post by: Argon2 on September 17, 2017, 11:44:02 PM
Our node implementation has full support for bip-0151. Why are we seeing and speaking to Bitcoin Core nodes with bip-0151 support on mainnet but no source code in GitHub. The paper says "Reference implementation" and it is blank. Is this closed source development we are detecting on mainnet or is there a public branch with the code? ???


Title: Re: BIP0151 nodes detected on mainnet
Post by: achow101 on September 18, 2017, 02:06:57 AM
That may be jonasschnelli doing some implementation and testing work for it, but AFAIK there are no pull requests to implement BIP 151 in Bitcoin Core yet.


Title: Re: BIP0151 nodes detected on mainnet
Post by: Argon2 on September 18, 2017, 06:37:31 AM
That may be jonasschnelli doing some implementation and testing work for it, but AFAIK there are no pull requests to implement BIP 151 in Bitcoin Core yet.
ok, thanks!


Title: Re: BIP0151 nodes detected on mainnet
Post by: gmaxwell on September 18, 2017, 10:05:27 PM
Our node implementation has full support for bip-0151.
Might be a waste of your time there, I expect it to change when it gets review and public implementation work.

Quote
Why are we seeing and speaking to Bitcoin Core nodes with bip-0151 support on mainnet but no source code in GitHub. The paper says "Reference implementation" and it is blank. Is this closed source development we are detecting on mainnet or is there a public branch with the code? ???

You're probably connecting to fake bitcoin core nodes, there are a lot of them mostly run by blockchain analytics companies, thanks for identifying a new distinguisher.


Title: Re: BIP0151 nodes detected on mainnet
Post by: bitPico on September 19, 2017, 11:42:37 PM
If you ban nodes that contain the sequence Bitcoin ABC, Classic, BitcoinUnlimited or BuCash in the user agent string you will stop seeing these BIP0151 messages. We saw the same and they were coming from one or more of these user agents but no Core nodes.