|
Title: Bitcoin client svn: Problems closing dialogs (osx, wxwidgets svn) patch proposed Post by: piotrp on December 17, 2010, 03:16:38 PM I've compiled the bitcoin client from svn using, compiled against wxwidgets svn.
I can't close the "about" dialog and the "options" dialog. I've replaced the Close() calls with EndModal(false) to fix it. patch supplied as attachment, added .cpp extension as I'm not allowed to upload .diff files :S details: Mac OSX 10.6.5 i386 wxwidgets from svn revision 66398 bitcoin revision 204 Title: Re: Bitcoin client svn: Problems closing dialogs (osx, wxwidgets svn) patch proposed Post by: Gavin Andresen on December 17, 2010, 05:11:25 PM Works nicely on Linux, and is the recommended way to close dialogs.
Anybody able to give it a quick compile and test on Windows? Title: Re: Bitcoin client svn: Problems closing dialogs (osx, wxwidgets svn) patch proposed Post by: Gavin Andresen on December 20, 2010, 03:49:36 PM Anybody have a chance to compile/test this on Windows?
I created an Official Pull Request for this, which I will accept and apply unless I hear objections today: https://github.com/bitcoin/bitcoin/pull/9 |