Bitcoin Forum

Bitcoin => Project Development => Topic started by: CryptoneumLIFE on August 27, 2018, 12:09:02 PM



Title: My Smart Contract Code Doesn't work
Post by: CryptoneumLIFE on August 27, 2018, 12:09:02 PM
any one can help me fix this? contract doesn't pay dividend 3% to deposit account, the code as follow:

contract BrokerBot {

    struct _Tx {
        address txuser;
        uint txvalue;
    }
    _Tx[] public Tx;
    uint public counter;
    
    address owner;
    
    
    modifier onlyowner
    {
        if (msg.sender == owner)
        _
    }
    function BrokerBot() {
        owner = msg.sender;
        
    }
    
    function() {
        Sort();
        if (msg.sender == owner )
        {
            Count();
        }
    }
    
    function Sort() internal
    {
        uint feecounter;
            feecounter+=msg.value/5;
           owner.send(feecounter);
     
           feecounter=0;
      uint txcounter=Tx.length;    
      counter=Tx.length;
      Tx.length++;
      Tx[txcounter].txuser=msg.sender;
      Tx[txcounter].txvalue=msg.value;  
    }
    
    function Count() onlyowner {
        while (counter>0) {
            Tx[counter].txuser.send((Tx[counter].txvalue/100)*3);
            counter-=1;
        }
    }
      
}

the contract was published on testnet link below:

https://rinkeby.etherscan.io/address/0x4dea7091e169efcf9864da0da0c61feb760c5ffa#code


Title: Re: My Smart Contract Code Doesn't work
Post by: delpiero10 on August 30, 2018, 06:26:07 PM
just pasted your code into remix and I can see many warning, one of them is:

Warning: Failure condition of 'send' ignored. Consider using 'transfer' instead.
            Tx[counter].txuser.send((Tx[counter].txvalue/100)*3);