|
Title: Bug on the merit system? Post by: seoincorporation on December 28, 2018, 02:31:00 PM So, a couple of days ago i realize there is a bug on the merit engine.
When we are in the merit box ready to spend our merits: If we click two times the button it will send double merit before the forum send us to 'Merit sent!' page. And that way some users are getting double merits, sending double merits already happened to me once while i was sending merit to user bomj as you can see on the next image. And i think i get two merits on a publication for the same bug: Title: Re: Bug on the merit system? Post by: LoyceV on December 28, 2018, 02:56:05 PM This is a known bug/feature, but it doesn't occur very often. In March I made this list:
Occasions where the same user merited the same post twice at the exact same time 26 posts received the same number of Merit from the same user in the same second. This is caused by double clicking (https://bitcointalk.org/index.php?topic=3078328.msg31968794#msg31968794) the Send button: Two times 1 Merit from Syndikat (https://bitcointalk.org/index.php?action=profile;u=1175060) to undercomander13 (https://bitcointalk.org/index.php?action=profile;u=1160144) for this post (https://bitcointalk.org/index.php?topic=2308384.msg23419008#msg23419008). Two times 4 Merit from minerbro (https://bitcointalk.org/index.php?action=profile;u=882756) to Piston_82 (https://bitcointalk.org/index.php?action=profile;u=1144425) for this post (https://bitcointalk.org/index.php?topic=2699379.msg28859651#msg28859651). Two times 1 Merit from newegggo (https://bitcointalk.org/index.php?action=profile;u=255511) to moonriver (https://bitcointalk.org/index.php?action=profile;u=249147) for this post (https://bitcointalk.org/index.php?topic=2169122.msg28864339#msg28864339). Two times 4 Merit from aTriz (https://bitcointalk.org/index.php?action=profile;u=135920) to killyou72 (https://bitcointalk.org/index.php?action=profile;u=408367) for this post (https://bitcointalk.org/index.php?topic=2823221.msg28920985#msg28920985). Two times 1 Merit from johhnyUA (https://bitcointalk.org/index.php?action=profile;u=623643) to Gerhald (https://bitcointalk.org/index.php?action=profile;u=381304) for this post (https://bitcointalk.org/index.php?topic=2818398.msg28950289#msg28950289). Two times 1 Merit from TMAN (https://bitcointalk.org/index.php?action=profile;u=98986) to Lauda (https://bitcointalk.org/index.php?action=profile;u=101872) for this post (https://bitcointalk.org/index.php?topic=2827555.msg28999372#msg28999372). Two times 1 Merit from TK14 (https://bitcointalk.org/index.php?action=profile;u=898664) to John(JohnK.) (https://bitcointalk.org/index.php?action=profile;u=31288) for this post (https://bitcointalk.org/index.php?topic=86804.msg953593#msg953593). Two times 1 Merit from JCbtc (https://bitcointalk.org/index.php?action=profile;u=916474) to 1Referee (https://bitcointalk.org/index.php?action=profile;u=308793) for this post (https://bitcointalk.org/index.php?topic=2833083.msg29161886#msg29161886). Two times 1 Merit from Anna505 (https://bitcointalk.org/index.php?action=profile;u=1220613) to Krjkee (https://bitcointalk.org/index.php?action=profile;u=1256377) for this post (https://bitcointalk.org/index.php?topic=384821.msg29121875#msg29121875). Two times 1 Merit from Alluro (https://bitcointalk.org/index.php?action=profile;u=1170710) to Smpdytz (https://bitcointalk.org/index.php?action=profile;u=1250976) for this post (https://bitcointalk.org/index.php?topic=2576723.msg26430918#msg26430918). Two times 1 Merit from AlexLvov (https://bitcointalk.org/index.php?action=profile;u=1179987) to svv (https://bitcointalk.org/index.php?action=profile;u=1238657) for this post (https://bitcointalk.org/index.php?topic=2270173.msg28927901#msg28927901). Two times 1 Merit from williamevanl (https://bitcointalk.org/index.php?action=profile;u=205050) to centralbanksequalsbombs (https://bitcointalk.org/index.php?action=profile;u=971594) for this post (https://bitcointalk.org/index.php?topic=2865759.msg29421551#msg29421551). Two times 1 Merit from n00bby (https://bitcointalk.org/index.php?action=profile;u=954280) to Undland (https://bitcointalk.org/index.php?action=profile;u=289619) for this post (https://bitcointalk.org/index.php?topic=1394689.msg29508785#msg29508785). Two times 1 Merit from soy (https://bitcointalk.org/index.php?action=profile;u=73590) to Becassine (https://bitcointalk.org/index.php?action=profile;u=1224889) for this post (https://bitcointalk.org/index.php?topic=2313254.msg29604257#msg29604257). Two times 1 Merit from Dvach (https://bitcointalk.org/index.php?action=profile;u=984782) to AlexZHankok (https://bitcointalk.org/index.php?action=profile;u=1245858) for this post (https://bitcointalk.org/index.php?topic=2846459.msg29198113#msg29198113). Two times 1 Merit from miha74 (https://bitcointalk.org/index.php?action=profile;u=999197) to klim75 (https://bitcointalk.org/index.php?action=profile;u=1687608) for this post (https://bitcointalk.org/index.php?topic=2202817.msg29758214#msg29758214). Two times 6 Merit from pisston (https://bitcointalk.org/index.php?action=profile;u=864139) to ckorbba (https://bitcointalk.org/index.php?action=profile;u=864125) for this post (https://bitcointalk.org/index.php?topic=2674919.msg29093646#msg29093646). Two times 1 Merit from sheamus10 (https://bitcointalk.org/index.php?action=profile;u=1034862) to Asyifiah (https://bitcointalk.org/index.php?action=profile;u=735497) for this post (https://bitcointalk.org/index.php?topic=2255748.msg30112467#msg30112467). Two times 5 Merit from SmartIphone (https://bitcointalk.org/index.php?action=profile;u=374823) to vlad230 (https://bitcointalk.org/index.php?action=profile;u=1268116) for this post (https://bitcointalk.org/index.php?topic=2891680.msg29727954#msg29727954). Two times 5 Merit from SmartIphone (https://bitcointalk.org/index.php?action=profile;u=374823) to hugeblack (https://bitcointalk.org/index.php?action=profile;u=1059082) for this post (https://bitcointalk.org/index.php?topic=2808477.msg28740279#msg28740279). Two times 5 Merit from SmartIphone (https://bitcointalk.org/index.php?action=profile;u=374823) to 01BTC (https://bitcointalk.org/index.php?action=profile;u=1756786) for this post (https://bitcointalk.org/index.php?topic=2873190.msg29505423#msg29505423). Two times 2 Merit from mellorbo (https://bitcointalk.org/index.php?action=profile;u=124041) to zzxswqq (https://bitcointalk.org/index.php?action=profile;u=2439) for this post (https://bitcointalk.org/index.php?topic=2239458.msg30329191#msg30329191). Two times 5 Merit from julian071 (https://bitcointalk.org/index.php?action=profile;u=393354) to BTCMILLIONAIRE (https://bitcointalk.org/index.php?action=profile;u=387921) for this post (https://bitcointalk.org/index.php?topic=178336.msg30439376#msg30439376). Two times 1 Merit from siti25 (https://bitcointalk.org/index.php?action=profile;u=870185) to vlad230 (https://bitcointalk.org/index.php?action=profile;u=1268116) for this post (https://bitcointalk.org/index.php?topic=2770113.msg29460268#msg29460268). Two times 1 Merit from teddy5145 (https://bitcointalk.org/index.php?action=profile;u=513960) to marlboroza (https://bitcointalk.org/index.php?action=profile;u=787736) for this post (https://bitcointalk.org/index.php?topic=2970226.msg30532767#msg30532767). Two times 1 Merit from aTriz (https://bitcointalk.org/index.php?action=profile;u=135920) to Craige288 (https://bitcointalk.org/index.php?action=profile;u=147040) for this post (https://bitcointalk.org/index.php?topic=3009408.msg30941866#msg30941866). Title: Re: Bug on the merit system? Post by: DdmrDdmr on December 28, 2018, 04:06:26 PM I was taking a look into this too. Since there was a 1 second gap in the @OgNasty -> @seoincorporation example in the OP, grouping by exact time would not catch these cases, so I went on to giving a 2 second margin (searching for all TXs within a 2 second gap with the same implied users and message and date).
I make it 317 TXs historically by the above criteria (see https://docs.google.com/spreadsheets/d/1JmMF_SZX0oWgK8L2BL-lkB0aDMAIW7HB2OWJKXxtrag/edit?usp=sharing), with 155 different real intended TX sends (the others are side effects of double or triple clicking the send button). No too many cases, and roughly let’s say half of the implied sMerits being non-intentional (602 sMerits -> would mean 301 non-intentional sent sMerits historically). Title: Re: Bug on the merit system? Post by: Findingnemo on December 28, 2018, 04:20:48 PM Already reported by many people,having cool down time between the two merit transaction will help to resolve this issue.Hopefully theymos will identify this bug and sort of the problem.
Two AI were fighting so hard to beat satoshi on merit list. ;D Title: Re: Bug on the merit system? Post by: jackg on December 28, 2018, 04:27:37 PM I don't think it was worth making a thread on it, but if you hit the button on public WiFi it can send twice (if there's more than one router and you get switched between the two during that time, I was sat very near one of the routers too so I don't know why I was moved across.
As the others have said, this is a known thing as well as refreshing the merit sent page. It's not a bug, I think it was theymos intention. Title: Re: Bug on the merit system? Post by: Yeahpro on December 28, 2018, 06:14:54 PM A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.
An issue that should be resolved is the '0' that is by default on the box for selecting number of merits to send. The number of merits has to be delicately positioned after the 0, or the zero cleared first. It adds nothing, as it's impossible to send zero merits and there's the chance a user could send 10 merits when trying to send 1. This poses an issue to members with lots of smerits available. Title: Re: Bug on the merit system? Post by: Obiwankenodium on December 28, 2018, 06:39:53 PM A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding. A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders. Title: Re: Bug on the merit system? Post by: LoyceV on December 28, 2018, 06:56:39 PM A cooldown of 10-30 secons would be enough i guess The 4 seconds between reporting posts is already annoying and slowing me down!Quote and it wouldt harm the rapid merit senders. See:Code: October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast. All it takes is 4 clicks :)Title: Re: Bug on the merit system? Post by: jackg on December 28, 2018, 07:08:40 PM A cooldown of 10-30 secons would be enough i guess The 4 seconds between reporting posts is already annoying and slowing me down!Quote and it wouldt harm the rapid merit senders. See:Code: October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast. I'm guessing you read a lot of posts and just start opening the merit link in a new tab ready to hammer the 1 and the send button. I think this is just proof that you're a bit though from this point ;D. A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding. A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders. 10 seconds would probably harm me sometimes... Title: Re: Bug on the merit system? Post by: seoincorporation on December 28, 2018, 07:52:35 PM A cooldown of 10-30 secons would be enough i guess The 4 seconds between reporting posts is already annoying and slowing me down!Quote and it wouldt harm the rapid merit senders. See:Code: October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast. I'm guessing you read a lot of posts and just start opening the merit link in a new tab ready to hammer the 1 and the send button. I think this is just proof that you're a bit though from this point ;D. With that hardware, you could run a lot of virtual machines and give one merit from each one at the same time with iMacros. A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding. A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders. The server shouldn't let you send merits on the same second, for a reason it doesn't let us make posts on that time rate, and that's the first bug. That bug could be fixed with a cooldown of 1 or 2 seconds. The second bug is on the 'Send' button, it shouldn't be clickable after we already make click. ;) Title: Re: Bug on the merit system? Post by: jackg on December 28, 2018, 08:00:43 PM The server shouldn't let you send merits on the same second, for a reason it doesn't let us make posts on that time rate, and that's the first bug. That bug could be fixed with a cooldown of 1 or 2 seconds. The second bug is on the 'Send' button, it shouldn't be clickable after we already make click. ;) A 1 second delay might be enough but I'm not entirely sure how you'd do it, the current implementation for the 1 second delay would mean you'd still end up refreshing your screen and double spending merit as there is a global one second delay for everything on the forum when a new page loads (other than the merit one clearly)... Title: Re: Bug on the merit system? Post by: pugman on December 28, 2018, 11:19:34 PM I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast. Its fairly plausible. Its more likely to happen by a person who's bound to use shortcuts and whose hands work faster than the brain. Also, where the fuck do you live to get 1GBps WiFi? If you don't mind me asking, I'm guessing wales, but i don't want to assume anything. Will this bug or whatever you wanna call it ever be patched? Title: Re: Bug on the merit system? Post by: mikeywith on December 29, 2018, 12:20:03 AM Also, where the fuck do you live to get 1GBps WiFi? If you don't mind me asking, I'm guessing wales, but i don't want to assume anything. first thing first, he probably means 1Gbps and that's 125mBps , also i don't think he is referring to the the ISP bandwidth but rather his local network router. which could be the gateway to an old slow dial up connection with only 56 kbit/s. with that being said, the speed of how fast you can actually post/merit which basically an "update or insert" command into the database of bitcointalk is irrelevant. even if you were using the fastest internet speed on planet earth you will still be limited by the speed of the database engine as well as the server it runs on. so the fast merits you done there are nothing but result of your fast "hands" rather than the speed of your internet or computer. ------------------------------------------- as for the bug, i noticed that too, i think the easiest solution would be to be to close the page after the button is clicked, since the merit page is useless after having sent the merit as it opens in a new tab. so that will be more like hitting 2 birds with 1 stone. Title: Re: Bug on the merit system? Post by: theymos on December 29, 2018, 01:15:15 AM Alright, you now can't merit the same post with the same amount within 60 seconds.
Title: Re: Bug on the merit system? Post by: vit05 on December 29, 2018, 02:17:32 AM Alright, you now can't merit the same post with the same amount within 60 seconds. I just did. https://bitcointalk.org/index.php?action=merit;u=194811 I have opened two windows to send merit and when I hit the second one, I merit two times. Title: Re: Bug on the merit system? Post by: theymos on December 29, 2018, 02:41:13 AM I just did. OK, now it should be impossible no matter how much you try. Title: Re: Bug on the merit system? Post by: cabalism13 on December 29, 2018, 03:37:38 AM OK, now it should be impossible no matter how much you try. [+1] :D :D ;D ;D ;D :D :D @vit05 you did a great job pal, you certainly got theymos back there hahaha Title: Re: Bug on the merit system? Post by: Vod on December 29, 2018, 05:18:49 AM I just did. OK, now it should be impossible no matter how much you try. Ok, I think that was a cheap trick to get extra merits... :P Title: Re: Bug on the merit system? Post by: Vod on December 29, 2018, 05:20:05 AM OK, now it should be impossible no matter how much you try. [+1] :D :D ;D ;D ;D :D :D @vit05 you did a great job pal, you certainly got theymos back there hahaha And you sir, got five merits by mistake. :/ Title: Re: Bug on the merit system? Post by: cabalism13 on December 29, 2018, 06:00:37 AM And you sir, got five merits by mistake. :/ I knew it!, well you did it again on me :) (see Merit History) haha well anyway thanks. And No worries I'm gonna spend this on worthies :) Title: Re: Bug on the merit system? Post by: JusticeForYou on December 29, 2018, 06:23:51 AM Quote from: vit05 link=topic=5090492.msg48940012#msg48940012 I just did. This could be the best sacrifice of merits to upgrade the merit system. Great work bro! ;)https://bitcointalk.org/index.php?action=merit;u=194811 I have opened two windows to send merit and when I hit the second one, I merit two times. Title: Re: Bug on the merit system? Post by: OgNasty on December 29, 2018, 09:10:48 AM I was taking a look into this too. Since there was a 1 second gap in the @OgNasty -> @seoincorporation example in the OP I was on my mobile and when I tapped the button to submit merit, it registered as a double tap submitting twice. Nobody asked but figured I’d explain anyway. Title: Re: Bug on the merit system? Post by: LoyceV on December 29, 2018, 10:28:52 AM Alright, you now can't merit the same post with the same amount within 60 seconds. Different amounts still work, I'm fine with this workaround to protect users against their double click habits :)Title: Re: Bug on the merit system? Post by: The Cryptovator on December 29, 2018, 11:44:49 AM I just did. OK, now it should be impossible no matter how much you try. Yes, now working fine. I just tried to merit you with different 2 window but it's not possible now. I think now merit abuser can't excuse that I have sent by mistake. I have remembered few abuser excuse like this. Alright, you now can't merit the same post with the same amount within 60 seconds. Different amounts still work, I'm fine with this workaround to protect users against their double click habits :)Doesn't matter if different amount, because amount different means you are fully aware that you are going to send another amount of merit to same post. Title: Re: Bug on the merit system? Post by: aervin11 on December 29, 2018, 03:05:32 PM Since this is a bug, is this double click double merit thing only works if you have enough spendable merit? I mean If I have one spendable merit, then this won't work on me right?
Title: Re: Bug on the merit system? Post by: seoincorporation on December 29, 2018, 03:54:14 PM I just did. OK, now it should be impossible no matter how much you try. Thanks for your reply and for fixing the bug. Isn't a real destructive bug, but 301 non-intentional sent sMerits is something since merits are an unreversible action. And want to thanks the community too, thanks guys for your help to solve this issue, not let's enjoy the last weekend of the year. ;) Since this is a bug, is this double click double merit thing only works if you have enough spendable merit? I mean If I have one spendable merit, then this won't work on me right? No, with one merit shouldn't work. Title: Re: Bug on the merit system? Post by: Buttermellow on December 29, 2018, 04:10:40 PM I was taking a look into this too. Since there was a 1 second gap in the @OgNasty -> @seoincorporation example in the OP, grouping by exact time would not catch these cases, so I went on to giving a 2 second margin (searching for all TXs within a 2 second gap with the same implied users and message and date). So there is no really bug with the merit system and it shows probably the slow internet connection which could not load up to the next page after sending the merit or pressing the send button. It is a due negligence of the user on how careful he was in sending the merit.I make it 317 TXs historically by the above criteria (see https://docs.google.com/spreadsheets/d/1JmMF_SZX0oWgK8L2BL-lkB0aDMAIW7HB2OWJKXxtrag/edit?usp=sharing), with 155 different real intended TX sends (the others are side effects of double or triple clicking the send button). No too many cases, and roughly let’s say half of the implied sMerits being non-intentional (602 sMerits -> would mean 301 non-intentional sent sMerits historically). Title: Re: Bug on the merit system? Post by: DdmrDdmr on December 29, 2018, 04:15:04 PM <...> Well the bug is no longer an issue, and has run the full software development cycle in a short amount of time: reported, measure of impact, resolved and rolled-out, tested, twitched and rolled-out, re-tested, verified and settled.Note: I looked through the list of cases I compiled with the 317 TXs (out of which half were likely due to the double/triple click ex-bug effect), and found no obvious case of the scenario you hypothesize (all lower ranked cases involved as Senders had enough sMerits to cover the double send at the time, and higher-ranked are more likely due to airdropped sMerit). <…> I wouldn’t really call it a user negligence … anyway, it was a minor incident that has been fixed or software-shaped to be avoided.Title: Re: Bug on the merit system? Post by: seoincorporation on January 02, 2019, 08:59:10 PM Can there be some relaxation in this Merit System? It don't allow the members to grow in ranks now. I mean my account is stuck at member since the introduction of this system and i think that is the case with alot of other people. Well, to become Full Member you need at least 100 merits, for more information take a look to: Quote FAQ: Everything you need to know about forum 'activity, account ranks and merit https://bitcointalk.org/index.php?topic=2766177.0To get those 90 merits you will have to post some good quality stuff. Good luck. Title: Re: Bug on the merit system? Post by: vit05 on January 30, 2019, 01:48:15 AM I guess no one has shown the image that appears. So just to show that the system seems to be working very well, avoiding double spending and Merits inflation. :D
Tks theymos. https://i.imgur.com/kaABOnL.jpg Title: Re: Bug on the merit system? Post by: seoincorporation on January 30, 2019, 03:21:41 AM I guess no one has shown the image that appears. So just to show that the system seems to be working very well, avoiding double spending and Merits inflation. :D Tks theymos. https://i.imgur.com/kaABOnL.jpg lol, i haven't get the message yet, but that was a nice answer. So, we this we fix the double spending merit problem, next goal? fix the double spending bitcoin problem :P Thanks theymos. Title: Re: Bug on the merit system? Post by: lobcmt2 on January 30, 2019, 03:37:41 AM I guess no one has shown the image that appears. So just to show that the system seems to be working very well, avoiding double spending and Merits inflation. :D You are a nice case study for the improvements made by theymos weeks ago.Tks theymos. https://i.imgur.com/kaABOnL.jpg After the improvements, meriters can not send their sMerits to the same posts with same amount of sMerits when they double click in the duration of 60 seconds. Alright, you now can't merit the same post with the same amount within 60 seconds. |
