Bitcoin Forum

Bitcoin => Bitcoin Technical Support => Topic started by: NotATether on June 13, 2023, 10:03:38 AM



Title: When was "createwallet" RPC added to Bitcoin Core?
Post by: NotATether on June 13, 2023, 10:03:38 AM
I need to surgically implant this RPC for a fork of the dogecoin full node (don't ask) to make my library work with all required cryptocurrencies, so I'm trying to look for the commit where the command was added.

Note: I already know where it's located in the current version of the codebase, but now it is using C++17 and so there will be a lot of hair-splitting agony trying to port it to C++11 doge :(

What I do know is that it's not in Bitcoin Core <= 0.15, so it must be in a more recent version. Any help locating it using "git blame" or something will be appreciated.


Title: Re: When was "createwallet" RPC added to Bitcoin Core?
Post by: nc50lc on June 13, 2023, 10:12:44 AM
According to ChainQuery, it's available since version 0.17.0.
I did not research to confirm it though.

Reference: https://chainquery.com/bitcoin-cli/createwallet (https://chainquery.com/bitcoin-cli/createwallet)


Title: Re: When was "createwallet" RPC added to Bitcoin Core?
Post by: NotATether on June 13, 2023, 10:21:57 AM
Perfect, thanks both of you.


Title: Re: When was "createwallet" RPC added to Bitcoin Core?
Post by: achow101 on June 13, 2023, 02:27:11 PM
https://github.com/bitcoin/bitcoin/pull/13058