Bitcoin Forum

Other => Meta => Topic started by: BitcoinGirl.Club on August 01, 2024, 06:10:08 AM



Title: Topic locked but the quote button is still active.
Post by: BitcoinGirl.Club on August 01, 2024, 06:10:08 AM
I am noticing some changes which includes no factoid anymore. I used to like it a lot.
We now have the quote button active when a topic is locked.
https://talkimg.com/images/2024/08/01/5ZYlb.png

These two changes do not look good to me. Having no quote button for locked topic was good, we would not need to waste the time to write a response then discover the topic is locked. Also the factoids were good too.


Title: Re: Topic locked but the quote button is still active.
Post by: Apocollapse on August 01, 2024, 06:40:24 AM
It's weird you see an "active thread" based on quote button.

Before you open the thread, you will see padlock icon, even you accidentally open the thread, the locked topic has no reply button on the top right.

I see most people like it Quoting from locked threads (SMF patch) (https://bitcointalk.org/index.php?topic=5499453.0), so I don't think we will see changes..


Title: Re: Topic locked but the quote button is still active.
Post by: mindrust on August 01, 2024, 06:42:49 AM
It is a good change as people who got sick of not being able to quote locked posts (like me) were already using an addon/plugin/script whatever…

Why was it there in the first place? Gj dev team for deleting obstacles.


Title: Re: Topic locked but the quote button is still active.
Post by: joker_josue on August 01, 2024, 06:43:41 AM
The idea of ​​the quote button remaining active is to be able to copy quotes from any post at any time.

I had the idea that information would emerge that the topic was closed. But it seems that there is no such message after all.  :-\


Title: Re: Topic locked but the quote button is still active.
Post by: _act_ on August 01, 2024, 06:44:47 AM
In a locked thread, the reply icon is not there. Also the quote button will not be in blue but pale, unlike the thread that is not locked which the quote button is in blue.

What I will just like is that there should be a warning at the top in red, making it obviousl that the thread is locked because with all these that I know, I still make mistake to try to reply to the thread. Although the reply is not working but what if I quote instead. Although if you quote, the post button will not be seen and it is obvious which is enough to know that you can not post on the thread.

I like the way it is now. I have no complaints about it even if nothing changed. But if there is a warning in red at the top indicating the thread is locked, it would be good also.


Title: Re: Topic locked but the quote button is still active.
Post by: Cantsay on August 01, 2024, 11:37:19 AM

I like the way it is now. I have no complaints about it even if nothing changed. But if there is a warning in red at the top indicating the thread is locked, it would be good also.

Although it’s not in red but there’s a warning at the top of a locked thread thread when quoted.

If it’s turned to red color it would make it more noticeable than it is right now, which would be better.

https://talkimg.com/images/2024/08/01/5nNrq.jpeg


Title: Re: Topic locked but the quote button is still active.
Post by: Findingnemo on August 01, 2024, 11:54:22 AM

I like the way it is now. I have no complaints about it even if nothing changed. But if there is a warning in red at the top indicating the thread is locked, it would be good also.

Although it’s not in red but there’s a warning at the top of a locked thread thread when quoted.

If it’s turned to red color it would make it more noticeable than it is right now, which would be better.

https://talkimg.com/images/2024/08/01/5nNrq.jpeg

Red will make it more visible than any other color, like what we see after session expired or new replies were added.

We are seeing a lot of changes to the forum in this year than every other year combined since my existence here, so people who used to the UI may take a while to adapt to the recent changes.


Title: Re: Topic locked but the quote button is still active.
Post by: joker_josue on August 01, 2024, 12:47:15 PM

I like the way it is now. I have no complaints about it even if nothing changed. But if there is a warning in red at the top indicating the thread is locked, it would be good also.

Although it’s not in red but there’s a warning at the top of a locked thread thread when quoted.

If it’s turned to red color it would make it more noticeable than it is right now, which would be better.

https://talkimg.com/images/2024/08/01/5nNrq.jpeg

Exactly, there is a warning. I had this idea.
Now, it could really stand out a little more relevant, compared to what it currently has.

@PowerGlove do you think this highlight could be improved?


Title: Re: Topic locked but the quote button is still active.
Post by: Peanutswar on August 01, 2024, 01:59:29 PM
I just recently noticed this because I want to quote a post of mine but I remember that I locked the thread so I made a second look on the thread I created to make sure I locked it already for me, this feature is very convenient we can now quote those replies and we don't need to use the quote tag and then put the link and author at the same time if needed as their references, just the quote itself. A thumbs up for this improvement. I like too if the lock thread will be added in the upper right corner.


Title: Re: Topic locked but the quote button is still active.
Post by: dzungmobile on August 01, 2024, 02:14:34 PM
I see most people like it Quoting from locked threads (SMF patch) (https://bitcointalk.org/index.php?topic=5499453.0), so I don't think we will see changes..
PowerGlove made the SMF patch that was approved by theymos.

The announcement of approval
Nice! It's a pretty self-contained patch, so I was able to add it fairly easily. I left a warning on the post page, though, since I don't think it was otherwise obvious enough what was going on.

We now have the quote button active when a topic is locked.
It's nearly two months since the approval of the patch, BitcoinGirl.Club you are late to the party  :D


Title: Re: Topic locked but the quote button is still active.
Post by: Upgrade00 on August 01, 2024, 02:36:39 PM
Having no quote button for locked topic was good, we would not need to waste the time to write a response then discover the topic is locked.
Having no quote button was a headache for those who wanted to quote from locked topics in a different thread. I ran into that issue many a times before this patch was implemented.

When you reach a locked topic there's a padlock right besides it. When you open the thread, the "reply" icon is also not available and the padlock sign is on the page too. If you somehow missed that, when you click the quote button in a locked thread there's no post option, so that should be a pointer not to write a response.

I think it's a great feature and was implemented as best as it could be


Title: Re: Topic locked but the quote button is still active.
Post by: skarais on August 01, 2024, 02:55:51 PM
I like the improvements to the forum so far and one of them is that I can now quote any post on a locked topic. The idea has been quite useful for me so far and I welcome the improvements, but of course some users may not find it great.

I might wonder why the warning word isn't made red or some other prominent color to prevent someone from replying on a topic that is already locked?
It could be that someone rushes to reply without noticing that the topic is already locked.

Example:

Quote
This topic is locked, so you can't actually reply!


Title: Re: Topic locked but the quote button is still active.
Post by: Mate2237 on August 01, 2024, 02:58:02 PM
Snip
I am also just seeing it and I clicked on one of them to see if I can make comments and send but there is no post or send button. You can only type but you can't preview or send so there is big problem for that. But it is good to disable the feature since it is not on use. PowerGlove was looking for some to do to busy himself so probably he has found out this.

But I am also seeing a usefulness of the quote button showing on the locked thread. If there is link which someone is interested to use them the person can click on the quote and copy the link and use it. So to some extent it is good feature showing there.

No link to click send or post.
https://www.talkimg.com/images/2024/08/01/5nxa2.jpeg


Title: Re: Topic locked but the quote button is still active.
Post by: Lafu on August 01, 2024, 02:58:56 PM
Having no quote button was a headache for those who wanted to quote from locked topics in a different thread. I ran into that issue many a times before this patch was implemented.
I think it's a great feature and was implemented as best as it could be
Yeb same here , it was few times a headache or let say a bit laborious to quote from locked topics before it was implemented.
One of the best feature we got lately here on the Forum.

It's nearly two months since the approval of the patch, BitcoinGirl.Club you are late to the party  :D
First i was thinking the same , but dont know how often he/she is online and things.

These two changes do not look good to me.
Having no quote button for locked topic was good, we would not need to waste the time to write a response then discover the topic is locked.
I really see no problem with the quote button for locked topics , you are long enough here to see if the topic is locked or not.
But yeah the Info that topic is locked should be maybe in a red color to see it better or be aware earlier.


Title: Re: Topic locked but the quote button is still active.
Post by: Z_MBFM on August 01, 2024, 04:54:13 PM
This is a very good update. Earlier it was a lot of trouble to quote a post from a locked topic. Script, extension etc. had to be used for this. Now we don't have to worry about that.

Previously, when I used to manually quote a post on a lock topic, I could not set the exact time on that post. So for me this new update will help a lot


Title: Re: Topic locked but the quote button is still active.
Post by: PowerGlove on August 01, 2024, 05:04:34 PM
@PowerGlove do you think this highlight could be improved?
Ha! In the original patch, I actually disabled the existing locked-topic warning and left this comment:

// Skip this if we're in the context of a "peek" request. (This warning *seems* germane in this context, but it's not: the whole point of "peek" requests is to allow messages to be inspected from inside locked topics, so warning the user about something that they already know, and against an action that they're unable to take, is pretty silly.)

In hindsight, there's a (human-shaped) hole in that rationale, so I think theymos was right to add a notice. Personally, I'm happy with the current placement/style, but if I go hunting for something to improve in that area, then I suppose it would be harder to miss (and perhaps more logical) if it were closer to where the "Post" and "Preview" buttons would have been, like this:

https://talkimg.com/images/2024/08/01/5CQtw.png

(That just involves taking the existing <tr> for that notice, and moving it to the end of its containing <table>, and then changing align="left" to align="middle" on the second child <td>.)

My point of view: Ignoring edge cases like the topic becoming locked while you were already browsing it, I struggle to see how someone could miss both the padlock icon before entering the topic, and the gray-instead-of-blue quote button with the "Inspect message" tooltip (and the "Inspect message" page title, and the notice that theymos added, too)... If you (the proverbial "you", not you specifically, obviously) often find yourself in a position where you've blown past all that, and end up confused, then I'll stop just shy of calling you an idiot, but, chances are good that you should do some introspection around your posting habits, because being blissfully unaware of whether or not a given topic has run its course is something I can only imagine repeatedly happening to someone that posts a lot of donkey twaddle.


Title: Re: Topic locked but the quote button is still active.
Post by: acroman08 on August 01, 2024, 05:25:06 PM
These two changes do not look good to me. Having no quote button for locked topic was good, we would not need to waste the time to write a response then discover the topic is locked. Also the factoids were good too.
I think it is a good change, it makes it easier to quote posts from locked threads. it is usually noticeable when a thread is locked since the lock icon is right next to the title of the thread so I think there won't be a lot of people wasting their time writing a reply since it is noticeable when a thread is locked.

also, I just want to add that this SMF patch is probably a godsend to forum members who uses phones to access the forum because quoting posts from locked threads is so much easier now.


Title: Re: Topic locked but the quote button is still active.
Post by: joker_josue on August 01, 2024, 06:57:53 PM
My point of view: Ignoring edge cases like the topic becoming locked while you were already browsing it, I struggle to see how someone could miss both the padlock icon before entering the topic, and the gray-instead-of-blue quote button with the "Inspect message" tooltip (and the "Inspect message" page title, and the notice that theymos added, too)... If you (the proverbial "you", not you specifically, obviously) often find yourself in a position where you've blown past all that, and end up confused, then I'll stop just shy of calling you an idiot, but, chances are good that you should do some introspection around your posting habits, because being blissfully unaware of whether or not a given topic has run its course is something I can only imagine repeatedly happening to someone that posts a lot of donkey twaddle.

I thought of a warning similar to the warning that occurs when a new post appears, before we post. But in this case it appears as soon as we enter the page.

Honestly, I don't think it's very difficult for people not to notice the closed topic. It just needs to be a topic that the user usually visits or has on their watch list, and simply clicks on "new" to see the new posts, and doesn't even notice the closing before clicking on quote. Furthermore, the size of the icons is not that big.

Either way, for me, I think it's fine. I was just thinking of something to minimize what the OP reported.  ;)


Title: Re: Topic locked but the quote button is still active.
Post by: BitcoinGirl.Club on August 03, 2024, 03:27:59 PM
My point of view: Ignoring edge cases like the topic becoming locked while you were already browsing it, I struggle to see how someone could miss both the padlock icon before entering the topic, and the gray-instead-of-blue quote button with the "Inspect message" tooltip (and the "Inspect message" page title, and the notice that theymos added, too)... If you (the proverbial "you", not you specifically, obviously) often find yourself in a position where you've blown past all that, and end up confused, then I'll stop just shy of calling you an idiot, but, chances are good that you should do some introspection around your posting habits, because being blissfully unaware of whether or not a given topic has run its course is something I can only imagine repeatedly happening to someone that posts a lot of donkey twaddle.
I noticed the tooltip now, I did not know it was even existed before reading you LOL

https://i.ibb.co/PTRLP5h/Screenshot-1.png
https://i.ibb.co/wMK8Msm/Screenshot-2.png

But I must have color recognizing issue. I see both buttons have same color and I can not identify which one is gray and the other one blue.


Title: Re: Topic locked but the quote button is still active.
Post by: Pmalek on August 03, 2024, 04:03:36 PM
But I must have color recognizing issue. I see both buttons have same color and I can not identify which one is gray and the other one blue.
It's barely noticeable, especially on a screen of lower quality. Pay attention to the text in the "Quote" button. It's blue in open topics, grey in closed topics. The outside border of the button is blue in open threads but grey in closed ones. I also notice a slight bluish filling in the buttons in open threads.

Grey on top, Blue at the bottom. Do you see it?
https://www.talkimg.com/images/2024/08/03/5tIzT.jpeg


Title: Re: Topic locked but the quote button is still active.
Post by: AVE5 on August 03, 2024, 04:16:09 PM
The idea of ​​the quote button remaining active is to be able to copy quotes from any post at any time.

I had the idea that information would emerge that the topic was closed. But it seems that there is no such message after all.  :-\

Probably not just to copy the quote as I think but also to reveal the raw link if the thread contains some source links and edited on the URL.


Title: Re: Topic locked but the quote button is still active.
Post by: nakamura12 on August 03, 2024, 06:24:15 PM
The idea of ​​the quote button remaining active is to be able to copy quotes from any post at any time.

I had the idea that information would emerge that the topic was closed. But it seems that there is no such message after all.  :-\

Probably not just to copy the quote as I think but also to reveal the raw link if the thread contains some source links and edited on the URL.
Active quote button is most likely being used to copy the post in a thread that is locked. I also done the same where I am quoting the post and share it to where I am joining in discussions. If I haven't see the color difference between the quote then I wouldn't have known that it has different colors when it is locked and open topics. What you explained is also what people do to check if there are urls or not but as I have said, it is mostly for quoting posts for reference to different topics through using quote.