|
Title: [PULL] add 'settxfee' RPC Post by: xf2_org on April 12, 2011, 10:55:36 PM URL: https://github.com/bitcoin/bitcoin/pull/150 Add 'settxfee' RPC, to change TX fee setting at runtime This clamps TX fee, if not zero, between "network minimum" (0.01) and 5 BTC (IMO sanity limit). Presumably, the "network minimum" might be lowered, as is occasionally discussed on IRC and forum. This RPC prevents setting TX fee below network minimum. Title: Re: [PULL] add 'settxfee' RPC Post by: Luke-Jr on April 12, 2011, 11:56:53 PM This introduces a regression, since -settxfee accepts <0.01 right now, and it's sane to do so.
Title: Re: [PULL] add 'settxfee' RPC Post by: xf2_org on April 13, 2011, 12:14:53 AM This introduces a regression, since -settxfee accepts <0.01 right now, and it's sane to do so. That's intentional, not a regression. Title: Re: [PULL] add 'settxfee' RPC Post by: j16sdiz on April 13, 2011, 12:38:24 AM Remove the if (nAmount < CENT) and if (nAmount > (5 * COIN)) check.
API should be as powerful as (if not more powerful then) command line. Title: Re: [PULL] add 'settxfee' RPC Post by: Luke-Jr on April 13, 2011, 01:48:34 AM This introduces a regression, since -settxfee accepts <0.01 right now, and it's sane to do so. That's intentional, not a regression.Title: Re: [PULL] add 'settxfee' RPC Post by: Gavin Andresen on April 14, 2011, 01:54:09 AM I can see the GUI not allowing a less-than-CENT to save fat-fingered users from themselves, but I think the RPC should allow it; at the very least it makes it possible for a kind of grass-roots movement to arise between miners and people generating transactions so if we start seeing a lot of transactions with less-than-CENT-per-kbyte-fees then that's a really good indication the default definition of "free" needs to change.
And now that the RPC and GUI allow full-precision amounts for send/move, there is no problem with "I got 50.000001 bitcoins from mining, how do I send ALL of them?" Title: Re: [PULL] add 'settxfee' RPC Post by: xf2_org on April 14, 2011, 04:57:25 AM Updated pull request, removing the ValidFee() check.
|