|
Title: Has someone actually revised the entire code? Post by: kristoffernolgren on April 28, 2011, 01:59:43 PM So the code is open-source and revisable wich is good, but has someomne actully looked through the entire code?
Title: Re: Has someone actually revised the entire code? Post by: Mike Hearn on April 28, 2011, 02:12:38 PM I've looked through most of it. All the important parts for payment verification anyway. I think a few others have too (Hal, for one).
Now, that doesn't mean I'm fully convinced it's correct. BitCoin is VERY complicated. Title: Re: Has someone actually revised the entire code? Post by: khal on April 28, 2011, 02:15:34 PM Several people are working on different bitoin parts and propose patches (see : https://github.com/bitcoin/bitcoin/pulls).
So we can't say with that that all code has been reviewed, but it's a good start :p Title: Re: Has someone actually revised the entire code? Post by: asdf on April 28, 2011, 02:47:59 PM Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
Title: Re: Has someone actually revised the entire code? Post by: ribuck on April 28, 2011, 03:00:39 PM Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough? You don't get total coverage by separately reviewing every part of the code, because the different parts of the code may interact in ways that were not anticipated.Title: Re: Has someone actually revised the entire code? Post by: LZ on April 29, 2011, 09:38:56 AM I've looked through most of it. All the important parts for payment verification anyway. What you think about the 0.3.21 release? It seems that it requires mandatory fee. :-\Title: Re: Has someone actually revised the entire code? Post by: laanwj on April 29, 2011, 10:37:07 AM There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source.
https://code.google.com/p/bitcoinj/ Title: Re: Has someone actually revised the entire code? Post by: Pieter Wuille on April 29, 2011, 10:37:53 AM There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source. https://code.google.com/p/bitcoinj/ That guy was even the first to respond in this thread :) Title: Re: Has someone actually revised the entire code? Post by: laanwj on April 29, 2011, 10:43:02 AM Ha, didn't know his forum name :)
Title: Re: Has someone actually revised the entire code? Post by: xf2_org on April 30, 2011, 12:37:51 AM I've looked through most of it. All the important parts for payment verification anyway. What you think about the 0.3.21 release? It seems that it requires mandatory fee. :-\Not sure what you mean by this? Normal transactions remain free. Title: Re: Has someone actually revised the entire code? Post by: ShadowOfHarbringer on April 30, 2011, 09:20:07 AM I've looked through most of it. All the important parts for payment verification anyway. What you think about the 0.3.21 release? It seems that it requires mandatory fee. :-\?? Explain. Title: Re: Has someone actually revised the entire code? Post by: Cdecker on April 30, 2011, 10:54:34 AM We could pass all revisions through Gerrit to enforce Code review and sign-off... :D
Title: Re: Has someone actually revised the entire code? Post by: LZ on April 30, 2011, 11:19:55 AM Steps to reproduce:
1) withdraw X BTC from Mt.Gox; 2) then you will get it with 0.3.21; 3) try to send it to some address. If you will close 0.3.21 and run <0.3.21 - it will send without any fee. Title: Re: Has someone actually revised the entire code? Post by: Matt Corallo on April 30, 2011, 11:27:38 AM Steps to reproduce: Not the right thread, and gavin answered it at http://bitcointalk.org/index.php?topic=6642.msg99523#msg99523 (http://bitcointalk.org/index.php?topic=6642.msg99523#msg99523)1) withdraw X BTC from Mt.Gox; 2) then you will get it with 0.3.21; 3) try to send it to some address. If you will close 0.3.21 and run <0.3.21 - it will send without any fee. Title: Re: Has someone actually revised the entire code? Post by: LZ on April 30, 2011, 11:43:32 AM Yeah, you are right, sorry about that. It is not the right thread. I just read Gavin's answer. Thanks.
|