Bitcoin Forum

Bitcoin => Development & Technical Discussion => Topic started by: SilentCicer0 on November 08, 2014, 05:48:11 PM



Title: Where does the 40Byte OP_RETURN Restriction Exist in the Code?
Post by: SilentCicer0 on November 08, 2014, 05:48:11 PM
Where in the Bitcoin wallet code is the 40byte restriction for OP_RETURN transactions enforced?

So far, I've found material in the code on lines:
328 **src/script/script.h
, 678 **src/main.cpp
, 57 **src/script/standard.cpp

Is the 40byte restriction enforced in the code, or is there something I'm missing here?


... Answered my own question again... I think I found it here:
https://github.com/bitcoin/bitcoin/pull/3737/files


For anyone else who wants to read about OP_RETURN, this post was pretty sweet:
http://bitcoin.stackexchange.com/questions/29554/explanation-of-what-an-op-return-transaction-looks-like


Cheers,
SC.


References:
https://github.com/bitcoin/bitcoin/search?utf8=%E2%9C%93&q=OP_RETURN
https://en.bitcoin.it/wiki/Script
http://coinsecrets.org/
http://bitcoin.stackexchange.com/questions/23024/op-return-data-transaction


Title: Re: Where does the 40Byte OP_RETURN Restriction Exist in the Code?
Post by: instagibbs on November 08, 2014, 09:02:23 PM
https://github.com/bitcoin/bitcoin/pull/3737

Should be everything needed.


Title: Re: Where does the 40Byte OP_RETURN Restriction Exist in the Code?
Post by: Remember remember the 5th of November on November 09, 2014, 02:32:15 PM
https://github.com/bitcoin/bitcoin/pull/3737

Should be everything needed.
If you actually look a bit closer, 6-7 guys are responsible for whatever gets in the client.


Title: Re: Where does the 40Byte OP_RETURN Restriction Exist in the Code?
Post by: altcoinex on December 06, 2014, 04:47:56 PM
https://github.com/bitcoin/bitcoin/pull/3737/files#diff-4f6d60b6976522cec2974a0aea9a5ab3R296 In specific should show the code in question...


Title: Re: Where does the 40Byte OP_RETURN Restriction Exist in the Code?
Post by: dexX7 on December 08, 2014, 04:04:25 PM
If you actually look a bit closer, 6-7 guys are responsible for whatever gets in the client.

Likewise, there are a few open PRs addressing this topic:

Relay up to two (2) OP_RETURN outputs as IsStandard
https://github.com/bitcoin/bitcoin/pull/5075

Accept any sequence of PUSHDATAs in OP_RETURN outputs
https://github.com/bitcoin/bitcoin/pull/5079

Change the default maximum OP_RETURN size to 80 bytes
https://github.com/bitcoin/bitcoin/pull/5286