Bitcoin Forum

Bitcoin => Development & Technical Discussion => Topic started by: Gavin Andresen on December 16, 2010, 01:22:50 AM



Title: svn rev 103/104: listaccounts, listtransactions*, and -rpctimeout
Post by: Gavin Andresen on December 16, 2010, 01:22:50 AM
I just committed svn rev 103.  Changes are:

listaccounts :  lists all the accounts in your wallet along with their current balances.

listtransactions : call it with no arguments, or give it '*' as the account name, and it lists the last N (default 10, as before) transactions from all accounts.  Part of this change is disallowing '*' as an account name.

-rpctimeout : Thanks to Mt`AwAy who pointed out that, if somebody was allowed to connect to the bitcoin rpc port (via -rpcallowip), then they could connect, do nothing, and hang the connection, causing a denial-of-RPC-service.  Now bitcoin's RPC thread will close the connection if it doesn't get the HTTP request within -rpctimeout (default 30) seconds.


Title: Re: svn rev 103/104: listaccounts, listtransactions*, and -rpctimeout
Post by: Gavin Andresen on December 16, 2010, 06:24:05 PM
... and I just noticed an egregious bug:  listtransactions was reporting the receiving address instead of the account name for "receive" transactions.  Fix is svn rev 104.  Please bang on it and let me know if I screwed anything else up.

While I was committing, I also added "time" to transaction info output, and fixed a little bug reported a while ago (setgenerate true 0 is now the same as setgenerate false).


Title: Re: svn rev 103/104: listaccounts, listtransactions*, and -rpctimeout
Post by: bitcoinex on January 15, 2011, 02:30:39 PM
When will the official release of the next version of the client with these features?


Title: Re: svn rev 103/104: listaccounts, listtransactions*, and -rpctimeout
Post by: Gavin Andresen on January 15, 2011, 10:35:06 PM
When will the official release of the next version of the client with these features?

There's one tricky accounts-related bug that I think needs to get fixed before the next release:
   https://github.com/bitcoin/bitcoin/issues#issue/25

The only other possibly critical bug is:
  https://github.com/bitcoin/bitcoin/issues/#issue/28

... although I haven't been able to reproduce it, even running bitcoind on top of the 'valgrind' memory checker.

I plan to pull patches into the integration git branch early next week, and I'll ask for help testing the result.


Title: Re: svn rev 103/104: listaccounts, listtransactions*, and -rpctimeout
Post by: ShadowOfHarbringer on January 16, 2011, 04:35:02 AM
BTW:

Did Satoshi contribute anything to bitcoin code lately ? You know, there are already rumors on the forum that he is dead or whatever :P
/me is too lazy to check himself.