Title: mastercoin sync of all implementations Post by: grazcoin on December 08, 2013, 09:31:00 PM This is great that we have multiple implementations for the mastercoin protocol, but they should all agree with each other.
I think the sync action between the different implementations deserves its own thread. Currently I compare:
https://github.com/grazcoin/mastercoin-tools/commit/0fe108a0e234441d533414efc6ef4e7e4d1ac90d The diff is generated every round hour (since it seems like a heavy task on mastercoin-explorer.com): https://masterchain.info/general/difference.json Let's discuss the differences and try to get a sync. Grazcoin Title: Re: mastercoin sync of all implementations Post by: grazcoin on December 08, 2013, 09:49:08 PM That's how the diff looks now:
[{"139Dx25QXHBJD1tfLQMwASAAJrWFiM4BPz": "different", "13NRX88EZbS5q81x6XFrTECzrciPREo821": "different", "13tKKPNwDZGKhBK8gAHns7bXe2wtqhvzDb": "different", "15XJoDF4xCUrWX3ES9ftWq3wnGhuRsqrLk": "different", "15og4WXZPwkMnnsb3dj6HqgTUfcRLx4J9b": "different", "163EZawpo1XCyZJq9PQwszvwY98r3kLBeU": "different", "16X6UDz6dMkVAAkWdY6HKe85o6EVAbzDtn": "different", "16rUg4eijBqM6oYrSrUzvghe6QM9CHvTYW": "different", "17K6hXXAaemSsnUGPyDn5rh6Jfq4pz37vi": "only on mastercoin-explorer", "17UbSDAXDzmxRXCgn2w43EaaHzHK3Ncx87": "different", "17uK6u4nTbWv3h6WNKg7ejxmgXvy4qebBY": "only on mastercoin-explorer", "182osbPxCo88oaSX4ReJwUr9uAcchmJVaL": "different", "18ArFG8cPDT5P8NVdjFuSGjkybRTW8VBji": "only on mastercoin-explorer", "18chrWPjs9ug7Xq7xDiFkqbe9A8KQdG7eH": "different", "194iAz9vJw6tXbxpVZ22YWaYyWDL1QCBDz": "only on mastercoin-explorer", "19AA9UoPUf52DRcQCgJ2Kvsq9nHBtMxmKK": "only on masterchain", "19ABrTW1XhWErJxE3UvfNuBRzB4w6UcTRp": "different", "19JrWC2vGLVxBoyQfRVsj3wyE4RdvhKmpE": "different", "1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2": "only on masterchain", "1AtpNBfsu6xKkKxKkmoCue774KX7vRTp49": "only on mastercoin-explorer", "1BYk8d1fWy1JLcNqHyNTEg2Jxu9EDb1BmY": "different", "1Bb6KGwb2vq8uavfCNo1cHd5ERzj8VPag8": "only on masterchain", "1C3zqPDY8J948FQ4HPCQ7A6QfEZ8SdoGEV": "only on masterchain", "1DDhPhsydLh6dDgAg7GVT3xZuYd93tjqtp": "different", "1DoG8JupeK8y7jCHe9C92eEvJhmrJm3Xe9": "different", "1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj": "different", "1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P": "only on masterchain", "1F2KyKaLr1QbCgGGAjuBSQSJo8GQ6CaCwF": "different", "1F9jCeixNbK6GEkdQFq1ejkbJjAGwVVVqG": "different", "1Fq37GNfyxSvnmye3QdxH6GpPAQ3enarfs": "different", "1FwYtobPTZTL2ye4omY3RTJ35E3zVyUGpV": "only on mastercoin-explorer", "1G4YZM9sAMPGeqtkFUrudwpxE3tiMwgciF": "only on mastercoin-explorer", "1GZbNvX3weBvxG33RJyVaao9UNi1YtLvoL": "only on masterchain", "1GaNupdUBzfVF2B3JUAY1rZwHoXJgjyzXj": "different", "1HN4XivkzGfZdwKU9tgW7NffCbiR8otAr9": "different", "1KEr24zCxEwf4WAdwAQ8gy3grsXGfFPaGy": "only on mastercoin-explorer", "1LsSF18x1o8hpgbArgoWy9fd65jniNMCfj": "only on mastercoin-explorer", "1Mt1tCGyJnD6SHzBgxtg6GRJLUhqQrc4ff": "different", "1PJbt9HQJwvcpLqnK2xA7xaukpUENjeRn2": "different", "1PhV9yaVm7ArLvcfFuPj8nwnC3yod95Jr7": "only on masterchain", "1Q6LPs8V7QXVfNrmKjowvYSAXqN6r9ZoLb": "different", "1zAtHRASgdHvZDfHs6xJquMghga4eG7gy": "only on mastercoin-explorer"}] I'll just start with few: 139Dx25QXHBJD1tfLQMwASAAJrWFiM4BPz multiple change addresses. masterchain treats tx as a bitcoin payment https://masterchain.info/btcpayment.html?tx=8175fcd0221ee5cda1808f48861bef5c2d5e8b9acf91a7b0fade5768d35f6665¤cy=MSC mastercoin-explorer accepts http://mastercoin-explorer.com/transactions/8175fcd0221ee5cda1808f48861bef5c2d5e8b9acf91a7b0fade5768d35f6665 a24a6b5b38cec7047c14d2ce581c8576e233cf555bd318053d3bed12ebf803ce all bitcoin amount desired was paid, so the buyer should get all test mastercoins accepted (0.9) https://masterchain.info/sellaccept.html?tx=a24a6b5b38cec7047c14d2ce581c8576e233cf555bd318053d3bed12ebf803ce¤cy=TMSC on mastercoin-explorer a smaller amount was calculated (multiplication of amount times the price). rounding error. Let's try to make this list shorter until it vanishes, and then keep it empty. Grazcoin Title: Re: mastercoin sync of all implementations Post by: Tachikoma on December 09, 2013, 12:41:22 PM 139Dx25QXHBJD1tfLQMwASAAJrWFiM4BPz We have been having a discussion in the development thread about these payments. We want to accept them.multiple change addresses. masterchain treats tx as a bitcoin payment https://masterchain.info/btcpayment.html?tx=8175fcd0221ee5cda1808f48861bef5c2d5e8b9acf91a7b0fade5768d35f6665¤cy=MSC mastercoin-explorer accepts http://mastercoin-explorer.com/transactions/8175fcd0221ee5cda1808f48861bef5c2d5e8b9acf91a7b0fade5768d35f6665 a24a6b5b38cec7047c14d2ce581c8576e233cf555bd318053d3bed12ebf803ce all bitcoin amount desired was paid, so the buyer should get all test mastercoins accepted (0.9) https://masterchain.info/sellaccept.html?tx=a24a6b5b38cec7047c14d2ce581c8576e233cf555bd318053d3bed12ebf803ce¤cy=TMSC on mastercoin-explorer a smaller amount was calculated (multiplication of amount times the price). rounding error. I'm currently reparsing all exchange messages because of the added rule that only tests are accepted for now. Will get back on that one :) Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 09, 2013, 01:19:41 PM Here is the difference between mymastercoins mm and masterchain mc. I'll look at each address trans and report back.
MM=227.23987298 1Q1sFqsi8S5DxV5hz6sWLamGBp9To93iG7 MC=232.23987298 ecb77ee990de29745de949462e1f6e44584c310a0da12c9fbdf86dbe6ffabcfc not in mc MM=470 1PJbt9HQJwvcpLqnK2xA7xaukpUENjeRn2 MC=270 607dd8939d9a108e54229597bc26756588c1987fb9969d3256320c858572c998 not in mc MM=0.2065 1P8GMhC3qYkuvRRBsS5gqGegT7GvQoxAwY MC=0.0065 9a11be500211dd92f2caaa7678779aba11d0e5ef0e017190c10a9621f6c492b9 not in mc MM=334 1NK1rJSkMeDtg5SXfXaSbD14QxAqQbqAr6 MC=284 725210a6bfea06e4aa9a582602d758db920eff9c720aca380d6e77c08a4108ac not in mc MM=400 1LdgFp2gLvWfkPnyTYAtH7ENnzgBDdNwfd MC=200 58effd6afc7980392b17ba012943915a9be1db3a6d025969e5d5a197a3e25bc3 not in mc MM=347 1HN4XivkzGfZdwKU9tgW7NffCbiR8otAr9 MC=160 4583689089dc9cca48bed67f8e9ab35e6356c21290fcdfc3b0b6e9a9b2fa4acf not in mc MM=10 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj MC=9.99999991 MM=110 1DoG8JupeK8y7jCHe9C92eEvJhmrJm3Xe9 MC=60 MM=0 1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2 MC=9E-08 MM=15 195NyMnCNF8GQYN6gKLuf5LsArgoi5NCW7 MC=0 MM=187 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF MC=0 MM=380.84328263 15og4WXZPwkMnnsb3dj6HqgTUfcRLx4J9b MC=379.07493056 MM=235 15a4XCuWmx2cCQVf8wZK7mqdvj5uwo1vby MC=230 MM=380 15YmJ5UmEWWsE83kASiiwrTJvc394dRRn8 MC=470 MM=0 14hm8rTdknVCDpqXGY5nFqVWruU9UBeuHd MC=0.2 MM=1E-08 139Dx25QXHBJD1tfLQMwASAAJrWFiM4BPz MC=510.00000001 Dev msc from exodus address MM=625.21848545 1Fq37GNfyxSvnmye3QdxH6GpPAQ3enarfs MC=250.21848545 MM=1569.63027669 13NRX88EZbS5q81x6XFrTECzrciPREo821 MC=1194.63027669 MM=376.4046 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL MC=1.4476 Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 09, 2013, 01:54:18 PM Mymastercoins differences with Masterexplorer. List is getting shorter :)
MM=6.283E-05 1Mt1tCGyJnD6SHzBgxtg6GRJLUhqQrc4ff ME=5.00006283 MM=10 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj ME=10.2 MM=10.55548942 15XJoDF4xCUrWX3ES9ftWq3wnGhuRsqrLk ME=5.55548942 MM=501.60166005 16rUg4eijBqM6oYrSrUzvghe6QM9CHvTYW ME=500.60166005 Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 09, 2013, 02:00:24 PM For transaction
725210a6bfea06e4aa9a582602d758db920eff9c720aca380d6e77c08a4108ac The reference address is 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF The largest output is the change address which is also 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF 1NK1rJSkMeDtg5SXfXaSbD14QxAqQbqAr6 - (Unspent) 0.00006 BTC 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF - (Spent) 0.00046 BTC 1KgwXKs6TBRExnC7tswfzf5rg66HUEpsh5 - (Unspent) 0.00006 BTC 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P - (Unspent) 0.00006 BTC Is this transaction valid? (For my implementation I disregarded output addresses that are the same as the Reference address. Then used "peek and decode". ) Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 12, 2013, 01:38:55 PM a497e4fd11d2223e2129828e44b0d2110b2bb0ec3cb8a0f36bbd28f37a15ceef
Simple send in masterexplorer. Transaction is a purchase offer in mymastercoins. Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 12, 2013, 01:47:31 PM 1DDhPhsydLh6dDgAg7GVT3xZuYd93tjqtp
Master explorer has no generated msc coins but it has 100 generated test msc Mymastercoins 60.56 generated coins. Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 12, 2013, 02:00:37 PM 23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4
Invalid in mymastercoins sender has not enough msc to send. Valid in mastercoin explorer Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 12, 2013, 02:05:28 PM 15XJoDF4xCUrWX3ES9ftWq3wnGhuRsqrLk
a497e4fd11d2223e2129828e44b0d2110b2bb0ec3cb8a0f36bbd28f37a15ceef Transaction is invalid in mm. It is an msc purchase offer which should be invalid. Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 12, 2013, 02:07:16 PM 16rUg4eijBqM6oYrSrUzvghe6QM9CHvTYW
0559a71a19d2900ed64fcaff97ed245aeebd8cc0bf3bf73359c93ef944387edb Valid in master explorer but Is a purchase offer which is invalid. Title: Re: mastercoin sync of all implementations Post by: Bitoy on December 15, 2013, 01:41:02 PM Mm and masterchest difference
MM=152 15a4XCuWmx2cCQVf8wZK7mqdvj5uwo1vby MC=147 MM=177.23987298 1Q1sFqsi8S5DxV5hz6sWLamGBp9To93iG7 MC=182.23987298 ecb77ee990de29745de949462e1f6e44584c310a0da12c9fbdf86dbe6ffabcfc Is a valid 5 msc simple send from 1Q1sFqsi8S5DxV5hz6sWLamGBp9To93iG7 to 15a4XCuWmx2cCQVf8wZK7mqdvj5uwo1vby MM=376.4046 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL MC=376.4906 c2a904dd47797736617bf5df555f029064de0fc2ff5ba71197638e469caae7f5 Is a valid Simple Send Date: 10/14/2013 3:32:16 PM Sender: 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL Amount Sent: 0.04300000 MSC Recipient: 18ArFG8cPDT5P8NVdjFuSGjkybRTW8VBji MM=0.00006283 1Mt1tCGyJnD6SHzBgxtg6GRJLUhqQrc4ff MC=5.00006283 MM=10.55548942 15XJoDF4xCUrWX3ES9ftWq3wnGhuRsqrLk MC=5.55548942 a497e4fd11d2223e2129828e44b0d2110b2bb0ec3cb8a0f36bbd28f37a15ceef Is a purchase offer should not add 5 msc to 1Mt1tCGyJnD6SHzBgxtg6GRJLUhqQrc4ff and deduct from 15XJoDF4xCUrWX3ES9ftWq3wnGhuRsqrLk. |