|
Title: [PATCH] InitializationCompleted Post by: genjix on February 25, 2011, 09:57:17 AM I noticed that https://github.com/bitcoin/bitcoin hasn't had this patch merged into it,
https://github.com/genjix/spesmilo/blob/master/bitcoin.patch I've been using this for a while and it works fine. Can it be merged to make it into the next release please? Title: Re: [PATCH] InitializationCompleted Post by: jgarzik on February 25, 2011, 12:30:01 PM All this patch is doing is moving race windows around. Currently RPC server init happens last, and that is sufficient to see that bitcoin is initialized.
Title: Re: [PATCH] InitializationCompleted Post by: genjix on February 25, 2011, 12:41:44 PM No it's not.
There's no way to recover if there's some error starting the RPC server. Maybe if there's a SEGV signal you can catch the return value only. You're insisting on any wrapper around the bitcoin core to use hacks to implement incomplete functionality. Title: Re: [PATCH] InitializationCompleted Post by: genjix on March 10, 2011, 06:17:39 PM Once a process realises that something is going on which should not, the process shall just log it, die gracefully and let OS and sysadmins deal with it. Anything more than that is bloatware. And that has what to do with this patch.......? |