|
Title: Pull Request for Offline Wallet Info Update function. Feedback please. Post by: dabura667 on February 18, 2014, 05:12:09 PM https://github.com/spesmilo/electrum/pull/573
I had made an issue request a while back, but after a while I realized that no one really seemed to want this functionality (or at least no one on github) So I went and started learning python, and tinkering around. Maybe a total of 30-40 hours of messing around with pdb stepping through code to figure out things work, I have finally gotten a working, if slightly primitive and very sloppy, version. If anyone could look at my function, look at my pull request, look at how I comment, etc. and give me feedback on anything (github manners, best practices for python, ways to improve my function, anything) I would greatly appreciate it. I have had so much fun, I started to program some small game in pygame. I feel very proud of my accomplishment, but I realize that this is a molehill and not a mountain I have climbed. I would greatly appreciate any feedback. If for nothing else, this helps me and my set up very nicely. Thank you in advanced for your feedback and opinions. dabura :-) |