Bitcoin Forum

Alternate cryptocurrencies => Altcoin Discussion => Topic started by: zathras on February 24, 2014, 02:48:45 AM



Title: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 24, 2014, 02:48:45 AM
Hey guys,

I'd like some help testing the first proper alpha of the Windows Masterchest Wallet for the Master Protocol & Mastercoin.

The source & binary will be posted up here later tonight are below.  For starters you'll need to get your transaction index re-enabled in bitcoind/qt.  Please see the instructions for further information.

I'd suggest the very first testers have perhaps done sends via the advisor script & are technically minded.  

If possible I also suggest creating a new bitcoin wallet.dat (back up the old one of course - several times :P), grabbing the new address and sending a small amount of BTC and/or MSC (via the advisor script) to this new address.  Then test the wallet with this new bitcoin wallet.dat.  Remember this is alpha software - it would be foolish to test it on a wallet containing significant sums of any currency.

This initial alpha will focus on getting the wallet up and running along with simple sends.  Distributed Exchange functionality is disabled in this build.  I'll then release a build with DEx around the end of the week and the focus will switch to testing DEx.

EDIT: Alpha 0.2 is up for initial testing of the DEx functionality.  Instructions have been briefly updated.  Thanks!
EDIT: Alpha 0.3 is up for initial testing of the DEx functionality, including real MSC.  Thanks
EDIT: Alpha 0.3c is up for initial testing of the DEx functionality, including real MSC.  Thanks
EDIT: Alpha 0.4a is up for smart property support (display/send).  Thanks :)

Remember this is alpha software and still contains a lot of bugs - it would be incredibly foolish to test this on a bitcoin wallet holding any significant amount of funds.

https://i.imgur.com/7ArcsdB.png

Source:  Github (https://github.com/zathras-crypto/masterchest-wallet)
Binary:  Github (https://github.com/zathras-crypto/masterchest-wallet/blob/master/bin/MasterchestWalletAlpha_Bin.zip?raw=true)
Instructions:  here (https://masterchest.info/files/Masterchest_Wallet_User_Doco_Initial_Draft.pdf)

Requirements: .NET Framework 4, bitcoind/qt with transaction index enabled

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: chinabreak123 on February 24, 2014, 03:05:58 AM
that's great


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: jeroenn13 on February 24, 2014, 10:58:57 AM
This is good news! Will help testing.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 24, 2014, 11:25:54 AM
great job!
buy msc!
 ;D


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dacoinminster on February 24, 2014, 06:36:14 PM
I've already been using this wallet, and it's great!!

Zathras, can you also post this to the mastercoin forum?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 24, 2014, 06:57:02 PM
Links up!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 24, 2014, 07:06:11 PM
I've already been using this wallet, and it's great!!

Zathras, can you also post this to the mastercoin forum?

Done :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: jeroenn13 on February 24, 2014, 08:13:26 PM
Can't wait to test. Sync now with QT :\


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: prophetx on February 24, 2014, 10:12:10 PM
Zathras this is a better link

https://github.com/zathras-crypto/masterchest-wallet/blob/master/bin/MasterchestWalletAlpha_Bin.zip?raw=true


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on February 24, 2014, 10:19:35 PM
Hey,

very nice to see this update. Looks very, very good!

Didn't try sending, but wallets are identified, balances are correct, transaction history is there also! :)

Here are two problems I found so far:


1. RPC usernames and passwords are case sensitive

After reading the wallet.cfg the username and password are currently parsed and casted to lower case. This shouldn't happen.

This affects:

https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L95
https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L138
https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L141

Fix: remove .ToLower.



2. This was a nasty one! In some regions the decimal mark is a comma and somewhere else a point, e.g. "16058.671616199374" vs. "16058,671616199374".

Using a comma results in faulty SQL queries like this one:

Code:
insert into balances (address, cbalance, cbalancet) VALUES ('1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P', 1605867161619,94,0)

Which is invalid, because "1605867161619,94" is interpreted as two different values.

So far, I identified this line:

https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L564

Code:
cmd.CommandText = "insert into balances (address, cbalance, cbalancet) VALUES ('1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P', " & (devmsc * 100000000) & ",0)"

Fix for this one:

Code:
cmd.CommandText = "insert into balances (address, cbalance, cbalancet) VALUES ('1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P', " & (devmsc * 100000000).ToString(Globalization.CultureInfo.InvariantCulture) & ",0)"

It's probably a better solution to globally define the culture though. :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: prophetx on February 24, 2014, 10:37:42 PM
i am not able to get it to connect on win 8, i know bitcoin daemon is running b/c i can connect other apps to it

https://github.com/zathras-crypto/masterchest-wallet/issues/3


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 24, 2014, 10:44:11 PM
Wow thanks guys :)

Already straight into it :)  OK - dexX7 great thanks!

1) have already committed a bugfix for the tolower on RPC details which got missed
2) Ouch yeah I'll take a look at that now
2) this was actually a problem with my dev MSC calculation having too many decimals - that query should have only ever been sending a whole number to the db - committed a fix

Prophetx - could you try the latest binary - this way we can see if it's win8 or the rpc case issue.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dacoinminster on February 24, 2014, 11:03:40 PM
I'm using win8 successfully, so I know it isn't that.

Zathras - prophetx is trying to set up a skype chat with you. I've been chatting with him trying to figure it out, but you could probably do it better :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 24, 2014, 11:17:25 PM
I'm using win8 successfully, so I know it isn't that.

Zathras - prophetx is trying to set up a skype chat with you. I've been chatting with him trying to figure it out, but you could probably do it better :)

Thanks J.R. - just talked with prophetx and located a bug with rpcport detection, commit w/ updated binary has just gone up.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dacoinminster on February 24, 2014, 11:22:41 PM
I'm using win8 successfully, so I know it isn't that.

Zathras - prophetx is trying to set up a skype chat with you. I've been chatting with him trying to figure it out, but you could probably do it better :)

Thanks J.R. - just talked with prophetx and located a bug with rpcport detection, commit w/ updated binary has just gone up.


Nice! That was fast!

Also, there appears to be an emerging consensus problem for real MSC between Masterchest and Masterchain on the dev thread. :)

I hope you're enjoying finally being full-time. I know my first few days as full-time have been very very full!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 24, 2014, 11:25:03 PM
I'm using win8 successfully, so I know it isn't that.

Zathras - prophetx is trying to set up a skype chat with you. I've been chatting with him trying to figure it out, but you could probably do it better :)

Thanks J.R. - just talked with prophetx and located a bug with rpcport detection, commit w/ updated binary has just gone up.


Nice! That was fast!

Also, there appears to be an emerging consensus problem for real MSC between Masterchest and Masterchain on the dev thread. :)

I hope you're enjoying finally being full-time. I know my first few days as full-time have been very very full!

Just trying to get myself sorted out!  :)

I'm behind on emails - I wasn't aware of any consensus issues (except the skewed results due to mastercoin-explorer) - can you shoot me a subject line so I know what I'm looking for?

Thanks
Zathras

EDIT: Just checked my consensus page - seems like Masterchest & Masterchain are 100% for real MSC - unless of course the topic was about a problem with my consensus system
EDIT: Oh.  Seems like there is a problem with my consensus system :(
EDIT: Fixed my consensus system (now ignoring mastercoin-explorer results).  Seems Bitoy & I are 100%, but quite a few differences with Masterchain

EDIT: Looked over the first discrepancy.  Problem in Masterchain I believe.  Will wait for Graz to comment before moving onto investigating others further.
Graz,
Address 15a4XCuWmx2cCQVf8wZK7mqdvj5uwo1vby
You mark 221375a8dd6cc338af826ac9db5a01016e4c7a79a15b29aaf91a60685ecd7acd as invalid because of insufficient funds.  You don't see all the balance because it seems you're not decoding this transaction ecb77ee990de29745de949462e1f6e44584c310a0da12c9fbdf86dbe6ffabcfc (you see it just as a bitcoin payment).


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 25, 2014, 01:43:48 AM
great  job, great man! come on!hold your msc  ^buy msc!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: 520Bit on February 25, 2014, 08:32:43 AM
Waiting for official release.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 25, 2014, 03:06:31 PM
any good news? ;D


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dacoinminster on February 26, 2014, 12:14:47 AM
Yup!

http://www.mastercoinwallets.org


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 26, 2014, 01:46:04 AM
Yup!

http://www.mastercoinwallets.org

good! very good!

thanks for great job!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: editor499 on February 26, 2014, 02:36:42 AM
Waiting for official release.

me too ;)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 26, 2014, 04:58:43 AM
#2 Reindexing Bitcoin.....OMG! MUCH  MUCH  MUCH  TIME!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: SquareRobin on February 26, 2014, 06:38:17 AM
When starting Masterchest_Wallet.exe v0.1a in a protected directory (such as C:\Program Files\Masterchest) I get an error "Internal error: Cannot open the shared memory region." after the message "Startup: Testing database connection...".  Running the exe as an Administrator fixes this.  Installing Masterchest in a regular directory fixes this.

(Still Reindexing...)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 26, 2014, 08:10:42 AM
When starting Masterchest_Wallet.exe v0.1a in a protected directory (such as C:\Program Files\Masterchest) I get an error "Internal error: Cannot open the shared memory region." after the message "Startup: Testing database connection...".  Running the exe as an Administrator fixes this.  Installing Masterchest in a regular directory fixes this.

(Still Reindexing...)

Hi,

Sounds like a permissions issue.  You'll see that error if a write lock can't be obtained on the database.  You likely require admin rights to write inside C:\Program Files (go there in explorer and right click > New Folder and you'll likely see an icon indicating escalation to admin is required).  Either simply give your user account write permissions on this folder or as you noted extract it to a writable directory.

I'll put this all into an installer which can drop the binary in program files and set the permissions accordingly, but for now extracting to anywhere writable (or where you don't need admin rights to write) is sufficient.

Thanks :)
Zathras



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: SquareRobin on February 26, 2014, 03:00:14 PM
I suggest anyone thinking of eventually installing Masterchest to first start the bitcoin-qt reindexing process (as described in the Masterchest pdf), since it takes a long time to run.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 26, 2014, 03:38:06 PM
I suggest anyone thinking of eventually installing Masterchest to first start the bitcoin-qt reindexing process (as described in the Masterchest pdf), since it takes a long time to run.
very loooooooong  time


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 27, 2014, 12:36:27 AM
...
DEBUG: Block Analysis for: 250225
DEBUG: Block Analysis for: 250226
DEBUG: Block Analysis for: 250227
DEBUG: Block Analysis for: 250228
DEBUG: Block Analysis for: 250229
DEBUG: Block Analysis for: 250230
DEBUG: Block Analysis for: 250231
DEBUG: Block Analysis for: 250232
DEBUG: Block Analysis for: 250233
DEBUG: Block Analysis for: 250234
DEBUG: Block Analysis for: 250235
DEBUG: Block Analysis for: 250236
DEBUG: Block Analysis for: 250237
DEBUG: Block Analysis for: 250238
DEBUG: Block Analysis for: 250239
DEBUG: Block Analysis for: 250240
DEBUG: Block Analysis for: 250241
DEBUG: Block Analysis for: 250242
DEBUG: Block Analysis for: 250243
...
what is this?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: littleblue on February 27, 2014, 01:01:53 AM
经实践,这个钱包用不成。 :'(

用了这个后,比特币的钱包每次打开都要重新建立索引!!

彻底崩溃了。


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: softron on February 27, 2014, 01:10:54 AM
Nice where can i get test mastercoin


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on February 27, 2014, 04:08:41 AM
...
DEBUG: Block Analysis for: 250225
DEBUG: Block Analysis for: 250226
DEBUG: Block Analysis for: 250227
DEBUG: Block Analysis for: 250228
DEBUG: Block Analysis for: 250229
DEBUG: Block Analysis for: 250230
DEBUG: Block Analysis for: 250231
DEBUG: Block Analysis for: 250232
DEBUG: Block Analysis for: 250233
DEBUG: Block Analysis for: 250234
DEBUG: Block Analysis for: 250235
DEBUG: Block Analysis for: 250236
DEBUG: Block Analysis for: 250237
DEBUG: Block Analysis for: 250238
DEBUG: Block Analysis for: 250239
DEBUG: Block Analysis for: 250240
DEBUG: Block Analysis for: 250241
DEBUG: Block Analysis for: 250242
DEBUG: Block Analysis for: 250243
...
what is this?

That's the wallet using your bitcoin installation to scan blocks looking for Master Protocol messages :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on February 27, 2014, 08:31:58 PM
Nice where can i get test mastercoin

Try http://mastercoin-faucet.com! ;)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 01, 2014, 04:28:59 AM
I have been paying much attention to the project. I'm trying the wallet and it's syncronizing now. I like the style and great job,guys. Thank you Zathras. By the way, I think it's a little technical and complicated, the easier the better. Maybe you guys can find somebody who have little knowledge about IT and cryptocoins to use and test it and give you their advice. In addition, when  selling  MSCs why not list all the selling list and let  users referring to the price now in the market.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: jakecnn on March 01, 2014, 11:45:31 PM
So, after about 3 days of sync'ing the wallet I tried to do a send of TMSC. The response was that there's not enough funds in my wallet to cover the tx fee.
I got about 0.0004 BTC in that address.. What is the tx fee set to? 0.001?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 02, 2014, 11:14:18 AM
So, after about 3 days of sync'ing the wallet I tried to do a send of TMSC. The response was that there's not enough funds in my wallet to cover the tx fee.
I got about 0.0004 BTC in that address.. What is the tx fee set to? 0.001?

There are additional costs beyond just the miners fee (which is set at 0.00011) for funding the outputs for the transaction.  The library currently requires an unspent output >the total fee (~0.00035-0.00040 BTC) in order to send a transaction.

I actually wrote an appendix regarding the cost of Master Protocol messages, you can read it here if you're interested https://github.com/mastercoin-MSC/spec#appendix-e---understanding-the-cost-of-master-protocol-messages (https://github.com/mastercoin-MSC/spec#appendix-e---understanding-the-cost-of-master-protocol-messages)

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: JakeThePanda on March 02, 2014, 09:35:37 PM
No Mac wallet? :(


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: jakecnn on March 03, 2014, 07:49:38 PM
I successfully did a TMSC send with the wallet, but something is wrong - I had 0.418 TMSC before and sent 0.018.
The wallet shows the right balance afterwards(0.4), but masterchest and masterchain show 0.297 .
Is it because of open sellorders? I've never cancelled them I think.
Here is the log:
Code:
Recipient address is valid.
Raw transaction hex:
0100000001060c0a8e198b835bb18304fa8d19c08c52375f6bb63d25f998a61dc7c43d77fe0000000000ffffffff0450f00000000000001976a9142543163c517c4a59b2f4f6dd19a09d21c0093be288ac70170000000000001976a914946cb2e08075bcbaf157e47bcb67eb2b2339d24288ac70170000000000001976a9143c66ad4a06411af4e5a0d9f34e244969bee3adb088ace02e000000000000475121022b733322d7e855766a5bc4ad8f9707115980095d60d4ac138d507319702aa54321029B07F670D5FC1B4E93BE50BF51499F3C967BBD8BC133E1D012DDE615A2383B2652ae00000000
Raw transaction decode:
{"result":{"txid":"9d62eeb6588cb982bf4712ac35f55af69cb739f9e1ad270b25592d069b9206b9","version":1,"locktime":0,"vin":[{"txid":"fe773dc4c71da698f9253db66b5f37528cc0198dfa0483b15b838b198e0a0c06","vout":0,"scriptSig":{"asm":"","hex":""},"sequence":4294967295}],"vout":[{"value":0.00061520,"n":0,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 2543163c517c4a59b2f4f6dd19a09d21c0093be2 OP_EQUALVERIFY OP_CHECKSIG","hex":"76a9142543163c517c4a59b2f4f6dd19a09d21c0093be288ac","reqSigs":1,"type":"pubkeyhash","addresses":["14Q2NNiF5YzDZCjo7vrBuHdbZcmHRJyW3j"]}},{"value":0.00006000,"n":1,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 946cb2e08075bcbaf157e47bcb67eb2b2339d242 OP_EQUALVERIFY OP_CHECKSIG","hex":"76a914946cb2e08075bcbaf157e47bcb67eb2b2339d24288ac","reqSigs":1,"type":"pubkeyhash","addresses":["1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P"]}},{"value":0.00006000,"n":2,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 3c66ad4a06411af4e5a0d9f34e244969bee3adb0 OP_EQUALVERIFY OP_CHECKSIG","hex":"76a9143c66ad4a06411af4e5a0d9f34e244969bee3adb088ac","reqSigs":1,"type":"pubkeyhash","addresses":["16WNYdM4whfD9gV3shX35rmHqbYzTJ6xEG"]}},{"value":0.00012000,"n":3,"scriptPubKey":{"asm":"1 022b733322d7e855766a5bc4ad8f9707115980095d60d4ac138d507319702aa543 029b07f670d5fc1b4e93be50bf51499f3c967bbd8bc133e1d012dde615a2383b26 2 OP_CHECKMULTISIG","hex":"5121022b733322d7e855766a5bc4ad8f9707115980095d60d4ac138d507319702aa54321029b07f670d5fc1b4e93be50bf51499f3c967bbd8bc133e1d012dde615a2383b2652ae","reqSigs":1,"type":"multisig","addresses":["14Q2NNiF5YzDZCjo7vrBuHdbZcmHRJyW3j","14inwuhpBTew2C8EenXW2L7xMDWx9Jti5h"]}}]},"error":null,"id":"1"}

Signing appears successful.
Transaction sent, ID: 9e52649ea61ad6d69c228c6b252d261fc6ae62fba25228c2c10a609f22969d90


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: Tesca on March 04, 2014, 02:19:14 PM
Tried to get it working but stumbled upon some hurdles:
I've got some error messages on start because it couldn't find my username/passwort etc. Found out that preceding spaces (in front of the line) in the bitcoin-qt config file were the source of the error.
Next i got some errors because i forgot to start bitcoint-qt which isn't that much of a problem but, the text in the messages seems strange: "Exception thrown getting block hash: der Wert darf nicht NULL sein. Parametername: value". Shouldn't there a real value instead of the word 'value' be written? Or is the punctuation out of order? Anyway it is kind of confusing.

I also noticed it take quite a while for it to synchronize, it would be helpfull i there would be something like a progressbar to get a sense of how long it takes.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 05, 2014, 11:13:31 PM
I successfully did a TMSC send with the wallet, but something is wrong - I had 0.418 TMSC before and sent 0.018.
The wallet shows the right balance afterwards(0.4), but masterchest and masterchain show 0.297 .
Is it because of open sellorders? I've never cancelled them I think.
Here is the log:
Code:
Recipient address is valid.
Raw transaction hex:
0100000001060c0a8e198b835bb18304fa8d19c08c52375f6bb63d25f998a61dc7c43d77fe0000000000ffffffff0450f00000000000001976a9142543163c517c4a59b2f4f6dd19a09d21c0093be288ac70170000000000001976a914946cb2e08075bcbaf157e47bcb67eb2b2339d24288ac70170000000000001976a9143c66ad4a06411af4e5a0d9f34e244969bee3adb088ace02e000000000000475121022b733322d7e855766a5bc4ad8f9707115980095d60d4ac138d507319702aa54321029B07F670D5FC1B4E93BE50BF51499F3C967BBD8BC133E1D012DDE615A2383B2652ae00000000
Raw transaction decode:
{"result":{"txid":"9d62eeb6588cb982bf4712ac35f55af69cb739f9e1ad270b25592d069b9206b9","version":1,"locktime":0,"vin":[{"txid":"fe773dc4c71da698f9253db66b5f37528cc0198dfa0483b15b838b198e0a0c06","vout":0,"scriptSig":{"asm":"","hex":""},"sequence":4294967295}],"vout":[{"value":0.00061520,"n":0,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 2543163c517c4a59b2f4f6dd19a09d21c0093be2 OP_EQUALVERIFY OP_CHECKSIG","hex":"76a9142543163c517c4a59b2f4f6dd19a09d21c0093be288ac","reqSigs":1,"type":"pubkeyhash","addresses":["14Q2NNiF5YzDZCjo7vrBuHdbZcmHRJyW3j"]}},{"value":0.00006000,"n":1,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 946cb2e08075bcbaf157e47bcb67eb2b2339d242 OP_EQUALVERIFY OP_CHECKSIG","hex":"76a914946cb2e08075bcbaf157e47bcb67eb2b2339d24288ac","reqSigs":1,"type":"pubkeyhash","addresses":["1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P"]}},{"value":0.00006000,"n":2,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 3c66ad4a06411af4e5a0d9f34e244969bee3adb0 OP_EQUALVERIFY OP_CHECKSIG","hex":"76a9143c66ad4a06411af4e5a0d9f34e244969bee3adb088ac","reqSigs":1,"type":"pubkeyhash","addresses":["16WNYdM4whfD9gV3shX35rmHqbYzTJ6xEG"]}},{"value":0.00012000,"n":3,"scriptPubKey":{"asm":"1 022b733322d7e855766a5bc4ad8f9707115980095d60d4ac138d507319702aa543 029b07f670d5fc1b4e93be50bf51499f3c967bbd8bc133e1d012dde615a2383b26 2 OP_CHECKMULTISIG","hex":"5121022b733322d7e855766a5bc4ad8f9707115980095d60d4ac138d507319702aa54321029b07f670d5fc1b4e93be50bf51499f3c967bbd8bc133e1d012dde615a2383b2652ae","reqSigs":1,"type":"multisig","addresses":["14Q2NNiF5YzDZCjo7vrBuHdbZcmHRJyW3j","14inwuhpBTew2C8EenXW2L7xMDWx9Jti5h"]}}]},"error":null,"id":"1"}

Signing appears successful.
Transaction sent, ID: 9e52649ea61ad6d69c228c6b252d261fc6ae62fba25228c2c10a609f22969d90

Thanks for testing! :)

Yep, that's just because the first version of the wallet didn't support DEx state processing (it parses the messages but doesn't process them).  The next alpha is going up today and that should display your sell offers automatically if they exist, so you can cancel them easy enough (right click sell > cancel).

Thanks!
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 05, 2014, 11:17:13 PM
Tried to get it working but stumbled upon some hurdles:
I've got some error messages on start because it couldn't find my username/passwort etc. Found out that preceding spaces (in front of the line) in the bitcoin-qt config file were the source of the error.
Next i got some errors because i forgot to start bitcoint-qt which isn't that much of a problem but, the text in the messages seems strange: "Exception thrown getting block hash: der Wert darf nicht NULL sein. Parametername: value". Shouldn't there a real value instead of the word 'value' be written? Or is the punctuation out of order? Anyway it is kind of confusing.

I also noticed it take quite a while for it to synchronize, it would be helpfull i there would be something like a progressbar to get a sense of how long it takes.

Thanks for testing :)

I hope to be able to spend some time trapping errors a little better.  Part of the sanity checks involve checking for an expected return value to a particular blockhash to further sanity check we're talking with a bitcoin RPC server on a valid blockchain.  That error gets thrown when we don't get the expected value back (in this case because bitcoin wasn't running).  The code shouldn't actually get that far - it should terminate when there is no connection to bitcoin available, I'll double check the exit code there.

Thanks!
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 06, 2014, 03:21:17 AM
wow,great,I have been looking forward to p2p exchange so long. Now it's come true at last,I'm so excited. It's great things in cryptocurrency market.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 06, 2014, 08:43:54 PM
First DEx alpha is up - OP updated :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 06, 2014, 09:19:02 PM
Let's go! ;)

Quote
DEBUG: SQL INSERT INTO processedblocks VALUES (289247,1394137090)
DEBUG: Block Analysis for: 289248
DEBUG: SQL INSERT INTO processedblocks VALUES (289248,1394136834)
DEBUG: Block Analysis for: 289249
DEBUG: SQL INSERT INTO processedblocks VALUES (289249,1394137433)
DEBUG: Block Analysis for: 289250
DEBUG: SQL INSERT INTO processedblocks VALUES (289250,1394140038)
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Transaction processing starting...
DEBUG: SQL SELECT MAX(BLOCKTIME) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
ERROR: Blockchain scanning thread threw exception : Fehler beim Analysieren der Abfrage. [ Token line number = 1,Token line offset = 220,Token in error = 33333333 ]
DEBUG: Thread exited with error condition.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 06, 2014, 09:39:49 PM
Let's go! ;)

Quote
DEBUG: SQL INSERT INTO processedblocks VALUES (289247,1394137090)
DEBUG: Block Analysis for: 289248
DEBUG: SQL INSERT INTO processedblocks VALUES (289248,1394136834)
DEBUG: Block Analysis for: 289249
DEBUG: SQL INSERT INTO processedblocks VALUES (289249,1394137433)
DEBUG: Block Analysis for: 289250
DEBUG: SQL INSERT INTO processedblocks VALUES (289250,1394140038)
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Transaction processing starting...
DEBUG: SQL SELECT MAX(BLOCKTIME) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
ERROR: Blockchain scanning thread threw exception : Fehler beim Analysieren der Abfrage. [ Token line number = 1,Token line offset = 220,Token in error = 33333333 ]
DEBUG: Thread exited with error condition.

Oh dear - now that's not a good start.  Let me take a look...


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 06, 2014, 09:54:33 PM
Let's go! ;)

Quote
DEBUG: SQL INSERT INTO processedblocks VALUES (289247,1394137090)
DEBUG: Block Analysis for: 289248
DEBUG: SQL INSERT INTO processedblocks VALUES (289248,1394136834)
DEBUG: Block Analysis for: 289249
DEBUG: SQL INSERT INTO processedblocks VALUES (289249,1394137433)
DEBUG: Block Analysis for: 289250
DEBUG: SQL INSERT INTO processedblocks VALUES (289250,1394140038)
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Transaction processing starting...
DEBUG: SQL SELECT MAX(BLOCKTIME) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
DEBUG: SQL SELECT MAX(BLOCKNUM) FROM processedblocks
ERROR: Blockchain scanning thread threw exception : Fehler beim Analysieren der Abfrage. [ Token line number = 1,Token line offset = 220,Token in error = 33333333 ]
DEBUG: Thread exited with error condition.

Oh dear - now that's not a good start.  Let me take a look...

I've committed an update (including binary) which massively increases the amount of debug info generated.  Can you run this again (in debug level med/high) and then provide the last 20 or so lines from the debug panel?

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 06, 2014, 10:06:16 PM
Sure! :)

http://pastebin.com/raw.php?i=J4Va5e4q


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 06, 2014, 10:22:36 PM
Sure! :)

http://pastebin.com/raw.php?i=J4Va5e4q

Great, thanks - that's pointed me to a bug with update integer math - committed a fix (hopefully).

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 06, 2014, 10:32:38 PM
Perfect, works fine now.

Edit: I really like the design. :)

You may check out the colored areas, those are the transactions from the other thread (link (https://bitcointalk.org/index.php?topic=292628.msg5554845#msg5554845)). I have no clear overview right now though, due to the mix of many transactions inbetween and afterwards. Note to myself: start with a clean wallet next time.

https://i.imgur.com/7vCCECd.png (https://i.imgur.com/7vCCECd.png)

Side note: It would be awesome, if a right click on a transaction would allow to copy the transaction id.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 06, 2014, 11:20:27 PM
Thanks - I'll have a look at these issues.  I'm wondering if perhaps something is not working well with my handling of localization, I noticed the chart - should look like this as of this moment:

https://i.imgur.com/DLO6Hbi.png

EDIT: Image proxy seems to not want to show the image - the chart should look like the image in the OP.  I use Google for charting until a later date when I'll shift to doing it internally.  DexX - if I ping you a custom build that gives you the chart creation URL are you OK to run it and shoot me the URL it generates?

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 06, 2014, 11:49:31 PM
Ah, this is the image I posted: https://i.imgur.com/7vCCECd.png

Yea, sure.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 07, 2014, 12:01:42 AM
Ah, this is the image I posted: https://i.imgur.com/7vCCECd.png

Yea, sure.

Custom version with a popup for chart build URL - https://masterchest.info/files/MasterchestWalletAlpha_Bin_DexX.zip (https://masterchest.info/files/MasterchestWalletAlpha_Bin_DexX.zip)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 07, 2014, 12:13:31 AM
Code:
http://chart.googleapis.com/chart?cht=lc&chd=t0:0,0001,0,0001,0,0001,0,0001,0,001,0,001,0,001,0,01,4,94E-06,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,20000037,0,20000037,0,20000037,0,20000037,0,0002,0,003,0,02231932,0,4954955,0,4954955,0,001,0,01|0,0,0,0,0,0,001,0,001,0,001,0,011,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,0,20000037,0,20000037,0,20000037,0,20000037,0,0002,0,0002,0,4954955,0,4954955,0,4954955,0,001|0,0,0,0,0,001,0,001,0,001,0,011,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,0,20000037,0,20000037,0,20000037,0,20000037,0,0002,0,0002,0,4954955,0,4954955,0,4954955,0,001,0,01|0,0001,0,0001,0,0001,0,0001,0,001,0,001,0,001,0,011,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,20000037,0,20000037,0,20000037,0,20000037,0,003,0,003,0,4954955,0,4954955,0,4954955,0,001,0,01&chm=F,,0,-1,10&chs=426x205&chf=bg,s,252526&chxt=x,y&chds=0,0,54504505&chxr=1,0,0,54504505&chxs=1N*F4*,D1D1D1,11,0,lt|0,D1D1D1,11,0,lt&chxl=0:|07.01|11.01|17.01|23.01|29.01|04.02|10.02|16.02|22.02|28.02|06.03

The chart looks like this here, too, but is actually green-white, instead of green-black.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 07, 2014, 12:23:48 AM
Code:
http://chart.googleapis.com/chart?cht=lc&chd=t0:0,0001,0,0001,0,0001,0,0001,0,001,0,001,0,001,0,01,4,94E-06,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,20000037,0,20000037,0,20000037,0,20000037,0,0002,0,003,0,02231932,0,4954955,0,4954955,0,001,0,01|0,0,0,0,0,0,001,0,001,0,001,0,011,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,0,20000037,0,20000037,0,20000037,0,20000037,0,0002,0,0002,0,4954955,0,4954955,0,4954955,0,001|0,0,0,0,0,001,0,001,0,001,0,011,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,1E-05,0,20000037,0,20000037,0,20000037,0,20000037,0,0002,0,0002,0,4954955,0,4954955,0,4954955,0,001,0,01|0,0001,0,0001,0,0001,0,0001,0,001,0,001,0,001,0,011,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,01,0,20000037,0,20000037,0,20000037,0,20000037,0,003,0,003,0,4954955,0,4954955,0,4954955,0,001,0,01&chm=F,,0,-1,10&chs=426x205&chf=bg,s,252526&chxt=x,y&chds=0,0,54504505&chxr=1,0,0,54504505&chxs=1N*F4*,D1D1D1,11,0,lt|0,D1D1D1,11,0,lt&chxl=0:|07.01|11.01|17.01|23.01|29.01|04.02|10.02|16.02|22.02|28.02|06.03

The chart looks like this here, too, but is actually green-white, instead of green-black.
Great, thanks - I'll see if I can make out what this data is doing.

Re white/black, yeah I couldn't find a way to do that with the chart API and have it look right so I just flip those bits once I've pulled the chart into the buffer:
Code:
 'flip black pixels to white to make up for charts api colour control
        For y As Integer = 0 To gcimg.Height - 1
            For x As Integer = 0 To gcimg.Width - 1
                Dim clr As Color = gcimg.GetPixel(x, y)
                If (CInt(clr.R) + clr.G + clr.B) < 50 Then
                    gcimg.SetPixel(x, y, Color.White)
                End If
                If x > 1 And x < 21 And y > 174 And y < 189 Then
                    gcimg.SetPixel(x, y, Color.FromArgb(37, 37, 38))
                End If
            Next x
        Next y


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 07, 2014, 12:55:40 AM
When I buying,the screen became like this,wish it's helpful. By the way I like the UI style of this wallet very very much. Could somebody else please send me a little TMSC so that I can go on the testing. My address is 1Bohpd8tqJe4BdDFNctrzPhCmA2soCYspn, thanks.
http://imagecheese.net/images/buyingpic.jpg


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 07, 2014, 01:04:56 AM
Hey DexX,

I've gone over the numbers and it seems your client is submitting , instead of . when it builds the chart data.  I think this could lead to some unexpected things so I've just gone ahead and declared it's use globally.  Hopefully this will sort it.  Can you pull the latest binary and test?  I'll continue to look at the other issues mentioned.

Code:
        'declare globalization to make sure we use a . for decimal only
        Dim customCulture As System.Globalization.CultureInfo = System.Threading.Thread.CurrentThread.CurrentCulture.Clone()
        customCulture.NumberFormat.NumberDecimalSeparator = "."
        System.Threading.Thread.CurrentThread.CurrentCulture = customCulture
        System.Threading.Thread.CurrentThread.CurrentUICulture = customCulture

Hey pplwjd,

I can't see the image (image proxy error), any chance you can include something like an imgur link?

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 07, 2014, 01:38:48 AM
The chart is still broken, but I assume the culture info is only set for the specific thread and not globally. I'm not aware of a workaround, but it's probably worth to look into and to combat this whenever possible. Could also lead to broken queries, if floating points are used somewhere for example.

Code:
Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture

Has a broader effect and is not only limited to decimal marks, so something related may be preferred.


The image from pplwjd: https://i.imgur.com/vwEK0WC.jpg

edit: sent you some! :)

53e7ecbbdafb260e66531f4743dd6f5d332c2f0463148b14368be1ebfde28ff2 (0.005 MSC)
cd0923045d076fc9fbdae6c6f2d601cc549667b21e2e949fcbabb64e592f8541 (0.2 TMSC)

Will probably take a few minutes until it's visible on masterchest.info.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 07, 2014, 01:45:26 AM
The chart is still broken, but I assume the the culture info is only set for the specific thread and not globally. I'm not aware of a workaround, but it's probably worth to look into and to combat this whenever possible. Could also lead to broken queries, if floating points are used somewhere for example.

Code:
Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture

Has a broader effect and is not only limited to decimal marks, so something related may be preferred.


The image from pplwjd: https://i.imgur.com/vwEK0WC.jpg

edit: sent you some! :)

53e7ecbbdafb260e66531f4743dd6f5d332c2f0463148b14368be1ebfde28ff2 (0.005 MSC)
cd0923045d076fc9fbdae6c6f2d601cc549667b21e2e949fcbabb64e592f8541 (0.2 TMSC)

Will probably take a few minutes until it's visible on masterchest.info.
Good point - the chart is drawn by the scanning thread - as a stop gap while I look into invariantculture I've added to scanning thread - can you please try again?

Pplwjd - that's bizarre - seems it can't even find the right fonts etc - what OS & language is that & any customizations (DPI, scaling etc)?

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 07, 2014, 01:55:43 AM
Thank you dexX7

To Zathras, my os is win7 and language is chinese. Screen Resolution is 1680*1050 and I changed my screen fonts size 125% so that I can see it comfortably.

The chart is still broken, but I assume the the culture info is only set for the specific thread and not globally. I'm not aware of a workaround, but it's probably worth to look into and to combat this whenever possible. Could also lead to broken queries, if floating points are used somewhere for example.
 
Code:
Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture

Has a broader effect and is not only limited to decimal marks, so something related may be preferred.


The image from pplwjd: https://i.imgur.com/vwEK0WC.jpg

edit: sent you some! :)

53e7ecbbdafb260e66531f4743dd6f5d332c2f0463148b14368be1ebfde28ff2 (0.005 MSC)
cd0923045d076fc9fbdae6c6f2d601cc549667b21e2e949fcbabb64e592f8541 (0.2 TMSC)

Will probably take a few minutes until it's visible on masterchest.info.
Good point - the chart is drawn by the scanning thread - as a stop gap while I look into invariantculture I've added to scanning thread - can you please try again?

Pplwjd - that's bizarre - seems it can't even find the right fonts etc - what OS & language is that & any customizations (DPI, scaling etc)?

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 07, 2014, 02:04:44 AM
Hmm.. did also not help. It's pretty late here already, so I guess the next round comes tomorrow. Cheers! :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 07, 2014, 02:08:43 AM
Hmm.. did also not help. It's pretty late here already, so I guess the next round comes tomorrow. Cheers! :)

DexX - No worries, thanks for helping test - greatly appreciated :)  I'll see about some further testing my end...

Pplwjd - Just for a test, could you set font size to 100% and then see if everything looks right?  You can set it back to 125% afterwards.  I'd just like to see if that's part of the issue.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 07, 2014, 04:38:43 AM
Zathras,after I set font  size to 100%,the popup window is ok. The  blue color bottom line of the Rectangular buying popup window isn't there, is't ok?

Hmm.. did also not help. It's pretty late here already, so I guess the next round comes tomorrow. Cheers! :)

DexX - No worries, thanks for helping test - greatly appreciated :)  I'll see about some further testing my end...

Pplwjd - Just for a test, could you set font size to 100% and then see if everything looks right?  You can set it back to 125% afterwards.  I'd just like to see if that's part of the issue.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 07, 2014, 06:53:26 AM
When I sent payment,there was debug messages as follow and my wallet became "not synchronzied ".  After I restarted the wallet client the error is the same and I cannot synchronize. Then I restart both bitcoin-qt and msc wallet client, it's ok. 

DEBUG: Sanity checking balances table...
BLOCKSCAN: Finished, sleeping.
DEBUG: Thread exited.
DEBUG: Thread 'workthread' starting...
STATUS: Connection to bitcoin RPC established & sanity check OK.
STATUS: Connection to database established & sanity check OK.
STATUS: Database starting at block 289322
STATUS: Network is at block 289327
STATUS: 5 blocks to catch up
DEBUG: Block Analysis for: 289322
DEBUG: Block Analysis for: 289323
DEBUG: Block Analysis for: 289324
DEBUG: Block Analysis for: 289325
DEBUG: Block Analysis for: 289326
DEBUG: Block Analysis for: 289327
BLOCKSCAN: Found MSC transaction (accept offer): 485aecab6cf60af5cf2e50fa6fea71226e2efa1c091e084e33ce1bfc7a8e5a09
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Found pending MSC transaction (simple send): 37372d20fd5cd5bfa98b0a53072e775d333eaa55c960ec63c8117a7732cfbefa
BLOCKSCAN: Transaction processing starting...
DEBUG: Enumerating addresses...
ERROR: Blockchain scanning thread threw exception : 添加或减去的值产生无法表示的(my translation : "The added or subtracted value results in an un-representable") DateTime。
参数名(my translation "parameter name"): value
DEBUG: Thread exited with error condition.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 07, 2014, 09:08:53 AM
Hi guys,

Was this reported already? I googled and didn't find this error message regarding to Masterchest Wallet:

File version mismatch detected between ADO.NET


---------------------------
Masterchest_Wallet
---------------------------
File version mismatch detected between ADO.NET Provider and native binaries of SQL Server Compact which could result in an incorrect functionality.  This could be due to the presence of multiple instances of SQL Server Compact of different versions.  Please install SQL Server Compact binaries of matching version [ADO.NET Provider File Version = 3.5.5692.*, Native Binary File Version = 3.5.8080.*]
---------------------------
OK   
---------------------------

https://i.imgur.com/88wzySp.png


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: tradespoke on March 07, 2014, 12:00:50 PM
Do you want to use the masterchest wallet in another language?

Help with with translation and reviews are welcome here:

https://www.transifex.com/projects/p/masterchest-wallet-1/


You can do as much as you want or as little as you want, if you only translate a few words that fine. I'll do my best to handout rewards once new languages become available! To track this please use the same username here and on Transifex.

(still working on how payouts can be done fairly so please be patient if you have to wait for your payout until the official wallet supports your language)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 07, 2014, 09:42:17 PM
Hi guys,

Was this reported already? I googled and didn't find this error message regarding to Masterchest Wallet:

File version mismatch detected between ADO.NET


---------------------------
Masterchest_Wallet
---------------------------
File version mismatch detected between ADO.NET Provider and native binaries of SQL Server Compact which could result in an incorrect functionality.  This could be due to the presence of multiple instances of SQL Server Compact of different versions.  Please install SQL Server Compact binaries of matching version [ADO.NET Provider File Version = 3.5.5692.*, Native Binary File Version = 3.5.8080.*]
---------------------------
OK   
---------------------------

https://i.imgur.com/88wzySp.png

Hey Ron,

Hmm - this is an interesting one.  Basically I think you must already have a 32 bit installation of SQL Server 3.5 Compact, and that installation is older (3.5.5692) than the version I bundle with the wallet (3.5.8080).

I believe Windows uses the system SQL CE components if it's already been installed (rather than DLL's bundled in the application directory).

Either should fix:
1) Uninstall the SQL server compact edition you have on your machine which will make the wallet use the 3.5.8080 DLL's in the app directory (of course this may affect whatever software originally installed it)
2) Upgrade your local SQL server compact edition installation to 3.5.8080+

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 07, 2014, 09:43:09 PM
Re translations - I did notice some comments on github relating to preparing for translations, thanks for that and I will get back to you soon! :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 07, 2014, 11:01:54 PM
Hey zathras,

chart is fixed. You need to set the culture info at the beginning of the workthread_DoWork() method, too. I think that's also the only section where anything multithreaded is, right? So it should be fine then.. :)

I'm not sure, if CurrentThread.CurrentCulture is enough or if CurrentUICulture needs also to be set. But make sure you use CultureInfo.InvariantCulture instead of creating your own with only the decimal change.

Re: font size, this seems to be somewhat messy and there are some reports that users have problems with it, even when trying to change the element's size on the fly. Some said that the AutoScaleMode should set to .Dpi instead of .Font, but after testing the tables were still misplaced. Maybe you should use fixed font sizes all over the wallet and simply force a specific size, if this is possible. Less usability is still preferred over a broken interface imho.

It would also be nice, if the form is not entitled with "Form1". ;)

By the way, do you scan and refetch the block chain on the fly?


Edit: The balances in the "address overview" are accurate, but the "currencies overview" displays the balances as if the decimal limiter was ignored. https://i.imgur.com/wJoZ0iy.png

The date of a transaction created by the wallet is also affected by localization, I think: https://i.imgur.com/kUBEteZ.png + http://pastebin.com/raw.php?i=ad6HcMDR (log was super long, so I hope this is relevant part)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 08, 2014, 08:04:31 AM
Hey Ron,

Hmm - this is an interesting one.  Basically I think you must already have a 32 bit installation of SQL Server 3.5 Compact, and that installation is older (3.5.5692) than the version I bundle with the wallet (3.5.8080).

I believe Windows uses the system SQL CE components if it's already been installed (rather than DLL's bundled in the application directory).

Either should fix:
1) Uninstall the SQL server compact edition you have on your machine which will make the wallet use the 3.5.8080 DLL's in the app directory (of course this may affect whatever software originally installed it)
2) Upgrade your local SQL server compact edition installation to 3.5.8080+

Thanks
Zathras

1. I don't see SQL server in "Add / remove programs". I did spot it under "C:\Program Files\Microsoft SQL Server Compact Edition", and moved it to "C:\tmp" (I didn't want to just delete it). This didn't help, and I'm getting the same error.

2. This is not something that users should have to deal with - there needs to be a cleaner solution - the wallet should just work out of the box without users needing to tweak with other software installed on their system.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 08, 2014, 08:05:22 AM
P.S if you want to do a quick debugging session with me, ping me on skype.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: SyRenity on March 08, 2014, 10:02:20 AM
2. This is not something that users should have to deal with - there needs to be a cleaner solution - the wallet should just work out of the box without users needing to tweak with other software installed on their system.

Just a quick suggestion (I was involved in development of desktop app for a mass market in past, which also had same considerations) - please consider using SQLite.
It will give you same capabilities, minus all the distribution and installation headache that SQL server compact will introduce.

You only need to bundle a single DLL to make it work, and there is also an ADO provider (which seems to be useful in your case):
http://system.data.sqlite.org/index.html/doc/trunk/www/index.wiki

HTH.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: Tachikoma on March 08, 2014, 10:34:21 AM
I've been trying to break stuff as well and I finally managed to!

I just installed Alpha 2 and got this error when it appears the msc-chain got caught up:

Quote
DEBUG: Block Analysis for: 289519
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Transaction processing starting...
ERROR: Blockchain scanning thread threw exception : The column name is not valid. [ Node name (if any) = ,Column name = ADDRESS ]
DEBUG: Thread exited with error condition.

Is the version on the mastercoinwallets site always the latest version?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 08, 2014, 12:24:34 PM
Is the version on the mastercoinwallets site always the latest version?

Usually yes.

I received the same error and suggested a fix (https://github.com/zathras-crypto/masterchest-wallet/issues/7).


Edit: There is some difference with the cancel offer, I think:

https://masterchain.info/selloffer.html?tx=5c6802c5f1e3aa69f90a051250792bc1c5ad2e965259a2673059884df71dfd13&currency=TMSC
http://www.mymastercoins.com/default.aspx?TXID=5c6802c5f1e3aa69f90a051250792bc1c5ad2e965259a2673059884df71dfd13

Since this tx went through another open order shows an unit price of infinite: https://i.imgur.com/f6kUrO2.png (this was the state earlier, more or less: https://i.imgur.com/7vCCECd.png)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 08, 2014, 09:28:44 PM
I've been trying to break stuff as well and I finally managed to!

I just installed Alpha 2 and got this error when it appears the msc-chain got caught up:

Quote
DEBUG: Block Analysis for: 289519
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Transaction processing starting...
ERROR: Blockchain scanning thread threw exception : The column name is not valid. [ Node name (if any) = ,Column name = ADDRESS ]
DEBUG: Thread exited with error condition.

Is the version on the mastercoinwallets site always the latest version?

Firstly, thanks for all the bug reports guys, I am taking them on board and looking at them where I can.  

I may be a bit quiet today so sorry if you don't get an immediate response, since joining 'full-time' a couple of weeks ago I've worked through both weekends which has - shall we say, irritated - my better half whom I promised I would work less after leaving my day job!  So a bit of Sunday family time is in order I think :)  You know the drill, happy wife happy life.

Tachikoma/DexX, I've just pushed a commit up fixing this bug (thanks to DexX for highlighting the buggy code!).

SyRenity, yep I have been thinking about SQLite but time is so limited at the moment it hasn't made its way far up the priority list unfortunately.

Ron, moving that folder won't do it I'm afraid - SQLCE is just really DLLs and these will be in your GAC (global assembly cache) as well as your system folders so just moving that folder out of program files will be ineffective.  As I mentioned really it's a complete removal or an upgrade.  Best bet is simply run this http://www.microsoft.com/en-au/download/details.aspx?id=5783 to update your old SQLCE install.  Also whilst I do of course appreciate your desire to have things easy for the user, I think those expectations are perhaps a little too high.  I have put a lot of effort into this & I did indeed test both without SQLCE and with SQLCE installed, but I did not test with outdated SQLCE installed.  I can't test every possible scenario, hardware configuration and software portfolio before alpha - it's just not realistic.  This is why it's out here for the community to test and as you guys pick these things up I will of course address them and try to remove/automate resolution of problems etc.  There WILL be bugs at this stage.  Completely agree stable releases should be much better :) but initial alphas are inherently unstable as they're the first time code gets tested on a wide range of configurations.

Thanks guys! :)
Zathras

EDIT: Tachikoma, just tested the link on mastercoinwallets and that pulls directly from raw.github.com so yeah should always be the latest binary.  Every time I do a commit on source I do a build and update the binary in the bin archive on github so getting latest version should always just be redownloading that archive following any commits I do.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: Tachikoma on March 09, 2014, 10:25:08 AM
Awesome; I just re-tested everything and it syncs fine now. Thanks for the quick fix :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 09, 2014, 11:18:01 AM
Ron, moving that folder won't do it I'm afraid - SQLCE is just really DLLs and these will be in your GAC (global assembly cache) as well as your system folders so just moving that folder out of program files will be ineffective.  As I mentioned really it's a complete removal or an upgrade.  Best bet is simply run this http://www.microsoft.com/en-au/download/details.aspx?id=5783 to update your old SQLCE install.  Also whilst I do of course appreciate your desire to have things easy for the user, I think those expectations are perhaps a little too high.  I have put a lot of effort into this & I did indeed test both without SQLCE and with SQLCE installed, but I did not test with outdated SQLCE installed.  I can't test every possible scenario, hardware configuration and software portfolio before alpha - it's just not realistic.  This is why it's out here for the community to test and as you guys pick these things up I will of course address them and try to remove/automate resolution of problems etc.  There WILL be bugs at this stage.  Completely agree stable releases should be much better :) but initial alphas are inherently unstable as they're the first time code gets tested on a wide range of configurations.

Understood - I ran the SQLCE installer and this resolved the issue (you may want to link to this from your error message).

I also understand about the alpha stage - it's just that I guess I expected something a bit more stable at this stage of development, but it's understand that this is still a bit raw around some edges since the wallet was just released.

FYI - please see this error from the debug window.

Quote
ERROR: Database block appears newer than bitcoinrpc blocks - is bitcoinrpc up to date? Exiting thread.

1. Should the thread really exit at this point? Bitcoin-qt is still syncing, should the code just wait for it to sync rather than give up? Or perhaps it is doing that and the message just threw me off?
2. Actually the wallet doesn't show any sort of progress bar, so the user does't know if the wallet is waiting for sync, or gave up. I think that adding something like that would be good for the user to know that something is going on.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 09, 2014, 03:28:16 PM
I also understand about the alpha stage - it's just that I guess I expected something a bit more stable at this stage of development, but it's understand that this is still a bit raw around some edges since the wallet was just released.

I think proper error messages are very important for usability, too. Let's just write every one down, whenever one without nice information is found. :)


Edit: zathras, what is your take on the translation thing? Is it safe to start submitting translations to https://www.transifex.com/projects/p/masterchest-wallet-1/ or is not yet finalized and up to change?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: hennessyhemp on March 09, 2014, 05:21:01 PM
So I have some difficulty running this simply because running the Bitcoin client is not very friendly with my computer, will it ever work from a light weight wallet like Multibit?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: Tachikoma on March 09, 2014, 07:18:04 PM
So I have some difficulty running this simply because running the Bitcoin client is not very friendly with my computer, will it ever work from a light weight wallet like Multibit?

No, Masterchest probably won't. It needs the specific API calls from bitcoind, Multibit (as far as I know doesn't supply these calls). You can however still use a web-wallet like https://masterchain.info/, this could be considered light.

Zath, I'm trying to send the payment for an accepted DEx offer but I get the following error after filling in my password.

https://i.imgur.com/wgPiZ4t.png

Translated: "Value can't be null", parameter name: Value

Any idea what I'm doing wrong there? Is the offer perhaps already expired?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 09, 2014, 09:57:30 PM
Ron, moving that folder won't do it I'm afraid - SQLCE is just really DLLs and these will be in your GAC (global assembly cache) as well as your system folders so just moving that folder out of program files will be ineffective.  As I mentioned really it's a complete removal or an upgrade.  Best bet is simply run this http://www.microsoft.com/en-au/download/details.aspx?id=5783 to update your old SQLCE install.  Also whilst I do of course appreciate your desire to have things easy for the user, I think those expectations are perhaps a little too high.  I have put a lot of effort into this & I did indeed test both without SQLCE and with SQLCE installed, but I did not test with outdated SQLCE installed.  I can't test every possible scenario, hardware configuration and software portfolio before alpha - it's just not realistic.  This is why it's out here for the community to test and as you guys pick these things up I will of course address them and try to remove/automate resolution of problems etc.  There WILL be bugs at this stage.  Completely agree stable releases should be much better :) but initial alphas are inherently unstable as they're the first time code gets tested on a wide range of configurations.

Understood - I ran the SQLCE installer and this resolved the issue (you may want to link to this from your error message).

I also understand about the alpha stage - it's just that I guess I expected something a bit more stable at this stage of development, but it's understand that this is still a bit raw around some edges since the wallet was just released.

FYI - please see this error from the debug window.

Quote
ERROR: Database block appears newer than bitcoinrpc blocks - is bitcoinrpc up to date? Exiting thread.

1. Should the thread really exit at this point? Bitcoin-qt is still syncing, should the code just wait for it to sync rather than give up? Or perhaps it is doing that and the message just threw me off?
2. Actually the wallet doesn't show any sort of progress bar, so the user does't know if the wallet is waiting for sync, or gave up. I think that adding something like that would be good for the user to know that something is going on.

Hey Ron,

1.  Yes, the scanning thread needs to exit here.  Your database is at lets say block 288000 (because it's pre-seeded), and bitcoin-qt is at lets say block 240000 (maybe because it's still resyncing/reindexing for example).  The wallet cannot analyze its next block (288001) because bitcoin-qt doesn't have that block available yet via RPC.  Thus we have to exit the thread and wait until bitcoin-qt has the block data available.  I wouldn't want to just wait the thread while we wait for bitcoin-qt to finish syncing as that is an indeterminate time period.  The scanning thread restarts every 5 minutes anyway so once bitcoin-qt has the block data available the wallet simply starts syncing itself.

2.  If you're getting that error the wallet state should be a red cross with 'not synchronized' (unless there is a bug).  Once the wallet starts syncing the status should change including showing progress through the blocks.  I can certainly add a '% remaining' or similar.

Not sure what you mean by give up, but if I catch your meaning the wallet will never 'give up' as it were.  Yep the scanning thread might exit if there are conditions it doesn't like, but it'll just try again in 5 minutes time.  It continues like this until you close the wallet.  The overview should always be in one of three states:
* Not synchronized
* Synchronizing
* Synchronized

Thanks :)
Zathras
 


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 09, 2014, 10:01:04 PM
I also understand about the alpha stage - it's just that I guess I expected something a bit more stable at this stage of development, but it's understand that this is still a bit raw around some edges since the wallet was just released.

I think proper error messages are very important for usability, too. Let's just write every one down, whenever one without nice information is found. :)


Edit: zathras, what is your take on the translation thing? Is it safe to start submitting translations to https://www.transifex.com/projects/p/masterchest-wallet-1/ or is not yet finalized and up to change?
I agree - if you can tee up a batch of unclear error messages I can go through and adjust the handling to provide better guidance.

On the translations I honestly haven't had a chance to look at that/think about it at this stage.  I'll try to get some time to look at it :)



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 09, 2014, 10:16:36 PM
So I have some difficulty running this simply because running the Bitcoin client is not very friendly with my computer, will it ever work from a light weight wallet like Multibit?

No, Masterchest probably won't. It needs the specific API calls from bitcoind, Multibit (as far as I know doesn't supply these calls). You can however still use a web-wallet like https://masterchain.info/, this could be considered light.

Zath, I'm trying to send the payment for an accepted DEx offer but I get the following error after filling in my password.

https://i.imgur.com/wgPiZ4t.png

Translated: "Value can't be null", parameter name: Value

Any idea what I'm doing wrong there? Is the offer perhaps already expired?

Hmm, in the send payment window is everything populated (all fields on the left)? - Also I've just committed a quick addition of exception trapping on encoding functions in the library - perhaps that'll give some more visibility to the issue (just pull the bin archive again).  Otherwise I can throw you a custom build with a bunch of extra debugging.

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 09, 2014, 11:04:03 PM
Hey zathras,

chart is fixed. You need to set the culture info at the beginning of the workthread_DoWork() method, too. I think that's also the only section where anything multithreaded is, right? So it should be fine then.. :)

I'm not sure, if CurrentThread.CurrentCulture is enough or if CurrentUICulture needs also to be set. But make sure you use CultureInfo.InvariantCulture instead of creating your own with only the decimal change.

Re: font size, this seems to be somewhat messy and there are some reports that users have problems with it, even when trying to change the element's size on the fly. Some said that the AutoScaleMode should set to .Dpi instead of .Font, but after testing the tables were still misplaced. Maybe you should use fixed font sizes all over the wallet and simply force a specific size, if this is possible. Less usability is still preferred over a broken interface imho.

It would also be nice, if the form is not entitled with "Form1". ;)

By the way, do you scan and refetch the block chain on the fly?


Edit: The balances in the "address overview" are accurate, but the "currencies overview" displays the balances as if the decimal limiter was ignored. https://i.imgur.com/wJoZ0iy.png

The date of a transaction created by the wallet is also affected by localization, I think: https://i.imgur.com/kUBEteZ.png + http://pastebin.com/raw.php?i=ad6HcMDR (log was super long, so I hope this is relevant part)
Hey Dexx,

The culture stuff was added to the dowork method in https://github.com/zathras-crypto/masterchest-wallet/commit/e324be03d62e002fdb8fcd38ec731f6e889e00b0 but I need to spend more time understanding this to do it properly.

Haha on the form name - yeah all the others are named but this one kind of grew out of nothing, I'll rename it 'main' or something at some point.

Fetching the blockchain is left up to the local bitcoin instance, we just query that over RPC.  We currently roll back 5 blocks every time the scanning thread starts (every 5 minutes) and rescan to pick up new transactions.  Transaction state processing is completely redone on every completion of the scanning run start to finish.  There are a lot of inefficiencies/performance improvements I can fix up when time allows too.

Re dates, notice how the colour is blue - that's because it's an unconfirmed transaction (and thus has no blocktime) - we spoof a date in the year 9999 until confirmed so I don't think that's localization (just the zany way my brain thinks!).

The currencies overview is obviously not right - if you go to the exchange panel and click on 'sell', then select one of your addresses - does the 'available balance' show correctly?

Thanks :)
Zathras



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 09, 2014, 11:25:57 PM
I've just committed a new version with output to the debug panel when encoding transactions - this should help in diagnosing where things aren't working.

Polite reminder, this is alpha software, do not test it with wallets containing any significant amount of bitcoins/mastercoins.

:)

Thanks!
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 10, 2014, 02:34:42 AM
When I started my wallet client today,I have this error messages and my client displayed not  syncronized. When I restarted the client,it still hung at the block 289803 and got the same messages.
DEBUG: Block Analysis for: 289789
DEBUG: Block Analysis for: 289790
BLOCKSCAN: Found MSC transaction (simple send): b30c0a6a6c753dc7d1cce3580aa28258a75748f32de8e9f5dd4567524c94a280
DEBUG: Block Analysis for: 289791
DEBUG: Block Analysis for: 289792
DEBUG: Block Analysis for: 289793
DEBUG: Block Analysis for: 289794
DEBUG: Block Analysis for: 289795
DEBUG: Block Analysis for: 289796
DEBUG: Block Analysis for: 289797
DEBUG: Block Analysis for: 289798
DEBUG: Block Analysis for: 289799
DEBUG: Block Analysis for: 289800
DEBUG: Block Analysis for: 289801
DEBUG: Block Analysis for: 289802
DEBUG: Block Analysis for: 289803
BLOCKSCAN: Found MSC transaction (simple send): 464245fb57cf539fd4a2d987d9abed0c820add5bb304a9ee752711f829a8fe41
BLOCKSCAN: Found MSC transaction (simple send): 53d75f221fad5a497bc8c5c1fe942345d51851ec4850cda733e491263be7ecb6
BLOCKSCAN: Found MSC transaction (simple send): 2751409e5ac3acf2f76a4b8723816567ebda0188054272921ce73b126e64981e
BLOCKSCAN: Found MSC transaction (simple send): 9480f5fb41d8d477df89093947cf293e11266867d4b97eb7d0c10d2c0dc89b50
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Transaction processing starting...
ERROR: Blockchain scanning thread threw exception : The column name is not valid. [ Node name (if any) = ,Column name = ADDRESS ]
DEBUG: Thread exited with error condition.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 10, 2014, 03:28:35 AM
When I started my wallet client today,I have this error messages and my client displayed not  syncronized. When I restarted the client,it still hung at the block 289803 and got the same messages.
DEBUG: Block Analysis for: 289789
DEBUG: Block Analysis for: 289790
BLOCKSCAN: Found MSC transaction (simple send): b30c0a6a6c753dc7d1cce3580aa28258a75748f32de8e9f5dd4567524c94a280
DEBUG: Block Analysis for: 289791
DEBUG: Block Analysis for: 289792
DEBUG: Block Analysis for: 289793
DEBUG: Block Analysis for: 289794
DEBUG: Block Analysis for: 289795
DEBUG: Block Analysis for: 289796
DEBUG: Block Analysis for: 289797
DEBUG: Block Analysis for: 289798
DEBUG: Block Analysis for: 289799
DEBUG: Block Analysis for: 289800
DEBUG: Block Analysis for: 289801
DEBUG: Block Analysis for: 289802
DEBUG: Block Analysis for: 289803
BLOCKSCAN: Found MSC transaction (simple send): 464245fb57cf539fd4a2d987d9abed0c820add5bb304a9ee752711f829a8fe41
BLOCKSCAN: Found MSC transaction (simple send): 53d75f221fad5a497bc8c5c1fe942345d51851ec4850cda733e491263be7ecb6
BLOCKSCAN: Found MSC transaction (simple send): 2751409e5ac3acf2f76a4b8723816567ebda0188054272921ce73b126e64981e
BLOCKSCAN: Found MSC transaction (simple send): 9480f5fb41d8d477df89093947cf293e11266867d4b97eb7d0c10d2c0dc89b50
DEBUG: Block Analysis for pending transactions
BLOCKSCAN: Transaction processing starting...
ERROR: Blockchain scanning thread threw exception : The column name is not valid. [ Node name (if any) = ,Column name = ADDRESS ]
DEBUG: Thread exited with error condition.

Hey :)

Please update to the latest binary which should have that bug resolved.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 10, 2014, 10:02:35 AM
1. Should the thread really exit at this point? Bitcoin-qt is still syncing, should the code just wait for it to sync rather than give up? Or perhaps it is doing that and the message just threw me off?
2. Actually the wallet doesn't show any sort of progress bar, so the user does't know if the wallet is waiting for sync, or gave up. I think that adding something like that would be good for the user to know that something is going on.

Hey Ron,

1.  Yes, the scanning thread needs to exit here.  Your database is at lets say block 288000 (because it's pre-seeded), and bitcoin-qt is at lets say block 240000 (maybe because it's still resyncing/reindexing for example).  The wallet cannot analyze its next block (288001) because bitcoin-qt doesn't have that block available yet via RPC.  Thus we have to exit the thread and wait until bitcoin-qt has the block data available.  I wouldn't want to just wait the thread while we wait for bitcoin-qt to finish syncing as that is an indeterminate time period.  The scanning thread restarts every 5 minutes anyway so once bitcoin-qt has the block data available the wallet simply starts syncing itself.

2.  If you're getting that error the wallet state should be a red cross with 'not synchronized' (unless there is a bug).  Once the wallet starts syncing the status should change including showing progress through the blocks.  I can certainly add a '% remaining' or similar.

Not sure what you mean by give up, but if I catch your meaning the wallet will never 'give up' as it were.  Yep the scanning thread might exit if there are conditions it doesn't like, but it'll just try again in 5 minutes time.  It continues like this until you close the wallet.  The overview should always be in one of three states:
* Not synchronized
* Synchronizing
* Synchronized

Thanks :)
Zathras
 

I understand - I was afraid that when the thread exists it doesn't revive again.
5 minutes is a long time - can you test this every 5-10 seconds instead for better responsiveness? Is the test resource intensive?

Also, in this state (live block < pre-seed block), it would still be useful to have some progress/status on the blocks parsed/that remain to be parsed.
Right now it's not clear to the user whether the process is stuck or not.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 10, 2014, 11:24:10 AM
The currencies overview is obviously not right - if you go to the exchange panel and click on 'sell', then select one of your addresses - does the 'available balance' show correctly?

Yup, those numbers are correct.

I have an older sell order stuck which I can't delete. Sent more than one cancel offer already. At the same time there is an unpaid order, which is actually expired. https://i.imgur.com/l8Kv6X8.png (wallet.sdf (https://www.dropbox.com/s/swnce099y2768je/wallet_dexx.rar), started with the latest GH version, used seeded /debug wallet.sdf, tried to cancel the order)

Ah, 5 minutes, I see. Maybe include a button to update manually, e.g. replace the sync icon which pops up while syncing with a "force update" icon/button? You may check out the command line options "blocknotify" and "walletnotify":

Quote
-blocknotify=<cmd> Execute command when the best block changes (%s in cmd is replaced by block hash)
-walletnotify=<cmd> Execute command when a wallet transaction changes (%s in cmd is replaced by TxID)

As far as I know cmd can be replaced by a path or script to which the hash is passed, but I'm not sure, how easy or difficult it would be to combine this with the wallet. :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 10, 2014, 05:58:23 PM
1. Should the thread really exit at this point? Bitcoin-qt is still syncing, should the code just wait for it to sync rather than give up? Or perhaps it is doing that and the message just threw me off?
2. Actually the wallet doesn't show any sort of progress bar, so the user does't know if the wallet is waiting for sync, or gave up. I think that adding something like that would be good for the user to know that something is going on.

Hey Ron,

1.  Yes, the scanning thread needs to exit here.  Your database is at lets say block 288000 (because it's pre-seeded), and bitcoin-qt is at lets say block 240000 (maybe because it's still resyncing/reindexing for example).  The wallet cannot analyze its next block (288001) because bitcoin-qt doesn't have that block available yet via RPC.  Thus we have to exit the thread and wait until bitcoin-qt has the block data available.  I wouldn't want to just wait the thread while we wait for bitcoin-qt to finish syncing as that is an indeterminate time period.  The scanning thread restarts every 5 minutes anyway so once bitcoin-qt has the block data available the wallet simply starts syncing itself.

2.  If you're getting that error the wallet state should be a red cross with 'not synchronized' (unless there is a bug).  Once the wallet starts syncing the status should change including showing progress through the blocks.  I can certainly add a '% remaining' or similar.

Not sure what you mean by give up, but if I catch your meaning the wallet will never 'give up' as it were.  Yep the scanning thread might exit if there are conditions it doesn't like, but it'll just try again in 5 minutes time.  It continues like this until you close the wallet.  The overview should always be in one of three states:
* Not synchronized
* Synchronizing
* Synchronized

Thanks :)
Zathras
 

I understand - I was afraid that when the thread exists it doesn't revive again.
5 minutes is a long time - can you test this every 5-10 seconds instead for better responsiveness? Is the test resource intensive?

Also, in this state (live block < pre-seed block), it would still be useful to have some progress/status on the blocks parsed/that remain to be parsed.
Right now it's not clear to the user whether the process is stuck or not.

Hey Ron,

It's a very intensive thread, but the test for what block bitcoin is at itself isn't resource intensive.  5 minutes was chosen for a refresh on the scanning thread as it's half of the average bitcoin block so by and large the wallet will always be working from the latest block.

Re progress, the debug panel should state that quite clearly, for example on first run you may see:
* Database blocks 288000, Bitcoin RPC blocks 240000 - is bitcoinrpc up to date (or similar text)

Then on the next run you'd see:
* Database blocks 288000, Bitcoin RPC blocks 250000 - is bitcoinrpc up to date (and so on)

At the moment we don't do any processing until fully synced.  I'll have a think about how I can handle the appearance to the end user.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: crazy_rabbit on March 10, 2014, 05:58:45 PM
Will it be possible in the future to have a Masterchest Lite Client? I can't imagine reindexing the Blockchain everytime like this.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 10, 2014, 06:01:41 PM
The currencies overview is obviously not right - if you go to the exchange panel and click on 'sell', then select one of your addresses - does the 'available balance' show correctly?

Yup, those numbers are correct.

I have an older sell order stuck which I can't delete. Sent more than one cancel offer already. At the same time there is an unpaid order, which is actually expired. https://i.imgur.com/l8Kv6X8.png (wallet.sdf (https://www.dropbox.com/s/swnce099y2768je/wallet_dexx.rar), started with the latest GH version, used seeded /debug wallet.sdf, tried to cancel the order)

Ah, 5 minutes, I see. Maybe include a button to update manually, e.g. replace the sync icon which pops up while syncing with a "force update" icon/button? You may check out the command line options "blocknotify" and "walletnotify":

Quote
-blocknotify=<cmd> Execute command when the best block changes (%s in cmd is replaced by block hash)
-walletnotify=<cmd> Execute command when a wallet transaction changes (%s in cmd is replaced by TxID)

As far as I know cmd can be replaced by a path or script to which the hash is passed, but I'm not sure, how easy or difficult it would be to combine this with the wallet. :)

Great, thanks.

Any transaction you broadcast should automatically kick off the scanning thread to update, but yeah I have been toying with the idea of a manual sync button.  I have some plans around a better model for checking for new blocks, just requires time to implement splitting off the actual scanning thread from blockcount checks so that they can be run more frequently :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 10, 2014, 06:05:23 PM
Will it be possible in the future to have a Masterchest Lite Client? I can't imagine reindexing the Blockchain everytime like this.

Reindexing the blockchain should be a one-time event :)  However I have considered that yep - it would be a 'consensus based' thin client - so a thin client in the traditional sense, except that it only works on matching transaction data retrieved from multiple sources.  It all depends on the direction the project takes :)

Thanks!
Zathras



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dacoinminster on March 10, 2014, 09:10:49 PM

Reindexing the blockchain should be a one-time event :)  However I have considered that yep - it would be a 'consensus based' thin client - so a thin client in the traditional sense, except that it only works on matching transaction data retrieved from multiple sources.  It all depends on the direction the project takes :)

Thanks!
Zathras


That would be sweet!

On a side note, I know you've been working through the weekends lately. Don't push yourself too hard!!

On the other hand, I hope the financial rewards of all this work will also make your wife very happy in the long run :)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 11, 2014, 12:42:57 AM

Reindexing the blockchain should be a one-time event :)  However I have considered that yep - it would be a 'consensus based' thin client - so a thin client in the traditional sense, except that it only works on matching transaction data retrieved from multiple sources.  It all depends on the direction the project takes :)

Thanks!
Zathras


That would be sweet!

On a side note, I know you've been working through the weekends lately. Don't push yourself too hard!!

On the other hand, I hope the financial rewards of all this work will also make your wife very happy in the long run :)

Thanks J.R. - if only I'd just stopped at doing masterchest.info only :P  Nah just kidding :)  The better half is surprisingly understanding actually (financial rewards no doubt help :P) - I can just push it a bit far without thinking sometimes (like this morning I had a idea to fix a bug so got up & started coding around 4AM lol) - this is all new so it's a bit of an adjustment that's all.



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 11, 2014, 10:13:21 AM
Will it be possible in the future to have a Masterchest Lite Client? I can't imagine reindexing the Blockchain everytime like this.

Reindexing the blockchain should be a one-time event :)  However I have considered that yep - it would be a 'consensus based' thin client - so a thin client in the traditional sense, except that it only works on matching transaction data retrieved from multiple sources.  It all depends on the direction the project takes :)

Thanks!
Zathras



FYI we are discussing the possibility of Masterchest using mastercoin-tools (https://github.com/grazcoin/mastercoin-tools) as its parsing engine.
mastercoin-tools relies on SX with Obelisk servers, which is essentially a lite client experience.

My vision for Marchest going forward:

1. When you install Masterchest, it starts working with remote Obelisk servers.
2. It asks you "Do you want to upgrade to 'Full Client' mode ?"
3. If you confirm, then a local obelisk server is installed, and starts syncing with the network. You are told that the client is working in Lite mode for the time being.
4. When the blockchain syncs and is parsed, the client automatically switches from Lite Client mode to Full Client - instead of working with remote obelisk servers, it now uses the local one.

I realize this scenario requires some delicate coding! But I think it would provide the ultimate user experience in terms of a good compromise between security and usability.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 11, 2014, 05:34:33 PM
FYI we are discussing the possibility of Masterchest using mastercoin-tools (https://github.com/grazcoin/mastercoin-tools) as its parsing engine.

Having multiple parsing engines is essential to avoid too much centralization in my opinion.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dacoinminster on March 11, 2014, 11:18:59 PM
FYI we are discussing the possibility of Masterchest using mastercoin-tools (https://github.com/grazcoin/mastercoin-tools) as its parsing engine.

Having multiple parsing engines is essential to avoid too much centralization in my opinion.

Yeah, this isn't something we have completely agreed upon yet. I'm very reluctant to reduce the number of parsing engines - there are TONS of edge cases we catch because we have them.

On the other hand, it slows us down a lot, and you could argue that more strenuous testing would catch those same edge cases.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 12, 2014, 09:34:19 PM
FYI we are discussing the possibility of Masterchest using mastercoin-tools (https://github.com/grazcoin/mastercoin-tools) as its parsing engine.

Having multiple parsing engines is essential to avoid too much centralization in my opinion.

Yeah, this isn't something we have completely agreed upon yet. I'm very reluctant to reduce the number of parsing engines - there are TONS of edge cases we catch because we have them.

On the other hand, it slows us down a lot, and you could argue that more strenuous testing would catch those same edge cases.

Bitcoin has one reference implementation.
I'm not opposed to there being other implementations of mastercoin, but I want to directed our resources in the right way, and speed up development.

In most cases, having all the wallets agree on the balances (=consensus) is more important than having the implementations conform to the spec. The exception is bugs that cause people to lose money - but most bugs (=places where the implementation differs from the spec) aren't exploitable, and can be fixed in future releases.

I think Bitcoin's core devs were asked once to provide a spec for Bitcoin, and they replied that the implementation is the spec. (I may be misquoting here).


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 13, 2014, 06:05:51 AM
After I bought or sold TMSC by wallet exchange when testing , I checked my address in bitcoin block  explorer, I got this message as follow
   1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P 0.00006 BTC
(Escrow 1 of 157rMRZUve... 1PJCYPLdjP...) 0.00018 BTC
I'm confused with the Escrow line,could you please tell me what does it mean,where did the 0.00018BTC go to?
In addition,when buying or selling TMSC using wallet p2p exchange,I cancel my transaction,but I still have to pay for 0.00035BTC . I don't think it's reasonable. 


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 13, 2014, 10:32:47 AM
After I bought or sold TMSC by wallet exchange when testing , I checked my address in bitcoin block  explorer, I got this message as follow
   1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P 0.00006 BTC
(Escrow 1 of 157rMRZUve... 1PJCYPLdjP...) 0.00018 BTC
I'm confused with the Escrow line,could you please tell me what does it mean,where did the 0.00018BTC go to?
In addition,when buying or selling TMSC using wallet p2p exchange,I cancel my transaction,but I still have to pay for 0.00035BTC . I don't think it's reasonable. 


The 'Escrow' is actually a multisig address. It's what we call "Class B transaction" - see the spec (https://github.com/mastercoin-MSC/spec#class-b-transactions-also-known-as-the-multisig-method). You need not worry about it, it's just an implementation detail.

Regarding canceling orders - any action that changes the state of the DEx needs to be broadcast as a bitcoin transaction - there is no way to do that without paying the minimal transaction fee. Note that 0.00035BTC currently equals about 22 cents.

The DEx does not work like centralized exchanges, it has benefits and downsides. One of the downsides, unfortunately, is fees that needs to be paid per operation. However consider when buying large blocks on the DEx, you will not pay a relative fee, but rather just a fixed amount - so it should end up cheaper (not to mention you don't need to trust an exchange).


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: pplwjd on March 14, 2014, 12:29:53 AM
Thanks,Ron. I got it. By the way, I like the MSC project very much and look forward to your Omniwallet.

After I bought or sold TMSC by wallet exchange when testing , I checked my address in bitcoin block  explorer, I got this message as follow
   1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P 0.00006 BTC
(Escrow 1 of 157rMRZUve... 1PJCYPLdjP...) 0.00018 BTC
I'm confused with the Escrow line,could you please tell me what does it mean,where did the 0.00018BTC go to?
In addition,when buying or selling TMSC using wallet p2p exchange,I cancel my transaction,but I still have to pay for 0.00035BTC . I don't think it's reasonable. 


The 'Escrow' is actually a multisig address. It's what we call "Class B transaction" - see the spec (https://github.com/mastercoin-MSC/spec#class-b-transactions-also-known-as-the-multisig-method). You need not worry about it, it's just an implementation detail.

Regarding canceling orders - any action that changes the state of the DEx needs to be broadcast as a bitcoin transaction - there is no way to do that without paying the minimal transaction fee. Note that 0.00035BTC currently equals about 22 cents.

The DEx does not work like centralized exchanges, it has benefits and downsides. One of the downsides, unfortunately, is fees that needs to be paid per operation. However consider when buying large blocks on the DEx, you will not pay a relative fee, but rather just a fixed amount - so it should end up cheaper (not to mention you don't need to trust an exchange).


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: ripper234 on March 14, 2014, 12:33:35 AM
Thanks,Ron. I got it. By the way, I like the MSC project very much and look forward to your Omniwallet.

Thanks, your support is appreciated!

Little under 24 hours for the DEx launch! (block 290630)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 15, 2014, 07:58:26 AM
Alpha 0.3 is up.  OP updated.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: IamNotSure on March 15, 2014, 06:04:25 PM
I read somewhere that one can download a "reparsed" database to speed up the parsing process. Any link available ?

Don't want to wait 24+ hours to try the DEX


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: subSTRATA on March 15, 2014, 06:28:25 PM
Few issues with Alpha 0.3 on Win7 64-bit:

1. Initial draft .pdf says "NOTE: If you have customized your bitcoin installation (for example by using the --datadir flag to change the location of
your bitcoin configuration and database) you may need to specify your configuration manually. To do so simply change the four values in wallet.cfg
from empty to your chosen bitcoin RPC server configuration" but that is not true, if one is using non-default datadir than a new line must be added
to file in question. Only this one worked for me:

bitcoinrpcserv=localhost
bitcoinrpcport=8332
bitcoinrpcuser=(username_goes_here)
bitcoinrpcpass=(password_goes_here)
datadir=D:\BitcoinData

Omitting any data or line makes Masterchest complain and shutdown or keep on running but doing nothing.

2. Once Masterchest is started and starts syncing with blockchain, switching to "debug" tab and clicking on DEBUG LEVEL: LOW changes it to MED
and Masterchest becomes unresponsive including minimizing wallet window. It will start accepting user input only after syncing is fully done. Same
unresponsivness occurs once Masterchest starts to print debug text while on MED or HIGH setting. It is impossible to stop printing, it just goes worse
since user can only switch LOW to MED to HIGH level, not MED to LOW or OFF (which does not even exists).

3. Taskbar name for Masterchest is Form1

4. On "currencies" tab amount of coins is wrong, instead of 0.00125 MSC and 4.04268975 BTC it shows I have 125.00 MSC and 404268975.00 BTC

5. Right and bottom sides of main and other windows look wrong, see https://i.imgur.com/7W619QT.png


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 15, 2014, 10:58:48 PM
I read somewhere that one can download a "reparsed" database to speed up the parsing process. Any link available ?

Don't want to wait 24+ hours to try the DEX
All current binary downloads have a pre-seeded database to avoid the need to reparse everything.  Still requires enabling the transaction index though (please see the instructions included).

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 15, 2014, 11:06:58 PM
Thanks for testing :)  Comments in-line.

Thanks
Zathras

Few issues with Alpha 0.3 on Win7 64-bit:

1. Initial draft .pdf says "NOTE: If you have customized your bitcoin installation (for example by using the --datadir flag to change the location of
your bitcoin configuration and database) you may need to specify your configuration manually. To do so simply change the four values in wallet.cfg
from empty to your chosen bitcoin RPC server configuration" but that is not true, if one is using non-default datadir than a new line must be added
to file in question. Only this one worked for me:

bitcoinrpcserv=localhost
bitcoinrpcport=8332
bitcoinrpcuser=(username_goes_here)
bitcoinrpcpass=(password_goes_here)
datadir=D:\BitcoinData

Omitting any data or line makes Masterchest complain and shutdown or keep on running but doing nothing.

The 'datadir=' line is not read from wallet.cfg anywhere in the code, so I'm not sure how that would be possible.  Likely to be something else you changed at the same time.  FYI, The wallet only talks to bitcoin over RPC (a network communication channel), so where bitcoin itself stores its data on disk is irrelevant.  Auto-detection works by attempting to read %appdata%\bitcoin\bitcoin.conf for the RPC details, failing that it falls back to reading those four entries from wallet.cfg.

2. Once Masterchest is started and starts syncing with blockchain, switching to "debug" tab and clicking on DEBUG LEVEL: LOW changes it to MED
and Masterchest becomes unresponsive including minimizing wallet window. It will start accepting user input only after syncing is fully done. Same
unresponsivness occurs once Masterchest starts to print debug text while on MED or HIGH setting. It is impossible to stop printing, it just goes worse
since user can only switch LOW to MED to HIGH level, not MED to LOW or OFF (which does not even exists).

Ron raised a bug about this as well, but I don't see this behaviour locally.  I'm going to spin up a few VM's to try and replicate behaviour - machine/OS specs would be helpful.  Thanks

3. Taskbar name for Masterchest is Form1

Haha thanks, yes - so it is.  Will correct in next commit.

4. On "currencies" tab amount of coins is wrong, instead of 0.00125 MSC and 4.04268975 BTC it shows I have 125.00 MSC and 404268975.00 BTC

DexX raised this as well - do you usually use a comma instead of a period for decimal notation in your locale?  I've done some work to cultures which has corrected things like the chart etc in these locales, but the currencies tab still doesn't format properly.  I think DexX mentioned the numbers look OK elsewhere and the currencies overview is the only affected view - is that what you're seeing too?

5. Right and bottom sides of main and other windows look wrong, see https://i.imgur.com/7W619QT.png

Ahh - do you by chance have your font size set in (system) display settings above 100%?  If so that's the cause, I'm looking into this also.



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: IamNotSure on March 15, 2014, 11:23:38 PM
I read somewhere that one can download a "reparsed" database to speed up the parsing process. Any link available ?

Don't want to wait 24+ hours to try the DEX
All current binary downloads have a pre-seeded database to avoid the need to reparse everything.  Still requires enabling the transaction index though (please see the instructions included).

Thanks :)
Zathras


Great ! I was worry to overwrite the wallet.sdf file, so I left the old one, that explained how he was still trying to rebuild from scratch.

Many thanks, will test the DEX right now !

edit : in the send tab, drop down menu, the same address is displayed multiple times (everytime an operation is done, it adds a clone to the list)

edit : if I unlock my bitcoin wallet, masterchest still asks for my passphrase (it is independent I guess?)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 16, 2014, 01:25:36 AM
I read somewhere that one can download a "reparsed" database to speed up the parsing process. Any link available ?

Don't want to wait 24+ hours to try the DEX
All current binary downloads have a pre-seeded database to avoid the need to reparse everything.  Still requires enabling the transaction index though (please see the instructions included).

Thanks :)
Zathras


Great ! I was worry to overwrite the wallet.sdf file, so I left the old one, that explained how he was still trying to rebuild from scratch.

Many thanks, will test the DEX right now !

edit : in the send tab, drop down menu, the same address is displayed multiple times (everytime an operation is done, it adds a clone to the list)

edit : if I unlock my bitcoin wallet, masterchest still asks for my passphrase (it is independent I guess?)

OK, great - thanks!

I'll see if I can hunt down the bug that causes the same address to be displayed multiple times - those dropdowns have been modified in a recent change in response to some feedback from Ron (request to add the balance for each address).

Re passphrase - at the moment if you just leave the passphrase empty for an unlocked wallet it should be OK (it'll skip attempting to unlock the wallet if the passphrase is blank).  I do have a line item on my todo list which improves the UX handling of this.  If you're interested basically I can use the 'getinfo' RPC call which includes amid its JSON attribute pairs an attribute called 'unlocked_until'.  I intend to use this call to determine if the wallet is unlocked (and whether it will remain unlocked while we sign and broadcast) prior to throwing up the passphrase request.  TL:DR; it's on the list, just not massively high in terms of priority but should make it into one of the next few alphas no doubt.

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 21, 2014, 12:38:50 AM
Hey guys,

Alpha 0.3C is up.  OP updated.

This update focuses on:
* Major improvements in processing performance - parsing is about the same but my benchmarks show 200%+ improvement in processing - thus makes an up to date client much faster to use
* Hash based chain re-org protection (upgraded from always roll-back 5 blocks to storing hashes for blocks we process DB local and then comparing with bitcoind/qt when we start scanning)
* Some UI improvements, bugfixes

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 21, 2014, 01:27:32 AM
Looks good so far, the processing was indeed much much faster. And the progress bars are awesome!

What still remains is the problem with "," and "." interpretation of balances within the balance overview which shows super high amounts.

And I tested something else what normally shouldn't happen, but this may be handled nevertheless:

I'm using different wallets and I used the MSC wallet with Masterchest, then deleted all Masterchest folders, downloaded the new GitHub version, but changed the wallet.dat inbetween. After starting the new version for some reasons the addresses from the MSC wallet were still shown under addresses, but if I try to send coins, it only shows those from the new wallet. I'm actually a bit surprised, because I deleted also the wallet.sdf etc.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 21, 2014, 01:46:39 AM
Looks good so far, the processing was indeed much much faster. And the progress bars are awesome!
Thanks - have been wanting to get this out (but crazy couple of days as you know!) because I knew there was some low hanging fruit for optimization (+little indexing sprinkled here and there helps a lot!).

What still remains is the problem with "," and "." interpretation of balances within the balance overview which shows super high amounts.
Ah yes, been meaning to simulate that (setting a locale in a VM that has , instead of . so I can replicate myself & test).  Remind me again does it also do that on the currencies panel?

And I tested something else what normally shouldn't happen, but this may be handled nevertheless:

I'm using different wallets and I used the MSC wallet with Masterchest, then deleted all Masterchest folders, downloaded the new GitHub version, but changed the wallet.dat inbetween. After starting the new version for some reasons the addresses from the MSC wallet were still shown under addresses, but if I try to send coins, it only shows those from the new wallet. I'm actually a bit surprised, because I deleted also the wallet.sdf etc.
Hmm, we enumerate addresses via multiple RPC methods (because contrary to the bitcoin-core doco, listaddresses does not return all addresses - for example change) but then we check every one via the validateaddress RPC call, using the ismine:true condition before adding to the address stack.  Could you do me a favour?  In your bitcoin install run the command validateaddress address on one of your MSC addresses while in your other wallet.  I can't see any way that bitcoin would return anything other than ismine:false for that but good to check.

I'm also trying to think of other ways this could occur.

Thanks as always for testing :)
Zathras

P.S.  You can interchange wallet.dat as much as you like (as long as the wallet isn't running of course) - wallet.sdf holds no unique information (otherwise we'd need to encrypt it, back it up etc).  Technically calling Masterchest a wallet is a bit of a misnomer, bitcoind/qt is the wallet, Masterchest just overlays an extra layer of functionality over the top (thus allowing me to conveniently inherit the security of the bitcoin-core wallet :P)

FYI:
Code:
    Public Function getaddresses(ByVal bitcoin_con As bitcoinrpcconnection)
        Dim addresslist As New List(Of btcaddressbal)
        Dim plainaddresslist, myaddresslist As New List(Of String)

        'first use listreceivedbyaddress 0 true to get 'all addresses'
        Dim addresses As rcvaddress = JsonConvert.DeserializeObject(Of rcvaddress)(rpccall(bitcoin_con, "listreceivedbyaddress", 2, 0, True, 0))
        For Each result In addresses.result
            plainaddresslist.Add(result.address.ToString)
        Next
        'since documentation is wrong and this does not list all addresses (eg change), use listunspent to gather up any addresses not returned by listreceivedbyaddress
        Dim listunspent As unspent = JsonConvert.DeserializeObject(Of unspent)(rpccall(bitcoin_con, "listunspent", 2, 0, 999999, 0))
        For Each result In listunspent.result
            If Not plainaddresslist.Contains(result.address.ToString) Then 'avoid duplicates
                plainaddresslist.Add(result.address.ToString)
            End If
        Next
        'list_received_byaaddress also returns addresses transactions have been sent to (???) - run additional ismine check on each address
        For Each address As String In plainaddresslist
            Dim validate As validate = JsonConvert.DeserializeObject(Of validate)(rpccall(bitcoin_con, "validateaddress", 1, address, 0, 0))
            If validate.result.ismine = True Then
                myaddresslist.Add(address)
            End If
        Next
...


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: fordlincoln on March 21, 2014, 04:29:46 AM
So, after about 3 days of sync'ing the wallet I tried to do a send of TMSC. The response was that there's not enough funds in my wallet to cover the tx fee.
I got about 0.0004 BTC in that address.. What is the tx fee set to? 0.001?

There are additional costs beyond just the miners fee (which is set at 0.00011) for funding the outputs for the transaction.  The library currently requires an unspent output >the total fee (~0.00035-0.00040 BTC) in order to send a transaction.

I actually wrote an appendix regarding the cost of Master Protocol messages, you can read it here if you're interested https://github.com/mastercoin-MSC/spec#appendix-e---understanding-the-cost-of-master-protocol-messages (https://github.com/mastercoin-MSC/spec#appendix-e---understanding-the-cost-of-master-protocol-messages)

Thanks :)
Zathras

Zathras - Thanks for pointing this out, as I wasn't sure how the Miners fees were being handled with MSC transactions


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 21, 2014, 07:21:23 PM
After reimporting the other wallet.dat again, I think I was fooled by my own perception. Both share same transactions, thus the impression of a similar transaction history as well as many addresses with tiny balances etc.. ;D

I went through every view and added a bunch of notes, you'll find the part about the floating point delimter there, too: https://i.imgur.com/lffLvCB.png


Edit: found the delimiter problem: DataTables appearingly use their own localization information and overwrite even what was defined on a thread scope. Quickfix: currencylist.Locale = System.Globalization.CultureInfo.InvariantCulture in the module file.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 23, 2014, 08:15:59 PM
After reimporting the other wallet.dat again, I think I was fooled by my own perception. Both share same transactions, thus the impression of a similar transaction history as well as many addresses with tiny balances etc.. ;D

I went through every view and added a bunch of notes, you'll find the part about the floating point delimter there, too: https://i.imgur.com/lffLvCB.png


Edit: found the delimiter problem: DataTables appearingly use their own localization information and overwrite even what was defined on a thread scope. Quickfix: currencylist.Locale = System.Globalization.CultureInfo.InvariantCulture in the module file.

Legend DexX - added.

Thanks
Zathras

EDIT: Notes are extremely useful, thanks :)

On the 'ugly' scrollbars - couldn't agree more however since this is WinForms and not WPF repainting scrollbars is very scrappy/hacky I think - if you have any suggestions here I'm open to them absolutely.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 24, 2014, 02:19:43 AM
Build 0021 is up.

Minor bugfixes and some UI improvements (thanks for all the suggestions!).

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on March 24, 2014, 04:00:47 AM
I love you for the animated sync icon... ;D

And I see you adopted some of my suggestions. Thanks!

A general question: is there a reason that you show TMSC as default in the DEX? Also the balances in the addresses view have the order "BTC", "TMSC", "MSC" - I'd almost say: switch it! MSC is the most important one, BTC the least important one. I think. :)

About the support page: it would be very interesting to see how often it's opened. I read in the main thread that some said "all wallets are not very usable" (I disagree!), so this would be a tool to get some real numbers to falsify this fact.

Maybe this is a crazy idea, but what do you think about some kind of text box on the support landing page and after a user submitted his problem it is forwarded to a newly created mailing list (e.g. support at mastercoin.org). And volunteers could sign up to respond to those support requests? I think Dom is probably the right person who is able to evaluate such an idea?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 24, 2014, 05:39:05 AM
I love you for the animated sync icon... ;D

And I see you adopted some of my suggestions. Thanks!

A general question: is there a reason that you show TMSC as default in the DEX? Also the balances in the addresses view have the order "BTC", "TMSC", "MSC" - I'd almost say: switch it! MSC is the most important one, BTC the least important one. I think. :)

About the support page: it would be very interesting to see how often it's opened. I read in the main thread that some said "all wallets are not very usable" (I disagree!), so this would be a tool to get some real numbers to falsify this fact.

Maybe this is a crazy idea, but what do you think about some kind of text box on the support landing page and after a user submitted his problem it is forwarded to a newly created mailing list (e.g. support at mastercoin.org). And volunteers could sign up to respond to those support requests? I think Dom is probably the right person who is able to evaluate such an idea?

Hehe I wasted about an hour rotating that original sync icon a bunch of times to make an animation but the result was pretty poor - I think the new (properly generated) one looks much better - thanks for the ideas :)

I can change some of the defaults around, I think there is an issue for that already.

I could always grep the logs for the number of times that page is hit if needed sure.

Doing some sort of ticketing is great if a reasonable turnaround can be achieved - the difficulty with things today is people want their answers (now! now! now!) and even say 8 hours which used to be a good customer service turnaround is seen as slow (not that many in the crypto world deliver service even close to same day though!).

I think a decent FAQ needs to be added to that support landing page at minimum though.

EDIT: Perhaps that's expecting a bit much (8 hrs) - this is a very young industry after all - too much time in the day job negotiating SLAs with helpdesk :P


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: instinctIS on March 24, 2014, 11:48:17 PM
Nice app, congrats. However there is this issue that goes with your app but also others on Win8 x64 IE10 , and that is the error 500 which is returned by the bitcoin wallet/server .
As have said, the same behavior goes with any other rpc apps that are connecting via Explorer , and on the other hand all that are connecting via php or made in SciTE are passing just right.

http://seo2url.com/to_delete/500.png

Any ideas on why this happen are welcome, since they will help you + me + others.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on March 25, 2014, 09:55:27 PM
Nice app, congrats. However there is this issue that goes with your app but also others on Win8 x64 IE10 , and that is the error 500 which is returned by the bitcoin wallet/server .
As have said, the same behavior goes with any other rpc apps that are connecting via Explorer , and on the other hand all that are connecting via php or made in SciTE are passing just right.

http://seo2url.com/to_delete/500.png

Any ideas on why this happen are welcome, since they will help you + me + others.

I notice you're running build 0019, try the latest (0021) it has retry capability in the RPC calls if your bitcoin installation doesn't respond on the first try.  It's doubtful this will solve your issue (as it's an internal server error not connection error) but always good to be running the latest build.

Also, could you post the output on the debug panel?  

What antivirus platform are you running?  I've seen a few interfere with comms to RPC.  Any firewalling on the interface for bitcoin RPC? Is bitcoin fairly vanilla - any customization?  There are still some things that Masterchest won't support, for example force using IPv6 instead of IPv4 in bitcoin-core may cause problems (if you don't know what that is then don't worry you won't be using it).

Once we see which step it's up to in the debug panel perhaps I can give you a build with extra debugging at that step to shep some light on what's going on.  We do have users on Win8 x64 (unsure if IE10) using the wallet successfully, so I'm not sure if it's something specific to your local environment.

Thanks :)
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: nuffsaid420 on March 30, 2014, 04:15:27 PM
Hello,

I am working on an outdated Windows XP, not sure if that has anything to do with it. I am getting errors with the Mastercoin wallet syncing. I keep getting errors. I can clear the errors and it seems to keep syncing. It seems to be the same one that instinctIS is getting.
Also I cannot change the DEBUG level from low. When I click on the LOW item it doesnt do anything.

https://i.imgur.com/ocVsMlj.jpg


And the full debug log:

MASTERCHEST WALLET v0.3c
[2014-03-30T08:34:26] DEBUG: Thread 'workthread' starting...
[2014-03-30T08:34:26] STATUS: Connection to bitcoin RPC established & sanity check OK.
[2014-03-30T08:34:26] STATUS: Connection to database established & sanity check OK.
[2014-03-30T08:34:28] STATUS: Database starting at block 292433
[2014-03-30T08:34:28] STATUS: Network is at block 293247
[2014-03-30T08:34:28] STATUS: 815 blocks to catch up
[2014-03-30T08:34:28] DEBUG: Block Analysis for: 292433
[2014-03-30T08:34:35] DEBUG: Block Analysis for: 292434
[2014-03-30T08:37:26] DEBUG: Block Analysis for: 292435
[2014-03-30T08:37:30] DEBUG: Block Analysis for: 292436
[2014-03-30T08:37:31] DEBUG: Block Analysis for: 292437
[2014-03-30T08:40:24] DEBUG: Block Analysis for: 292438
[2014-03-30T08:40:31] DEBUG: Block Analysis for: 292439
[2014-03-30T08:40:42] DEBUG: Block Analysis for: 292440
[2014-03-30T08:40:49] DEBUG: Block Analysis for: 292441
[2014-03-30T08:40:52] DEBUG: Block Analysis for: 292442
[2014-03-30T08:41:05] DEBUG: Block Analysis for: 292443
[2014-03-30T08:41:34] DEBUG: Block Analysis for: 292444
[2014-03-30T08:41:46] DEBUG: Block Analysis for: 292445
[2014-03-30T08:41:58] DEBUG: Block Analysis for: 292446
[2014-03-30T08:42:11] DEBUG: Block Analysis for: 292447
[2014-03-30T08:42:14] DEBUG: Block Analysis for: 292448
[2014-03-30T08:42:23] DEBUG: Block Analysis for: 292449
[2014-03-30T08:42:39] DEBUG: Block Analysis for: 292450
[2014-03-30T08:42:49] DEBUG: Block Analysis for: 292451
[2014-03-30T08:43:03] DEBUG: Block Analysis for: 292452
[2014-03-30T08:43:18] BLOCKSCAN: Found MSC transaction (simple send): b2b1cf6d81a5e6cb5a80426f5ac0c18f6b468a4b8b5c685254499d2d9afc895d
[2014-03-30T08:43:24] DEBUG: Block Analysis for: 292453
[2014-03-30T08:43:31] DEBUG: Block Analysis for: 292454
[2014-03-30T08:43:50] DEBUG: Block Analysis for: 292455
[2014-03-30T08:44:09] DEBUG: Block Analysis for: 292456
[2014-03-30T08:44:19] DEBUG: Block Analysis for: 292457
[2014-03-30T08:56:39] DEBUG: Block Analysis for: 292458
[2014-03-30T08:56:42] DEBUG: Block Analysis for: 292459
[2014-03-30T08:56:44] DEBUG: Block Analysis for: 292460
[2014-03-30T08:56:45] DEBUG: Block Analysis for: 292461
[2014-03-30T08:56:48] DEBUG: Block Analysis for: 292462
[2014-03-30T08:56:50] DEBUG: Block Analysis for: 292463
[2014-03-30T08:57:04] DEBUG: Block Analysis for: 292464
[2014-03-30T08:57:05] DEBUG: Block Analysis for: 292465
[2014-03-30T08:57:18] DEBUG: Block Analysis for: 292466
[2014-03-30T08:57:31] DEBUG: Block Analysis for: 292467
[2014-03-30T08:57:35] DEBUG: Block Analysis for: 292468
[2014-03-30T08:57:38] DEBUG: Block Analysis for: 292469
[2014-03-30T08:57:40] DEBUG: Block Analysis for: 292470
[2014-03-30T08:57:41] BLOCKSCAN: Found MSC transaction (simple send): 8b1a3158b56a38ddb023e2199760654e8e36cd65a1b302628248d865dde96378
[2014-03-30T08:57:42] DEBUG: Block Analysis for: 292471
[2014-03-30T08:57:49] BLOCKSCAN: Found MSC transaction (simple send): 82cf64378f6d15f1f5595961bf76a71fd2358a343e09cb451a81891e848ccb3b
[2014-03-30T08:57:49] BLOCKSCAN: Found MSC transaction (simple send): a4197db8c2c9a2d9b1f9985f6b7a5bd0595a82a2533672c6b276971df1df4c60
[2014-03-30T08:57:53] DEBUG: Block Analysis for: 292472
[2014-03-30T08:57:59] DEBUG: Block Analysis for: 292473
[2014-03-30T08:58:00] DEBUG: Block Analysis for: 292474
[2014-03-30T08:58:12] DEBUG: Block Analysis for: 292475
[2014-03-30T08:58:34] DEBUG: Block Analysis for: 292476
[2014-03-30T08:58:39] DEBUG: Block Analysis for: 292477
[2014-03-30T08:58:40] DEBUG: Block Analysis for: 292478
[2014-03-30T08:58:42] DEBUG: Block Analysis for: 292479
[2014-03-30T08:58:56] DEBUG: Block Analysis for: 292480
[2014-03-30T08:58:57] DEBUG: Block Analysis for: 292481
[2014-03-30T09:08:52] DEBUG: Block Analysis for: 292482
[2014-03-30T09:09:05] DEBUG: Block Analysis for: 292483
[2014-03-30T09:09:18] DEBUG: Block Analysis for: 292484
[2014-03-30T09:09:24] DEBUG: Block Analysis for: 292485
[2014-03-30T09:09:29] DEBUG: Block Analysis for: 292486
[2014-03-30T09:09:54] DEBUG: Block Analysis for: 292487
[2014-03-30T09:09:57] DEBUG: Block Analysis for: 292488
[2014-03-30T09:10:27] DEBUG: Block Analysis for: 292489


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: g0re79 on April 01, 2014, 08:52:51 PM
Same error for me - Exception thrown in bitcoin rpc call: The remote server returned an error Internal Server Error (500). Both Bitcoin Core and Mastercon updated to latest versions, turning off AV and FW did not help, neither did port changing..

Debug log:
Code:
MASTERCHEST WALLET v0.3c
[2014-04-01T22:45:40] DEBUG: Thread 'workthread' starting...
[2014-04-01T22:45:40] STATUS: Connection to bitcoin RPC established & sanity check OK.
[2014-04-01T22:45:40] STATUS: Connection to database established & sanity check OK.
[2014-04-01T22:45:42] STATUS: Database starting at block 292147
[2014-04-01T22:45:42] STATUS: Network is at block 293631
[2014-04-01T22:45:42] STATUS: 1485 blocks to catch up
[2014-04-01T22:45:42] DEBUG: Block Analysis for: 292147

Mastercoin wallet.cfg:
Code:
bitcoinrpcserv=127.0.0.1
bitcoinrpcport=8332
bitcoinrpcuser=myrpcuser
bitcoinrpcpass=myrpcpass

bitcoin.conf
Code:
txindex=1
server=1
rpcport=8332
rpcconnect=127.0.0.1
rpcallowip=127.0.0.1
rpcuser=myrpcuser
rpcpassword=myrpcpass


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on April 02, 2014, 05:31:08 AM
Strange. RPC seems to be working, otherwise the initial check on startup would have failed. And in nuffsaid420's case MSC transactions were recognized which indicates a RPC connection as well as valid transaction fetching and parsing. When and how often does the exception occure? Several hundred times or only from now and then? Are "simple send" transactions the only ones found?

g0re79: does it stop at this point for you? (DEBUG: Block Analysis for: 292147)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: g0re79 on April 02, 2014, 05:38:11 AM
Strange. RPC seems to be working, otherwise the initial check on startup would have failed. And in nuffsaid420's case MSC transactions were recognized which indicates a RPC connection as well as valid transaction fetching and parsing. When and how often does the exception occure? Several hundred times or only from now and then? Are "simple send" transactions the only ones found?

g0re79: does it stop at this point for you? (DEBUG: Block Analysis for: 292147)

Yes, it hanged on block 292147. I wiped out blockchain and now redownloading it again (with -rebuild). I will update this in couple of hours.

EDIT: The only thing that changed is that its now stucked on block 292145 (bitcoin wallet synced)
EDIT: With every new run it hangs with block decreased by 2 (292143 - 292141 - 292139 - 292137...)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on April 03, 2014, 04:15:06 AM
Hi g0re79,

does an error occure between those two blocks each time?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 03, 2014, 04:24:46 AM
Strange. RPC seems to be working, otherwise the initial check on startup would have failed. And in nuffsaid420's case MSC transactions were recognized which indicates a RPC connection as well as valid transaction fetching and parsing. When and how often does the exception occure? Several hundred times or only from now and then? Are "simple send" transactions the only ones found?

g0re79: does it stop at this point for you? (DEBUG: Block Analysis for: 292147)

Yes, it hanged on block 292147. I wiped out blockchain and now redownloading it again (with -rebuild). I will update this in couple of hours.

EDIT: The only thing that changed is that its now stucked on block 292145 (bitcoin wallet synced)
EDIT: With every new run it hangs with block decreased by 2 (292143 - 292141 - 292139 - 292137...)

Hey guys, sorry haven't been around much - head down coding :)

g0re79 can you post the output of 'getinfo' from your bitcoin installation?

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: g0re79 on April 03, 2014, 05:39:18 AM
Strange. RPC seems to be working, otherwise the initial check on startup would have failed. And in nuffsaid420's case MSC transactions were recognized which indicates a RPC connection as well as valid transaction fetching and parsing. When and how often does the exception occure? Several hundred times or only from now and then? Are "simple send" transactions the only ones found?

g0re79: does it stop at this point for you? (DEBUG: Block Analysis for: 292147)

Yes, it hanged on block 292147. I wiped out blockchain and now redownloading it again (with -rebuild). I will update this in couple of hours.

EDIT: The only thing that changed is that its now stucked on block 292145 (bitcoin wallet synced)
EDIT: With every new run it hangs with block decreased by 2 (292143 - 292141 - 292139 - 292137...)

Hey guys, sorry haven't been around much - head down coding :)

g0re79 can you post the output of 'getinfo' from your bitcoin installation?

Thanks
Zathras

Code:
"version" : 90000,
"protocolversion" : 70002,
"walletversion" : 60000,
"balance" : 0.99323521,
"blocks" : 293901,
"timeoffset" : 0,
"connections" : 8,
"proxy" : "",
"difficulty" : 5006860589.20540050,
"testnet" : false,
"keypoololdest" : 1368442926,
"keypoolsize" : 101,
"paytxfee" : 0.00000000,
"errors" : ""

Quote
does an error occure between those two blocks each time?

As I wrote - every time I ran Mastercoin wallet there is same error with block number decreased by 2.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 03, 2014, 06:53:45 AM
Strange. RPC seems to be working, otherwise the initial check on startup would have failed. And in nuffsaid420's case MSC transactions were recognized which indicates a RPC connection as well as valid transaction fetching and parsing. When and how often does the exception occure? Several hundred times or only from now and then? Are "simple send" transactions the only ones found?

g0re79: does it stop at this point for you? (DEBUG: Block Analysis for: 292147)

Yes, it hanged on block 292147. I wiped out blockchain and now redownloading it again (with -rebuild). I will update this in couple of hours.

EDIT: The only thing that changed is that its now stucked on block 292145 (bitcoin wallet synced)
EDIT: With every new run it hangs with block decreased by 2 (292143 - 292141 - 292139 - 292137...)

Hey guys, sorry haven't been around much - head down coding :)

g0re79 can you post the output of 'getinfo' from your bitcoin installation?

Thanks
Zathras

Code:
"version" : 90000,
"protocolversion" : 70002,
"walletversion" : 60000,
"balance" : 0.99323521,
"blocks" : 293901,
"timeoffset" : 0,
"connections" : 8,
"proxy" : "",
"difficulty" : 5006860589.20540050,
"testnet" : false,
"keypoololdest" : 1368442926,
"keypoolsize" : 101,
"paytxfee" : 0.00000000,
"errors" : ""

Quote
does an error occure between those two blocks each time?

As I wrote - every time I ran Mastercoin wallet there is same error with block number decreased by 2.

Thanks for the info.  The next version will have additional debugging in failed RPC calls.  FYI the wallet is disposable - have you tried deleting the entire (Masterchest) wallet folder and pulling the download again?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: g0re79 on April 03, 2014, 05:58:05 PM
Thanks for the info.  The next version will have additional debugging in failed RPC calls.  FYI the wallet is disposable - have you tried deleting the entire (Masterchest) wallet folder and pulling the download again?

Yes I did. Only thing that happened is that "stucked" block has been reseted back to 292151 (and with that 2 block decreasing on every new run).. I would try to install MC on some of my mining rigs, but I donŽt have a free space for blockchain there and running it on VPN doesnŽt seems to be a good idea :-\ So by Mastercoin until next update, IŽll keep an eye on You.

http://i58.tinypic.com/2lo5929.png


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 04, 2014, 12:06:36 AM
OK thanks - just to double check are you fully re-indexed and fully synced (bitcoin wise)?  It looks like it from the screenshot, but bitcoin will throw a 500 if it can't find the transaction or block we're searching for.

The next library build will have some additional information provided when bitcoin returns internal server errors.

For an immediate fix on another topic, J.R. pointed me to a bug with empty history - was fixed in my smart property experimental branch but still buggy in master, so have committed that as an urgent fix.  If you get an exception because it's a fresh wallet or you've never done any Mastercoin transactions, please pull the download again for the fix.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 14, 2014, 12:00:24 AM
Build 0023 is available, please update.  This fixes a critical bug that flags payments for DEx purchases in the block immediately following expiry as valid (incorrectly).

If you would like further explanation please see below.

Binary via Github: Download (https://github.com/zathras-crypto/masterchest-wallet/blob/master/bin/MasterchestWalletAlpha_Bin.zip?raw=true)

Thanks
Zathras

In a Master Protocol distributed exchange transaction the seller decides on a 'payment window' - a length of time (in blocks) for the buyer to make payment after his acceptance has been confirmed in the blockchain.  After this payment window, the acceptance expires.

If for example the seller has specified a time limit of 10 blocks, and the buyer accepts the sell offer in block 300000, the buyer then has until block 300010 to make payment.

A bug in the way Masterchest processes expiration allowed these acceptances to remain pending for the block immediately following expiry in certain circumstances, thus potentially allowing a DEx payment to incorrectly be seen as valid if it was exactly one block late.

This bug was discovered via our consensus systems noting that Masterchest had deviated from the reference this morning (Masterchain.info - unaffected).  Masterchest softwares (wallet and block explorer) incorrectly validated the purchase accepted in https://masterchest.info/lookuptx.aspx?txid=0d2f2f864a51938721a17963aa63925da4cd67ab1072d9ae339c3c0073b1308c. 

This bug has now been corrected and all Masterchest users are strongly encouraged to update their wallet software.





Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: BADecker on April 17, 2014, 01:05:51 AM
I have downloaded the "MasterchestWalletAlpha_Bin.zip" once yesterday, and 3 times today, from the "Windows Wallet" link at http://www.mastercoinwallets.org/. The files extract just fine using either 7-zip or WinZip. But when I try to run the "Masterchest_Wallet.exe" program, my Norton deletes it, and gives me a message that the file contained the "SONAR.Heuristic.120" trojan.

I am still successfully using the "MasterchestWalletAlpha_Bin.zip" that I downloaded mid-March. But I wanted to update it.

Any ideas anyone?

:)

EDIT: Okay, the same thing happens when I download the download zip from github at https://github.com/zathras-crypto/masterchest-wallet.


EDIT: I haven't determined what the problem was, so I bypassed Symantec. We'll see. Mastercoin works just fine.
I ran the computer using a Linux OS off a USB Flash drive. It seems to have deleted the anomaly.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 18, 2014, 11:44:03 PM
I have downloaded the "MasterchestWalletAlpha_Bin.zip" once yesterday, and 3 times today, from the "Windows Wallet" link at http://www.mastercoinwallets.org/. The files extract just fine using either 7-zip or WinZip. But when I try to run the "Masterchest_Wallet.exe" program, my Norton deletes it, and gives me a message that the file contained the "SONAR.Heuristic.120" trojan.

I am still successfully using the "MasterchestWalletAlpha_Bin.zip" that I downloaded mid-March. But I wanted to update it.

Any ideas anyone?

:)

EDIT: Okay, the same thing happens when I download the download zip from github at https://github.com/zathras-crypto/masterchest-wallet.


EDIT: I haven't determined what the problem was, so I bypassed Symantec. We'll see. Mastercoin works just fine.
I ran the computer using a Linux OS off a USB Flash drive. It seems to have deleted the anomaly.

Hey,

I ran this through virustotal and wasn't able to see any issues - I actually recommend putting an exception in for any resident shield or network proxy, as if it proxies all the network requests (RPC) to bitcoind/qt it slows things down by >50%.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 18, 2014, 11:44:55 PM
Hey all,

Please note 0024 is available for download, corrects an issue where accept offers are displayed as expired while payment is pending.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: mishax1 on April 18, 2014, 11:56:32 PM
Here's my experience with 0.3C build 0023..

After sending the payment I get this on the history tab:

https://i.imgur.com/OyFFinI.png

and the sell offer appears on the exchange tab again:

https://i.imgur.com/A96yrEp.png

and after the payment gets confirmed the history tab info changes to this:

https://i.imgur.com/5j2tAlR.png

and the sell order finally disappears from the exchange tab.

That is kinda confusing for a 1st time uesr..  ::)

edit:
just saw this
Hey all,

Please note 0024 is available for download, corrects an issue where accept offers are displayed as expired while payment is pending.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 20, 2014, 01:48:14 AM
Here's my experience with 0.3C build 0023..

After sending the payment I get this on the history tab:

https://i.imgur.com/OyFFinI.png

and the sell offer appears on the exchange tab again:

https://i.imgur.com/A96yrEp.png

and after the payment gets confirmed the history tab info changes to this:

https://i.imgur.com/5j2tAlR.png

and the sell order finally disappears from the exchange tab.

That is kinda confusing for a 1st time uesr..  ::)

edit:
just saw this
Hey all,

Please note 0024 is available for download, corrects an issue where accept offers are displayed as expired while payment is pending.

Thanks
Zathras

Hi, yep sorry about that, the previous fix on expiry was too aggressive and caused pending buys already paid to appear expired (self correcting one the payment was confirmed), that behaviour should now be fixed.

Thanks
Zathras



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on April 20, 2014, 01:48:49 AM
Hey all,

0025 is available for download, corrects an issue where action byte is not enforced for case 0x02 where no previous sell exists (should be invalidated) and applies formula fix for rounding on purchase amounts.

Please update.

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: crazy_rabbit on April 21, 2014, 01:22:22 PM
I'm a little confused at the moment, I'm on the exchange tab, and there are sell orders for "0.00" as well as Unit prices from .0799999998 till 3, yet the charge shows a giant green bar up to .4?



Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: mishax1 on April 21, 2014, 01:25:26 PM
I'm a little confused at the moment, I'm on the exchange tab, and there are sell orders for "0.00" as well as Unit prices from .0799999998 till 3, yet the charge shows a giant green bar up to .4?



Someone bought at 0.37 skipping all other orders - https://masterchest.info/lookuptx.aspx?TXID=46886cdcff50dab670d84788d0fe7fccea21f0a90ab91a5bd910b27c001b5272

And the graphs just jumped up to 0.37.

Hope this will change..


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: crazy_rabbit on April 21, 2014, 01:59:46 PM
I'm a little confused at the moment, I'm on the exchange tab, and there are sell orders for "0.00" as well as Unit prices from .0799999998 till 3, yet the charge shows a giant green bar up to .4?



Someone bought at 0.37 skipping all other orders - https://masterchest.info/lookuptx.aspx?TXID=46886cdcff50dab670d84788d0fe7fccea21f0a90ab91a5bd910b27c001b5272

And the graphs just jumped up to 0.37.

Hope this will change..

I see- I bet that person thought he would purchase everything UP to 0.37, not only at 0.37 skipping the orders. Indeed I hope there is a way to fix that, although perhaps there isn't.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on April 21, 2014, 02:07:55 PM
I see- I bet that person thought he would purchase everything UP to 0.37, not only at 0.37 skipping the orders. Indeed I hope there is a way to fix that, although perhaps there isn't.

I doubt this because you need to accept and pay for specific orders and there is no "buy now at x" mechanism in Masterchest. But it's actually a nice idea.. mask the atomic transactions in the background and simply "buy".

The charting is tricky due to the same reasons. If one wants, he could create a sell order at 0.5 BTC/MSC for 0.0001 MSC and raise the bars after buying this one. I have no idea how the charts could be constructed in a way which is more transparent. Any input regarding this topic is highly appreciated!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: crazy_rabbit on April 21, 2014, 02:12:32 PM
I see- I bet that person thought he would purchase everything UP to 0.37, not only at 0.37 skipping the orders. Indeed I hope there is a way to fix that, although perhaps there isn't.

I doubt this because you need to accept and pay for specific orders and there is no "buy now at x" mechanism in Masterchest. But it's actually a nice idea.. mask the atomic transactions in the background and simply "buy".

The charting is tricky due to the same reasons. If one wants, he could create a sell order at 0.5 BTC/MSC for 0.0001 MSC and raise the bars after buying this one. I have no idea how the charts could be constructed in a way which is more transparent. Any input regarding this topic is highly appreciated!

Yes, in thinking about it- I think it's probably not possible to "buy up till" as that would require substantial logic to calculate. The distributed contracts are more like specific contracts for specific agreements. The charts makes this hard to understand.

Perhaps it would be better to not see charts and instead perhaps see some sort of point graph.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on April 21, 2014, 02:24:05 PM
Perhaps it would be better to not see charts and instead perhaps see some sort of point graph.

You are the best!! ;)

Noted. Thanks for the great idea! This is actually what bitcoin.de was doing earlier which has a similar underlying system: a point graph is used with 3 h and 12 h weighted averages.

https://i.imgur.com/yx1oRLc.png

Looks much nicer with more data points but this should be enough to give an idea.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: BldSwtTrs on April 21, 2014, 04:59:38 PM
Any idea why when I try to install Masterchest I have the following error message:
"There was a problem configuring your connection to bitcoind/qt. Both autodetection and manual configuration appear to have failed.

Will now exit."


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: crazy_rabbit on April 21, 2014, 05:42:18 PM
Any idea why when I try to install Masterchest I have the following error message:
"There was a problem configuring your connection to bitcoind/qt. Both autodetection and manual configuration appear to have failed.

Will now exit."

Recheck your bitcoin-qt setup. Ensure it's running for starters. :-) Then check your config file, and then check that you don't have any firewall preventing the RPC calls. :-)


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: milkyman on April 21, 2014, 10:02:44 PM
Something is wrong with the total BTC amount in the sell book of the dex...

Why are there entries like:

SELL AMOUNT: 0.00000002
UNIT PRICE: 0.0799998
TOTAL: 1.999995

0.00000002 * 0.0799998 = 1.999995 ???

Or do I get something wrong? Thanks


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: mishax1 on April 23, 2014, 03:00:42 PM
Trying to cancel a sell offer at the wallet, says I don't have enough funds (got 0.013BTC in that address).

Did manage to cancel the sell offer using masterchain.info.

What could be the reason ?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: crazy_rabbit on April 23, 2014, 03:35:50 PM
Something is wrong with the total BTC amount in the sell book of the dex...

Why are there entries like:

SELL AMOUNT: 0.00000002
UNIT PRICE: 0.0799998
TOTAL: 1.999995

0.00000002 * 0.0799998 = 1.999995 ???

Or do I get something wrong? Thanks


I see the same- not sure what to make of it.

also- Masterchest online shows my addressses Maidsafe coins, but the wallet on my local machine, does not. Any ideas?


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: milkyman on April 24, 2014, 08:59:26 PM
There seems to be another problem with the wallet:

My actual balance is
7.999 MSC
10 TMSC
0.10268 BTC, see
https://masterchest.info/lookupadd.aspx?address=1CHoqNqBmYgxFX3wuoJYfGw4rVAbeRWPcU (https://masterchest.info/lookupadd.aspx?address=1CHoqNqBmYgxFX3wuoJYfGw4rVAbeRWPcU)

Furthermore, I should have received a few thousand maidsafecoins, see
https://blockchain.info/address/1CHoqNqBmYgxFX3wuoJYfGw4rVAbeRWPcU (https://blockchain.info/address/1CHoqNqBmYgxFX3wuoJYfGw4rVAbeRWPcU)

Instead, the masterchest wallet (version Alpha 0.3C Build 0025) shows:
9.37205714 MSC
11.37305714 TMSC
0.10238 BTC

So, 1.37305714 MSC / TMSC more than I actually own.
What could be the reason for this error? And why are no maidsafecoins displayed?

Thanks!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: rlhead7173 on April 25, 2014, 05:32:38 AM
I have a question regarding how to see my Maidsafe coins. I sent 1 bitcoin from my wallet on my PC, not a web wallet, to the Maidsafe genesis block. I then downloaded the Mastercoin Wallet Alpha 0.3c Build 0025 and followed the instructions on installing it on the same PC as my bitcoin wallet. The Mastercoin wallet is working. I can send and receive both Mastercoins and Test Mastercoins. I can see that I received my Maidsafe coins on the Masterchest.info site. I also can see the fractional payment of bitcoins in my wallet that was used to send the Maidsafe Coins. However, I cannot see any Maidsafe coins in the Mastercoin wallet on my PC. The only coins listed in my Mastercoin wallet on my PC are Mastercoin, Test Mastercoin, and Bitcoin. Is the downloadable wallet capable of showing Maidsafe coins or must we use a web wallet? 


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: dexX7 on April 26, 2014, 10:15:47 AM
The Masterchest Windows wallet does not yet support other tokens than Mastercoin and Test Mastercoin, but will likely very soon.


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: rlhead7173 on April 26, 2014, 12:54:55 PM
The Masterchest Windows wallet does not yet support other tokens than Mastercoin and Test Mastercoin, but will likely very soon.

Thanks for the information!


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on May 12, 2014, 01:33:38 AM
Hey guys,

0.4 is up.  This includes SP support (display & send).

I'd like to take a moment to remind everyone that this is experimental alpha testing software and all use is at your own risk - please remember this if you're considering using it with anything other than small testing amounts.

Also, while I have you :)

0.4 will be the last Masterchest release of the wallet.  As of now the project is being handed over to the foundation and they will own the development and direction of future desktop wallet development.  Since I know the tendency for people to interpret differently is very prevalent in the Crypto space, I'd like to make a few things very clear :) as follows:

* I am not stopping development, nor am I stepping down in my role as RBB Developer for the foundation
* 0.4 is the last "Masterchest" release, but that does not mean last release period.  The foundation will of course be continuing the development of wallet software - perhaps my .NET wallet, perhaps something else.  Desktop wallet direction is a hotly discussed topic at the moment, but one thing we all agree on is a need for a consolidated direction - moving the wallet project to the foundation is a logical step in pursuit of this
* I will be continuing work on other Masterchest projects, most notably the Masterchest.info block explorer will continue to be actively developed
* I will be contributing to a consolidated wallet development effort, though not leading it, regardless of the direction chosen for development

With those points out the way (I would hate for this to be construed as negative), I just wanted to add a personal note; this project was launched as an idea, but an idea that needed software to turn it into something tangible and Masterchest was a rapid prototype to bridge that gap.  It's been a wonderful (if tiring!) journey but as we grow and evolve into something more mature, more organized and more focused the 'one-man-band' approach that is Zathras & Masterchest is of course not a long term scalable prospect (or good for the project) - but I'm extremely proud to have helped the project along in my own little way & look forward to contributing to a consolidated & shared development effort as we charge ever further ahead! :)

Download (https://raw.githubusercontent.com/zathras-crypto/masterchest-wallet/master/bin/MasterchestWalletAlpha_Bin.zip)

Thanks
Zathras


Title: Re: Masterchest Wallet Alpha Testing Thread
Post by: zathras on May 20, 2014, 08:41:09 AM
Hey all,

I'm going to close this topic now in line with the foundations' desire to have forum communication over at mastercointalk.org... See you over there! :)

Thanks
Zathras