Bitcoin Forum

Bitcoin => Development & Technical Discussion => Topic started by: Coding Enthusiast on March 23, 2020, 08:38:16 AM



Title: Isn't "Only non-push operators allowed in signatures" error message wrong?
Post by: Coding Enthusiast on March 23, 2020, 08:38:16 AM
It seems like it should be either "Only push operations allowed..." or "Non-push operations aren't allowed...".

Ref: https://github.com/bitcoin/bitcoin/blob/57a8fa9c3b4452ef7a9d9ed4b957b3888f542fb0/src/script/script_error.cpp#L61

Update: issue #18411 (https://github.com/bitcoin/bitcoin/issues/18411) and PR #18412 (https://github.com/bitcoin/bitcoin/pull/18412)


Title: Re: Isn't "Only non-push operators allowed in signatures" error message wrong?
Post by: darosior on March 23, 2020, 09:38:31 AM
Indeed.

This line hasn't been modified since 2014 (https://github.com/bitcoin/bitcoin/commit/ab9edbd6b6eb3efbca11f16fa467c3c0ef905708).
Would be a great first contribution I guess  :)