Bitcoin Forum

Other => Meta => Topic started by: Herbert on April 01, 2012, 09:39:56 AM



Title: [SOLVED] support bitcoin-URIs
Post by: Herbert on April 01, 2012, 09:39:56 AM
Just tried to add a bitcoin-uri to my signature, but no luck. Board keeps adding "http://"-prefix as it does not recognize the bitcoin-uri.

What i want to do:
Code:
[url=bitcoin:12AxBpvmqzYbSHmvZML6Xv9TPncJgdnikm?label=Herbert]12AxBpvmqzYbSHmvZML6Xv9TPncJgdnikm[/url]

What gets stored:
Code:
[url=http://bitcoin:12AxBpvmqzYbSHmvZML6Xv9TPncJgdnikm?label=Herbert]12AxBpvmqzYbSHmvZML6Xv9TPncJgdnikm[/url]

I have no idea if this can be added easily or not...


Title: Re: support bitcoin-URIs
Post by: ThomasV on April 01, 2012, 09:46:10 AM
luke-jr wrote a patch for that: https://bitcointalk.org/index.php?topic=14947.0

unfortunately, the forum admins never cared to install it


Title: Re: support bitcoin-URIs
Post by: Herbert on April 01, 2012, 06:17:17 PM
 :'(
@Mods: Any chance to get this integrated? It's kinda shame that our forum doesn't support our own standards...


Title: Re: support bitcoin-URIs
Post by: ThomasV on April 01, 2012, 06:18:28 PM
:'(
@Mods: Any chance to get this integrated? It's kinda shame that our forum doesn't support our own standards...


I think it all depends on theymos


Title: Re: support bitcoin-URIs
Post by: Red Emerald on April 01, 2012, 06:20:01 PM
I'll make sure my forum software can do this.  I didn't think about non-HTTP links.


Title: Re: support bitcoin-URIs
Post by: theymos on April 01, 2012, 08:12:29 PM
Like I said in that thread, someone needs to thoroughly test the modifications.

I think I see a bug in Luke-Jr's patch, actually. This regex doesn't have a closing ~:
Code:
'~\b([1-9A-HJ-NP-Za-km-z]{26,35})\b'


Title: Re: support bitcoin-URIs
Post by: ThomasV on April 01, 2012, 08:30:50 PM
Like I said in that thread, someone needs to thoroughly test the modifications.

I think I see a bug in Luke-Jr's patch, actually. This regex doesn't have a closing ~:
Code:
'~\b([1-9A-HJ-NP-Za-km-z]{26,35})\b'

theymos, I believe that you are the most capable of testing and fixing this patch.
in addition, I think that it is not a complex patch, but a fairly simple one.
the question is, do you want to do it?



Title: Re: support bitcoin-URIs
Post by: theymos on April 01, 2012, 08:48:48 PM
I don't have a test forum set up and I don't care enough about it to set one up for this.


Title: Re: support bitcoin-URIs
Post by: theymos on April 04, 2012, 05:36:37 AM
OK, they're allowed now. Plain addresses won't be auto-converted to links, and I modified Luke-Jr's regex to be less greedy about converting bitcoin: text to links.


Title: Re: support bitcoin-URIs
Post by: ThomasV on April 04, 2012, 05:49:40 AM
OK, they're allowed now. Plain addresses won't be auto-converted to links, and I modified Luke-Jr's regex to be less greedy about converting bitcoin: text to links.

cool, thanks!
test: bitcoin:1DRtJjBzR59Vg76mJ4vU1d1Gji9zNK4PT9 (bitcoin:1DRtJjBzR59Vg76mJ4vU1d1Gji9zNK4PT9)


Title: Re: support bitcoin-URIs
Post by: Herbert on April 04, 2012, 09:21:38 AM
Great!

Thanks theymos  ;D


Title: Re: [SOLVED] support bitcoin-URIs
Post by: rjk on April 04, 2012, 02:22:50 PM
Sweet. Now I wonder if there is some way I can make Firefox interpret that URI as a blockexplorer link. Hmm...


Title: Re: [SOLVED] support bitcoin-URIs
Post by: Red Emerald on April 04, 2012, 06:36:22 PM
Sweet. Now I wonder if there is some way I can make Firefox interpret that URI as a blockexplorer link. Hmm...
I'm sure greasemonkey can.  Of course, greasemonkey could have done it even without the forum being modified.