FWIW, this issue has been assigned CVE-2012-1910
That's a great step, it would be even better to link the advisory. One I found by that number was for JavaRE and the other for Bind DNS :-/. Dia This thread is the advisory...
|
|
|
How do you pay for this if you have no fees? You don't include transactions in your blocks so you don't get any transactions fees. Even if you did, they wouldn't pay for the server you must need. What is your motivation? World Peace? Where did you read he doesn't include transactions? Also, there is still a 50BTC block subsidy. Luke-jr does have lower variance by having people mine with him, but theres plenty of pools that are run for the benefit of Bitcoin over profit. If you look at recent blocks found by Eligius http://blockchain.info/blocks/Eligius every block only contains the one generation transaction. Those aren't found by Eligius, it's just blockchain.info screwing up. See http://eligius.st/~artefact2/blocks/ for our real blocks.
|
|
|
FWIW, this issue has been assigned CVE-2012-1909
|
|
|
FWIW, this issue has been assigned CVE-2012-1910
|
|
|
a) provide p2pool users some control Hey, don't forget BitPenny and Eligius miners! Now is there a guide anywhere for compiling modified version of bitcoind under windows? If you want, I could trivially build a Windows binary. I won't bill for the time spent by the compiler, of course :p ".01 BTC" is not a reasonable fee, period. Here's why. Your argument seems to be based entirely on trying to profit from usury. Usury is evil, so IMO your argument can be ignored.
|
|
|
Looks good to me. Thanks for the prompt response. If this is complete, where would you like me to send a refund (if you want one) of your advance? Let me know if you would prefer to wait for testing and merging to mainline (which might require more time, depending on the reactions of other developers). Polvos, you also offered to contribute toward the bounty; if you feel the desire to tip me, you can use 1DGzpZzce1c7nsg1SN7exV6bsaju1Mcrc6 - it's fine with me if you choose not to, though. I've submitted an upstream pull request. Miners who want this feature should express their support on this thread, and developers with comments can do so on the pull request itself.
|
|
|
on line 64 (main.cpp) I would change this to 1024. It will be much easier to understand if miners announce pricing either as flat value or per KB (i.e. "0.01 BTC per KB"). bitcoind has always priced transactions per 1000 bytes (SI kB). I can certainly change it, but I don't think upstream will accept it that way. on line 5222 (init.cpp) if (nMinFeeBase / nMinFeePer > 0.00025 * COIN
Since this is for warning on excessively high fees I would increase the threshold. The current threshold ~0.1 US cents even if BTC value increased significantly it would still be sub 1 US cent. I would increase the warning point to 1 bitcent. (> 0.01). While 1 bitcent may be "high" it is likely an intentional value. Someone misunderstanding the concept or units (thinking they are satoshis, fractional BTC or %) would likely put a much higher value and still be warned. The warning limit here is 0.00025 BTC per byte, or 0.25 BTC per 1000 bytes. Surely that is sufficiently high? one line 592-602 of main.h Not sure what is happening here (this bounty gives me more excuse to look into bitcoind sourcecode). My first thought is we are comparing the bitcoind "spam" min fee to the user defined fee? The spam fee depends on coinage though and the processing fee shouldn't. Likely I am misunderstanding so feel free to school me. If the "spam fee" is higher than the user-defined fee, the spam fee is left alone. Otherwise, the user fee overrides it.
|
|
|
FWIW, BitVPS.com is offering Eligius miners 20% off with coupon code 'ELIGIUS'
|
|
|
Just sort of a relevant comment while you're on about this, but what about making fees proportional to the amount being sent? ie charging 0.1% as a fee rather than a nominal BTC amount. You could just use a higher % for extra small tx.
The main reason I would suggest doing it that way is since the trade value of BTC fluctuates so much it may be impractical on the user end to deal with fees set in nominal terms, whereas %s scale automatically and are simple to understand.
It's not possible to determine how much is being sent, and most of the transfers you would want to "tax" more are inversely proportional to that amount anyway. I intend to make it such that you can set it per-N-bytes, though.
|
|
|
One thing I thought of is it would be useful to have a getminfee to complement setminfee. Probably sufficient to just add it to the getmininginfo results?
|
|
|
20 BTC advanced and balance due upon completion sound ok? Sure. 1FXGUecLqVPdqGUR5qEpLt9QUjGg5P1k2K Just to clarify this min fee would be in addition to any spam rules. So bitcoind should do its normal spam checks and then exclude any tx (i.e setting min fee to 0.001 should still result in spam tx without min spam fee from being excluded). I could see some people setting the min fee to 1E-8 to exclude only free tx and I don't want the min fee rule to accidentally compromise any spam prevention. So if vanilla bitcoind would charge 0.0005 BTC for a fee, you want to charge 0.0005 BTC + "min fee" for the same? Or just the greater of the two? One thing I did think of is making bitcoind smarter to detect dependencies and including tx chains but that likely will need to wait for a future bounty. What I mean is I send 20 BTC from A to B (you) but I include no fee. You get tired of waiting so you make a tx based on the unconfirmed A->B as an input sending it to C with a fee. If the bitcoind was "smart" enough someday it could detect that B-> C depends on A->B and include both even if A->B is under the min fee (as long as B->C is over min fee). Yeah, I've wanted this kind of functionality for a while, but I haven't been able to justify spending the time to figure out the algorithms it would need.
|
|
|
Danger of buffer overflow, (if there is a bug in the to hex code). Virtually no real-life performance gain. 6% performance gain, to be specific. Tonal support, tonal is base 16 numbers with strange characters for the numbers higher than 9. Problem: nobody cares about tonal other than Luke. Or from others' perspective, nobody cares about Bitcoin other than Luke.
|
|
|
next-test is a branch of the mainline bitcoind & Bitcoin-Qt with as many pull requests merged as possible, to aid in testing them. This branch can be used to test many pull requests in your daily Bitcoin use. The goal is to help pull requests get the testing they need to be merged into the main tree, so once you test a change, please comment in the relevant pull request (ideally with details). Please note these might possibly corrupt your wallet. No warranty of any kind of provided. BACKUP YOUR WALLETAlso note this is the first next-test that excludes my Coinbaser enhancement. Click here for details. It is also the first next-test to include coderrr's coin control features. Today's next-test includes the following pull requests (green are merged now; red are disputed):
|
|
|
Actually, bitcoind already excludes transactions that don't meet the hard-coded fee rules. I'd be glad to write the simple JSON-RPC method to configure it for only 8 BTC/hr*. I expect it would take at most 4 hours, probably less.
* 8 BTC/hr rate assumes I publish it under the MIT license. I don't care who holds the copyright itself.
|
|
|
Give me a good reason and you can have a bunch free...
|
|
|
Is this affecting Bitcoin version 0.3.21?
Not this, but 0.3.* are not maintained and have several security and other bugs. Upgrade to at least 0.4.4.
|
|
|
I just spent coins from a generate and was charged a fee. The generate was for .6793514 and since 120 confirmations were required before they could be spent, and since I was trying ot send exactly .6793514, I expected to be able to send the transaction for free. Instead, a fee of .0005 was required and I had to spend .6788514 instead to afford the fee. I know that ultimately fees will be necessary to support mining, but I believe right now fees are only required for transactions that fall outside of a certain scope. My expectation did involve some assumption, but was based on this (from FAQ): Why is there a minimum payout? This feature was added to help miners avoid transaction fees. Just out of curiosity, was the minimum payout's intent to be able to spend without a fee (in which case maybe it is currently too low, whether it was when implemented or not) or just to minimize fees (100 .00678851 inputs would have presumably required a larger fee)? The intent is to avoid 1000x .001 BTC inputs for a 1 BTC payment. Odd that you were charged a fee like that; I wonder why.
|
|
|
|