I added the functionality, and submitted a pull request:
https://github.com/sassame/bitcoin/tree/estimatetxfeeGavin, I understand your concern, but when thinking about the use case (specifically, checking
during a transfer if there's enough bitcoin), there's probably a pretty low chance of the estimate changing. I would still like to see the ability to add a "max tx fee" to the send rpc calls, which would address when the tx fee goes up after estimate. But, this is better than nothing.
As a side note, this is the first C++ I've written in 5 years, I profusely apologize for it sucking. I realize instantiating a transaction that you know is going to be destroyed is wasteful, but I didn't feel comfortable enough with the source to refactor the fee calculation code (since I'd end up touching many of the most important functions). Do I need to do anything to dispose of the transaction?