Show Posts
|
Pages: [1]
|
I will try to clean this up a little more based on your comments, then after this can try to keep my commits more granular. This changeset became too unwieldy as it got bigger.
|
|
|
The reindent tool also deleted some continuation lines at the end of files, so I restored them.
Would like to help where I can. I'll let you know what I'm thinking after I've spent some more time using the dev branch build.
|
|
|
Looks like the reindent tool has some problems. Will send whitespaces fix patch. Will respond to your other comments after.
|
|
|
Ok. I am not using an IDE but ran the reindent tool from pypi, which only allows indent with 4 spaces for some reason.
Fixed them and am sending you a new patch.
|
|
|
I just sent the patch to the email address you use in git.
|
|
|
I'd like to to create a PR of the work I've done, but I don't have an adequately anonymous github account and they've made it very difficult to create one.
Could I email you a patchset?
|
|
|
Ok. So what about CppBlockUtils.py, which no longer exists? There are a few calls into that module in dialog code (e.g. MultiSigDialogs.py calling CryptoECDSA()). Looks like the plan is to add boilerplate to CppBridge.py for each method like this.
Anyway so far I have been separating the dialogs and forms out incrementally, keeping the code in a runnable state as I make changes where possible, and not changing logic having to do with CppBridge code. But the calls to missing modules, where I'm not quite sure how to resolve them, are making it hard for me to proceed this way.
|
|
|
Hi,
I built the latest dev branch and was able to successfully get the Armory UI running. It looks like the code is in the middle of migration to PySide2, and some of the menus are disconnected.
Most dialogs were originally implemented in one place (qtdialogs/qtdialogs.py, and some in qtdialogs/qtdefines.py), and some of these have been pulled out into their own modules. I successfully untangled a few more of them and got them to work properly in the UI, and then got stuck on ui/toolsDialogs.py. This imports from a module called jasvet.py, which was removed from the git repo in January. This module has some cryptographic functions and calls CppBlockUtils to get a random number using Crypto++ library.
What was the plan when this jasvet.py module was removed? Aside from that, am I on the right track in trying to untangle these PySide2 dialogs?
|
|
|
|