Cannot build AUR armory-goatpig-git

[firstman]

In building the armory-goatpig-git package (via pacaur and makepkg), it fails to build:

Code:

libtool: compile:  g++ -std=c++11 -DHAVE_CONFIG_H -I. -I.. -D_FORTIFY_SOURCE=2 -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -O2 -std=c++11 -Ilmdb -Icryptopp -I/usr/include/python2.7 -D__STDC_LIMIT_MACROS -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -O2 -MT libCppBlockUtils_la-Wallets.lo -MD -MP -MF .deps/libCppBlockUtils_la-Wallets.Tpo -c Wallets.cpp -o libCppBlockUtils_la-Wallets.o >/dev/null 2>&1             
mv -f .deps/libCppBlockUtils_la-EncryptionUtils.Tpo .deps/libCppBlockUtils_la-EncryptionUtils.Plo                
mv -f .deps/libCppBlockUtils_la-SwigClient.Tpo .deps/libCppBlockUtils_la-SwigClient.Plo                          
mv -f .deps/ArmoryDB-BDM_Server.Tpo .deps/ArmoryDB-BDM_Server.Po                                                 
mv -f .deps/ArmoryDB-BDM_supportClasses.Tpo .deps/ArmoryDB-BDM_supportClasses.Po                                 
mv -f .deps/libCppBlockUtils_la-WalletManager.Tpo .deps/libCppBlockUtils_la-WalletManager.Plo                    
mv -f .deps/libCppBlockUtils_la-Script.Tpo .deps/libCppBlockUtils_la-Script.Plo                                  
mv -f .deps/libCppBlockUtils_la-Wallets.Tpo .deps/libCppBlockUtils_la-Wallets.Plo                                
make[3]: Leaving directory '/home/firstman/Downloads/armory-goatpig-git/src/armory/cppForSwig'                    
make[2]: *** [Makefile:1445: all-recursive] Error 1     
make[2]: Leaving directory '/home/firstman/Downloads/armory-goatpig-git/src/armory/cppForSwig'                    
make[1]: *** [Makefile:429: all-recursive] Error 1      
make[1]: Leaving directory '/home/firstman/Downloads/armory-goatpig-git/src/armory'                               
make: *** [Makefile:361: all] Error 2                   
==> ERROR: A failure occurred in build().               
    Aborting...  

happens with clang and gcc. arch system updated.

[goatpig]

Did you init the git submodules?

[UncleHunto]

Greetings, maintainer of the "armory-goatpig-git" package here, it is no longer building for me either, I will look into it and see if I can figure out what the problem is. Any suggestions or advice is welcome. 

[UncleHunto]

I haven't been able to figure this one out. The init of the git submodules is done by the aur package. It might be because Arch distros use a newer version of gcc, I'm running Manjaro, which uses gcc 7.1.1. I have tried building it with gcc 4.9 and 4.7 but could not get that to work either, and the moment I am at a loss in regards to how to fix it.

EDIT: Also tried gcc 5.4, which i couldn't get to work either.

[firstman]

I attempted to manually build it (after initing the submodules) and it didn't build with the same issue. Something with the arch environment, but I don't have the technical know-how to figure it out. Thanks Uncle for taking a look.

[UncleHunto]

No worries, I'd like to fix it, if anyone can figure out what the problem is  here are some error messages I get (when building with gcc 7.1.1) which might be helpful:

make[3]: *** [Makefile:863: libCppBlockUtils_la-TransactionBatch.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
TxClasses.h:481: Warning 472: Overloaded method UTXO::UTXO() with no explicit typecheck typemap for arg 4 of type 'BinaryData'
TxClasses.h:481: Warning 472: Overloaded method UTXO::UTXO() with no explicit typecheck typemap for arg 5 of type 'BinaryData'
TxClasses.h:547: Warning 472: Overloaded method AddressBookEntry::AddressBookEntry(BinaryData) with no explicit typecheck typemap for arg 0 of type 'BinaryData'
WalletManager.h:497: Warning 473: Returning a pointer or reference in a director method is not recommended.
WalletManager.h:498: Warning 473: Returning a pointer or reference in a director method is not recommended.
make[3]: Leaving directory '/home/uncle/AURpackages/AUR/armory-goatpig-git/src/armory/cppForSwig'
make[2]: *** [Makefile:1445: all-recursive] Error 1
make[2]: Leaving directory '/home/uncle/AURpackages/AUR/armory-goatpig-git/src/armory/cppForSwig'
make[1]: *** [Makefile:429: all-recursive] Error 1
make[1]: Leaving directory '/home/uncle/AURpackages/AUR/armory-goatpig-git/src/armory'
make: *** [Makefile:361: all] Error 2

[UncleHunto]

Another thing I thought of, which might be causing the problem, is that Arch uses python 3 by default, whereas Armory and most other programs and OS's use python 2 by default, but the setup of the AUR package was working for 0.96 up until now.

[goatpig]

These are warnings not errors. Post the entire make output on pastebin for me to look at.

[UncleHunto]

The make output was too large for pastebin, so I put it on my github page:

https://raw.githubusercontent.com/UncleHunto/logs/master/armorymakelog.txt

[goatpig]

This is basically saying it can't build std::function

Create a .cpp and test the lib against that. File would look something like this:

Code:

...
#include <functional>

int main(void)
{
   std::function<int(void)> aFunc = [](void)->int
   {
      return 1;
   };

   aFunc();
   return 0;
}

[UncleHunto]

This is basically saying it can't build std::function

Create a .cpp and test the lib against that.

So forgive my C++ ignorance, I have created the .cpp file, now how would I go about using that to test the lib against?

[goatpig]

It's gonna be nearly impossible to debug this if you don't have any C++ in you sorry.

[firstman]

Uncle, a fix will be pushed that adds #include <functional> to cppForSwig/TransactionBatch.h, which fixes the build issue. Python 2 is also required I discovered, but your AUR package already passes PYTHON_VERSION=2.7, so that's ok. However, you must add qt5-libtools as a dependency, as it fails to build without it (otherwise you get a lrelease: command not found).

[goatpig]

Armory uses qt4, therefor qt5's lrelease may or may not get Armory to choke on the language packs. Ideally, it should run qt4's lrelease.

I'll add the missing include (no idea why this is breaking compilation, as it has not been an issue so far). I'll also add a check for lrelease in the executable path.

[UncleHunto]

Thank you, firstman and goatpig, for your help on this one! It is much appreciated! <thumbs up>

[firstman]

When will the fix to TransactionBatch.h be committed?

I am now getting a new build issue:

make log: http://sprunge.us/KZWA and configure: http://sprunge.us/HIXN

[goatpig]

It's been there for a while now.