I've done a lot of work in this space
Same. (see:
https://simplexum.com), but it is not focused solely on coin selection, so probably you've done more work in this direction.
This seems like a reasonable approach for consumer wallets to use, but I don't think it's going to scale very far.
What would prevent this from scaling ?
the more utxo's you have the easier it is.
Yes, but if you have too much small utxo, and you need to send large payment at inconvenient time (when fee is high) - you will pay a premium, as delaying payment is often not an option. Also you might hit transaction size limitations, and will need to send several transactions to satisfy one payment.
Holding both fair amount of big utxo and a lot of small utxo in hot wallet might mean your hot wallet balance is higher than necessary, and your risks are also higher.
If it takes a week to confirm, it's not a big deal.
But this means you are freezing this funds for a week, and need to get funds for operation from somewhere else, like your cold wallet.
Also, big sweeping transaction is more visible.