Bitcoin Forum
May 12, 2024, 05:38:51 PM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1] 2 3 »  All
  Print  
Author Topic: [BOUNTY] Armory Bugs: 0.1 BTC each (Disabled: Coming back soon!)  (Read 7626 times)
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 23, 2012, 05:13:33 PM
Last edit: May 10, 2013, 08:35:42 PM by etotheipi
 #1

There is a bounty of 0.1 BTC per new bug found in Armory 0.86.3-beta, up to a maximum of 3 BTC.  This test drive ends on Jan 1, 2013.  (at my discretion, I may pay more than 0.1 BTC, depending on the scope/impact/subtleness of the bug)

Armory doesn't have enough testers.  And the current testers are mostly Armory veterans that have been using it for a while and not doing new-user operations like creating new wallets, printing their one-time backups, etc.  So I'm hoping that this post will get some fresh eyes on the app, and also give current testers some incentive to really try to break things.

So, I'm going to test bug bounties for a short period of time, to see what kind of response I get.  I may extend it in the future, if it turns out to be an efficient way to get testers and find bugs without too much dispute.  And I do expect some dispute, but I'm going to try to be lenient about it.  That's also why I've set an upper limit of 3 BTC, to limit the impact of this going terribly wrong...

What qualifies as a "bug" is anything that impacts usability: I don't really want to give out bounties for grammatical improvements or missing punctuation in dialogs.  Though maybe some would argue that I should.    What I'm really looking for is things like checkboxes that should be disabled but aren't when using a watching-only wallet, selection dialogs with zero things to choose from, buttons that do nothing when clicked, etc.  And obviously crashes, too.  

Here's a list of well-known bugs that don't count, because I already know about them and there's nothing I can do at the moment:
  • (1) Armory uses a lot of RAM
  • (2) Loading Armory before Bitcoin-Qt is sync'd causes rapid connect-disconnect flickering
  • (3) Lack of unicode support (coming soon, actually, just not in 0.86.3).
  • (4) Windows systems always detect memory pool corruption and delete it.
  • (5) Anything to do with the message-signing dialog -- it's queued to be revamped soon to be more useful (and match Bitcoin-Qt)
  • (6) *.deb package is of "bad quality" according to newer versions of Ubuntu
  • (7) Armory sometimes crashes after 0.5-6 days (it's not a memory leak, for sure)
  • (8 ) Paper backup printing doesn't work in OSX.  Please copy the data by hand or copy to another program where printing does work.
  • (9) System tray icon does not disappear when Armory is closed (Windows only).
  • (10) Unclickable link in version-check window

Here's what you need to do to collect the bounty:
  • (1) Be the first to post about a particular bug for the current testing version
  • (2) If you don't include a payment address in your post, I will assume that I should send the 0.1 BTC to donation address in your signature
  • (3) Either post relevant portions of the log file, or send me the log via email or PM (File-->Export Log File)
  • (4) Have some patience -- I need to figure out the best way to run this operation.  Also, I will send out payments in batches.  If 4 people find 3 bugs each, I'll be sending out one tx paying 0.3 BTC to all four people at the end of the day or the next morning (you can request sooner if you're super anxious for some reason).

If you're interested please download the absolute latest: Armory 0.86.3-beta.  It's not a testing version, but there won't be another testing version for a while, and I'm sure there's still plenty of bugs to be found here.

UPDATE:  Also, I've decided that anything in the testing branch is fair game.  That is probably more bug-dense, but this little bounty drive will encourage me to do more internal testing before merging anything into that branch Smiley   (for 0.86.5-testing, I compiled and posted Windows-testing versions above).



Bugs reported (and thus, don't expect a bounty if you just found it):
(1) UAC/admin needed even for local installation of Armory on Windows.  
(2) Wallets with P2Pool payouts crash Armory!  (reported here).
(3) Missing string replacement on dashboard when user is missing blk*.dat files.

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
1715535531
Hero Member
*
Offline Offline

Posts: 1715535531

View Profile Personal Message (Offline)

Ignore
1715535531
Reply with quote  #2

1715535531
Report to moderator
1715535531
Hero Member
*
Offline Offline

Posts: 1715535531

View Profile Personal Message (Offline)

Ignore
1715535531
Reply with quote  #2

1715535531
Report to moderator
1715535531
Hero Member
*
Offline Offline

Posts: 1715535531

View Profile Personal Message (Offline)

Ignore
1715535531
Reply with quote  #2

1715535531
Report to moderator
You get merit points when someone likes your post enough to give you some. And for every 2 merit points you receive, you can send 1 merit point to someone else!
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
1715535531
Hero Member
*
Offline Offline

Posts: 1715535531

View Profile Personal Message (Offline)

Ignore
1715535531
Reply with quote  #2

1715535531
Report to moderator
1715535531
Hero Member
*
Offline Offline

Posts: 1715535531

View Profile Personal Message (Offline)

Ignore
1715535531
Reply with quote  #2

1715535531
Report to moderator
1715535531
Hero Member
*
Offline Offline

Posts: 1715535531

View Profile Personal Message (Offline)

Ignore
1715535531
Reply with quote  #2

1715535531
Report to moderator
flatfly
Legendary
*
Offline Offline

Activity: 1078
Merit: 1016

760930


View Profile
December 23, 2012, 08:59:41 PM
 #2

Nice initiative!

Not sure if this can be called a bug, but the Armory installer refuses to proceed on a non-admin user account (on Windows.)  Could this possibly be changed, or are there good reasons for that? The Bitcoin-Qt installer happily proceeds on a standard account, by the way.
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 23, 2012, 11:15:29 PM
 #3

Nice initiative!

Not sure if this can be called a bug, but the Armory installer refuses to proceed on a non-admin user account (on Windows.)  Could this possibly be changed, or are there good reasons for that? The Bitcoin-Qt installer happily proceeds on a standard account, by the way.

I assume you tried to install it in a non-admin-required directory?  Even the "bitcoin:" URL-registration should happen at the user-level, so I'm not sure what would require admin privileges.  I just tried installing it in a non-admin directory and I got a UAC dialog asking if I want to allow this program from the internet to make changes to my hard drive.  Is that an Admin-required dialog?  I even have unchecked the box in my .msi builder that says "Must be admin to install"... hmmm.  I wonder if it's something to do with code-signing?

Admittedly, I'd prefer users to install it via admin, so it's slightly harder for someone to manipulate the installed files -- but maybe that's pointless with all the root exploits in Windows.  Users should have the option to install it as non-admins...

I'll add you to the list of 0.1 BTC recipients Smiley

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
flatfly
Legendary
*
Offline Offline

Activity: 1078
Merit: 1016

760930


View Profile
December 24, 2012, 09:08:23 AM
Last edit: December 24, 2012, 11:59:52 AM by flatfly
 #4

Nice initiative!

Not sure if this can be called a bug, but the Armory installer refuses to proceed on a non-admin user account (on Windows.)  Could this possibly be changed, or are there good reasons for that? The Bitcoin-Qt installer happily proceeds on a standard account, by the way.

I assume you tried to install it in a non-admin-required directory?  Even the "bitcoin:" URL-registration should happen at the user-level, so I'm not sure what would require admin privileges.  I just tried installing it in a non-admin directory and I got a UAC dialog asking if I want to allow this program from the internet to make changes to my hard drive.  Is that an Admin-required dialog?  I even have unchecked the box in my .msi builder that says "Must be admin to install"... hmmm.  I wonder if it's something to do with code-signing?

Admittedly, I'd prefer users to install it via admin, so it's slightly harder for someone to manipulate the installed files -- but maybe that's pointless with all the root exploits in Windows.  Users should have the option to install it as non-admins...

I'll add you to the list of 0.1 BTC recipients Smiley

Thanks!

Yes, I do try to install it to a non-admin directory. The attached screenshot, while not very detailed, might provide some clues as to what exactly is causing the installation to abort. Notice how it refers to "all users"...



EDIT: After further analysis, I am 99% confident this happens because the installer tries to create the desktop and start menu shortcuts for ALL existing profiles, not just the current one.

I've played around with the GUI for the first time, and I must say I'm quite impressed by the overall quality and level of attention to detail. Great job!
flatfly
Legendary
*
Offline Offline

Activity: 1078
Merit: 1016

760930


View Profile
December 24, 2012, 12:31:06 PM
 #5

Another small one: if Bitcoin-Qt is not running, or not up-to-date, Armory
correctly detects that it is in "offline mode", but the Send Bitcoins
button does show the normal Send dialog.

Isn't it supposed to show the below message instead, as it does when started
through the "Armory (Offline)" shortcut?

Armory is currently running in offline mode, and has no ability to determine balances or create transactions.   In order to send coins from this wallet you must use a full copy of this wallet from an online computer, or initiate an "offline transaction" using a watching-only wallet on an online computer.
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 24, 2012, 06:12:56 PM
 #6

Another small one: if Bitcoin-Qt is not running, or not up-to-date, Armory
correctly detects that it is in "offline mode", but the Send Bitcoins
button does show the normal Send dialog.

Isn't it supposed to show the below message instead, as it does when started
through the "Armory (Offline)" shortcut?

Armory is currently running in offline mode, and has no ability to determine balances or create transactions.   In order to send coins from this wallet you must use a full copy of this wallet from an online computer, or initiate an "offline transaction" using a watching-only wallet on an online computer.

Thanks flatfly.  There is a box that says "Install for Current User Only" which is checked... but perhaps my MSI creator doesn't do that correctly.  Maybe there's a way to force the correct behavior.

The "offline" thing is one of these strange situations... that message is expected to occur for users who are actually on an offline computer, and won't show up if they are on an online computer that isn't finished scanning.  If the user explicitly puts Armory into offline mode but could be online... I don't know what message to display to match their use case.  I would guess that's the correct message...?   I'll think about that.  Either way,  I added your name to my spreadsheet again Smiley

I'm glad you like the app -- I was thinking this might be good marketing for Armory, in addition to getting people to help test it.  If you keep digging through it, maybe you can vacuum up all the bounties for yourself Smiley  (and I hope you can see why I can't test this myself... there's an extraordinary number of options, actions, and states that Armory can be in for each of those). 

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
techmix
Newbie
*
Offline Offline

Activity: 15
Merit: 0



View Profile
December 25, 2012, 11:46:06 AM
Last edit: December 25, 2012, 12:54:22 PM by techmix
 #7

I wanted to import some of my private keys, I found out that you cant import keys in hex with upper case characters.
I get this error:
http://i.minus.com/iZMKGeDQwlcbo.png

When I import it in lower case it works fine Smiley
my test was under ubuntu 64bit

EDIT: I found the problem in the source code. I made a pull request here: https://github.com/etotheipi/BitcoinArmory/pull/36
flatfly
Legendary
*
Offline Offline

Activity: 1078
Merit: 1016

760930


View Profile
December 25, 2012, 03:39:37 PM
 #8

Another small one: if Bitcoin-Qt is not running, or not up-to-date, Armory
correctly detects that it is in "offline mode", but the Send Bitcoins
button does show the normal Send dialog.

Isn't it supposed to show the below message instead, as it does when started
through the "Armory (Offline)" shortcut?

Armory is currently running in offline mode, and has no ability to determine balances or create transactions.   In order to send coins from this wallet you must use a full copy of this wallet from an online computer, or initiate an "offline transaction" using a watching-only wallet on an online computer.

Thanks flatfly.  There is a box that says "Install for Current User Only" which is checked... but perhaps my MSI creator doesn't do that correctly.  Maybe there's a way to force the correct behavior.

The "offline" thing is one of these strange situations... that message is expected to occur for users who are actually on an offline computer, and won't show up if they are on an online computer that isn't finished scanning.  If the user explicitly puts Armory into offline mode but could be online... I don't know what message to display to match their use case.  I would guess that's the correct message...?   I'll think about that.  Either way,  I added your name to my spreadsheet again Smiley

I'm glad you like the app -- I was thinking this might be good marketing for Armory, in addition to getting people to help test it.  If you keep digging through it, maybe you can vacuum up all the bounties for yourself Smiley  (and I hope you can see why I can't test this myself... there's an extraordinary number of options, actions, and states that Armory can be in for each of those). 

Smiley No, I think i will let others grab some bounties as well! Actually, I don't have a working bitcoin-qt + full blockchain, so there's a lot of functionality I can't even test right now.
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 25, 2012, 06:11:33 PM
 #9

When I import it in lower case it works fine Smiley
my test was under ubuntu 64bit

EDIT: I found the problem in the source code. I made a pull request here: https://github.com/etotheipi/BitcoinArmory/pull/36

Nice catch!  The hex conversion normally takes uppercase chars, but my little char-counting method doesn't.  I added 1ioQoMa7v2YLGtrqznQhrafvrJdeDBN3c for 0.1 to my list Smiley

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 28, 2012, 04:02:02 PM
 #10

Restart the bounty!  Finally chased down the P2Pool issue (actually in 0.86.4) and it appears I fixed the problems with bitcoind/-qt 0.8+.   Not only that, but I got lucky and ran into a bug that only occurs when multiple blocks are received during blockchain scanning. 

Armory 0.86.5-testing for Win64
Armory 0.86.5-testing for Win64 and Win32

Any bug I claim to have fixed but isn't fixed, counts for the bounty.  That means that there's almost guaranteed to be a bug related to bitcoind 0.8+ that I haven't caught.  Let's find them!

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
Red Emerald
Hero Member
*****
Offline Offline

Activity: 742
Merit: 500



View Profile WWW
December 28, 2012, 10:21:51 PM
 #11

I've posted this elsewhere, but figured this was a good place to put it, too.

If you are on OSX and want to try out the testing branch, you can use the latest update to my brew tap.

https://bitcointalk.org/index.php?topic=133097

Code:
brew install --devel armory-qt

etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 28, 2012, 10:31:37 PM
 #12

I'll just post stuff I consider a bug and let you decide if it really is or not. It is easier for me that way. Machine I'm using runs WinXP SP3 + 2GB RAM.

<img>


Yes, that counts!  If it's a blatant programming error, or data is missing from a dialog, etc, that definitely counts.  I only offer 0.1 BTC because I expect lots of little things like this -- which I really do want to find, but there could be lots of them, so I want to avoid going broke over them.


2. Armory icon stays in tray after normal shutdown. User must mouseover icon to remove it from there.

<img>

This is a bug I've known about for a very long time.  And I've tried, multiple times to fix it.   But nothing I do works!  (I actually have code in Armory to try to hide the icon just before it closes... not sure why that doesn't work, actually).   You still deserve 0.1 BTC for it, and I will add it to the list of bugs-I-already-know-about.

Post, PM or email me a BTC address and I'll send you 0.2 BTC in the near future.  I can send it right away, but it sounds like you'll be finding more stuff in the near future Smiley


Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
Marker88
Member
**
Offline Offline

Activity: 118
Merit: 10



View Profile
December 28, 2012, 10:49:52 PM
 #13

When importing my wallet, you have it to detect ".wallet" files, I think for newer users it would be more helpful for it to include ".dat" types, since the main Bitcoin client uses wallet.dat. Just a thought. Ubuntu 64 Bit

Bitbook.biz - The best odds and quickest transactions of any BTC sportsbook
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 28, 2012, 10:55:13 PM
 #14

3. When clicking on Help icon left to Close Window icon (top right window corner), mouse pointer turns to "Unavailable" shape instead
of "Help Select" shape. I can't reproduce it in screenshot since screen capture software I use just turns any pointer into normal shape.
Hovering over any (?) area in Armory still shows tooltip with text, though.
<img>

You know -- never once in my entire life have I ever clicked on one of those Windows help buttons.  And now that I do, I think it's behavior is correct -- whatever you expect it to do:  it's unavailable.  I don't even know how to override that behavior if I wanted to. 

When importing my wallet, you have it to detect ".wallet" files, I think for newer users it would be more helpful for it to include ".dat" types, since the main Bitcoin client uses wallet.dat. Just a thought. Ubuntu 64 Bit

Bitcoin-Qt wallet files are not compatible with Armory.  So, I actually do not want users to be able to select Bitcoin-Qt wallet files.   When the new wallet files are complete, I'll bring back the "Bitcoin-Qt Wallet Migration" feature, and then there will be a separate dialog for that.  Until then, it would be a bug if it did let you select a .dat file Smiley

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
flatfly
Legendary
*
Offline Offline

Activity: 1078
Merit: 1016

760930


View Profile
December 28, 2012, 11:54:53 PM
Last edit: December 29, 2012, 12:05:31 AM by flatfly
 #15

Do we also get rewarded if we provide fixes for those bugs?  
That might encourage me to spend some time playing around with some of them...  Grin
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 29, 2012, 12:05:00 AM
 #16

4. After selecting Tools > Message Signing, window appears where "Keys" tab is selected. Absolute hmmm-moment for new user.
Another option on tools menu, EC Calculator, shows same window but "Eliptic Curve" tab is selected instead. Point here is to just
use same names for menu items and tabs, else, unless user is Bitcoin expert, it's not straightforward obvious what is shown.

See (5) in original post:  I said that anything to do with message signing or EC calc is already known -- they are not exactly broken, but they are buggy.  That whole thing will be revamped in the near future (when I sync my signing algorithm with Bitcoin-Qt).


5. After creating new wallet in offline mode, I double-clicked on it and than selected "Import/Sweep Private Keys". Once window
was shown, one of options was greyed-out. Not sure if it should be that way.

<img>

Yes and no.  The option should be grayed out, but it should also say "Only available when online".  It does say that if Armory is currently scanning the blockchain, but I guess I missed the trigger when you're in offline mode.  I'll give you that one Smiley

The reason it's grayed out is because "Sweeping" requires being connected to the network in order to broadcast the sweep transaction (moving all the coins from one address to another).  This can't be done in offline offline.  OTOH, importing is simply saving the key to your wallet file, which does not require an internet connection.

6. On window shown in previous post, once user selects "Multiple Keys", no warning message will be shown after clicking on OK
unless there are at least 2 lines of data entered. On all other windows I spotted by now, clicking on OK or Accept without some
data being entered results in some warning message.

I must give you this one, too.  Even though there's no real user impact, there is an error thrown under-the-hood, and it deserves being fixed. 

7. After selecting menu Help > Revert All Settings > Yes, Armory will reset the state of License Agreement as well as other
settings. Is that intentional or not?

That's intentional.  It is essentially a "factory reset".



@ subSTRATA:  I do appreciate all these little bugs.  This is actually exactly what I was looking for, for 0.1 BTC each.  But please collect them internally and post them in batches of 5 or something.  I'm starting to feel spammed by the constant notifications.  Also, please PM me a receiving address so I can send you the bounties (I won't send it yet, but I need to add it to my spreadsheet).



Do we also get rewarded if we provide fixes for those bugs?   Grin
That might encourage me to spend some time playing around with some of them...

This is a little fuzzier... I want to encourage people to get involved, but I also don't want to pay people for helping fix bugs that I can take care of on my own in less than 5 minutes.  If you plan to try to fix a bug and want a bounty for it, please PM or email me first.  If it looks like it will save me time, I will happily pay a bounty for it.

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
OpenYourEyes
Full Member
***
Offline Offline

Activity: 238
Merit: 100



View Profile
December 29, 2012, 12:27:35 AM
 #17

I'm normally good at spotting bugs, but I've yet to find any in this version. I'll check out the testing version later to see if I can discover anything.

Also, not a bug per-se so not expecting a bounty payment, but you have two spelling mistakes on the get-armory web page (http://bitcoinarmory.com/index.php/get-armory)

incorrect: arithmatic - correct: arithmetic
incorrect: resistent - correct: resistant

There's a few grammar mistakes also, but I suppose they are open to interpretation.

takemybitcoins.com: Spend a few seconds entering a merchants email address to encourage them to accept Bitcoin
PGP key | Bitmessage: BM-GuCA7CkQ8ojXSFGrREpMDuWgv495FUX7
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 29, 2012, 03:42:46 PM
 #18

Just to point out about older Armory version still being linked in starting post. You should update link with one posted here so
that eventual bug hunters who don't check whole thread first don't unneccessarily download and work on outdated version.

I need both versions tested.  The stable version is perhaps more important for finding bugs, since a significant bug there will require a re-release.  The testing version is expected to have some bugs, and is updated more easily.  I added a link in that first post at the bottom (yesterday) that the "testing" version is now fair-game.  Bugs reported in either one are valid, but not repeatable (if the same bug is in both, I will only give the bounty for the first report).



@OpenYourEyes -- I'll toss you 0.1 for that.  Those are both errors that have been there for a while, and on a high-traffic page.  For grammer, send it to me via PM if you think it's warranted.  But I'm not going to really focus on the webpage too much, since it's constantly under construction.



@subSTRATA:  Okay, so now onto your plethora of reports.  This is where it gets fuzzy, because I can't give out 36 bounties for closely-related bugs.  And also, some of these are very minor or due to a misunderstanding about the software.  I have to use my judgment here, and say that anything that is exceptionally minor, but still warrants changing something in the code is worth half the bounty.  Also, things that are more of a "clarification needed" than a bug will get half a bounty.

(Each star* is a half-bounty)
(8*)  It sounds like you have never run bitcoin-qt on this particular computer?  Or it's in a non-standard location?  Armory most definitely detects when Bitcoin-Qt is started later, but if it's never been started, ever, it can't re-check for blkfiles.  Thus it only hits this condition when Bitcoin-Qt has never been started before.  Please tell me if this does not match your experience.  *But I have to give this to you, because it does warrant adding "...you may have to restart Armory" to catch this condition.
(9)  This is not an Armory bug as much as a PyQt bug.  And it's not something I can fix.
(10*)  That's actually a very intelligent dialog, which gives you only the options available for your current state (the button text and enabled/unabled changes depending on what wallets you have and your online/offline state).  Since you are offline, there is no way to create new transactions (hence disabled top button).  Additionally, if you were online, the bottom button would say "Sign or Broadcast Transaction".  If you actually have an offline/cold wallet, this makes more sense.  I will modify the text slightly.
(11**)  This is pretty much as-planned, except for the ability to save an empty transaction.  I'll modify it.  (either transaction type can be saved here, depending on whether what is in the box is signed or unsigned).
(12*)  Meh.  It's an OS-specific behavior that is sub-optimal.  But I'm not quite sure how to fix it, nor do I know how to fix it.  I'll give a 0.1 bounty for someone who does figure out how to fix it (it's Windows-only).
(13)  That was an explicit decision due to space constraints.  In expert usermode there is just no space to add those buttons, and the user can still escape with the X or by hitting ESC.
(14***)   I'll count this as 4 half bugs:  The red box should be reset after the error goes away.  The Send-Bitcoins window should not even be accessible in offline mode (it is disabled in when scanning, but apparently not when simply offline).  The -0.00000001 spendable balance obviously is in error.  The "Create Unsigned Tx" button should be disabled in offline mode.
(15)  This was intentional as the truncated version is all that is needed given the space constraints.
(16*)  I suppose the address list could use a refresh here...
(17)  "Empty" and "Unused" can only be evaluated when you are online.  Armory doesn't know whether the addresses are empty or unused.
(18*)  A clarification window may be warranted, but the overall behavior is as-intended.
(19)  Does Notepad++ show links?  It definitely creates links for me when I copy it into a word processor or email.
(20**)  Okay, that's a real bug!  I'll look into that
(21**)  More-intelligent warning is warranted.
(22)  Not all wallets have passwords.  Wallet file could be deleted from the user's app directory without the password.  I chose to use 31 consecutive warning dialogs instead.  That's by design (especially if someone is deleting the wallet because they forgot their password)
(23)  Wallet name standardization is a good idea, but Armory was designed not to care.  And the user rarely ever sees the filename or cares... as long as the word "watch" is in there.  In my own testing, I don't see any behavior warranting code modification.

I count an extra 14 half-bounties here, for 0.7 BTC in addition to your 0.4 yesterday.  If you dispute anything in particular please do so over PM or email and I'll update this post.  I don't want to spam this list anymore.  This is a lot of tiny things, but all of them together do add up to non-negligible polishing improvement.

This concludes 1.6 BTC worth of bounties.  I've got 1.4 more, and I hope we'll find some higher-level bugs, too (although 20 was a good bug that might distract me for a bit...)


Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 29, 2012, 03:56:40 PM
 #19

(Cool Of course I have Bitcoin-Qt on computer, you could see that in log file attached to my first post. Client is installed in default
location, but data directory is on D: partition and I haven't yet come to part where I need to instruct Armory where to look for Bitcoin
datadir. Points with report is that Armory does detect if Bitcoin-Qt is running or not but only if Bitcoin-Qt is started before Armory, even
when it can't find data in default directory.

I think your first screenshot is pretty clear about how to point Armory towards your blockfiles: run Armory with the " --satoshi-datadir=" option.

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
etotheipi (OP)
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
December 29, 2012, 07:46:06 PM
 #20

(11) "(either transaction type can be saved here, depending on whether what is in the box is signed or unsigned)." Hmm, with file extension
filter showing and allowing both signed.tx and unsigned.tx at all times, does it really matter what is in the box? I mean, will I be prevented
from saving signed transaction in file test.unsigned.tx? If not, will Armory inform me I'm about to overwrite unsigned transaction with signed one?
(13) Even in Expert mode, there is enough room for "Cancel" button next to "Send" one - at least on my side.
(15) There quite a lot of space on right from truncated address - at least on my side.
(19) Notepad++ shows links, highlights syntax and so much more.

As said in PM, I do not expect everything I posted to be accepted as bug. It is just so much easier for me to report anything and everything
I find not working, unusual and unexpected, and throw-in some suggestions - or even complaints - in the mix. If you think something does not
pass the "Is it a bug or not?" test, it is fine with me, really. But OK, from now on, I'll avoid posting non-critical stuff.

Don't read my response as a "don't do it" instruction.  I actually appreciate the level of detail.  But if I'm going to reject or reduce a bounty, I feel it deserves justification (i.e.- responding to each one).   As long as you keep batching them up like that, I'm fine with the tiny things, as long as you're fine that I'm not rewarding every one.

(11) The user may want to see what other transactions they have in the folder, signed or unsigned, while deciding on a filename.  Although, the filename is auto-filled if there is useful data in the box, so there's not really a problem with overwriting.
(13,15) There's room at the default window size.  But these windows also need fit nicely when size-reduced on, say, netbooks.  I've gotten a lot of complaints about compactness, so I pick and choose what I think is important.  I was just pointing out that (13) and (15) were explicit decisions to save space.  That's all.
(19) Admittedly, I couldn't get the "Click to copy to clipboard" button to work right.  I have lots of examples copying plain text to clipboard, but not HTML.  Perhaps this would behave a little more consistently if I do that.

A new 0.3 BTC bounty: figure out how to get native HTML objects into the clipboard in PyQt.  You don't need to add the button to the application, I just need a code snippet that doesn't result in plain text on the clipboard. I'm pretty sure QMimeData has something to do with it.   This could be a super-easy 0.3 BTC!  (I've tried before and failed, and don't feel like figuring it out right now...)


Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
Pages: [1] 2 3 »  All
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!