Bitcoin Forum
December 08, 2016, 04:35:09 AM *
News: To be able to use the next phase of the beta forum software, please ensure that your email address is correct/functional.
 
   Home   Help Search Donate Login Register  
Pages: « 1 2 3 4 5 6 7 8 9 10 [11] 12 13 »  All
  Print  
Author Topic: [20 BTC] Multithreaded Keep-alive Implementation in Bitcoind  (Read 29386 times)
Inaba
Legendary
*
Offline Offline

Activity: 1260



View Profile WWW
July 19, 2011, 11:55:07 AM
 #201

3151 XXX      20   0  389m 167m 7556 S    8  1.4  20:04.13 bitcoind

That's about 16 hours of running, so looks good to me.

If you're searching these lines for a point, you've probably missed it.  There was never anything there in the first place.
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1481171709
Hero Member
*
Offline Offline

Posts: 1481171709

View Profile Personal Message (Offline)

Ignore
1481171709
Reply with quote  #2

1481171709
Report to moderator
1481171709
Hero Member
*
Offline Offline

Posts: 1481171709

View Profile Personal Message (Offline)

Ignore
1481171709
Reply with quote  #2

1481171709
Report to moderator
JoelKatz
Legendary
*
Offline Offline

Activity: 1386


Democracy is vulnerable to a 51% attack.


View Profile WWW
July 19, 2011, 04:24:34 PM
 #202

Thanks guys.

I am an employee of Ripple.
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
phorensic
Hero Member
*****
Offline Offline

Activity: 630



View Profile
July 19, 2011, 06:04:51 PM
 #203

Is everything stable, yet?  Time to freeze the code?  Release Candidate #1?  No new features planned?  I really want to run this code on my pool and it sounds like you have hit a milestone.
Matt Corallo
Hero Member
*****
Offline Offline

Activity: 751


View Profile
July 19, 2011, 06:11:48 PM
 #204

Is everything stable, yet?  Time to freeze the code?  Release Candidate #1?  No new features planned?  I really want to run this code on my pool and it sounds like you have hit a milestone.
And then pull request it so it can get a more thorough look-through and get merged upstream.

Bitcoin Ubuntu PPA maintainer - donate to me personally: 1JBMattRztKDF2KRS3vhjJXA7h47NEsn2c
http://bitcoinrelaynetwork.org maintainer
PGP ID: 07DF 3E57 A548 CCFB 7530  7091 89BB B866 3E2E65CE
Inaba
Legendary
*
Offline Offline

Activity: 1260



View Profile WWW
July 19, 2011, 06:13:13 PM
 #205

I think there's still the getwork skeleton issue to work out, but other than that it's a big improvement.

I'm not sure if the changes to hub mode have made it into the diff yet, as well?

As far as a pull request, it's unlikely it will be mainstreamed due to some of the features/changes are not good for clients.  Though maybe I misunderstood that part?  I'd be happy to see it in the mainstream code.

If you're searching these lines for a point, you've probably missed it.  There was never anything there in the first place.
Matt Corallo
Hero Member
*****
Offline Offline

Activity: 751


View Profile
July 19, 2011, 06:15:27 PM
 #206

As far as a pull request, it's unlikely it will be mainstreamed due to some of the features/changes are not good for clients.  Though maybe I misunderstood that part?  I'd be happy to see it in the mainstream code.
Well yes, hub mode probably won't get implemented as its really a hack to get it to work with the current network segmentation, but most, if not all, of the various code optimizations and RPC multithreading/asio/etc absolutely can and will eventually get merged upstream.

Bitcoin Ubuntu PPA maintainer - donate to me personally: 1JBMattRztKDF2KRS3vhjJXA7h47NEsn2c
http://bitcoinrelaynetwork.org maintainer
PGP ID: 07DF 3E57 A548 CCFB 7530  7091 89BB B866 3E2E65CE
JoelKatz
Legendary
*
Offline Offline

Activity: 1386


Democracy is vulnerable to a 51% attack.


View Profile WWW
July 19, 2011, 06:22:57 PM
 #207

The less ugly optimizations and straight bug fixes should certainly be merge candidates. The hub mode patches and uglier optimizations are not sensible merge candidates.

Obvious merge candidates would be:

1) strRPCUser/strRPCPass variables to avoid extracting them on each RPC call.

2) Native long polling support.

3) ToHex replacing HexStr.

4) Faster Base64 decoder.

5) Leak fix in pthreads version of CreateThread.

Also, some version of the RPC/keepalive fix needs to be merged but it doesn't have to be my version.

I am an employee of Ripple.
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
error
Hero Member
*****
Offline Offline

Activity: 574



View Profile
July 19, 2011, 10:25:37 PM
 #208

Please send pull requests for these!

15UFyv6kfWgq83Pp3yhXPr8rknv9m6581W
phorensic
Hero Member
*****
Offline Offline

Activity: 630



View Profile
July 20, 2011, 12:50:53 AM
 #209

As far as a pull request, it's unlikely it will be mainstreamed due to some of the features/changes are not good for clients.  Though maybe I misunderstood that part?  I'd be happy to see it in the mainstream code.
I agree with you.  This is a pool oriented fork and Jay Garzik will probably take a couple seconds to look at the code and then close the pull request.
JoelKatz
Legendary
*
Offline Offline

Activity: 1386


Democracy is vulnerable to a 51% attack.


View Profile WWW
July 20, 2011, 02:22:48 AM
 #210

I agree with you.  This is a pool oriented fork and Jay Garzik will probably take a couple seconds to look at the code and then close the pull request.
I think the five things I specifically mentioned would be accepted. The long polling support is really the only maybe.

I am an employee of Ripple.
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
simplecoin
Sr. Member
****
Offline Offline

Activity: 406



View Profile WWW
July 20, 2011, 02:13:53 PM
 #211

Is there a unified patch ready that is stable, or better yet working repo? I've been running the last stable 3diff against .23 I saw weeks ago.

Donations: 1VjGJHPtLodwCFBDWsHJMdEhqRcRKdBQk
Furyan
Full Member
***
Offline Offline

Activity: 175



View Profile
July 20, 2011, 05:16:08 PM
 #212

Is there a unified patch ready that is stable, or better yet working repo? I've been running the last stable 3diff against .23 I saw weeks ago.

I have 4diff running stably against 0.3.24.
Inaba
Legendary
*
Offline Offline

Activity: 1260



View Profile WWW
July 20, 2011, 05:43:00 PM
 #213

As do I

If you're searching these lines for a point, you've probably missed it.  There was never anything there in the first place.
backburn
Member
**
Offline Offline

Activity: 112


★Trash&Burn [TBC/TXB]★


View Profile
July 20, 2011, 08:29:45 PM
 #214

3.24 4-diff is running stable for over 24 hrs. Solved several blocks @ 175 GHash

Code:
 PID USER      PR  NI  VIRT  RES  SHR S %CPU %MEM    TIME+  COMMAND                                                    
22895 tacos    20   0  466m 260m 6800 S    4  3.3  52:03.41 bitcoind-24prev

TeraPool
Jr. Member
*
Offline Offline

Activity: 42


View Profile
July 20, 2011, 09:39:22 PM
 #215

Can somebody please spoon feed me the process as to how to patch the source code with JoelKatz' diff .txt file?

I know how to compile bitcoind, but am a noob when it comes to patching things :S

JoelKatz
Legendary
*
Offline Offline

Activity: 1386


Democracy is vulnerable to a 51% attack.


View Profile WWW
July 20, 2011, 10:01:00 PM
 #216

Can somebody please spoon feed me the process as to how to patch the source code with JoelKatz' diff .txt file?

I know how to compile bitcoind, but am a noob when it comes to patching things :S
Go to the 'src' directory, and then:

1) If you don't have the diff already, use this command:
wget http://davids.webmaster.com/~davids/bitcoin-4diff.txt

2) To patch it:
patch -p1 < bitcoin-4diff.txt

If you did it correctly, the output should be this:
patching file init.cpp
patching file main.cpp
patching file net.cpp
patching file net.h
patching file rpc.cpp
patching file util.cpp
patching file util.h


Update: Sorry about the typo in the URL.

I am an employee of Ripple.
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
phorensic
Hero Member
*****
Offline Offline

Activity: 630



View Profile
July 21, 2011, 06:00:49 AM
 #217

Testing bitcoind v0.3.24 + Joel Katz v0.98 4diff on our pool.  Going very well so far.
TeraPool
Jr. Member
*
Offline Offline

Activity: 42


View Profile
July 21, 2011, 11:02:25 PM
 #218

Can somebody please spoon feed me the process as to how to patch the source code with JoelKatz' diff .txt file?

I know how to compile bitcoind, but am a noob when it comes to patching things :S
Go to the 'src' directory, and then:

1) If you don't have the diff already, use this command:
wget http://davids.webmaster.com/~davids/bitcoin-4diff.txt

2) To patch it:
patch -p1 < bitcoin-4diff.txt

If you did it correctly, the output should be this:
patching file init.cpp
patching file main.cpp
patching file net.cpp
patching file net.h
patching file rpc.cpp
patching file util.cpp
patching file util.h


Update: Sorry about the typo in the URL.


THANK YOU!

P.S. My hand has been forced to make a donation!

Just sent 1 to your payb.tc address. Thanks again.

AnnihilaT
Full Member
***
Offline Offline

Activity: 196



View Profile
July 27, 2011, 02:10:36 PM
 #219

Testing bitcoind v0.3.24 + Joel Katz v0.99 4diff on our pool now.... so far so good in the last 15 mins...

Does anyone know the difd from 0.98 and 0.99 ?  couldnt find a copy of the older version anywhere.
Inaba
Legendary
*
Offline Offline

Activity: 1260



View Profile WWW
July 27, 2011, 02:24:57 PM
 #220

Why would you want the older version?

Anyway ... I think there might be a small memory leak somewhere still.  My bitcoind is up to almost 700m at this point and I'm getting some connection errors occasionally, though that may be due to some other issues not related to bitcoind.

If you're searching these lines for a point, you've probably missed it.  There was never anything there in the first place.
Pages: « 1 2 3 4 5 6 7 8 9 10 [11] 12 13 »  All
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!