Armory 0.96.5 RC2

[goatpig]

Fixed all the stuff reported for RC1, this should be the final RC for this version.

Changes

Code:

   - Break backwards compatibility for unsigned transactions carrying bech32 outputs. 
     Older versions cannot make sense of bech32 addresses, therefor they shouldn't 
     be able to sign the tx at all.

   - Properly detect output script type when filtering UTXOs.
   - Use relevant config files with testnet/regtest modes.
   - Properly display bech32 address strings in transaction system tray notification.
   - Fix signing transactions with OP_RETURN outputs.
   - Fix passing satoshi-port argument through ArmoryQt to auto-managed ArmoryDB.

   - Use blockstream.info instead of blockchain.info as the external block explorer link.

Binaries

https://github.com/goatpig/BitcoinArmory/releases/tag/v0.96.4.991

RC1 thread

https://bitcointalk.org/index.php?topic=5071932.0

[Ratatosk]

Thank you very much for your huge and excellent work.

I still think you should include a Donate button in the front user interface, so that anyboby can send you some Satoshi or more to thank you for your efforts, one or more time, when happy to use Armory...

Best regards

[Carlton Banks]

Compiling now...

[bobulus]

Compiled and ran from source. Preliminary testing looks good.

One issue I ran into in conjunction with the JSON-RPC script, is receiving from a bech32 address cause the getledger api call to fail. I saw this issue in RC1 as well. To reproduce:

1. Receive from a Bech32 address. Verify that the Armory Qt UI looks good.
2. Run the JSON-RPC server and use the following call:

Code:

> curl http://hi:there@localhost:18225 -d '{"method":"getledger","params":["abc123"]}'
[{"Error Value": "invalid char in b58 string", "Error Type": "RuntimeError", "Error": "An error occurred in getledger"}]

In the logs:

Code:

Traceback (most recent call last):
  File "/usr/local/lib/armory/armoryengine/Decorators.py", line 79, in inner
    rv = func(*args, **kwargs)
  File "/usr/local/lib/armory/armoryd.py", line 1365, in jsonrpc_getledger
    if ledgerWlt.hasScrAddr(recipScrAddr):
  File "/usr/local/lib/armory/CppBlockUtils.py", line 4139, in hasScrAddr
    return _CppBlockUtils.WalletContainer_hasScrAddr(self, scrAddr)
RuntimeError: invalid char in b58 string

I'm willing to attempt a fix myself, but would appreciate any guidance, thanks.

[goatpig]

armoryd is a separate repo, I'll look into that after this release.

[bobulus]

Thanks, I was able to hack a workaround in armoryd.py, by checking if the sender's address is bech32 (i.e. starts with bt or tb), and skipping the call to ledgerWlt.hasScrAddr(). Basically I'm just assuming all bech32 addresses are change addresses through that code path.

I tried to understand what was going on within the Armory source, but got lost between the C++ and Python/swig code.