Exploring Electrum source code forks *not forks of BTC

[sdp]

I was wondering if there are any people other than myself who like to hack Electrum but they have not been able to get their pull requests accepted and have decided to just use a fork for themselves.  I find it rather tedious to explore the forks on Github because the forks that have been accepted and are just "behind" Spesmilo's (standard Electrum) original source remain in the list and so do not really allow you to browse changed versions efficiently.

I decided to just keep a fork of Electrum that I can update most of the time to spesmilo's original when he makes changes rather than try to convince the others they are okay and I only need to refactor when Spesmilo does.  You can check it out at https://github.com/shawnpringle/electrum .  The difference between his and mine is only that it displays the numbers a bit better.  I invite anyone with such a fork to reply with your own and just say why it's different and where it is downloadable from.

[1714672952]

1714672952

[1714672952]

1714672952

[1714672952]

1714672952

[1714672952]

1714672952

[1714672952]

1714672952

[1714672952]

1714672952

[HCP]

The difference between his and mine is only that it displays the numbers a bit better.

I had a quick look at your commits... so basically all you're doing is adding the 000's separator?

Where exactly is this used? Because in the parts of the UI that I would think need to display the separator (for me, the fiat values)... I can already see it... for instance:


Is it if you have your units set to mBTC or something?

[sdp]

You're right.  I do use mBTC and it only adds in the thousands separator.  It will show in your transaction history, and when you enter an amount to send.  It is simple to do but there is not enough interest by the maintainer to have them.    Commas are added automatically when you type in the number and it should work for people using other locales like Europeans who use both commas and periods but use them in the opposite ways.

If you try to run this in --testnet mode.  Send me a testnet bitcoin address so I can send you some. 

Many software packages will not put commas after the decimal point.  I had to custom write this part.  Probably this problem has never been addressed before because most fiat currencies have only two decimal places.  Now with eight, it is kind of ugly not to have them.

I do not remember seeing fiat values in Electrum.  Where do I find that?

[pooya87]

I do not remember seeing fiat values in Electrum.  Where do I find that?

from menu: Tools > Preference > Fiat (tab)
then select a fiat currency and the API to use to fetch the values from.