although the advice letter makes it sound like it was already implicitly legal anyway.
Correct. The OCC cannot make law but only interprets the laws Congress writes or issues regulations when Congress grants them specific authority to do so. In a way, the OCC coming out and saying it this way is better right now since it implies that any banks that have been doing this were not breaking the law.
this won't have any effect on derivatives and securities (ETF) markets since those types of offerings also have to comply with CFTC, SEC, etc regulations.
Correct
as for encouraging adoption, i don't expect much to happen immediately. most banks will be too conservative to dip their toes in for quite a while, and small, tech-minded banks can only penetrate so far.
Banks will move slow but I'm already seeing some start to inquire about testing possible custody offerings. You'll see the fintech companies move in first, perhaps getting the new payments charter. There will be lots of push back here. Entrenched national banks, state chartered banks, and state regulators (who are dependent on fees) will view this as a threat. Thankfully the OCC does not appear to care and would rather open up competition. I'd expect to see the OCC move in further by perhaps allowing trading or encouraging the development of bank issued stablecoins.