What type of wallet would you opt for and why?
I believe you almost failed to differentiate between a hot wallet and a desktop wallet, so I agree with Hosemary. Your comparison should be between either cold wallets and hot wallets, or mobile wallets and desktop wallets.As long as a wallet is on a device, whether desktop or mobile, that is connected to the internet, it is simply considered a hot wallet. Cold wallets should have no direct access to the internet. Transactions are signed separately and completely offline before they are broadcast to the network. And like Charles-Tim stated, a cold wallet is generally the better option for storing your coins because of its higher level of security. But this does not mean it is 100% safe from scams or attacks. There can still be device vulnerabilities that could lead to your wallet being compromised, and that may be completely out of your control.
There is also user error, which Charles-Tim mentioned. It is your responsibility to make sure your private keys are kept safe and completely out of reach of third parties. One common mistake people make is storing their keys on a device that is connected to the internet. If that device becomes infected with malware, hackers could potentially gain access to your keys and steal your coins.
There are many ways scammers and hackers can make you vulnerable, so it is better to follow good security practices from the beginning. Using a cold wallet to store your long term holdings is one of those practices. You can still use hot wallets, but I would avoid keeping large amounts of my investment in them. They are better suited for smaller amounts and everyday transactions when necessary.