So roughly speaking the strategy implies you buy BTC 500 days before the halving and sell it 500 after the halving.
When is it the right time to buy BTC
As logical as your analogy looks, it’s still not a guarantee that if you try it out in real time that you’re certain on being profitable at the rate you speculate it. This is the reason it’s always better to set a time frame for yourself within which you will use in accumulating your bitcoin without trying to over calculate the market. To start with, if you’re attempting to make a single buy, how much can you buy at a go? In most cases, you can only buy just a little fraction of bitcoin.
The right time to buy bitcoin is when you have the financial means of doing so and afterwards, you can then grow your bitcoin till you’ve attained a reasonable amount in your portfolio. If at the attainment of your investment target bitcoin gets really bullish even within a short period of time, that’s even a huge plus.
I would say that this is a good method; it's just that we do not always have the money for it. By logic, if you buy 500 days before halving and sell 500 days after, that's not bad. But I would take it a step further; I think we could do even a year before halving and a year after halving. In that sense, it would be 2 years, so you would make money that way.
Buy in 2027, a year before halving, and sell in 209 a year after halving, and you should be in profit, better than what stock trading would give, or gold would give. However, the only downside for me is that most of the time, even though I know this, I just do not have the money for it; I do not have anything that I can offer, and the only way I could ever get any money would be loans, and I could not pay that back for 2 years before I get profit. Hence, I know it, but I can't do it, and many people, the majority in the world, are like me.