[SOLVED] Did pull, can't compile due to miniupnpc problems

cdnbcguy (OP)

Full Member

Offline

Activity: 128
Merit: 100

[SOLVED] Did pull, can't compile due to miniupnpc problems

April 18, 2011, 01:54:03 AM
Last edit: April 19, 2011, 12:49:38 PM by gavinandresen

#1

I've been around computers since forever but due to stuff happening I am new to Unix.

Had 3.20 compiling and running fine.

Did git pull, tried make said can't find a miniupnpc file /usr/include/miniupnpc/portlistingparse.h

Re-read build-unix.txt - noticed new miniupnpc thingy.

got miniupnpc and ran make then make install.

tried make for Bitcoin - got can't find file again. The install didn't put it there.

file is in /home/cdnbcguy/miniupnpc-1.5.20110314 so I go into sudo natulus and copy it to /usr/include/miniupnpc/

I realize I am probably in a state of sin by this time.

I do this again for two other files.

NOW when I run make I don't get that error any more I get this one

cdnbcguy@beauty:~/bitcoin from github/bitcoin$ make -f makefile.unix
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DFOURWAYSSE2 -DUSE_SSL -DUSE_UPNP=0 -I/usr/local/lib/wx/include/gtk2-unicode-debug-static-2.9 -I/usr/local/include/wx-2.9 -D_FILE_OFFSET_BITS=64 -D__WXDEBUG__ -D__WXGTK__ -pthread -DGUI -o obj/net.o net.cpp
/usr/include/miniupnpc/miniupnpc.h: In function ‘void ThreadMapPort2(void*)’:
/usr/include/miniupnpc/miniupnpc.h:53: error: too few arguments to function ‘UPNPDev* upnpDiscover(int, const char*, const char*, int, int*)’
net.cpp:903: error: at this point in file
/usr/include/miniupnpc/upnpcommands.h:117: error: too few arguments to function ‘int UPNP_AddPortMapping(const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*)’
net.cpp:916: error: at this point in file
make: *** [obj/net.o] Error 1

Could someone please point out the obvious chickenshit error I have made, please?

Annona ad! Please keep in mind that there is nothing wrong with Bitcoin itself. All it's scandals are caused by wonky websites and sleazy people exploiting it. The light attracts bugs.

When all this bullshit drys up and blows away, Bitcoin will be stronger than ever.

Luke-Jr

Legendary

Offline

Activity: 2576
Merit: 1186

Re: Did pull, can't compile due to miniupnpc problems

April 18, 2011, 02:32:12 AM

#2

For now, use this:

Code:

make -f makefile.unix USE_UPNP=

Yes, that's a null value, not a 0.

Donate: (PM me)
My projects: Bitcoin Knots, Bitcoin Core, BFGMiner, Eloipool (pool software), Tonal Bitcoin, and BitGit (Bitcoin code directory)

cdnbcguy (OP)

Full Member

Offline

Activity: 128
Merit: 100

Re: Did pull, can't compile due to miniupnpc problems

April 18, 2011, 03:12:19 AM

#3

Thank you very much - it goes a lot further but kaks with this

obj/db.o: In function `CWalletDB::LoadWallet()':
/home/cdnbcguy/bitcoin from github/bitcoin/db.cpp:811: undefined reference to `fUseUPnP'
obj/db.o: In function `Unserialize<CDataStream>':
/home/cdnbcguy/bitcoin from github/bitcoin/serialize.h:136: undefined reference to `fUseUPnP'
collect2: ld returned 1 exit status
make: *** [bitcoin] Error 1

Annona ad! Please keep in mind that there is nothing wrong with Bitcoin itself. All it's scandals are caused by wonky websites and sleazy people exploiting it. The light attracts bugs.

When all this bullshit drys up and blows away, Bitcoin will be stronger than ever.

Pieter Wuille

Legendary

Offline

Activity: 1072
Merit: 1174

Re: Did pull, can't compile due to miniupnpc problems

April 18, 2011, 09:08:36 AM

#4

Remove your previous obj/*.o files.

I do Bitcoin stuff.

cdnbcguy (OP)

Full Member

Offline

Activity: 128
Merit: 100

Re: Did pull, can't compile due to miniupnpc problems

April 18, 2011, 04:27:09 PM

#5

Worked. Thanks to you guys, you rule!

Annona ad! Please keep in mind that there is nothing wrong with Bitcoin itself. All it's scandals are caused by wonky websites and sleazy people exploiting it. The light attracts bugs.

When all this bullshit drys up and blows away, Bitcoin will be stronger than ever.

Matt Corallo

Hero Member

Offline

Activity: 755
Merit: 515

Re: Did pull, can't compile due to miniupnpc problems

April 18, 2011, 10:32:50 PM

#6

Quote from: cdnbcguy on April 18, 2011, 01:54:03 AM

file is in /home/cdnbcguy/miniupnpc-1.5.20110314 so I go into sudo natulus and copy it to /usr/include/miniupnpc/

/usr/include/miniupnpc/upnpcommands.h:117: error: too few arguments to function ‘int UPNP_AddPortMapping(const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*)’

I thought I made it clear in the make file but I guess not as I've seen this too many times.
For the unix and osx makefiles, you need the 1.5 stable version of miniupnpc (ie miniupnpc-1.5 not miniupnpc-1.5.XXXXXXXX). This was done due to build issues I and several others have seen on various new versions and because its always better to use the release versions.
You'll notice in net.cpp that there is a different UPNP_AddPortMapping command for Windows due to other build issues there. If you really need to use the latest versions of miniupnpc, you can simply use that command instead.

Bitcoin Core, rust-lightning, http://bitcoinfibre.org etc.
PGP ID: 07DF 3E57 A548 CCFB 7530 7091 89BB B866 3E2E65CE

cdnbcguy (OP)

Full Member

Offline

Activity: 128
Merit: 100

Re: Did pull, can't compile due to miniupnpc problems

April 19, 2011, 03:59:53 AM

#7

Point. I missed the part where it says

miniupnpc
---------
tar -xzvf miniupnpc-1.5.tar.gz
cd miniupnpc-1.5
make
sudo su
make install

which is weird because it is just below the part that I DID read to install wxWidgets...

Thanks for your time and I want you to know I appreciate your work.

Annona ad! Please keep in mind that there is nothing wrong with Bitcoin itself. All it's scandals are caused by wonky websites and sleazy people exploiting it. The light attracts bugs.

When all this bullshit drys up and blows away, Bitcoin will be stronger than ever.