Bitcoin Forum
May 28, 2022, 05:04:02 PM *
News: Latest Bitcoin Core release: 23.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: Has someone actually revised the entire code?  (Read 1934 times)
kristoffernolgren
Newbie
*
Offline Offline

Activity: 23
Merit: 0


View Profile
April 28, 2011, 01:59:43 PM
 #1

So the code is open-source and revisable wich is good, but has someomne actully looked through the entire code? 
1653757442
Hero Member
*
Offline Offline

Posts: 1653757442

View Profile Personal Message (Offline)

Ignore
1653757442
Reply with quote  #2

1653757442
Report to moderator
1653757442
Hero Member
*
Offline Offline

Posts: 1653757442

View Profile Personal Message (Offline)

Ignore
1653757442
Reply with quote  #2

1653757442
Report to moderator
1653757442
Hero Member
*
Offline Offline

Posts: 1653757442

View Profile Personal Message (Offline)

Ignore
1653757442
Reply with quote  #2

1653757442
Report to moderator
Remember that Bitcoin is still beta software. Don't put all of your money into BTC!
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1653757442
Hero Member
*
Offline Offline

Posts: 1653757442

View Profile Personal Message (Offline)

Ignore
1653757442
Reply with quote  #2

1653757442
Report to moderator
1653757442
Hero Member
*
Offline Offline

Posts: 1653757442

View Profile Personal Message (Offline)

Ignore
1653757442
Reply with quote  #2

1653757442
Report to moderator
Mike Hearn
Legendary
*
expert
Offline Offline

Activity: 1526
Merit: 1056


View Profile
April 28, 2011, 02:12:38 PM
 #2

I've looked through most of it. All the important parts for payment verification anyway. I think a few others have too (Hal, for one).

Now, that doesn't mean I'm fully convinced it's correct. BitCoin is VERY complicated.
khal
Hero Member
*****
Offline Offline

Activity: 540
Merit: 500



View Profile WWW
April 28, 2011, 02:15:34 PM
 #3

Several people are working on different bitoin parts and propose patches (see : https://github.com/bitcoin/bitcoin/pulls).
So we can't say with that that all code has been reviewed, but it's a good start :p
asdf
Hero Member
*****
Offline Offline

Activity: 527
Merit: 500


View Profile
April 28, 2011, 02:47:59 PM
 #4

Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
ribuck
Donator
Hero Member
*
Offline Offline

Activity: 826
Merit: 1024


View Profile
April 28, 2011, 03:00:39 PM
 #5

Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
You don't get total coverage by separately reviewing every part of the code, because the different parts of the code may interact in ways that were not anticipated.
LZ
Legendary
*
Offline Offline

Activity: 1722
Merit: 1069


P2P Cryptocurrency


View Profile
April 29, 2011, 09:38:56 AM
 #6

I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. Undecided

My OpenPGP fingerprint: 5099EB8C0F2E68C63B4ECBB9A9D0993E04143362
wumpus
Hero Member
*****
qt
Offline Offline

Activity: 812
Merit: 1014

No Maps for These Territories


View Profile
April 29, 2011, 10:37:07 AM
 #7

There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source.

https://code.google.com/p/bitcoinj/

Bitcoin Core developer [PGP] Warning: For most, coin loss is a larger risk than coin theft. A disk can die any time. Regularly back up your wallet through FileBackup Wallet to an external storage or the (encrypted!) cloud. Use a separate offline wallet for storing larger amounts.
Pieter Wuille
Legendary
*
qt
Offline Offline

Activity: 1064
Merit: 1096


View Profile WWW
April 29, 2011, 10:37:53 AM
 #8

There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source.

https://code.google.com/p/bitcoinj/

That guy was even the first to respond in this thread Smiley

I do Bitcoin stuff.
wumpus
Hero Member
*****
qt
Offline Offline

Activity: 812
Merit: 1014

No Maps for These Territories


View Profile
April 29, 2011, 10:43:02 AM
 #9

Ha, didn't know his forum name Smiley

Bitcoin Core developer [PGP] Warning: For most, coin loss is a larger risk than coin theft. A disk can die any time. Regularly back up your wallet through FileBackup Wallet to an external storage or the (encrypted!) cloud. Use a separate offline wallet for storing larger amounts.
xf2_org
Member
**
Offline Offline

Activity: 98
Merit: 11


View Profile
April 30, 2011, 12:37:51 AM
 #10

I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. Undecided

Not sure what you mean by this?  Normal transactions remain free.

ShadowOfHarbringer
Legendary
*
Offline Offline

Activity: 1470
Merit: 1004


Bringing Legendary Har® to you since 1952


View Profile
April 30, 2011, 09:20:07 AM
 #11

I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. Undecided

??

Explain.

Cdecker
Hero Member
*****
Offline Offline

Activity: 489
Merit: 504



View Profile WWW
April 30, 2011, 10:54:34 AM
 #12

We could pass all revisions through Gerrit to enforce Code review and sign-off... Cheesy

Want to see what developers are chatting about? http://bitcoinstats.com/irc/bitcoin-dev/logs/
Bitcoin-OTC Rating
LZ
Legendary
*
Offline Offline

Activity: 1722
Merit: 1069


P2P Cryptocurrency


View Profile
April 30, 2011, 11:19:55 AM
 #13

Steps to reproduce:
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.

If you will close 0.3.21 and run <0.3.21 - it will send without any fee.

My OpenPGP fingerprint: 5099EB8C0F2E68C63B4ECBB9A9D0993E04143362
Matt Corallo
Hero Member
*****
expert
Offline Offline

Activity: 755
Merit: 513


View Profile
April 30, 2011, 11:27:38 AM
 #14

Steps to reproduce:
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.

If you will close 0.3.21 and run <0.3.21 - it will send without any fee.
Not the right thread, and gavin answered it at http://bitcointalk.org/index.php?topic=6642.msg99523#msg99523

Bitcoin Core, rust-lightning, http://bitcoinfibre.org etc.
PGP ID: 07DF 3E57 A548 CCFB 7530  7091 89BB B866 3E2E65CE
LZ
Legendary
*
Offline Offline

Activity: 1722
Merit: 1069


P2P Cryptocurrency


View Profile
April 30, 2011, 11:43:32 AM
 #15

Yeah, you are right, sorry about that. It is not the right thread. I just read Gavin's answer. Thanks.

My OpenPGP fingerprint: 5099EB8C0F2E68C63B4ECBB9A9D0993E04143362
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!