Title: Armory 0.96 third testing builds Post by: goatpig on March 31, 2017, 07:55:27 PM Third testing builds, updated changelog. Added RBF auto fee bump from the ledger (right click a RBF zc to see the option)
Binaries: https://github.com/goatpig/BitcoinArmory/releases/tag/v0.95.99.3-testing --------------------------------- The changelog covers most of what's new with a couple caveats: - Added CPFP and RBF. CPFP is accessible from the coin control GUI, RBF has its own. CPFP and RBF are mutually exclusive. The RBF GUI is up for change, this is just a tentative approach for now. - Auto bitcoind woes should be fixed, give it a spin --------------------------------- I'll repeat the warning in the changelog for the good measure: This version introduces new address types. These address types are not compatible with previous versions of Armory. Any version of Armory (or any wallet for that matter) can pay to these addresses, but only Armory 0.96 can spend from them. Naturally, the new features are opt-in, even code wise. Legacy P2PKH addresses are untouched and can still be signed by anything 0.92+. The SegWit address type is locked to testnet only. --------------------------------- I've spent to and from the new nested compressed key script on the mainnet. Regardless, I recommend to start with small amounts at first, as a precaution. Title: Re: Armory 0.96 testing builds Post by: droark on March 31, 2017, 08:01:26 PM The SegWit address type is locked to testnet only. Are you referring to BIP 142? If so, GMax says it's abandoned (https://www.reddit.com/r/btc/comments/627l4a/it_seems_that_alot_of_bu_supporters_are_unaware/dfkniu9/). In any event, thanks for getting this out to everyone! Looking forward to everybody's feedback. Title: Re: Armory 0.96 testing builds Post by: Aurik on March 31, 2017, 08:10:08 PM Any estimated time to a final 0.96 release yet?
Ty for all your work btw :) Title: Re: Armory 0.96 testing builds Post by: achow101 on March 31, 2017, 08:10:20 PM The SegWit address type is locked to testnet only. Are you referring to BIP 142? If so, GMax says it's abandoned (https://www.reddit.com/r/btc/comments/627l4a/it_seems_that_alot_of_bu_supporters_are_unaware/dfkniu9/). In any event, thanks for getting this out to everyone! Looking forward to everybody's feedback. Title: Re: Armory 0.96 testing builds Post by: droark on March 31, 2017, 09:34:54 PM The segwit address type is the p2sh nested segwit addresses. Ahhh, okay. Disregard my previous post. :) Title: Re: Armory 0.96 testing builds Post by: goatpig on March 31, 2017, 09:45:31 PM Any estimated time to a final 0.96 release yet? Ty for all your work btw :) Can't tell. If a lot of bugs are found during this testing phase, I can't quite release in such state. Title: Re: Armory 0.96 testing builds Post by: Wr8th on April 02, 2017, 04:26:05 PM OK, tried the new build. Running Windows 8.1, had Armory 95.1 installed, but uninstalled it after 1st error. Could not run the new .exe. Here's contents of the ArmoryQt.exe.log log file.
Let me know if you need anything else. I have core .14 so Armory wasn't working before I tried this anyway. (ERROR) ArmoryUtils.pyc:3742 - Unsupported language specified. Defaulting to English (en) (ERROR) Traceback (most recent call last): File "ArmoryQt.py", line 55, in <module> NameError: name '__file__' is not defined Traceback (most recent call last): File "ArmoryQt.py", line 55, in <module> NameError: name '__file__' is not defined Title: Re: Armory 0.96 testing builds Post by: achow101 on April 02, 2017, 07:27:50 PM OK, tried the new build. Running Windows 8.1, had Armory 95.1 installed, but uninstalled it after 1st error. Could not run the new .exe. Here's contents of the ArmoryQt.exe.log log file. If you go to the folder where you installed Armory, do you see a folder named "lang"?Let me know if you need anything else. I have core .14 so Armory wasn't working before I tried this anyway. (ERROR) ArmoryUtils.pyc:3742 - Unsupported language specified. Defaulting to English (en) (ERROR) Traceback (most recent call last): File "ArmoryQt.py", line 55, in <module> NameError: name '__file__' is not defined Traceback (most recent call last): File "ArmoryQt.py", line 55, in <module> NameError: name '__file__' is not defined Title: Re: Armory 0.96 testing builds Post by: Wr8th on April 02, 2017, 07:36:24 PM No - no folder named "lang". Only folder under where I installed Armory is one called "tcl"
Title: Re: Armory 0.96 testing builds Post by: achow101 on April 02, 2017, 07:52:53 PM No - no folder named "lang". Only folder under where I installed Armory is one called "tcl" That's probably the issue then as it is expecting the translation files to be there. There's probably a packaging problem for Windows.Title: Re: Armory 0.96 testing builds Post by: Wr8th on April 02, 2017, 08:16:24 PM Well, please remember that I was at least able to bring up Armory 95.1. It had problems connecting/communicating with the 14.0 core - but at least I could see it.
This beta version won't even come up. As I said, I uninstalled that 95.1 version after the first error from the beta build - so I must've also removed the lang folder?? Why isn't it there for the beta? Should I uninstall beta, go back to 95.1 and copy the lang folder? Or can someone just tell me how to get it? Thanks for whatever you can do. Title: Re: Armory 0.96 testing builds Post by: achow101 on April 02, 2017, 08:40:27 PM Well, please remember that I was at least able to bring up Armory 95.1. It had problems connecting/communicating with the 14.0 core - but at least I could see it. Here is a copy of what I have in my lang folder: https://drive.google.com/open?id=0Bxw3ip9QfNOUTU1laEEyU2l6a1E. Extract the zip file into wherever you installed Armory. Make sure that if you double click the lang folder, you see a bunch of files with a .qm extension on them.This beta version won't even come up. As I said, I uninstalled that 95.1 version after the first error from the beta build - so I must've also removed the lang folder?? Why isn't it there for the beta? Should I uninstall beta, go back to 95.1 and copy the lang folder? Or can someone just tell me how to get it? Thanks for whatever you can do. The reason the lang folder is not there is due to improper packaging of the binaries and the installer. I have it because I do development of Armory and run straight from source. Title: Re: Armory 0.96 testing builds Post by: Wr8th on April 02, 2017, 10:33:35 PM I'm afraid it's still not coming up. When I run it now it complains it can't write to the logfile even though file is there and read and writable.
I tried moving it out and a few other things but exe still won't run. Thanx for your efforts - I 'preciate it. But, I'm kinda on a time crunch to get some bitcoins so I'm thinking of trying another wallet if 0.96 ain't available soon. Title: Re: Armory 0.96 testing builds Post by: achow101 on April 02, 2017, 10:35:41 PM I'm afraid it's still not coming up. When I run it now it complains it can't write to the logfile even though file is there and read and writable. I'll see if I can replicate the issue.I tried moving it out and a few other things but exe still won't run. Thanx for your efforts - I 'preciate it. But, I'm kinda on a time crunch to get some bitcoins so I'm thinking of trying another wallet if 0.96 ain't available soon. For now, you can use 0.95.1 and downgrade to Bitcoin Core 0.13.2. Title: Re: Armory 0.96 testing builds Post by: Wr8th on April 02, 2017, 11:17:01 PM Thank you.
By downgrading to Bitcoin Core 0.13.2 - it's not going to download that huge database again, right? Title: Re: Armory 0.96 testing builds Post by: achow101 on April 02, 2017, 11:39:46 PM Thank you. No, it will not have to download the blockchain again. It will use what is already downloaded.By downgrading to Bitcoin Core 0.13.2 - it's not going to download that huge database again, right? Title: Re: Armory 0.96 testing builds Post by: Wr8th on April 03, 2017, 03:06:53 AM Well, I've got Armory 0.95.1 running with Bitcoin Core 0.13.2 but it is just sitting there - as it was with BC 0.14.
There's a full green box in the "Initializing Bitcoin Engine" section with that little icon slowly spinning around. This is what is was doing with 0.14. The task manager tells me that ArmoryQT.exe is indeed running and I also see a "bitcoind" process running, but it appears that nothing is really happening. Is it building its own database? Where can I look to see if it's doing something? Sorry to keep giving this stuff to you (should I move to another thread?) - but just trying to figure out if I'm spinning my wheels here or if something is going on. Do you know if this combo has run in W8.1 succesfully before. Thanks so much for your support. Title: Re: Armory 0.96 testing builds Post by: achow101 on April 03, 2017, 03:10:44 AM Well, I've got Armory 0.95.1 running with Bitcoin Core 0.13.2 but it is just sitting there - as it was with BC 0.14. You need to run Bitcoin Core and Armory separately. In Armory's settings, uncheck the box "Let Armory run Bitcoin Core in the background". Then stop Armory, start Bitcoin Core, and restart Armory.There's a full green box in the "Initializing Bitcoin Engine" section with that little icon slowly spinning around. This is what is was doing with 0.14. The task manager tells me that ArmoryQT.exe is indeed running and I also see a "bitcoind" process running, but it appears that nothing is really happening. Is it building its own database? Where can I look to see if it's doing something? Sorry to keep giving this stuff to you (should I move to another thread?) - but just trying to figure out if I'm spinning my wheels here or if something is going on. Do you know if this combo has run in W8.1 succesfully before. Thanks so much for your support. Title: Re: Armory 0.96 testing builds Post by: Wr8th on April 03, 2017, 04:04:19 AM Hey! That did it. I'm online and connected.
Thanx so much again for your help. Title: Re: Armory 0.96 testing builds Post by: goatpig on April 03, 2017, 04:36:02 PM Bundling the Windows tsl fix with a bunch of others, new build ETA: Friday
Title: Re: Armory 0.96 testing builds Post by: gangtraet on April 03, 2017, 08:37:02 PM Trying it out on a Mac:
http://imgur.com/a/6p13s EDIT: It is normal the balance is zero. It is a testing wallet. But there should be addresses in the wallet. :) Title: Re: Armory 0.96 testing builds Post by: achow101 on April 03, 2017, 08:38:35 PM
http://imgur.com/a/6p13s EDIT: It is normal the balance is zero. It is a testing wallet. But there should be addresses in the wallet. :) Title: Re: Armory 0.96 testing builds Post by: goatpig on April 03, 2017, 09:27:34 PM Viewing the addresses in a walled does not work There are addresses. What is happening is that Qt is using weird column sizing by default, and the first (left most) column (the one for addresses) is shrunk. You have to enlarge it and your setting will carry over from there on, but the first time around, the first column on any tree structure is super tiny. Title: Re: Armory 0.96 testing builds Post by: gangtraet on April 04, 2017, 05:16:44 PM I see it now. Clicking on the triangles did not show anything, but that was because the column was too small. Expanding it and it works. I am not sure I like the tree-structure, but there is probably too much info to show otherwise. One thing I am missing, though, is the "hide empty" button.
Thanks for your replies. Title: Re: Armory 0.96 testing builds Post by: goatpig on April 04, 2017, 05:42:21 PM One thing I am missing, though, is the "hide empty" button. Will think about it Quote I am not sure I like the tree-structure, but there is probably too much info to show otherwise. Have to distinguish between the new script types now. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 10, 2017, 01:10:00 AM New round of builds, test away.
Title: Re: Armory 0.96 second testing builds Post by: arulbero on April 14, 2017, 12:57:07 PM 0.95.99.2-testing_win64.exe:
Code: Log file opened at 1492164611: C:\Users\Antonio\AppData\Roaming/Armory/dbLog.txt Title: Re: Armory 0.96 second testing builds Post by: achow101 on April 14, 2017, 01:13:52 PM 0.95.99.2-testing_win64.exe: What version of Bitcoin Core are you running?Code: Log file opened at 1492164611: C:\Users\Antonio\AppData\Roaming/Armory/dbLog.txt Title: Re: Armory 0.96 second testing builds Post by: arulbero on April 14, 2017, 01:19:10 PM What version of Bitcoin Core are you running? 0.13.2 Title: Re: Armory 0.96 second testing builds Post by: achow101 on April 14, 2017, 01:23:43 PM What version of Bitcoin Core are you running? 0.13.2 Title: Re: Armory 0.96 second testing builds Post by: unamis76 on April 15, 2017, 11:27:56 AM I'll repeat the warning in the changelog for the good measure: This version introduces new address types. These address types are not compatible with previous versions of Armory. Any version of Armory (or any wallet for that matter) can pay to these addresses, but only Armory 0.96 can spend from them. Naturally, the new features are opt-in, even code wise. Does this mean old versions in cold storage have to be updated? And will I need to create a new wallet? If I'm not mistaken my cold storage wallet is still on 0.93.3. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 15, 2017, 11:56:10 AM 1) Any wallet can pay to the new address types
2) You need the new code to spend from the new address types 3) Just putting 0.96 on your offline signer is enough to support that 4) 0.96 won't produce these receive/change address types by default. You have to manually set the default in the Settings tab. 5) Old code can spend from P2PKH. Nothing changed there. Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 15, 2017, 03:33:37 PM I am trying to run armory after installing the testing .deb file on Ubuntu 16.04 LTS x64. Installation works just fine. However, I don't see any icons in my launcher. If I search in the file browser I see it has been installed. However, the icons are all blank and when I try to launch it from there I get "There was an error launching the application".
What can I provide to make debugging easier. Or is it know to not run on this system? Any help appreciated. Edit: It also doesn't show as installed in Software-Center although just after installation it tells me that installation was successful and I would have the option to reinstall. Synaptic shows the armory package as green. And I can also uninstall it from there. Edit2: Is there no longer a Win 32 installation package? I use Win32 for my offline signing. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 15, 2017, 04:32:23 PM Quote What can I provide to make debugging easier. Or is it know to not run on this system? Any help appreciated. Does it run from the terminal? Type 'armory' to try. Quote Edit2: Is there no longer a Win 32 installation package? I use Win32 for my offline signing. As is x86 Windows? There hasn't been a build for that arch since the 0.92 era. Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 15, 2017, 05:31:16 PM Quote What can I provide to make debugging easier. Or is it know to not run on this system? Any help appreciated. Does it run from the terminal? Type 'armory' to try. As is x86 Windows? There hasn't been a build for that arch since the 0.92 era. Returns: Illegal instruction (core dumped) Can I still sign transactions with my old Armory version? The installation is still fine and running. Or will that no longer work. All wallets and backups were also generated using this old version. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 15, 2017, 07:20:12 PM 1) Any wallet can pay to the new address types 2) You need the new code to spend from the new address types 3) Just putting 0.96 on your offline signer is enough to support that 4) 0.96 won't produce these receive/change address types by default. You have to manually set the default in the Settings tab. 5) Old code can spend from P2PKH. Nothing changed there. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 15, 2017, 07:21:19 PM Try 'ArmoryDB' in terminal
Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 15, 2017, 08:02:35 PM Try 'ArmoryDB' in terminal Same response as for the armory command Edit: How it looks. https://i.imgur.com/tpKycLy.png https://i.imgur.com/1H7CR2s.png Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 15, 2017, 08:56:08 PM run
Code: sudo dpkg -r armory to uninstall the package. Make sure there is nothing left (check /usr/local/bin and /usr/local/lib). Install the package and try again. Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 15, 2017, 09:35:16 PM run Code: sudo dpkg -r armory to uninstall the package. Make sure there is nothing left (check /usr/local/bin and /usr/local/lib). Install the package and try again. Uninstalled as you mentioned. checked the locations you mentioned. There was still an armory folder in lib. -> delteted it. The was no bin path at all. I used Code: gksudo nautilus Edit: Also, this is a completely fresh ubuntu installation and so far only features bitcoin core. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 15, 2017, 11:51:29 PM Noted, will look into it.
Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 16, 2017, 12:04:22 PM Noted, will look into it. Thx, let me know when you find something. Title: Re: Armory 0.96 second testing builds Post by: Carlton Banks on April 16, 2017, 01:30:30 PM Build fails with current testing (a4e681c), latest Debian 8.7 based Whonix
Code: TransactionBatch.cpp: In member function 'void TransactionBatch::unserialize_recipients(const std::vector<std::basic_string<char> >&, std::pair<unsigned int, unsigned int>&)': Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 16, 2017, 02:14:19 PM Build fails with current testing (a4e681c), latest Debian 8.7 based Whonix What's your gcc version? Title: Re: Armory 0.96 second testing builds Post by: Carlton Banks on April 16, 2017, 02:31:39 PM 4.9
The .deb package for 0.95.99.1 complained to me about gcc 4.9, telling me I needed 5.something. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 16, 2017, 02:57:55 PM It was build with Ubuntu 16.04 LTS so you would run into that issue indeed. Investigating the build issue on Debian Wheezy atm.
Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 16, 2017, 03:39:34 PM Should be fixed.
Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 16, 2017, 05:13:24 PM Should be fixed. Does that mean there will be a new .deb package soon, or was that another issue? Title: Re: Armory 0.96 second testing builds Post by: Carlton Banks on April 16, 2017, 05:34:00 PM Should be fixed. Does that mean there will be a new .deb package soon, or was that another issue? It's probably separate to your issue, it's a build specific issue, and it appears goatpig has used the same version of Ubuntu that you are for at least some of the Debian Linux install packages (Ubuntu is a fork of Debian) In other news, building works for me now :) thanks goatpig Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 16, 2017, 05:46:42 PM Should be fixed. Does that mean there will be a new .deb package soon, or was that another issue? There will be a new build to push in the new fixes, but I can't reproduce your issue. This is what I got: 1) Install Ubuntu 16.04 from scratch 2) Installed Armory (0.95.99.2-testing, didn't install Core) Run either ArmoryDB or armory succesfully from the terminal. I'm investigating the icon issues. Try to run this: Code: > armory --offline How far do you get? Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 16, 2017, 07:38:30 PM Code: > armory --offline How far do you get? Same as above. Also no icon for Armory (Offline). I might try another reinstall and install Armory first thing. Just have to find a place to put the blocks I just downloaded meanwhile. Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 16, 2017, 10:16:49 PM Just tried again after fresh install of Ubuntu. I am just now downloading Ubuntu again and burning a new disk. Might maybe also be of interest is how the package looks in ubuntu SW center. Also if I open the package again, SW center does not recognize it's installed and asks me again if I want to install. If I do, it kind of takes way shorter then the first time. Uninsall just hung up out of SW center which previously worked with the package manager.
https://i.imgur.com/JzQYokP.png Title: Re: Armory 0.96 second testing builds Post by: Carlton Banks on April 17, 2017, 04:48:56 AM Just tried again after fresh install of Ubuntu. I am just now downloading Ubuntu again and burning a new disk. Might maybe also be of interest is how the package looks in ubuntu SW center. Also if I open the package again, SW center does not recognize it's installed and asks me again if I want to install. If I do, it kind of takes way shorter then the first time. Uninsall just hung up out of SW center which previously worked with the package manager. Don't use the Software Center, that would be my advice. Software Center uses dpkg or apt in the background anyway, just open a Terminal and use dpkg -i armory.deb (whatever the real filename for the package is) directly. dpkg and apt-get are far more rigorously bug-tested on Debian (and derivatives like Ubuntu), in general you'll find that with all Linux software. The software ecosystem is too diverse for the (mostly unpaid) developers to test absolutely every combination of everything, and so expecting the GUI to work oftentimes ends with you solving the problem one way or another in a terminal shell. Just start in the shell, and you'll have less problems, and more skill, in the end. Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 17, 2017, 05:46:44 AM I don't know why it's branded as non free, seeing the source is available online. As for your issue, I can't reproduce (with or without Core installed). I would suggest you build from source to try things out.
You'd want to first uninstall armory, then run the following commands in a folder dedicated to the source: Code: git clone https://github.com/goatpig/BitcoinArmory.git With that done, you can then run Armory from the terminal using 'armory'. You can uninstall by browsing to the source folder and running 'sudo make uninstall' Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 17, 2017, 07:16:34 AM I don't know why it's branded as non free, seeing the source is available online. As for your issue, I can't reproduce (with or without Core installed). I would suggest you build from source to try things out. You'd want to first uninstall armory, then run the following commands in a folder dedicated to the source: Code: git clone https://github.com/goatpig/BitcoinArmory.git With that done, you can then run Armory from the terminal using 'armory'. You can uninstall by browsing to the source folder and running 'sudo make uninstall' OK I will try that tonight just after Carltons tip. Thank you all. By the way I installed Ubuntu again from fresh disk of 16.04.2. Same behavior. I did use other package managers to install before but not the all terminal option. Title: Re: Armory 0.96 second testing builds Post by: Carlton Banks on April 17, 2017, 07:53:51 AM Also, running dpkg -i will almost certainly give you more detail with any errors in the process, it will help goatpig if you post what it says.
And it also might simply work without errors using dpkg, and then we know the problem lies with the Software Center. Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 17, 2017, 10:54:47 AM Carlton's tip didn't work either. It tells me it is successfully installed and then I have the same behavior. Building from source needed some dependancies installed. I did that and it seems up to
Code: ./configure However, the make process ends with: Code: make[3]: Leaving directory '/home/ben/ArmoryGit/BitcoinArmory/cppForSwig' The install process then ends with: Code: libtool: install: /usr/bin/install -c DB1kIterTest /usr/local/bin/DB1kIterTest There seem to be a lot of armory files created (including icons ;-)) but somehow installation failed. Any advice? Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 17, 2017, 11:05:12 AM sudo apt-get install swig
Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 17, 2017, 01:37:53 PM It's running now. Now I have to set up my node again and get it online. Thy for all the help. Was maybe one of the dependencies missing for running it from the .deb file?
Edit: Even though I kept the blocks, it is taking ages to synch the block headers. Could I have prevented this in any way? Title: Re: Armory 0.96 second testing builds Post by: unamis76 on April 17, 2017, 03:47:39 PM 4) 0.96 won't produce these receive/change address types by default. You have to manually set the default in the Settings tab. Thank you. I think I'll refrain from updating for the time being. Title: Re: Armory 0.96 second testing builds Post by: Searinox on April 17, 2017, 03:49:59 PM Windows 7 x64 SP1 - the wallet properties transaction list looks weird with a bunch of dropdowns and blank options with no addresses listed. I did rebuild armory's DB, no effect.
Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 17, 2017, 05:01:25 PM Was maybe one of the dependencies missing for running it from the .deb file? dpkg would fail to install the package if the dependencies aren't satisfied. Quote Even though I kept the blocks, it is taking ages to synch the block headers. Could I have prevented this in any way? Did it get past that step? Post your logs otherwise. Quote Windows 7 x64 SP1 - the wallet properties transaction list looks weird with a bunch of dropdowns and blank options with no addresses listed. The address column (leftmost) is tiny by default (Qt4, go figure). Just expand it, it will make sense right away. Title: Re: Armory 0.96 second testing builds Post by: Searinox on April 18, 2017, 04:53:07 PM Okay thank you they do now. What are the differences between the 3 address generation methods from a performance and security standpoint?
Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 18, 2017, 06:30:40 PM 1) P2PKH is Armory's legacy type script type. Uses uncompressed keys. Any 0.92+ signer can sign these outputs even if they are created by 0.96 and later.
Output scripts are 23 bytes large, input scripts are [72~74 + 65] bytes long (sig + uncompressed pub key) 2) (nested) P2SH-P2PK is a single sig compressed key script. a) The smallest single sig construct is raw P2PK, where you put the compressed public key as is in the output. This is a loss of security over P2PKH because your public key is exposed before redeeming its content (you don't get the extra protection afforded by the hash). This results in the smallest single input at redemption, which would be only the signature. A 1-of-1 raw multisig would give you the same result for the same downfall. This path gives you a 34 byte output script and 72~74 byte input script. b) The most common way to use compressed public keys is with regular P2PKH. You hash the compressed public key instead of the uncompressed one, the rest is plain P2PKH. This yields a 23 bytes output and [72~74 + 33] bytes input (sig + compressed key) c) Then there's P2SH-P2PK, which is being introduced in Armory. This nests the P2PK script from a) in a P2SH. You get the hash protection and about the same size as b. You would have 22 bytes outputs and [72~74 + 34] bytes input (sig + compressed P2PK script). I decided to use the P2SH path instead of compressed keys over P2PKH for 2 reasons: - The original wallets were built with no P2SH in. When lockboxes were introduced, etotheipi made a point of distinguishing lockboxes from wallets by P2SH vs P2PKH. By doing this, it makes it easier to deliver compressed key support as an opt-in feature. The whole development processed was tailored to keep all that new code opt-in. - This opens up a path for privacy improvement: Currently Armory can only create P2PKH change. When paying to a P2SH address (a lot of services use those now), your change becomes obvious. By introducing a P2SH script type, it allows Armory to match the script type for the change output if you allow it to. You need to pick the auto change option in the settings for that to happen, but the GUI will warn you from now on if your change type differs from the spend type. 3) (nested) P2SH-P2WPKH. This is a straight forward nested SegWit single sig output. As per SegWit convention, it uses compressed keys. Since it's P2SH, non SegWit wallets can pay to this script type, so you can pass it around to make sure you receive a SW output. This will net you a 22 bytes output, 22 bytes input (version 0 p2wpkh script) and [72~74 + 33] bytes witness program (sig + compressed pub key). ----------- EDIT: there is no significant difference in performance between any of these script types. Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 20, 2017, 10:05:00 PM I moved to a Windows 7 x64 system with 16 gb ram as the ubuntu pc just din't handle the DB build ever. Now I constantly get this. Sorry for the ugly screenshot but as soon as I press cancle ArmorDB and the CMD vanish.
So far always happended between maybe 18 an 28 % progress. any idea? https://i.imgur.com/1eN9BjT.jpg Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 20, 2017, 10:41:36 PM Are you using the same block file data on the Windows machine than on the Ubuntu one?
Quote So far always happended between maybe 18 an 28 % progress. Delete the database and try again from the top with --thread-count=1. Does it always fail at the same spot now? Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 21, 2017, 05:58:40 AM Are you using the same block file data on the Windows machine than on the Ubuntu one? Quote So far always happended between maybe 18 an 28 % progress. Yes I copied it over. Bitcoin QT workes fine and is synched. I do not use the default datadir, neither for Armory nor Bitcoin-QT. However it starts to build the DB in the correct place? Do you recommend to re-download the whole chain again? Delete the database and try again from the top with --thread-count=1. Does it always fail at the same spot now? Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 21, 2017, 06:59:35 AM Quote Delete the database and try again from the top with --thread-count=1. Does it always fail at the same spot now? That's what I hope to reveal Quote Do you recommend to re-download the whole chain again? Not yet, I wanna see what's messed with it. Title: Re: Armory 0.96 second testing builds Post by: SimonBelmond on April 21, 2017, 07:11:20 PM OK with that option I get this:
https://i.imgur.com/B9mWG4j.jpg Without that option the behavior seems the same, a console with ArmoryDB.exe appears with a ton of -INFO and Armory starts making its things. Currently at 14% of building database and also initializing Bitcoin engine. I changed and let armory handle bitcoin in the background. Who knows, maybe works better that way without starting BitcoinQt first. I'll update. Edit: Nope stuck at block file 220 this time. Is there an ArmoryDB log somewhere? Title: Re: Armory 0.96 second testing builds Post by: goatpig on April 22, 2017, 02:19:21 AM Quote Without that option the behavior seems the same, a console with ArmoryDB.exe appears with a ton of -INFO and Armory starts making its things. Currently at 14% of building database and also initializing Bitcoin engine. I changed and let armory handle bitcoin in the background. Who knows, maybe works better that way without starting BitcoinQt first. I'll update. Don't run ArmoryQt with the arg. Just run ArmoryDB with the arg, then run the client on its own. It will find the db. First, delete the databases folder again. Then, in F:\Armory, create a armorydb.conf text file. Fill it with this: Code: satoshi-datadir=F:\Bitcoin Save and close, then run: Code: > ArmoryDB.exe --datadir=F:\Armory Then in another cmd prompt, run the client (while the DB is still running): Code: > ArmoryQt.exe --datadir=F:\Armory Quote Is there an ArmoryDB log somewhere? dbLog.txt in your datadir. Title: Re: Armory 0.96 thired testing builds Post by: SimonBelmond on April 22, 2017, 10:58:16 AM It seems to have worked out. Only on the bottom it still tells me Armory is offline. I import my watch only wallets now and see if the balances show up correctly.
Edit: Wallet balances are shown as 0 for all wallets. It also tells me that the Bitcoin node is offline. I set Armory to manage Bitcoin and gave it the correct directories. Edit2: I think it looks good now. Had to stop ArmoryDB and let everything run by ArmoryQt and have it rund the ArmoryDB itself. I am now at scanning transaction history but database seems built and all. I report again as soon as I can see my balances. History scan seems to take another 30min or so. https://i.imgur.com/u4j2CTM.jpg Title: Re: Armory 0.96 thired testing builds Post by: SimonBelmond on April 22, 2017, 11:30:16 AM I think Armory Wants to drive me crazy.... ;-) At 99% of scanning my wallets I get this:
Edit: Just reproduced it. It happens at the exact same spot just after height #461932. Any advice for this? https://i.imgur.com/gFNHBP2.jpg Title: Re: Armory 0.96 thired testing builds Post by: Carlton Banks on April 22, 2017, 02:49:57 PM Try using a different external disk. And/or be extra careful not to knock the USB cable connecting your disk to your machine. The issue you're having might be disk failure, or cable failure. Certainly, Armory isn't happy with what it's reading from the Bitcoin blockchain when it scans your wallet transactions.
Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 22, 2017, 05:59:12 PM Add this line to the .conf:
Code: db-type=DB_BARE Then start from the top. How much RAM do you have? If you have less than 8GB, also add ram-usage=1 Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 23, 2017, 06:25:55 AM It worked, thank you so much! I am online! ;D
Regarding the ram usage, on this machine I have 16gb, and I switched over from the Ubuntu PC which only has 4gb. In the long run I would prefer the Ubuntu PC as I can leave it online 24/7. Do you think with the settings you recommended to me now, it might also work on the Ubuntu PC where it always got stuck building the DB? Title: Re: Armory 0.96 third testing builds Post by: Carlton Banks on April 23, 2017, 06:38:14 AM @Simon Belmond
The settings goatpig recommended are tailored for low-RAM low-CPU machines, but there are no guarantees. Try it, and you will see. Glad to hear you have a working Armory setup now regardless. @goatpig, did you change the location of the Armory installation for 0.96? I've tried the 0.95.99.3 .deb package, but I'm getting an absence of installation at /usr/lib/ (even the directory /usr/lib/armory isn't created, /usr/local/armory & /usr/local/armorydb are created). Installation is suspiciously quick also, is there some error in the install package? Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 23, 2017, 06:52:43 AM It worked, thank you so much! I am online! ;D Regarding the ram usage, on this machine I have 16gb, and I switched over from the Ubuntu PC which only has 4gb. In the long run I would prefer the Ubuntu PC as I can leave it online 24/7. Do you think with the settings you recommended to me now, it might also work on the Ubuntu PC where it always got stuck building the DB? On your low RAM machine, you should use: Code: db-type=DB_BARE On your other machine, you shouldn't need any of these extra settings at all. If it's still failing to build & scan, use DB_BARE. DB_BARE is an initialization setting, you can't swap it around after the DB has been created. Once you create a DB_BARE db, that setting will stick for the db's lifetime, so manage it accordingly. The fact that your machines require DB_BARE suggests some sort of system instability (by default the build phase will max out your CPU). Quote @goatpig, did you change the location of the Armory installation for 0.96? I've tried the 0.95.99.3 .deb package, but I'm getting an absence of installation at /usr/lib/ (even the directory /usr/lib/armory isn't created, /usr/local/armory & /usr/local/armorydb are created). Installation is suspiciously quick also, is there some error in the install package? Plenty changed, courtesy of autotools. All binaries now go to /usr/local/bin, libs and python code files go to /usr/local/lib/armory. Desktop files still go to /usr/share/applications. The .deb does not distribute CPP code files anymore. Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 23, 2017, 06:59:10 AM Oh boy, just realized I am still on 0.91 on my offline win 32 PC. Can't sign the transaction as the format changed. I was under the impression I was on 0.93 or something.
I was just thinking about installing Ubuntu on that machine and creating the Offline PC from scratch. However, this will be the same HW as the online Ubuntu PC so I fear that I cant't install from .deb and installing all the dependencies to build from source will be a major pain without plugging it into the network. I'll probably try to find a Win x64 installation disk somehow and try it that way. Any other ideas? Edit: What if I downgrade my bitcoin node to 0.13 and use 0.96 Armory? Kind of don't want to change a running system since I just got it all online. Edit2: Or I use the last 0.95 deb and hope it will work that way? Edit3: I now disconnected my Ubuntu PC from the network and have set it up as offline machine. Now the next problem haunts me: It tells me my unsigned transaction I want to sign is unrecognized. Tried to export it as unsigned tx file and as text only. It tells me it is unrecognized. Could there be a problem with the language settings. Edit4: Just tried it from a different wallet and it also tells me unrecognized. Both versions of Armory are the newest testing build. The log just tells me the file was loaded. why it was unrecognized it doesn't tell me. Edit5: My online wallet can successfully import the unsigned TX and recognizes everything as expected. It must be some kind of language, date format or ASCI Table problem. Any advice mostly appreciated. Terminal Output: Code: Traceback (most recent call last): Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 23, 2017, 09:20:53 AM 1) What is the signer's version?
2) The .deb packages work, I got no idea what kind of Ubuntu you are using that it can't get them to run. Try the gcc4.7 I made just in case you are using some weird distro. Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 23, 2017, 09:33:24 AM 1) What is the signer's version? 2) The .deb packages work, I got no idea what kind of Ubuntu you are using that it can't get them to run. Try the gcc4.7 I made just in case you are using some weird distro. 1. Where do I find it? 2. Armory is running fine in offline mode on Ubuntu. It was the one built from source as you instructed me to do (0.95.99.2 on both systems). Testing branch. gcc4.7??? I assume versions should be compatible as the are the same testing version. I am seriously considering importing the encrypted wallets to my online system and moving to another wallet. However, I love armory for its M/N backups and of course I would have to re-setup backup schedules for me and some other people that I manage their wallets for. Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 23, 2017, 11:16:28 AM 3rd testing build has the fix for the txsigcollet issue. I was assuming you were using that.
You can get the gcc4.7 build in the usual place: https://github.com/goatpig/BitcoinArmory/releases/tag/v0.95.99.3-testing Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 23, 2017, 11:23:14 AM 3rd testing build has the fix for the txsigcollet issue. I was assuming you were using that. You can get the gcc4.7 build in the usual place: https://github.com/goatpig/BitcoinArmory/releases/tag/v0.95.99.3-testing Just checked again. Testing build 2 on both systems. Can you ELI5 gcc4.7? Where should I install this? On both systems or on my online system only? What about the terminal output I posted above? It seems to not be able to recognize certain parts of the TX as it states it's no legal ASCI or so. Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 23, 2017, 12:08:37 PM Quote Just checked again. Testing build 2 on both systems. Can you ELI5 gcc4.7? Where should I install this? On both systems or on my online system only? I'm not telling you to install an older GCC, I'm telling you to try the 0.95.99.3 gcc4.7 testing build. Quote What about the terminal output I posted above? It seems to not be able to recognize certain parts of the TX as it states it's no legal ASCI or so. Fixed on 0.95.99.3. You need it on your online machine to create proper txsigcollect packets. Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 23, 2017, 12:28:04 PM Wonderful, that worked now. Thank you so much! :-*
Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 23, 2017, 08:39:57 PM Wonderful, that worked now. Thank you so much! :-* What worked? The .deb, the txsigcollect, or both? Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 23, 2017, 09:06:42 PM Wonderful, that worked now. Thank you so much! :-* What worked? The .deb, the txsigcollect, or both? Installed testing version 3 over the top of testing version 2 on the win 7 x64 online machine. Now it creates unsigned tx which can be recognized by the offline testing version 2 on the Ubuntu x64. Sent a transaction went all good. Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 23, 2017, 09:54:22 PM Can you try the .3 gcc4.7 deb on a Ubuntu machine?
Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 24, 2017, 06:28:18 AM Can you try the .3 gcc4.7 deb on a Ubuntu machine? So you mean test the .deb? Or build from source? I will have to flatten and set up my old offline PC and install Ubuntu to make it my online machine again. I will try this in the next few days. I will then use this low ram option to build the DB. Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 24, 2017, 08:47:59 AM Try the .deb
Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 24, 2017, 07:34:23 PM armory_0.95.99.3-testing-gcc4.7_amd64
Code: armory --offline Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 25, 2017, 05:09:35 AM ugh this is supposed to work... I'll try one more thing to get the deb going. What's your CPU on that machine btw?
Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 25, 2017, 07:29:11 AM I think it is this one, will have to double check.
Prozessor Typ Intel Core i5 Modell i5-2400s Grundtaktfrequenz 2.5 GHz Sockel total/frei 1 / 1 Pretty sure it's this PC: https://support.hp.com/us-en/product/hp-compaq-8200-elite-ultra-slim-pc/5037958/manuals Title: Re: Armory 0.96 third testing builds Post by: SimonBelmond on April 25, 2017, 10:20:28 PM Actually it's this one, just checked:
http://www.computershopper.com/desktops/reviews/hp-compaq-8000f-elite-ultra-slim-desktop-pc Title: Re: Armory 0.96 third testing builds Post by: Carlton Banks on April 26, 2017, 09:45:51 PM Quote @goatpig, did you change the location of the Armory installation for 0.96? I've tried the 0.95.99.3 .deb package, but I'm getting an absence of installation at /usr/lib/ (even the directory /usr/lib/armory isn't created, /usr/local/armory & /usr/local/armorydb are created). Installation is suspiciously quick also, is there some error in the install package? Plenty changed, courtesy of autotools. All binaries now go to /usr/local/bin, libs and python code files go to /usr/local/lib/armory. Desktop files still go to /usr/share/applications. The .deb does not distribute CPP code files anymore. Okay, with Qubes OS, this is an issue. /home and /usr/local are the only directories that the VM templates do not refresh in the user VMs that do the actual client work (the templates have strict firewall rules that prevent any network access except a local software update proxy VM). This means that user VMs derived from their template VMs do not pick up any changes to the filesystem made to the /home and /usr/local directories and below. That means re-creating the user VMs every time a new Armory package is installed (I've tested this out). If the bitcoin blockchain or armory databases are installed on the actual VM disk, which is the most convenient (and also the default) option, then they must be copied off the old VM and onto the new. It's serious rigamarole, in short. What can be done here? Basically, anywhere but /usr/local will eliminate this problem for Qubes users. Title: Re: Armory 0.96 third testing builds Post by: goatpig on April 27, 2017, 05:17:56 AM make install installs to $(DESTDIR)$(PREFIX):
https://github.com/goatpig/BitcoinArmory/blob/testing/Makefile.am#L39 For info, $(DESTDIR) is empty, only $(PREFIX) has anything in it, which defaults to /usr/local You could either set a DESTDIR or use a custom PREFIX during ./configure and build yourself. If you insist on having a built package that fits your setup, I would consider doing that for the gcc4.7 build, but you'd have to research how to force the different install path with dh-make (which calls ./configure each run). This is the script used to package .deb: https://github.com/goatpig/BitcoinArmory/blob/testing/dpkgfiles/make_deb_package.py Title: Re: Armory 0.96 third testing builds Post by: tmib on April 28, 2017, 08:47:46 PM looking forward to the 0.96 final release! thanks for the good work!
Title: Re: Armory 0.96 third testing builds - Lost In Translation Post by: Mr.Vice on May 01, 2017, 11:47:29 AM There is a translation in the desciption of the wallet security settings missing. Where it says "Encryped" it should be in German "Verschlüsselt". :-)
Title: Re: Armory 0.96 third testing builds - Lost In Translation Post by: achow101 on May 01, 2017, 01:17:37 PM There is a translation in the desciption of the wallet security settings missing. Where it says "Encryped" it should be in German "Verschlüsselt". :-) Not everything has been translated yet, and some translations seem to be broken (particularly with the Secureprint strings because of unicode). If there are no translations for a string, it will just default to the English strings.Title: Re: Armory 0.96 third testing builds - Lost In Translation Post by: Mr.Vice on May 01, 2017, 01:30:51 PM There is a translation in the desciption of the wallet security settings missing. Where it says "Encryped" it should be in German "Verschlüsselt". :-) Not everything has been translated yet, and some translations seem to be broken (particularly with the Secureprint strings because of unicode). If there are no translations for a string, it will just default to the English strings.Okay, got it! Another more "urgent" issue I encountered is regarding to multi-sig (MultiSig>FUND>Fund from Wallet). When I use the fund from wallet option the usual warning of simulfund prompts up, but after pressing ok nothing happens. Code: 2017-05-01 15:09 (INFO) -- ArmoryQt.py:5414 - Attempting to close the main window! Title: Re: Armory 0.96 third testing builds Post by: goatpig on May 01, 2017, 01:33:37 PM Will fix the simulfund issue for 0.96.1
Title: Re: Armory 0.96 third testing builds Post by: Mr.Vice on May 01, 2017, 01:48:41 PM Will fix the simulfund issue for 0.96.1 Nice, thx goatpig ;-) But anyway this build is running very stable! Didn't see any major issues apart from the before mentioned, but you can still fund the lockbox by just copying the address' public key by openening the wallet properties in expert mode. |