Are you always invalidating it? Or only if there are two purchase offers on both of the addresses? I think it would add flexibility if we would allow multi-input payments we just need to track which inputs have an offer open.
I also agree on the flexibility of allowing multi input as payment but only for one purchase offer. If there are 2 purchase offers for both address , payment transaction will be applied only to 1 purchase offer of one the of the address (lesser n value) Currently I invalidated the transaction. Will change the code if this is approved. Currently reading it. Will post comments soon. |
|
|
|
What kind of payment is this suppose to be? A payment for the distributed exchange?
I guess we need to think of a way to properly handle this case. I'm guessing that we could backtrace and see if one of these addresses did a Purchase Offer. If both of them did a purchase offer we invalidate the transaction. Could that work?
It supposed to be a payment of 1NZC9Pk4Rt1mVe5dL8w2fShXJppyJU7Vq8. The wallet has 2 address 1NZC9Pk4Rt1mVe5dL8w2fShXJppyJU7Vq8 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb then I used sendmany api function and that was the result. My implementation also invalidated it =) |
|
|
|
|
The transaction below has multiple inputs
5697c55a0fb5ee61f6e9c78cb9c84cef23e11c84c68cd6e2821b8869489b808c
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb (0.00006 BTC - Output) n=2
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb (0.00006 BTC - Output) n=2
1NZC9Pk4Rt1mVe5dL8w2fShXJppyJU7Vq8 (0.00009 BTC - Output) n=1
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb (0.00006 BTC - Output) n=2
Which one of the address will be the reference address?
|
|
|
|
Update: I was able to get into the wallet as long as I ignored the error. (posted above) In the wallet I get the error "Format of the initialization string does not conform to specification starting at index 0" I filled out my settings and followed the guide, I am not waiting for it to update as it now says "Getting Exodus Transactions..." I don't see any progress being made though? But it's only been a few minutes so I will give it some time. New error while wallet is running : http://pastebin.com/J4zTQvewStill stuck at "getting exodus transactions" The error means it is not connecting to the SQL 2008 express db. Click settings tab There is a field there connect string. If you know the connect strin to Mymastercoins.mdf you can enter it there, then restart the program. If you have ms SQL try to import the mymastercoin.mdf then enter you SQL connect string in the settings. (I should not have used SQL express 2008 will check if updating to SQL 2010 fixes the problem) |
|
|
|
I attempted to install as well, with sql express 2012, and can't be installed as well. (Using Win 7) Subscribed for more testing  Since you already have sql express installed, simply copy the files in the easyinstall folder https://github.com/Bitoy88/MyMastercoinsWalletBeta/Copy all files in the easyinstall folder to your a folder ex. c:\MyMastercoinsWallet Run c:\MyMastercoinsWallet\MyMastercoinsWallet.exe Please follow the link below for user's instructions. http://www.mymastercoins.com/MyMSCWallet.aspxHope this works  Have SQL and tried easy install - it says that there is no program associated to the executable file... I'm guessing it maybe has something with my SQL so i'll install 2008 express an try again... The exe program should just run. Can you post a screen shot. If you already have SQL, try to import the tables at mymastercoins.mdf. Then enter the connect string in the settings tab. |
|
|
|
I attempted to install as well, with sql express 2012, and can't be installed as well. (Using Win 7) Subscribed for more testing Since you already have sql express installed, simply copy the files in the easyinstall folder https://github.com/Bitoy88/MyMastercoinsWalletBeta/Copy all files in the easyinstall folder to your a folder ex. c:\MyMastercoinsWallet Run c:\MyMastercoinsWallet\MyMastercoinsWallet.exe Please follow the link below for user's instructions. http://www.mymastercoins.com/MyMSCWallet.aspxHope this works |
|
|
|
Windows based Mastercoins Wallet http://mymastercoins.com/MyMSCWallet.aspxMyMastercoins Wallet v 1.01.01 (12/18/2013) Added "Transaction Fee" field in Buy tab update "Send Payment" MyMastercoins Wallet v 1.01 Updated database to sql 2012 local db. Fixed bug with sending payment MyMastercoins Wallet v 1 Fixing the installation problem with the wallet. sql express 2008 can't be installed. |
|
|
|
Hi aTriz, If you are able to test it, please post your findings here. The contest also gives a prizes for testing |
|
|
|
MyMastercoins Wallet http://mymastercoins.com/MyMSCWallet.aspxPlease post here if you find any bugs. Thanks to Zathras for the send multisig Edit The package folder contains the windows installer. The source code in vb.net is also included (under folder source code) You can compile it in vs 2010. There is also an easyinstall folder. This contains the database and exe files. |
|
|
|
Hi Zathras, I've finished testing the wallet with your multisig encodetx and it worked. For the payment I used the sendmany api. Buy this might not work if a user has multiple MSC address (send many api requires an Account input not a specific address). So from the encodetx i'd like to make an encodepaymenttx. This is for sending payment to a Seller (after the buyer has Purchased a Sell Offer). Example Buyer wants to send 1 BTC to Seller Buyer is the fromadd Seller is the toadd SatAmount = 100000000 (Amount to send is Satoshi) txfee = 6000 (Dust to Exodus) changeamount = (fromtxamount) - (SatAmounttoPay + txfee) Is this correct (below is the code for your reference)? Thank you =) 'handle change
changeamount = (fromtxamount) - (SatAmounttoPay + txfee)
'build tx hex raw
txhex = "01000000" 'version
txhex = txhex & "01" 'vin count
txhex = txhex & txidtohex(fromtxid) 'input txid hex
txhex = txhex & i32tohex(fromtxvout) 'input vout 00000000
txhex = txhex & "00" 'scriptsig length
txhex = txhex & "ffffffff" 'sequence
txhex = txhex & "03" 'number of vouts,
'change output
txhex = txhex & i64tohex(changeamount) 'changeamount value
txhex = txhex & "19" 'length - 25 bytes
txhex = txhex & "76a914" & addresstopubkey(fromadd) & "88ac" 'change scriptpubkey
'exodus output
txhex = txhex & i64tohex(txfee)
txhex = txhex & "19"
txhex = txhex & "76a914946cb2e08075bcbaf157e47bcb67eb2b2339d24288ac" 'exodus scriptpubkey
'reference/destination output
txhex = txhex & i64tohex(SatAmounttoPay)
txhex = txhex & "19"
txhex = txhex & "76a914" & addresstopubkey(toadd) & "88ac" 'data scriptpubkey
|
|
|
|
Grats on getting that out in the wild! I was hoping to get this out next week just so that we can post tramsactions but the blockchain loading is really very slow (50 weeks to go Ouch. Did you not have too much luck running bitcoind over at AWS and making your RPC calls to bitcoind there for your initial testing? Please don't hesitate to let me know if you need help with this btw, anything to help with development speed Bitcoind in aws ran out of disk space (30 gb) so I have to buy more disk space and run it again. Once I have the full block chain ill test your codes to send multisig. If it works, next step is to release it in the wild with big disclaimer . How is your wallet implementation? I think you made a test msc purchase and it looks ok. Congrats ! |
|
|
|
Grats on getting that out in the wild! I was hoping to get this out next week just so that we can post tramsactions but the blockchain loading is really very slow (50 weeks to go |
|
|
|
I would say yes. It's basically free MSC for User B. Why not give it.
It's a side effect (given that its a good one for the buyer). But As Zathras pointed out it will create unintented micro transaction bloat. |
|
|
|
Thanks for your results Bitoy (Seriously was your username always Bitoy? I always read it as BitBoy, sorry about that.) they are very helpful.
Did we establish that Mastercoin messages that were send after an Purchase Offer has been opened couldn't be used as funds for such offers?
I don't like discriminating payments based on their possible intend, you are sending somebody funds, so why shouldn't these count? What do you guys think?
It's Bitoy. (Bitboy sounds good also Here is my 2 cents To keep it simple transactions should not be treated as payment. consider this example. 1. User A sends a sell offer 2. user B sends a purchase offer to User A 3. User B changes his mind and sends another purchase offer to User A Will transaction 3 be considered a payment for transaction 2? |
|
|
|
Here are the parsing results based on MyMastercoins v1.01 Valid Transactions Hash: 339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6, AmountBought: 9.39900000 MSC, PaymentTransactions: [66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745]
Hash: 4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99, AmountBought: 0.10100001 MSC, PaymentTransactions:[cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d]
Hash: baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b
Can't be accepted as payment because it is a transaction.
The transaction is invalid because
Seller 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj has no more coins for sale. (Seller still has 10 MSC available but it is reserved for another buyer at that time)
Date: 11/17/2013 4:03:10 PM
Invalid transactions. Hash: fffbde998c925d159c13020bb4e9c6d71cf1553e75624aeb174488102b7b0c0c, AmountBought: 0.00030000 MSC, PaymentTransactions: [7d4d70eac81d514e30ce8762434b91cd1d1650bf492779a3992bbd6f0c2043aa]
Note: 7d4d70eac81d514e30ce8762434b91cd1d1650bf492779a3992bbd6f0c2043aa is a purchase transaction not valid as payment.
Hash: 57e8880da36ca97456828900b66c4699617875c3826ce263ab9a2d7572fe0885, AmountBought: 0.00030000 MSC, PaymentTransactions: [23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4]
1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj has no more coins for sale. (Seller still has .5 MSC but it is already reserved for another Buyer)
|
|
|
|
339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6
invalid transaction
4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99
Invalid transaction
Why do you consider those invalid? I found a bug in my implementation. Will investigate this again and report asap. |
|
|
|
Let me put it in the following format for easier comparison: Payment offers and their attached data and bitcoin payments. Hash: fffbde998c925d159c13020bb4e9c6d71cf1553e75624aeb174488102b7b0c0c, AmountBought: 0.00030000 MSC, PaymentTransactions: [7d4d70eac81d514e30ce8762434b91cd1d1650bf492779a3992bbd6f0c2043aa]
Hash: 57e8880da36ca97456828900b66c4699617875c3826ce263ab9a2d7572fe0885, AmountBought: 0.00030000 MSC, PaymentTransactions: [23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4]
Hash: 339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6, AmountBought: 9.39900000 MSC, PaymentTransactions: [66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745]
Hash: baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b, AmountBought: 0.10130000 MSC, PaymentTransactions:[339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6, cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d]
Hash: 4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99, AmountBought: 0.10130000 MSC, PaymentTransactions:[cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d, baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b]
Here is my report. If it is wrong, please advise 23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4 Invalid Transaction. Date: 11/17/2013 9:21:12 PM Remarks: Seller 1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2 doesn't have enough MSC to send. 23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4 Invalid Transaction. Date: 11/17/2013 9:21:12 PM Remarks: Seller 1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2 doesn't have enough MSC to send. 66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745 Invalid Transaction. Date: 11/17/2013 5:44:30 PM Remarks: Buyer Payment: Purchase confirmation not found or payment time has expired. cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d, is a valid payment for baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b This is a purchase transaction not valid as payment 339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6 invalid transaction 4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99 Invalid transaction . |
|
|
|
|
Show Posts
