Bitcoin Forum
June 24, 2024, 09:04:30 AM *
News: Voting for pizza day contest
 
   Home   Help Search Login Register More  
Pages: « 1 2 [3]  All
  Print  
Author Topic: [ANN][LKY] Luckycoin Security Update  (Read 4259 times)
ghostlander
Legendary
*
Offline Offline

Activity: 1239
Merit: 1020


No surrender, no retreat, no regret.


View Profile WWW
November 21, 2013, 07:52:25 AM
 #41

Titan, that's good to see you know how to pull the code from the Feathercoin repository and to integrate it into your code base. I'm talking about Sunny King's commits on Advanced Checkpointing and network alerts as well as my fix of getnetworkhashps. Have you missed the licence under which the Advanced Checkpointing code has been included in Feathercoin? I'll remind you.

https://github.com/FeatherCoin/FeatherCoin/blob/master/src/checkpointsync.cpp

Code:
// Copyright (c) 2012-2013 PPCoin developers
// Copyright (c) 2013 Primecoin developers
//
// A perpetual use license of this advanced checkpoint technology is granted
// to feathercoin by Sunny King on behalf of PPCoin developers and Primecoin
// developers.
//
// Permission is hereby granted to any person obtaining a copy of the advanced
// checkpoint technology, for perpetual use in feathercoin network, including
// the rights to use, copy, modify, merge, publish, distribute, subject to the
// following conditions:
//
// a) This license is not transferrable, no sublicense, and applies to
//    feathercoin only.
// b) The above copyright notice and this permission notice shall be included
//    in all copies of source code distributions.
//
// Feathercoin is waived from displaying the above copyright notice in
// 'About' for the inclusion of advanced checkpoint technology. Reference
// in file 'COPYING' is appreciated but not required.

That's what you have put instead:

https://github.com/LuckyCoinFoundation/Luckycoin/blob/master/src/checkpointsync.cpp

Code:
// Copyright (c) 2009-2012 The Bitcoin developers
// Copyright (c) 2011-2013 The PPCoin developers
// Copyright (c) 2013 The Luckycoin developers
// Distributed under the MIT/X11 software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.

Not to mention the Bitcoin developers have nothing to do with synchronised checkpoints, but you have even added your copyright to the code where your only "contribution" is a pair of public keys. I doubt you have talked to Sunny King on this matter, so the whole thing is a theft in fact.

"If you've got a problem and have to spread some coins to make it go away, you've got no problem. You've got an expence." ~ Phoenixcoin (PXC) and Orbitcoin (ORB) and Halcyon (HAL)
Titan (OP)
Sr. Member
****
Offline Offline

Activity: 260
Merit: 250



View Profile
November 23, 2013, 04:15:20 AM
 #42

Dear ghostlander,

I have put a copyright notice regarding the PPCoin code prominently in the About box of Luckycoin client v0.9.9 and therefore removed the Feathercoin specific exemption notice from the source.
The original source of the checkpointing and alert code is definitely the PPCoin code base and therefore the PPCoin is mentioned in the About box. 

Copyright © 2009-2012 Bitcoin Developers           
Copyright © 2011-2012 Litecoin Developers           
Copyright © 2011-2013 PPCoin Developers           
Copyright © 2013 Luckycoin Developers

I have contacted Sunny King regarding the code integration.

Titan
Titan (OP)
Sr. Member
****
Offline Offline

Activity: 260
Merit: 250



View Profile
November 23, 2013, 04:18:33 AM
 #43

Response from Sunny King:

Hi Titan,

Typically the copyright notice and licensing text (MIT/X11) should also be included in the COPYING file in the source code.

Thanks for following open source ethics!

Best Regards,

Dear Sunny King,

I have integrated checkpointing and alert code that originates from the PPCoin code base into the Luckycoin client. I have added a copyright notice in the About box of the Luckycoin referring to PPCoin.

Copyright © 2009-2012 Bitcoin Developers              
Copyright © 2011-2012 Litecoin Developers              
Copyright © 2011-2013 PPCoin Developers              
Copyright © 2013 Luckycoin Developers

Is this sufficient from a legal point of view regarding the PPCoin code?

Source repository:
https://github.com/LuckyCoinFoundation/Luckycoin

Best regards,

Titan
Luckycoin Developer
Titan (OP)
Sr. Member
****
Offline Offline

Activity: 260
Merit: 250



View Profile
December 14, 2013, 04:34:39 AM
 #44



Dear Luckycoin community,

Please update your clients to the latest version Luckycoin v1.0.0 on Github.

Windows:
https://github.com/LuckyCoinFoundation/LuckycoinQT

Source:
https://github.com/LuckyCoinFoundation/Luckycoin

The new Luckycoin client v1.0.0 introduces a block rate limiter!

Please update your Luckycoin clients before block 95360!


Forum link: https://cryptocointalk.com/topic/2209-luckycoin-v100-security-update-block-rate-limiter/
 
Giveaway thread: https://cryptocointalk.com/topic/1786-luckycoin-giveaway-2-celebrating-luckycoin-block-88888/

Get Lucky,

Titan
Pages: « 1 2 [3]  All
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!