This is a bad move. Supporting a dictator such as Erdogan can bring no positives, especially at a time when he is trying to convert Turkey in to an Islamic Caliphate. Turkey has been a major rival of Russia for the past 700 years. And the situation is not going to change during the next 700 years as well.
There is more at play here, than western medias let on.
First, Turkey is 99% muslim country and has been for generations, since multiconfessional, multietnic empire that preceded it was torn apart by powers, that beat it back in a Great war. So rather than caliphate, Turkey is starting to reflect values of its people again after long period of time, when it was ruled by westernized globalists.
Gülenist coup, that was crashed after mere three days. What does that tell you? Gülen is pretty much Turkeys main proponent of Muslim brotherhood. HE is the islamist in this case, amusingly residing and directing his operations from behind safety of United States, that he got many years ago. The fact, that coup was done with so quickly despite tacit support of United States tells us two things. Secular military as whole refused to support islamists against elected government of Erdogan, despite the fact, that relationship between Sultan and military has been bad before. Second, Turkey have been warned from outside and prepared itself for islamist coup. Interestingly, soon after Russians and Turks, who until then were on a brink of war quickly resolved their differences and turned their eyes west...
That brings us to your last point. Yes, Russians and Turks and Iranians and Chinese have all been rivals. Fighting each other for the territory and power for centuries. What makes life long enemies amend their past and join forces?
Common threat.
Unlike globalists - coutries mentioned above do not have luxury of endless money printing. They have their own trump cards, however. Unlike western civilization, they havent left behind values that formed their culture. It is still alive. In a conflict they can rely on a God, on legacy of their ancestors, on patriotic frenzy and on culture, that promotes large families.
Euroasia is turning into natural obstacle to New World Order and Turkey is now joining its ranks.
Just my two cents.