|
r3wt
|
 |
March 28, 2015, 09:51:04 PM |
|
Based on the quality of code of your linked repo, i seriously doubt you have 10 years experience in any of the languages you mention.
lets look at the css in style.css:
- * {} should be used to set all block level elements box-sizing to border-box
-no usage of shorthand attribute arguments. you set padding-left,padding-right, etc manually on .bodyHeader
-vendor prefixing border radius. its 2015, you'd be hard pressed to find a browser that doesn't support the border-radius property.
lets look at the php index.php:
-using @ for error suppression.
-for some reason you have chose to prefix your variable names with `var`. why? we already know its a var, thats what the $ symbol means.
-in $varAverageArray, you are manually defining the keys, when when they default to numeric anyway. not sure why.
lets look at the html in index.php
- .exchangesDiv has no closing tag
lets look at the javascript in index.php
- 3 separate script tags are used for inline scripts. 1 for each conversion function and 1 for instantiation of the jQuery autogrow plugin.
- echoing php values directly into your function.
- poorly devised functions. should have constructed an object with the currency type to store the values for each currency, and use the currency name as the key to access the values. then you would not need that lengthy if else loop at all.
- loading ancient version of jQuery(1.11.2) tells me you probably don't know much about jQuery or don't understand your target market well. paired with the css properties you used, i can make an educated guess that you don't plan on supporting old versions of Internet Explorer, so logically you should have included the jQuery 2.x library instead.
|
