Bounty for CPFP Enabled Wallet

[d4n13]

CPFP (Child Pays for Parent) Bounty
3FEUByMeaxrNmBCVYjvsnhyAjiUdat5i7M

Anyone who can put a CPFP transaction creation feature into any wallet featured on the bitcoin homepage can claim this bounty.  

I outlined the basic idea of the bounty in this BIP proposal before I was educated on CPFP.

To claim the bounty / pizza you will need to convince the following holders of the multisig

• Me
• theymos
• kcud_dab

Rules:

• Must be a wallet featured on the bitcoin homepage
• Must be either accepted into primary build branch of (1), or available in an official release / beta / dev build of (1)

References:

• My old BIP proposal
• My "reference" implementation using Bitcoin-RPC and Python
• CPFP thread on dev-bitcoin
• Bounty fundraising campaign thread
• Bounty fundraising mempool lifeguard service
• RBF (different technique) thread
  

[1538087943]

1538087943

[1538087943]

1538087943

[Andreas Schildbach]

We're already working on getting child-pays-for-parent into Bitcoin Wallet. The branch is here: https://github.com/schildbach/bitcoin-wallet/commits/fee-cpfp

It's still a bit rough and needs work. The biggest missing part is PIN entry, so you currently need to unset your PIN before raising the fee.

Any code review is appreciated.

[d4n13]

We're already working on getting child-pays-for-parent into Bitcoin Wallet. The branch is here: https://github.com/schildbach/bitcoin-wallet/commits/fee-cpfp

It's still a bit rough and needs work. The biggest missing part is PIN entry, so you currently need to unset your PIN before raising the fee.

Any code review is appreciated.

Wow... fantastic news.... I'll be happy to look at it...

Setting up an android build server will take a bit.  If no one beats me too it, I'll try to post a testnet build from the branch... expect it to take a while.

[achow101]

Does the CPFP patch have to make it into the stable build released by the developers of the wallets or can it just be a patch that you apply yourself?

[d4n13]

Does the CPFP patch have to make it into the stable build released by the developers of the wallets or can it just be a patch that you apply yourself?

I added a rules section to OP

Rules:

• Must be a wallet featured on the bitcoin homepage
• Must be either accepted into primary build branch of (1), or available in a production / beta / dev build of (1)

[Andreas Schildbach]

I just updated our branch so that it supports encrypted wallets (spending PIN).

[Andreas Schildbach]

The feature is now finished, merged and starts to roll out to 10% of users.

If you feel like skipping the queue you can download directly from here:

https://github.com/schildbach/bitcoin-wallet/releases/tag/v4.37

[d4n13]

The feature is now finished, merged and starts to roll out to 10% of users.

If you feel like skipping the queue you can download directly from here:

https://github.com/schildbach/bitcoin-wallet/releases/tag/v4.37

All over it... Thx... I assume the "test" is testnet.

[d4n13]

The feature is now finished, merged and starts to roll out to 10% of users.

If you feel like skipping the queue you can download directly from here:

https://github.com/schildbach/bitcoin-wallet/releases/tag/v4.37

Awarded
to Andreas Schildbach

congrats!
https://blockchain.info/tx/8ec943be37e8e45ba60e0c3ae82323cade5e084b25e9154714e86a5d80a1a44b

[unamis76]

Good news that this has been implemented... However I don't use the software in which it was Hoping this at least makes it to the Core wallet.

[arnuschky]

A bit OT, but which other nodes/wallets implement CPFP already out-of-the-box?

[brianddk]

A bit OT, but which other nodes/wallets implement CPFP already out-of-the-box?

Only Android Bitcoin-Wallet...

No others that I've seen, which is why it won the bounty.

[voisine]

We included CPFP in breadwallet a few months back (two months before the bounty was created) for when the user spends unconfirmed non-change inputs. Happy to let the bounty go to Andreas though. Andreas and co. are doing good work.

https://github.com/voisine/breadwallet/blob/v0.5.1/BreadWallet/BRWallet.m#L382

[unamis76]

We included CPFP in breadwallet a few months back (two months before the bounty was created) for when the user spends unconfirmed non-change inputs. Happy to let the bounty go to Andreas though. Andreas and co. are doing good work.

https://github.com/voisine/breadwallet/blob/v0.5.1/BreadWallet/BRWallet.m#L382

Wasn't aware that one of my favorite wallets already had it Nice job. It will probably come in handy some day