0.94 preliminary testing phase

[goatpig]

Build error:

fixed

Does armoryd indicate if the transaction is RBF? Or is it just GUI right now?

only the GUI

[achow101]

Build error:

fixed

Does armoryd indicate if the transaction is RBF? Or is it just GUI right now?

only the GUI

Great. Testing it now.

Also, I used to be able to double click an address in my wallet for more details but it seems that I can't do that now.

[goatpig]

Also, I used to be able to double click an address in my wallet for more details but it seems that I can't do that now.

Fixed.

Ima delay the testing build release for as long it will take me to go over the changes in the cleanupATI branch and merge it in. I'd rather figure out the due diligence before putting out binaries.

[droark]

Edit: Build error:

Interesting. I just built the latest version without any problems. What's your platform?

That said, I wasn't able to send coins on the latest version.

Code:

Traceback (most recent call last):
  File "/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/ui/TxFrames.py", line 826, in createTxAndBroadcast
    self.main.broadcastTransaction(finalTx)
  File "/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/ArmoryQt.py", line 3746, in broadcastTransaction
    LOGPPRINT(pytx, logging.INFO)
  File "/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/armoryengine/ArmoryUtils.py", line 871, in LOGPPRINT
    theObj.pprint()
  File "/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/armoryengine/Transaction.py", line 744, in pprint
    if self.optInRBF:
AttributeError: 'PyTx' object has no attribute 'optInRBF'

Had to comment out that line and the previous one. At that point, everything went through.

[achow101]

Edit: Build error:

Interesting. I just built the latest version without any problems. What's your platform?

It's fixed on the latest version. I'm on Ubuntu 15.10

[goatpig]

Merged in knightdk's changes around the ATI references and turning off the phone home code. Give it a spin, try to find broken dialogs (although I think I got them all). I'll be traveling tomorrow so the testing builds will have to wait for Thursday/Friday.

[achow101]

Merged in knightdk's changes around the ATI references and turning off the phone home code. Give it a spin, try to find broken dialogs (although I think I got them all). I'll be traveling tomorrow so the testing builds will have to wait for Thursday/Friday.

What about the links to bitcoinarmory.com like those on the dashboard when armory is offline? What should be done about those?

Edit: Also, I am unable to open the Lockboxes and the Address Book dialogs.

[goatpig]

Also, I am unable to open the Lockboxes and the Address Book dialogs.

Fixed the lockbox issue, can't reproduce the address book one. Do you have some Python error in your terminal when that happens?

What about the links to bitcoinarmory.com like those on the dashboard when armory is offline? What should be done about those?

Comment them out. Just PR to dev if you have minor changes.

[achow101]

Also, I am unable to open the Lockboxes and the Address Book dialogs.

Fixed the lockbox issue, can't reproduce the address book one. Do you have some Python error in your terminal when that happens?

Yeah, I get this error:

Code:

(ERROR) Traceback (most recent call last):
  File "/home/andy/bitcoin/armory/BitcoinArmory/ArmoryQt.py", line 3900, in execAddressBook
    DlgAddressBook(self, self, None, None, None).exec_()
  File "/home/andy/bitcoin/armory/BitcoinArmory/qtdialogs.py", line 8073, in __init__
    rowHeight = tightSizeStr(self.font, 'XygjpHI')[1]
  File "/home/andy/bitcoin/armory/BitcoinArmory/qtdefines.py", line 215, in tightSizeStr
    fm = QFontMetricsF(QFont(obj))
TypeError: QFont(): argument 1 has unexpected type 'builtin_function_or_method'

Traceback (most recent call last):
  File "/home/andy/bitcoin/armory/BitcoinArmory/ArmoryQt.py", line 3900, in execAddressBook
    DlgAddressBook(self, self, None, None, None).exec_()
  File "/home/andy/bitcoin/armory/BitcoinArmory/qtdialogs.py", line 8073, in __init__
    rowHeight = tightSizeStr(self.font, 'XygjpHI')[1]
  File "/home/andy/bitcoin/armory/BitcoinArmory/qtdefines.py", line 215, in tightSizeStr
    fm = QFontMetricsF(QFont(obj))
TypeError: QFont(): argument 1 has unexpected type 'builtin_function_or_method'

What about the links to bitcoinarmory.com like those on the dashboard when armory is offline? What should be done about those?

Comment them out. Just PR to dev if you have minor changes.

Alright, will do that shortly.

[goatpig]

Yeah, I get this error:

That's pretty severe, I should get this error too but I can't reproduce it. Anyone else running into this? Can you git stash git pull and try again?

[achow101]

Yeah, I get this error:

That's pretty severe, I should get this error too but I can't reproduce it. Anyone else running into this? Can you git stash git pull and try again?

Same error. Nothing was stashed and nothing was pulled.

[goatpig]

Same error. Nothing was stashed and nothing was pulled.

The part of the code that is failing has not been changed in over 2 years. If you are getting this error now you should be getting it with other versions. Start 0.93 offline and try.