[ETH] PiggyBank - Earn Ethereum Forever!

[alani123]

FYI, the code on this seems broken. Also OP didn't mention the fee he gets.

[1715038705]

1715038705

[1715038705]

1715038705

[1715038705]

1715038705

[Coconuter]

It says that the Contract of the 3% that was sent to me was cancelled....  Either way many others have signed after me and i should have received 3% each investor right ?  so its not working...

[DoctorBugsBunny]

GUYS! Do not invest in this until op answers why this address is taking most of the profit funds from the contract:

Address: 0xf303bde76a36411b7c0459efdd2e5f7069964203

That address has only deposited 0.51 Ether, and it's receiving mostly all the profits from the contract.

 
Here's the etherscan website to check it out yourself. OP can you explain this?

https://etherscan.io/address/0xf303bde76a36411b7c0459efdd2e5f7069964203#internaltx

[Polly Stripe]

GUYS! Do not invest in this until op answers why this address is taking most of the profit funds from the contract:

Address: 0xf303bde76a36411b7c0459efdd2e5f7069964203

That address has only deposited 0.51 Ether, and it's receiving mostly all the profits from the contract.

 
Here's the etherscan website to check it out yourself. OP can you explain this?

https://etherscan.io/address/0xf303bde76a36411b7c0459efdd2e5f7069964203#internaltx

Finally it's someone had seen. Guys is better to use proven doublers

Small queue, tested code, honest developers.


http://rubixi.wix.com/hello

http://eth-eth.com/

http://double-ethe.rhcloud.com/

http://protect-the-castle.ether-contract.org/

[contractcoordinator]

trying to use this as an example to learn how contracts work.

I believe i've identified the problem in the contract, but i would love to hear from someone who actually knows.


I think the problem is this line:

Code:

                while (balance > investors[k].amount * 3 / 100 && k < total_inv) //exit condition to avoid infinite loop

total_inv is always going to be 0.

so this basically never runs. the only investor that is paid is at id 0, the first investor. ie: the owner.

Can someone else confirm?

[noobhelper178]

trying to use this as an example to learn how contracts work.

I believe i've identified the problem in the contract, but i would love to hear from someone who actually knows.


I think the problem is this line:

Code:

                while (balance > investors[k].amount * 3 / 100 && k < total_inv) //exit condition to avoid infinite loop

total_inv is always going to be 0.

so this basically never runs. the only investor that is paid is at id 0, the first investor. ie: the owner.

Can someone else confirm?

Thats nonsense, you cant read the code, the total_inv is set to the lenght of the investors array, which is scaling after each contract execution by +1.

Read it again:

contract PiggyBank {

  struct InvestorArray {
      address etherAddress;
      uint amount;
  }

  InvestorArray[] public investors;

  uint public k = 0;
  uint public fees;
  uint public balance = 0;
  address public owner;

  // simple single-sig function modifier
  modifier onlyowner { if (msg.sender == owner) _ }

  // this function is executed at initialization and sets the owner of the contract
  function PiggyBank() {
    owner = msg.sender;
  }

  // fallback function - simple transactions trigger this
  function() {
    enter();
  }
  
  function enter() {
    if (msg.value < 50 finney) {
        msg.sender.send(msg.value);
        return;
    }
   
    uint amount=msg.value;


    // add a new participant to array
   uint total_inv = investors.length;
   investors.length += 1;
    investors[total_inv].etherAddress = msg.sender;
    investors[total_inv].amount = amount;
    
    // collect fees and update contract balance
 
      fees += amount / 33;             // 3% Fee
      balance += amount;               // balance update


     if (fees != 0)
     {
        if(balance>fees)
   {
         owner.send(fees);
         balance -= fees;                 //balance update
   }
     }
 

   // 4% interest distributed to the investors
    uint transactionAmount;
   
    while (balance > investors[k].amount * 3/100 && k<total_inv)  //exit condition to avoid infinite loop
    {
    
     if(k%25==0 &&  balance > investors[k].amount * 9/100)
     {
      transactionAmount = investors[k].amount * 9/100;  
      investors[k].etherAddress.send(transactionAmount);
      balance -= investors[k].amount * 9/100;                      //balance update
      }
     else
     {
      transactionAmount = investors[k].amount *3/100;  
      investors[k].etherAddress.send(transactionAmount);
      balance -= investors[k].amount *3/100;                         //balance update
      }
      
      k += 1;
    }
    
    //----------------end enter
  }



  function setOwner(address new_owner) onlyowner {
      owner = new_owner;
  }
}

[Coconuter]

noobhelper178, i msg you so how come i invested 16hours agoo and the only 3% sent to my wallet got Contract Cancelled ?  If the ether address received my fund it should return the investment....


ANd whyAddress: 0xf303bde76a36411b7c0459efdd2e5f7069964203   is receiving 99% of the deposited ether?

[contractcoordinator]

so the reason more people are not getting paid is because most of the money is being paid to the owner in fees?

0xf303bde76a36411b7c0459efdd2e5f7069964203

https://etherscan.io/address/0xf303bde76a36411b7c0459efdd2e5f7069964203#internaltx

Code:

                fees += amount / 33; // 3% Fee
                balance += amount; // balance update


                if (fees != 0) {
                        if (balance > fees) {
                                owner.send(fees);
                                balance -= fees; //balance update
                        }
                }

what's left goes to the first few investors, then amount becomes too low and stops the loop, making later investors get nothing?

is amount/33 really 3%?

Just trying to understand how this all works.

[DoctorBugsBunny]

so the reason more people are not getting paid is because most of the money is being paid to the owner in fees?

0xf303bde76a36411b7c0459efdd2e5f7069964203

https://etherscan.io/address/0xf303bde76a36411b7c0459efdd2e5f7069964203#internaltx

Code:

                fees += amount / 33; // 3% Fee
                balance += amount; // balance update


                if (fees != 0) {
                        if (balance > fees) {
                                owner.send(fees);
                                balance -= fees; //balance update
                        }
                }

what's left goes to the first few investors, then amount becomes too low and stops the loop, making later investors get nothing?

is amount/33 really 3%?

Just trying to understand how this all works.

Is there a way to edit the contract?

[Coconuter]

Doc, that should be an option to reset contracts like these and refund all transactions once proven its a scam... 

Only by asking every wallet involved if they want to reset, within a certain % agrees it should proceed and refund...

Since ethereum are SMART contracts this should be a option and would bring more safety to users...

[DoctorBugsBunny]

Doc, that should be an option to reset contracts like these and refund all transactions once proven its a scam...  

Only by asking every wallet involved if they want to reset, within a certain % agrees it should proceed and refund...

Since ethereum are SMART contracts this should be a option and would bring more safety to users...

I totally agree, if there was a way to edit/reset contracts, I believe there would be less scams.

I just lost about roughly 64 Ether.  

[Coconuter]

I lost a bit also!!!

Dont worry theres a thing kalled KARMA in life...

He got 295Ether but life will take 600 ether from him in different events in his life!

Since most of the ether are all stored in one account it would be nice to retrive them tho, or even block it from using it...

[newrad]

Wow can't believe I got scammed out of my Eth, and I actually defended this guy.  I'm poor and can barely afford food, thanks a lot.



If this is an honest mistake in your coding, refund those who lost, and redo the Piggybank contract. Simple as that.
You'll make more money in the long run being honest than running off with our crumbs.

[noobhelper178]

noobhelper178, i msg you so how come i invested 16hours agoo and the only 3% sent to my wallet got Contract Cancelled ?  If the ether address received my fund it should return the investment....


ANd whyAddress: 0xf303bde76a36411b7c0459efdd2e5f7069964203   is receiving 99% of the deposited ether?

you probably sent too small gas, try again with higher gas

what's left goes to the first few investors, then amount becomes too low and stops the loop, making later investors get nothing?

is amount/33 really 3%?

Just trying to understand how this all works.

no, first me and the investors get paid, but everyone in the loop gets paid, by the order they invested

the balance currently is low, so that is why later investors will get delayed payments, but after the balance gets high, they will get paid

Is there a way to edit the contract?

if there would be then it would not be transparent

Doc, that should be an option to reset contracts like these and refund all transactions once proven its a scam... 

Only by asking every wallet involved if they want to reset, within a certain % agrees it should proceed and refund...

Since ethereum are SMART contracts this should be a option and would bring more safety to users...

it's open source ffs, how can it be a scam?

you can see the code right there

[noobhelper178]

I totally agree, if there was a way to edit/reset contracts, I believe there would be less scams.

I just lost about roughly 64 Ether. 

you didnt lost it, you will earn eth after more people invest

Wow can't believe I got scammed out of my Eth, and I actually defended this guy.  I'm poor and can barely afford food, thanks a lot.

you didnt got scammed, you will be paid out after more people join


Seriously guys, this contract lives on the blockchain forever, so just wait a few hours and days and everyone will be paid.

The faster you invested the faster you will get paid, but after some time everyone will be!


Just make sure you dont throw away your current address, and then just wait, everyone will be paid!!!

[newrad]

Well maybe it's not a scam.... I'll wait a few days and see what happens before I jump to conclusions.

This is a great idea, I just hope the coding is 100% right, and people continue to participate.




I'll keep everyone updated.

[Coconuter]

noobhelper178,

the thing is that most of Ether are going to only one wallet 'https://etherscan.io/address/0xf303bde76a36411b7c0459efdd2e5f7069964203' and not coming out of it.... So your fee is like 90% of deposited ether.... As you can see people deposited allot and almost all went to that wallet wich only invested 0.5ether, and not to other investors... So only one account 'yours' is profiting...  Why is that ?

And after i sent the ether 18hours agoo the contract tried to pay me 3% but the contract got canceled so i didnt even received the first 3%...

After my deposit we had over 30-50 new deposits in wich your claim is that each deposit investors would receive 3% wich isnt happening

i Messaged you the contract that was suppose to pay me 3% and got canceled, and got no response.

The main thing is that all the ether is going out to 0xf303bde76a36411b7c0459efdd2e5f7069964203  and not to other investors...

[BetGod]

I totally agree, if there was a way to edit/reset contracts, I believe there would be less scams.

I just lost about roughly 64 Ether. 

you didnt lost it, you will earn eth after more people invest

Wow can't believe I got scammed out of my Eth, and I actually defended this guy.  I'm poor and can barely afford food, thanks a lot.

you didnt got scammed, you will be paid out after more people join


Seriously guys, this contract lives on the blockchain forever, so just wait a few hours and days and everyone will be paid.

The faster you invested the faster you will get paid, but after some time everyone will be!


Just make sure you dont throw away your current address, and then just wait, everyone will be paid!!!

i believe ya, i already got paid 10+ times since i deposited hours ago

the money just comes to my address automatically, so it works, and i`m very happy

[BetGod]

Well maybe it's not a scam.... I'll wait a few days and see what happens before I jump to conclusions.

yea, i already got paid many times

so as the OP said, the contract is uploaded there forever, so i think the money will come automatically just like it does to me after a while.

maybe wait a few hours, because there are many participants already so it may be some delay, but the system is there forever so you have nothing to lose by just waiting a bit more

[DoctorBugsBunny]

noobhelper178, i msg you so how come i invested 16hours agoo and the only 3% sent to my wallet got Contract Cancelled ?  If the ether address received my fund it should return the investment....


ANd whyAddress: 0xf303bde76a36411b7c0459efdd2e5f7069964203   is receiving 99% of the deposited ether?

you probably sent too small gas, try again with higher gas

what's left goes to the first few investors, then amount becomes too low and stops the loop, making later investors get nothing?

is amount/33 really 3%?

Just trying to understand how this all works.

no, first me and the investors get paid, but everyone in the loop gets paid, by the order they invested

the balance currently is low, so that is why later investors will get delayed payments, but after the balance gets high, they will get paid

Is there a way to edit the contract?

if there would be then it would not be transparent

Doc, that should be an option to reset contracts like these and refund all transactions once proven its a scam... 

Only by asking every wallet involved if they want to reset, within a certain % agrees it should proceed and refund...

Since ethereum are SMART contracts this should be a option and would bring more safety to users...

it's open source ffs, how can it be a scam?

you can see the code right there

Well, if it's you and the investors getting paid why didn't you include that in the beginning?

Also, the profit only goes to one account, which is the owner of the contract, which I believe is you.

You state to review the code, but people have reviewed the code, as stated in previous comments, and prove the code is broken.

To be frank man, do everyone a huge solid, return their funds, redo the contract from scratch, have someone else review it other than yourself, and earn some eth the correct way.