|
Sileniced
Newbie
Offline
Activity: 42
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 03:09:33 PM Last edit: April 12, 2016, 06:52:40 PM by Sileniced |
|
Heeeey BetGod... You mastermind you ![Wink](https://bitcointalk.org/Smileys/default/wink.gif) 4/12/2016 gkucmierz has updated his website to reflect the below warning. !WARNING!Code in question: // calculate ROI based on investor value function calculateROI() internal returns (uint8) { if (msg.value <= 1 ether) return 110; // 110% if (msg.value <= 10 ether) return 120; // 120% if (msg.value <= 100 ether) return 130; // 130% return 0; } gkucmierz does not mention here that anything above 100 ether does not count as an investmenthttp://imgur.com/Zu4crlx - 4/12/2016 TESTING CONTRACT: http://etherscan.io/address/0x49C3019b7A83B3c77A823255533975969027308D#codeIn this testing contract 4 finney acts like inputs above 100 ether. It does not show in the mist browser that the input of 4 finney has any days left of pay out http://imgur.com/tIT6vk2
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 03:11:54 PM |
|
Heeeey BetGod... You mastermind you ![Wink](https://bitcointalk.org/Smileys/default/wink.gif) what? ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif)
|
|
|
|
Sileniced
Newbie
Offline
Activity: 42
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 03:22:21 PM |
|
I'm just kidding, don't worry. Your code seems interesting. Do you have an address where I can see that you have tested it yourself? A testing contract?
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 03:24:39 PM |
|
I'm just kidding, don't worry. Your code seems interesting. Do you have an address where I can see that you have tested it yourself? A testing contract?
Unfortunately no This is test battlefield ![Wink](https://bitcointalk.org/Smileys/default/wink.gif)
|
|
|
|
Sileniced
Newbie
Offline
Activity: 42
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 03:54:22 PM |
|
I'm just kidding, don't worry. Your code seems interesting. Do you have an address where I can see that you have tested it yourself? A testing contract?
Unfortunately no This is test battlefield ![Wink](https://bitcointalk.org/Smileys/default/wink.gif) So you're basically giving others incentives to deploy your code themselves to test it out on their own.
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 03:58:45 PM |
|
So you're basically giving others incentives to deploy your code themselves to test it out on their own.
My mind is like turing machine. I was testing whole code few times in my mind and thats is enough for such simple contract ![Roll Eyes](https://bitcointalk.org/Smileys/default/rolleyes.gif)
|
|
|
|
Sileniced
Newbie
Offline
Activity: 42
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 04:01:18 PM |
|
So you're basically giving others incentives to deploy your code themselves to test it out on their own.
My mind is like turing machine. I was testing whole code few times in my mind and thats is enough for such simple contract ![Roll Eyes](https://bitcointalk.org/Smileys/default/rolleyes.gif) I will definitely count that as empirical truth... /sarcasm I will test your contract and post results here. If anyone has arguments to stop me from doing this. Now is your time. EDIT: I don't even know how lol. I can deploy three contracts.. Which one should I deploy? Is it the last one because that would trigger the others?
|
|
|
|
Tdecha
Newbie
Offline
Activity: 28
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 04:05:14 PM |
|
So you're basically giving others incentives to deploy your code themselves to test it out on their own.
My mind is like turing machine. I was testing whole code few times in my mind and thats is enough for such simple contract ![Roll Eyes](https://bitcointalk.org/Smileys/default/rolleyes.gif) I will definitely count that as empirical truth... /sarcasm I will test your contract and post results here. If anyone has arguments to stop me from doing this. Now is your time. Don't
|
|
|
|
Katatsuki
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 04:10:40 PM |
|
So you're basically giving others incentives to deploy your code themselves to test it out on their own.
My mind is like turing machine. I was testing whole code few times in my mind and thats is enough for such simple contract ![Roll Eyes](https://bitcointalk.org/Smileys/default/rolleyes.gif) As a developer, that's pretty hilarious to read. No matter how simple the project or how smart the developer, testing and re-testing are always a must.
|
|
|
|
Sileniced
Newbie
Offline
Activity: 42
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 04:11:40 PM |
|
I will definitely count that as empirical truth... /sarcasm
I will test your contract and post results here.
If anyone has arguments to stop me from doing this. Now is your time.
Don't Not an argument. EDIT: I don't even know how lol. I can deploy three contracts.. Which one should I deploy? Is it the last one because that would trigger the others?
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 04:35:48 PM |
|
I will definitely count that as empirical truth... /sarcasm
I will test your contract and post results here.
If anyone has arguments to stop me from doing this. Now is your time.
Don't Not an argument. EDIT: I don't even know how lol. I can deploy three contracts.. Which one should I deploy? Is it the last one because that would trigger the others? Thats right. You should deploy last contract. I needed to ask crew from etherscan.io to provide that functionality in contract validation tool.
|
|
|
|
Sileniced
Newbie
Offline
Activity: 42
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 05:29:14 PM Last edit: April 12, 2016, 06:06:39 PM by Sileniced |
|
Thank you for your reply gkucmierz. Let's put your turing mind to the test shall we ![Wink](https://bitcointalk.org/Smileys/default/wink.gif) ? I've changed the parameters of the contract minimum of 1 finney to a maximum of 4 finney. disables fees as well. 4 finney (above 100 eth in real contract) == 0 days of payout?? <- I don't understand why you have that in there in function calculateROI 1 finney == 110 days of payout 2 finney == 120 days of payout 3 finney == 130 days of payout What happens in your actual contract when I put in less then 1 ether? ROI returns 0? so then I have 0 days left in leftPayDays? But I can see that it does work in your invoked transactions. Can you explain how this works exactly? And I've added a currentOwner.send(this.balance) And to do that I had to change uint balance to uint balanc Also next time it's proper manners to use EDIT: I've also added some more uint public about stuff I'm generally curious for
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 05:40:25 PM |
|
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 06:37:17 PM |
|
Heeeey BetGod... You mastermind you !WARNING SUSPICIOUS CODE!Code in question: // calculate ROI based on investor value function calculateROI() internal returns (uint8) { if (msg.value <= 1 ether) return 110; // 110% if (msg.value <= 10 ether) return 120; // 120% if (msg.value <= 100 ether) return 130; // 130% return 0; } I am not trying to hide it. It is very clear visible in code. If your investment is 100 ether + 1 wei or more than your ROI => 0 This is limit which is here to not block whole system too early and let it work for months. EDIT: I did updated the page to make it clear -> http://jsfiddle.net/ju0bss7f/9/embedded/result/
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 06:49:14 PM |
|
What happens in your actual contract when I put in less then 1 ether?
In answer to your question it is very clear visible in code: http://imgur.com/Avka2zYIf your deposit is less than 100 finney than contract will produce error and your deposit wil never happen. 4/12/2016 gkucmierz has updated his website to reflect the below warning.
Thank you for being so suspicious. I appreciate your work man ![Smiley](https://bitcointalk.org/Smileys/default/smiley.gif)
|
|
|
|
Katatsuki
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 12, 2016, 07:50:26 PM |
|
Oh, so if the deposit is more than 100 ethers the person loses all the money, and said money is used to pay everyone else. That seems perfectly reasonable. NOT. What the fuck, people? How do you dare to release shit like this?
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 13, 2016, 01:49:15 PM |
|
Oh, so if the deposit is more than 100 ethers the person loses all the money, and said money is used to pay everyone else. That seems perfectly reasonable. NOT. What the fuck, people? How do you dare to release shit like this?
If user is dumb and cant understand this rule (max limit), than in fact its real problem. After all this feature is giving users possibility to support this contract.
|
|
|
|
askolein
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 70
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 13, 2016, 05:52:18 PM |
|
Oh, so if the deposit is more than 100 ethers the person loses all the money, and said money is used to pay everyone else. That seems perfectly reasonable. NOT. What the fuck, people? How do you dare to release shit like this?
If user is dumb and cant understand this rule (max limit), than in fact its real problem. After all this feature is giving users possibility to support this contract. So you don't know that you can refund the surplus ? Or you just don't care, 100 eth is a lot.. Such code is not secure, shame !
|
|
|
|
gkucmierz (OP)
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 60
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
April 29, 2017, 04:44:23 AM |
|
It is funny. On this contract there are still 30 ETH and nobody takes it. It is still possible to take part of them cause there was first bonus transaction.
|
|
|
|
|