Bitcoin Peak

[runeks]

How do you even know that $35 is not infact the correct price ?

Does the data contain any trades between 31.9099 and 35.0000? If not, I'd say it's pretty certain to be an error. The price jumping from 31.9099 to 35.0000 and then back again to no more than 31.9099 I'd say is highly unlikely. It would basically mean a complete absence of any asks from 31.9099 and up to 35.0000, and and a buyer entering at least $35 as his purchase price (I don't think market orders were implemented on Mt. Gox at that time).

[1715083116]

1715083116

[1715083116]

1715083116

[1715083116]

1715083116

[ripper234]

Your statement that the code is bugged is untrue and dishonest. The code is available for peer review on http://bitcoin.gdsl.no/bitpeak.zip. It does return $35 as the peak price as this is the data returned by http://blockchain.info/.

It might be untrue, I haven't actually ran your PHP code, but it's not dishonest - if anything it's an honest mistake.
The reason I wrote that it returns $35 is because my code based on the exact same algorithm and returns $35.
Now, before you go accusing me of bugs in my own code ... the bug is actually in blockchain.info's data ... one of the entries it returns is has price 35, which needs to be manually ignored.

How do you even know that $35 is not infact the correct price ?

Everybody involved with Bitcoins knows that the price was never over $32.

If you disagree with the blockchain.info market data I suggest you take it up with them.

I see your attack on the code quality as an attack on me in a pathethic attempt to save face.

I will update https://bitcointalk.org/index.php?topic=147308.0 with payment recived. I will however keep the recomendation not to bid on your offers.

You know, in software development you can do two things.
A) You can keep the letter of your contracts, and stick to them ... even if you know there are bugs, or the client asked for the wrong thing.
B) Or, you can try actually be helpful to your client, work around 3rd bugs instead of laying blame, and working with clients to improve the spec if needed.

You seem to choose the first approach - good luck with that.
Please don't hesitate not to bid on my offers in the future ... no need to remain angry ... I am not angry with you, as you did save me a bit of time (I could have gotten the same by asking a question on bitcoin.stackexchange for free, but I didn't, and here we are). I hope you're not angry with me, but if you are it's your problem, not mine.

Cheers.

[ripper234]

How do you even know that $35 is not infact the correct price ?

Does the data contain any trades between 31.9099 and 35.0000? If not, I'd say it's pretty certain to be an error. The price jumping from 31.9099 to 35.0000 and then back again to no more than 31.9099 I'd say is highly unlikely. It would basically mean a complete absence of any asks from 31.9099 and up to 35.0000, and and a buyer entering at least $35 as his purchase price (I don't think market orders were implemented on Mt. Gox at that time).

Come on. An easier answer is "it is known". Nobody ever wrote anywhere that bitcoin went above $32.
Another hint is the exact round price of 35.0000 ... the price is never round.

I needed the peak of the bitcoin price, not the peak of the "bitcoin price as returned by blockchain.info".

[ineededausername]

the site isn't working...

[ripper234]

the site isn't working...

Yeah I know, another bug in the original algorithm, see discussion above about delivering a working product.

The bug is due to reliance on blockchain.info API that only updates once a day (I hope it doesn't update less than once a day!)
This will cause both a delay in the results and inaccurate results.

The API should be switched to something like Mt. Gox API. Maybe this weekend?
I'll post it once it's done.

[Meni Rosenfeld]

Thread discussing new all-time high: https://bitcointalk.org/index.php?topic=147475

[gdsl]

The bug is due to reliance on blockchain.info API that only updates once a day (I hope it doesn't update less than once a day!)
This will cause both a delay in the results and inaccurate results.

The API should be switched to something like Mt. Gox API. Maybe this weekend?
I'll post it once it's done.

I agree. The blockchain update rate is too slow for my code to have any real use.

I will update the code to add bitcoincharts and mtgox as data sourses.

[gdsl]

Done.

New version with support for bitcoincharts and mtgox is available from http://bitcoin.gdsl.no/bitpeak.zip.

[ripper234]

the site isn't working...

Fixed.

Done.

New version with support for bitcoincharts and mtgox is available from http://bitcoin.gdsl.no/bitpeak.zip.

Pro tip: learn and start using github. zips are so 1990.

[Cyberdyne]

Could someone please explain why bitcoinpeak.org says $112.25 and not ~$266?

I mean, it's obviously only taking the last X days into account, but what is the value of X?

[ripper234]

Could someone please explain why bitcoinpeak.org says $112.25 and not ~$266?

I mean, it's obviously only taking the last X days into account, but what is the value of X?

Yeah, I noticed the problem this week, not sure why it's behaving this way.
It doesn't just take the last X days ... it showed $32 right before the recent peek.

My guess is that the data feed I'm getting is faulty in some way.

Planning to debug it this weekend.

[ripper234]

Issue resolved.

The problem was caused by BitcoinCharts API returning only 20,000 records instead of the full range (I don't know if this is documented or not).

I modified the app to save a daily snapshot of the peak price into a database, and take the max of bitcoincharts data and the previous day's peak.

Thanks again for reporting!

[Cyberdyne]

Issue resolved.

The problem was caused by BitcoinCharts API returning only 20,000 records instead of the full range (I don't know if this is documented or not).

I modified the app to save a daily snapshot of the peak price into a database, and take the max of bitcoincharts data and the previous day's peak.

Thanks again for reporting!

Was the exact peak 266.00 or did you just put that in there manually? I seem to recall it being something like 265.95 but I could be wrong.

[Meni Rosenfeld]

Issue resolved.

The problem was caused by BitcoinCharts API returning only 20,000 records instead of the full range (I don't know if this is documented or not).

I modified the app to save a daily snapshot of the peak price into a database, and take the max of bitcoincharts data and the previous day's peak.

Thanks again for reporting!

Was the exact peak 266.00 or did you just put that in there manually? I seem to recall it being something like 265.95 but I could be wrong.

According to the data in bitcoincharts.com it was exactly 266.

[K1773R]

Issue resolved.

The problem was caused by BitcoinCharts API returning only 20,000 records instead of the full range (I don't know if this is documented or not).

I modified the app to save a daily snapshot of the peak price into a database, and take the max of bitcoincharts data and the previous day's peak.

Thanks again for reporting!

Was the exact peak 266.00 or did you just put that in there manually? I seem to recall it being something like 265.95 but I could be wrong.

According to the data in bitcoincharts.com it was exactly 266.

rounding

[ripper234]

I entered it manually, if anyone has an authoritative source for the exact peak, please let me know.

[ripper234]

I entered it manually, if anyone has an authoritative source for the exact peak, please let me know.

why don't you just write a simple program to catch the streaming ticker last price and compare it, then change the value.

I guess I might miss a momentary pick this way (if it peaks between 2 consecutive reads).

Anyway, the current design works, I don't have time to change it (pull requests welcome if they improve the product).

[runeks]

Here's the authoritative source for the $266 peak, Mt. Gox' own data: https://data.mtgox.com/api/1/BTCUSD/trades?since=1365596104182691

Four trades were executed at that price:

Code:

{"date":1365597112,"price":"266","amount":"2.89855634","price_int":"26600000","amount_int":"289855634","tid":"1365597112268682","price_currency":"USD","item":"BTC","trade_type":"bid","primary":"Y","properties":"market"}

{"date":1365597288,"price":"266","amount":"9.42711773","price_int":"26600000","amount_int":"942711773","tid":"1365597288625945","price_currency":"USD","item":"BTC","trade_type":"bid","primary":"Y","properties":"market"}

{"date":1365597288,"price":"266","amount":"0.91906947","price_int":"26600000","amount_int":"91906947","tid":"1365597288780532","price_currency":"USD","item":"BTC","trade_type":"bid","primary":"Y","properties":"market"}

{"date":1365597964,"price":"266","amount":"7.94166141","price_int":"26600000","amount_int":"794166141","tid":"1365597964844406","price_currency":"USD","item":"BTC","trade_type":"bid","primary":"Y","properties":"market"}

For a total of 21.18640495 BTC ($5635.58).

[ripper234]

Crap, I checked the service yesterday and it worked ... but now it shows 0 USD peak price for some reason.
I don't have time to debug it right now ... and we're approaching a new all time peak.