Do you see any attacks that I haven't thought of?
Would it be in the swap space somewhere unencrypted?
Yes, that's true. That should be mentioned. I don't use swap for that reason myself.
But some footnotes:
- If Bitcoin is implemented properly, it wouldn't store keys in swappable memory.
- Swap should be encrypted anyway - but that makes hibernation more difficult.