Bitcoin Forum
July 05, 2024, 02:42:42 PM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: Typo in key.h  (Read 849 times)
Blinken (OP)
Sr. Member
****
Offline Offline

Activity: 338
Merit: 253



View Profile
March 16, 2017, 05:02:27 AM
 #1

In the bitcoin core file key.h there is a typo:

//! Check whether the 32-byte array pointed to be vch is valid keydata.
     bool static Check(const unsigned char* vch);

The comment should read:

//! Check whether the 32-byte array pointed to by vch is valid keydata.

I am not registered so I cannot submit bugs. Maybe somebody who works with the code base can fix it.


Bitcoin ♦♦♦ Trust in Mathematics, Not Bankers ♦♦♦
achow101
Moderator
Legendary
*
expert
Offline Offline

Activity: 3444
Merit: 6746


Just writing some code


View Profile WWW
March 16, 2017, 06:40:20 AM
 #2

Typos, especially just comment typos, are generally very low priority and don't need their own pull requests for every single typo, especially one character ones like this. These are usually batched into big "typo fix" PRs. There really isn't any need to fix typos anyways, the comments are generally understandable.

gmaxwell
Moderator
Legendary
*
expert
Offline Offline

Activity: 4200
Merit: 8442



View Profile WWW
March 16, 2017, 06:52:57 AM
Merited by ABCbits (1)
 #3

In the bitcoin core file key.h there is a typo:

//! Check whether the 32-byte array pointed to be vch is valid keydata.
     bool static Check(const unsigned char* vch);

The comment should read:

//! Check whether the 32-byte array pointed to by vch is valid keydata.

I am not registered so I cannot submit bugs. Maybe somebody who works with the code base can fix it.




Thanks for pointing this out-- only takes a second to register on github... but if you don't it'll get picked up eventually.

Please feel free to report any other issues you find (though best on github!)
Carlton Banks
Legendary
*
Offline Offline

Activity: 3430
Merit: 3074



View Profile
March 16, 2017, 07:06:22 AM
 #4

I am not registered so I cannot submit bugs.

There is an error in this sentence. Bugs cannot be submitted to github repositories, but bug reports can be submitted.


Please correct your error, others reading may be confused by the lack of clarity. Sorry if this seems nitpicky.

Vires in numeris
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!