Bitcoin Forum
November 13, 2024, 05:59:20 PM *
News: Latest Bitcoin Core release: 28.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: Terrible decision by Electrum Devs to remove Bip39 Checksum  (Read 324 times)
jonald_fyookball (OP)
Legendary
*
Offline Offline

Activity: 1302
Merit: 1008


Core dev leaves me neg feedback #abuse #political


View Profile
August 20, 2017, 05:26:02 AM
 #1

The latest codebase does not enforce bip39 checksum.  I think this is a really bad decision.

What this means:

If you import a seed from another wallet like jaxx, Electrum used to not let you import
it unless it was a valid bip39 seed.  Now, they simply give you a warning.

That means people can think they are importing the right seed and get different
addresses.  Really bad, someone is going to lose money.  I strongly recommend
going back to the old way.

They have their reasons for this but i dont agree. 

pooya87
Legendary
*
Offline Offline

Activity: 3626
Merit: 11031


Crypto Swap Exchange


View Profile
August 21, 2017, 04:30:23 AM
 #2

you don't need to copy paste what you have already said on github here too. and it is already answered there by ecdsa https://github.com/spesmilo/electrum/commit/8b194cd409a1a79e616578a5eaf91cba68b36dab#commitcomment-23752528

and i think he is pointing to this commit: https://github.com/spesmilo/electrum/commit/c6e09a60388325050410101e78fb72f43aaa525b

█▀▀▀











█▄▄▄
▀▀▀▀▀▀▀▀▀▀▀
e
▄▄▄▄▄▄▄▄▄▄▄
█████████████
████████████▄███
██▐███████▄█████▀
█████████▄████▀
███▐████▄███▀
████▐██████▀
█████▀█████
███████████▄
████████████▄
██▄█████▀█████▄
▄█████████▀█████▀
███████████▀██▀
████▀█████████
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
c.h.
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
▀▀▀█











▄▄▄█
▄██████▄▄▄
█████████████▄▄
███████████████
███████████████
███████████████
███████████████
███░░█████████
███▌▐█████████
█████████████
███████████▀
██████████▀
████████▀
▀██▀▀
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!