Rahar02
|
|
September 02, 2017, 09:48:37 AM |
|
A trading bot is a good hand to help someone execute orders in order to do not miss the chance to buy and sell, especially this is a free trading bot. But, too many people claim being scammed or give bad rating to Poloniex, many people have withdraw their funds out of this exchange. Few months ago, Poloniex is a recommended trading platforms, they have the biggest trading volume, but look at it right now, drastically declined.
|
|
|
|
klaaas
|
|
September 02, 2017, 11:44:22 AM |
|
I liked you made it opensource so we all can benefit from it and verify the code. Thank you, will check it out.
|
|
|
|
MrCrank
|
|
September 02, 2017, 11:46:51 AM |
|
Good job! Friendly and easy UI. What strategy use your bot? Could you post details about your algorithm. I learning how to create bot now..
|
|
|
|
osmanadak (OP)
Newbie
Offline
Activity: 59
Merit: 0
|
|
September 02, 2017, 01:45:21 PM |
|
Firstly I want to say the site is beautiful and simple, congratulations.
Also I think you've got a great setup here, I really like it. The script seems easy to read so far.
On looking at a few files, like login.php, I noticed this was in there...
$dbh->prepare('SELECT * FROM users WHERE username = "'.$_POST['username'].'" AND password = "'.$password.'"');
I could be wrong but I would have thought this is actually dangerous for SQL injection as someone can put anything they like into $_POST['username'] bit since it's in the statement area of the prepare bit?
I have to admit, I haven't checked if $dbh is actually your own custom rolled mysqli object but even it if was it still seems dangerous. I.e. I use '?' and bind parameters to prevent this issue... not a major issue at all given people would need to know the trading bot server to attack in the first place but if you decided to release it as a paid-for-service I expect this needs changing to keep users safe.
Making it open source is a great idea too, I can see people wanting to include things like SMS alerts and other exchanges for you.
Thank you for comment. Users install it to their server. So it can be close system. But i am open for suggestions for SQL injection
|
|
|
|
osmanadak (OP)
Newbie
Offline
Activity: 59
Merit: 0
|
|
September 02, 2017, 01:46:29 PM |
|
Good job! Friendly and easy UI. What strategy use your bot? Could you post details about your algorithm. I learning how to create bot now..
There is not a strategy. You have to create a strategy and create it as a rule
|
|
|
|
J. Cooper
Full Member
Offline
Activity: 294
Merit: 125
Alea iacta est
|
|
September 02, 2017, 02:09:47 PM |
|
Let's do a simple thinking exercise. If there truly was some sort of bot that only made profitable trades and never ever made a loss. In that case their creator/owner should surely be the worlds richest man right now. Now if that bot would be free of charge then everybody would be able to benefit from it, right? That implies that everyone must be rich by now? This scenario isn't anywhere near the reality. There are no free trading bots that are good.
|
|
|
|
osmanadak (OP)
Newbie
Offline
Activity: 59
Merit: 0
|
|
September 02, 2017, 02:54:54 PM |
|
Let's do a simple thinking exercise. If there truly was some sort of bot that only made profitable trades and never ever made a loss. In that case their creator/owner should surely be the worlds richest man right now. Now if that bot would be free of charge then everybody would be able to benefit from it, right? That implies that everyone must be rich by now? This scenario isn't anywhere near the reality. There are no free trading bots that are good.
But this bot gives you trading property automatically. Never guarantee profit. If your rules are good you would always get profit. İf your rules are bad, you would lose.
|
|
|
|
osmanadak (OP)
Newbie
Offline
Activity: 59
Merit: 0
|
|
September 03, 2017, 06:25:36 PM |
|
Did anyone tried the bot friends? Waiting for comments
|
|
|
|
osmanadak (OP)
Newbie
Offline
Activity: 59
Merit: 0
|
|
September 04, 2017, 12:37:46 PM |
|
Git updated
|
|
|
|
Bobby_Atlas
Full Member
Offline
Activity: 132
Merit: 100
Walking alone in the darkness
|
|
September 05, 2017, 01:12:40 AM |
|
Did anyone tried the bot friends? Waiting for comments
i'm in process, will provide feedback soon
|
|
|
|
osmanadak (OP)
Newbie
Offline
Activity: 59
Merit: 0
|
|
September 06, 2017, 08:35:05 AM |
|
Did anyone tried the bot friends? Waiting for comments
i'm in process, will provide feedback soon I am waiting for comments
|
|
|
|
eternalgloom
Legendary
Offline
Activity: 1792
Merit: 1283
|
|
September 06, 2017, 11:49:21 AM |
|
Thanks for making this, I've been running it from my local server for about 2 days now and I've also made a small profit. I would also really like to see a Bittrex version of this, any updates on that?
If you want, I can give you a small donation with Paypal?
|
|
|
|
osmanadak (OP)
Newbie
Offline
Activity: 59
Merit: 0
|
|
September 06, 2017, 07:22:51 PM |
|
Thanks for making this, I've been running it from my local server for about 2 days now and I've also made a small profit. I would also really like to see a Bittrex version of this, any updates on that?
If you want, I can give you a small donation with Paypal?
I am really happy that you are glad to use bot. If you want to donate my btc wallet address is 1PavtWu59TUeaJfxdU7XkXBpbgTRLsu4Za Thank you
|
|
|
|
Vargum
Full Member
Offline
Activity: 322
Merit: 100
WPP ENERGY - BACKED ASSET GREEN ENERGY TOKEN
|
|
September 07, 2017, 04:46:07 AM |
|
Guys, I recently started trading on the Polonex and Bittrex exchanges. About trading bots, of course, I heard, but did not try. Your, in my opinion, the design is cool, and in my work I think that it will prove itself! I want to try it in the future! Thanks for the useful information! Smiley
|
﹏﹏﹋﹌﹌ WPP ENERGY ﹌﹌﹋﹏﹏
☆═══━┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈━═══☆
≈ WORLD POWER PRODUCTION ≈ █ █ █
|
|
|
VTOS.IO
|
|
September 07, 2017, 12:55:32 PM |
|
Seems a very excellent project maybe i will try for me in the future
|
|
|
|
s2
|
|
September 07, 2017, 04:33:10 PM |
|
I'm not clear on what the rules actually translate to. Are you able to share an example of the rules we'd need to setup to do for the following?
If owning BTC, if the profit rises by 2% (from your last tx) sell everything (ideally when it starts decreasing again). If it drops by 5% sell everything.
If not owning BTC, if the price drops by 2% (from your last tx) and now starting to rise back above 2% buy as much as you can. If the price rises by 5% buy back as much as you can.
I.e. a set of rules to earn value from volatility rather than immediate price climbs/drops.
Also, any way to do regression testing with it?
|
|
|
|
wumBowo
|
|
September 07, 2017, 04:55:13 PM |
|
Can we use this directly on bittrex with putting our API key on it ? or is there something we need to change ?
|
Tozex | | ● ● ● ● ● ● ●
| | | | ● ● ● ● ● ● ●
| | Powered by,
|
|
|
|
orarider
|
|
September 07, 2017, 05:16:19 PM |
|
Recently, I frequently see similar posts on this forum, it made me feel ridiculous. I will never believe in such things.
|
|
|
|
ronajon
Newbie
Offline
Activity: 29
Merit: 0
|
|
September 07, 2017, 07:42:25 PM |
|
sounds interesting, will give it a try. can i use it as a testing demo on my local server ?
|
|
|
|
s2
|
|
September 08, 2017, 12:21:13 PM |
|
$dbh->prepare('SELECT * FROM users WHERE username = "'.$_POST['username'].'" AND password = "'.$password.'"');
Thank you for comment. Users install it to their server. So it can be close system. But i am open for suggestions for SQL injection I believe in PHP you can use '?' in the prepare statement part and later user bind to assign either a string or integer to each item. For instance your line would become $select = $dbh->prepare('SELECT * FROM users WHERE username = ? AND password = ?); if (!$select->bind_param ("ss", $_POST['username'], $_POST['password'] ) do_error_handling_and_exit(); if (!$select->execute ()) do_error_handling_and_exit();
|
|
|
|
|