Bitcoin Forum
May 10, 2024, 08:23:08 AM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Bitcoin Forum > Bitcoin > Development & Technical Discussion > Bitcoin client svn: Problems closing dialogs (osx, wxwidgets svn) patch proposed
Pages: [1]
« previous topic next topic »
  Print  
Author Topic: Bitcoin client svn: Problems closing dialogs (osx, wxwidgets svn) patch proposed  (Read 1171 times)
piotrp (OP)
Newbie
*
Offline Offline

Activity: 1
Merit: 0


View Profile
December 17, 2010, 03:16:38 PM
 #1
I've compiled the bitcoin client from svn using, compiled against wxwidgets svn.

I can't close the "about" dialog and the "options" dialog. I've replaced the Close() calls with EndModal(false) to fix it.

patch supplied as attachment, added .cpp extension as I'm not allowed to upload .diff files :S

details:
Mac OSX 10.6.5 i386
wxwidgets from svn revision 66398
bitcoin revision 204
1715329388
Hero Member
*
Offline Offline

Posts: 1715329388

View Profile Personal Message (Offline)

Ignore
1715329388
1715329388
Reply with quote  #2
1715329388
Report to moderator
How can the Bitcoin system be changed?
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
1715329388
Hero Member
*
Offline Offline

Posts: 1715329388

View Profile Personal Message (Offline)

Ignore
1715329388
1715329388
Reply with quote  #2
1715329388
Report to moderator
Gavin Andresen
Legendary
*
qt
Offline Offline

Activity: 1652
Merit: 2216


Chief Scientist


View Profile WWW
December 17, 2010, 05:11:25 PM
 #2
Works nicely on Linux, and is the recommended way to close dialogs.

Anybody able to give it a quick compile and test on Windows?
How often do you get the chance to work on a potentially world-changing project?
Gavin Andresen
Legendary
*
qt
Offline Offline

Activity: 1652
Merit: 2216


Chief Scientist


View Profile WWW
December 20, 2010, 03:49:36 PM
 #3
Anybody have a chance to compile/test this on Windows?

I created an Official Pull Request for this, which I will accept and apply unless I hear objections today:
  https://github.com/bitcoin/bitcoin/pull/9
How often do you get the chance to work on a potentially world-changing project?
Pages: [1]
  Print  
Bitcoin Forum > Bitcoin > Development & Technical Discussion > Bitcoin client svn: Problems closing dialogs (osx, wxwidgets svn) patch proposed
 « previous topic next topic »
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!