Bitcoin Forum
December 02, 2016, 10:29:36 PM *
News: To be able to use the next phase of the beta forum software, please ensure that your email address is correct/functional.
 
   Home   Help Search Donate Login Register  
Pages: [1]
  Print  
Author Topic: Bitcoin client svn: Problems closing dialogs (osx, wxwidgets svn) patch proposed  (Read 959 times)
piotrp
Newbie
*
Offline Offline

Activity: 1


View Profile
December 17, 2010, 03:16:38 PM
 #1

I've compiled the bitcoin client from svn using, compiled against wxwidgets svn.

I can't close the "about" dialog and the "options" dialog. I've replaced the Close() calls with EndModal(false) to fix it.

patch supplied as attachment, added .cpp extension as I'm not allowed to upload .diff files :S

details:
Mac OSX 10.6.5 i386
wxwidgets from svn revision 66398
bitcoin revision 204
1480717776
Hero Member
*
Offline Offline

Posts: 1480717776

View Profile Personal Message (Offline)

Ignore
1480717776
Reply with quote  #2

1480717776
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
Gavin Andresen
Legendary
*
qt
Offline Offline

Activity: 1652


Chief Scientist


View Profile WWW
December 17, 2010, 05:11:25 PM
 #2

Works nicely on Linux, and is the recommended way to close dialogs.

Anybody able to give it a quick compile and test on Windows?

How often do you get the chance to work on a potentially world-changing project?
Gavin Andresen
Legendary
*
qt
Offline Offline

Activity: 1652


Chief Scientist


View Profile WWW
December 20, 2010, 03:49:36 PM
 #3

Anybody have a chance to compile/test this on Windows?

I created an Official Pull Request for this, which I will accept and apply unless I hear objections today:
  https://github.com/bitcoin/bitcoin/pull/9

How often do you get the chance to work on a potentially world-changing project?
Pages: [1]
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!