mercSuey
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 10:00:29 PM |
|
// miner's coin base reward based on nBits int64 GetProofOfWorkReward(unsigned int nHeight) { int64 nSubsidy = 0 * COIN;
if (nHeight > 0) { nSubsidy = 10 * COIN; // 500,000 coins } else if (nHeight > 50000) { nSubsidy = 5 * COIN; // 250,000 coins } else if (nHeight > 100000) { nSubsidy = 2.5 * COIN; // 125,000 coins } else if (nHeight > 150000) { nSubsidy = 1.25 * COIN; // 62,500 coins } else if (nHeight > 200000) { nSubsidy = 0.75 * COIN; // 37,500 coins } else if (nHeight > 250000) { nSubsidy = 0.375 * COIN; // 18,750 coins } else if (nHeight > 300000) { nSubsidy = 0.1875 * COIN; // 9,375 coins } else if (nHeight > 333334) { nSubsidy = 0.01 * COIN; // 5256 coins per year roughly 0.053% yearly inflation }
return nSubsidy; } That should be more like: // miner's coin base reward based on nBits int64 GetProofOfWorkReward(unsigned int nHeight) { int64 nSubsidy = 0 * COIN;
if (nHeight > 0) { nSubsidy = 10 * COIN; // 500,000 coins } if (nHeight > 50000) { nSubsidy = 5 * COIN; // 250,000 coins } if (nHeight > 100000) { nSubsidy = 2.5 * COIN; // 125,000 coins } if (nHeight > 150000) { nSubsidy = 1.25 * COIN; // 62,500 coins } if (nHeight > 200000) { nSubsidy = 0.75 * COIN; // 37,500 coins } if (nHeight > 250000) { nSubsidy = 0.375 * COIN; // 18,750 coins } if (nHeight > 300000) { nSubsidy = 0.1875 * COIN; // 9,375 coins } if (nHeight > 333334) { nSubsidy = 0.01 * COIN; // 5256 coins per year roughly 0.053% yearly inflation }
return nSubsidy; } Using else if is what caused it not to hard fork with a reduced subsidy because the first condition is always going to be true so there is never going to be an else. Your code would work, but it's not good because you'll get a true then a true every time. Instead is better to have first if statement as less than 50,000...then next else if as less than 100,000, etc.
|
|
|
|
Petr1fied
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 10:12:43 PM |
|
// miner's coin base reward based on nBits int64 GetProofOfWorkReward(unsigned int nHeight) { int64 nSubsidy = 0 * COIN;
if (nHeight > 0) { nSubsidy = 10 * COIN; // 500,000 coins } else if (nHeight > 50000) { nSubsidy = 5 * COIN; // 250,000 coins } else if (nHeight > 100000) { nSubsidy = 2.5 * COIN; // 125,000 coins } else if (nHeight > 150000) { nSubsidy = 1.25 * COIN; // 62,500 coins } else if (nHeight > 200000) { nSubsidy = 0.75 * COIN; // 37,500 coins } else if (nHeight > 250000) { nSubsidy = 0.375 * COIN; // 18,750 coins } else if (nHeight > 300000) { nSubsidy = 0.1875 * COIN; // 9,375 coins } else if (nHeight > 333334) { nSubsidy = 0.01 * COIN; // 5256 coins per year roughly 0.053% yearly inflation }
return nSubsidy; } That should be more like: // miner's coin base reward based on nBits int64 GetProofOfWorkReward(unsigned int nHeight) { int64 nSubsidy = 0 * COIN;
if (nHeight > 0) { nSubsidy = 10 * COIN; // 500,000 coins } if (nHeight > 50000) { nSubsidy = 5 * COIN; // 250,000 coins } if (nHeight > 100000) { nSubsidy = 2.5 * COIN; // 125,000 coins } if (nHeight > 150000) { nSubsidy = 1.25 * COIN; // 62,500 coins } if (nHeight > 200000) { nSubsidy = 0.75 * COIN; // 37,500 coins } if (nHeight > 250000) { nSubsidy = 0.375 * COIN; // 18,750 coins } if (nHeight > 300000) { nSubsidy = 0.1875 * COIN; // 9,375 coins } if (nHeight > 333334) { nSubsidy = 0.01 * COIN; // 5256 coins per year roughly 0.053% yearly inflation }
return nSubsidy; } Using else if is what caused it not to hard fork with a reduced subsidy because the first condition is always going to be true so there is never going to be an else. Your code would work, but it's not good because you'll get a true then a true every time. Instead is better to have first if statement as less than 50,000...then next else if as less than 100,000, etc. I wouldn't have written it like that myself, just using the original code as a template. It may be better using something like: // miner's coin base reward based on nBits int64 GetProofOfWorkReward(unsigned int nHeight) { int64 nSubsidy = 0 * COIN;
if (nHeight > 0 && nHeight < 50000) { nSubsidy = 10 * COIN; // 500,000 coins } else if (nHeight >= 50000 && nHeight < 100000) { nSubsidy = 5 * COIN; // 250,000 coins } else if (nHeight >= 100000 && nHeight < 150000) { nSubsidy = 2.5 * COIN; // 125,000 coins } else if (nHeight >= 150000 && nHeight < 200000) { nSubsidy = 1.25 * COIN; // 62,500 coins } else if (nHeight >= 200000 && nHeight < 250000) { nSubsidy = 0.75 * COIN; // 37,500 coins } else if (nHeight >= 250000 && nHeight < 300000) { nSubsidy = 0.375 * COIN; // 18,750 coins } else if (nHeight >= 300000 && nHeight < 333334) { nSubsidy = 0.1875 * COIN; // 9,375 coins } else { nSubsidy = 0.01 * COIN; // 5256 coins per year roughly 0.053% yearly inflation }
return nSubsidy; } Obviously block 50,000 can't be used anymore but something similar to the above is specifying the exact range of the blocks so not causing a true outcome overridden by another true outcome
|
|
|
|
DimaziK
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 10:54:21 PM |
|
Developers! When there will be a reduction of an award for the block?
|
|
|
|
2Kool4Skewl
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 11:04:43 PM |
|
The code should have been:
if((nHeight>0)&&(nHeight<=50000)) nSubsidy=10*COIN; // 500,000 coins else if((nHeight>50000)&&(nHeight<=100000)) nSubsidy=5*COIN; // 250,000 coins else if((nHeight>100000)&&(nHeight<=150000)) nSubsidy=2.5*COIN; // 125,000 coins else if((nHeight>150000)&&(nHeight<=200000)) nSubsidy=1.25*COIN; // 62,500 coins else if((nHeight>200000)&&(nHeight<=250000)) nSubsidy=0.75*COIN; // 37,500 coins else if((nHeight>250000)&&(nHeight<=300000)) nSubsidy=0.375*COIN; // 18,750 coins else if((nHeight>300000)&&(nHeight<=333334)) nSubsidy=0.1875*COIN; // 9,375 coins else if(nHeight>333334) nSubsidy = 0.01
I agree with mercSuey about how this should be fixed.
"New fix: 55K blocks @ 10 = 550,000 (up to block 55,000) 40k blocks @ 5 = 200,000 (up to block 95,000) 750K coins"
|
|
|
|
2Kool4Skewl
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 11:07:09 PM |
|
Oh wait... Petr1fied already posted the correct code. lol ![Smiley](https://bitcointalk.org/Smileys/default/smiley.gif)
|
|
|
|
DimaziK
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 11:07:40 PM |
|
"New fix: 51K blocks @ 10 = 510,000 (up to block 51,000) 48k blocks @ 5 = 240,000 (up to block 99,000) 750K coins"
|
|
|
|
2Kool4Skewl
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 11:09:02 PM |
|
"New fix: 51K blocks @ 10 = 510,000 (up to block 51,000) 48k blocks @ 5 = 240,000 (up to block 99,000) 750K coins"
Only, 1k more blocks? That doesn't give me enough time to get more CGB! ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif)
|
|
|
|
mercSuey
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 11:42:19 PM |
|
I posted above guys, block reward will half at block 55000 to give pool ops and exchanges, etc enough time to update client. But instead of block rewards halving again at block 100,000, it will have at 95000. So at the second halving of block rewards there will be 750K total coins just as with the previous halving schedule.
New fix: 55K blocks @ 10 = 550,000 (up to block 55,000) 40k blocks @ 5 = 200,000 (up to block 95,000) 750K total coins at block 95000
All is well that ends well...
|
|
|
|
sharkbyte093
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
July 31, 2013, 11:57:54 PM |
|
I was a little bored today, ended up messing around with photoshop & a modeling program. Came up with this: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FngQ2VWs.png&t=665&c=3PgIFMjdGGrOJw) I'm not sure if you're looking for a new logo, but if you are, I can fiddle a bit more when I've got some free time. Repost from other CGB thread.
|
|
|
|
mercSuey
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 12:26:15 AM |
|
I was a little bored today, ended up messing around with photoshop & a modeling program. Came up with this: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FngQ2VWs.png&t=665&c=3PgIFMjdGGrOJw) I'm not sure if you're looking for a new logo, but if you are, I can fiddle a bit more when I've got some free time. Repost from other CGB thread. Can you make the C larger just a tad? You picked the right color, that's the main color of the CGB website in development. ![Wink](https://bitcointalk.org/Smileys/default/wink.gif)
|
|
|
|
sharkbyte093
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 01:29:29 AM |
|
As requested:Enlarged C: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FN2EbiFN.png&t=665&c=R6Gw8WwTtufdGg) Inverted Colors: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FQycdavI.png&t=665&c=BQW7bSXmiE9itw)
|
|
|
|
Ghepetto
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 01:36:49 AM |
|
As requested:Enlarged C: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FN2EbiFN.png&t=665&c=R6Gw8WwTtufdGg) Inverted Colors: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FQycdavI.png&t=665&c=BQW7bSXmiE9itw) love the concept but the image needs to be sharpened up imho, ice is sharp
|
--------------------Bagholder Extraordinaire--------------------
|
|
|
mercSuey
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 06:40:18 AM |
|
As requested:Enlarged C: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FN2EbiFN.png&t=665&c=R6Gw8WwTtufdGg) Inverted Colors: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FQycdavI.png&t=665&c=BQW7bSXmiE9itw) love the concept but the image needs to be sharpened up imho, ice is sharp yeah, I think you're trying to go with the frost texture but it's just quite not working...how about a polished/shiny texture? Looking good so far!
|
|
|
|
mercSuey
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 06:44:56 AM |
|
As requested:Enlarged C: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FN2EbiFN.png&t=665&c=R6Gw8WwTtufdGg) Inverted Colors: ![](https://ip.bitcointalk.org/?u=https%3A%2F%2Fi.imgur.com%2FQycdavI.png&t=665&c=BQW7bSXmiE9itw) love the concept but the image needs to be sharpened up imho, ice is sharp yeah, I think you're trying to go with the frost texture but it's just quite not working...how about a polished/shiny texture? Looking good so far! We have outsourced some of our logo/design work but more options is good! By the way, client update imminent.
|
|
|
|
|
elambert (OP)
Legendary
Offline
Activity: 1696
Merit: 1008
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 09:56:51 AM |
|
August 1, 2013 Update:
Yesterday was truly an interesting day for CGB and the crypto community! The subsidy halving set to take place at 50k blocks did not occur due to an oversight in the code. The CGB team has responded, identified the issue and made the necessary corrections. The subsidy halving will now take place at block 55k. It is imperative that everyone download the latest client BEFORE block 55k. We apologize for the inconvenience and appreciate your continued support. Please be prepared for some additional major announcements coming for CGB!
Please download the updated client on OP.
|
|
|
|
elambert (OP)
Legendary
Offline
Activity: 1696
Merit: 1008
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 01:25:14 PM |
|
August 1, 2013 Update:
Yesterday was truly an interesting day for CGB and the crypto community! The subsidy halving set to take place at 50k blocks did not occur due to an oversight in the code. The CGB team has responded, identified the issue and made the necessary corrections. The subsidy halving will now take place at block 55k. It is imperative that everyone download the latest client BEFORE block 55k. We apologize for the inconvenience and appreciate your continued support. Please be prepared for some additional major announcements coming for CGB!
Please download the updated client on OP.
Mac wallet also updated on OP. Thank you Maxpower!!!
|
|
|
|
BTCat
Legendary
Offline
Activity: 1960
Merit: 1010
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 01:25:53 PM |
|
Why not make a bullion like the silver/gold bullions, it's different from all the other coins and can easier look more interesting. Shiny glimmer that represents a high value. Elambert posted this earlier (for website example) which could be awesome: http://commons.wikimedia.org/wiki/File:Johnson_Matthey_500_grammes_silver_bullion.jpgThe above posted blue/white logo does not look representable and recognizable at all. It's too simplistic with just a C in it and does not shine.
|
|
|
|
BTCat
Legendary
Offline
Activity: 1960
Merit: 1010
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 08:21:12 PM |
|
Everyone here please take a moment to vote for CGB in the poll as favorite coin. Right now there is 10 votes which is already above average for the new coins but if we can get a real big number together it will sure draw some extra attention https://bitcointalk.org/index.php?topic=264016.0
|
|
|
|
Lauda
Legendary
Offline
Activity: 2674
Merit: 2965
Terminated.
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
August 01, 2013, 08:23:04 PM |
|
Wow the new logo that someone posted above is impressive!
|
"The Times 03/Jan/2009 Chancellor on brink of second bailout for banks" 😼 Bitcoin Core ( onion)
|
|
|
|