0.96.4 RC2

[goatpig]

Binaries:

https://github.com/goatpig/BitcoinArmory/releases/tag/v0.96.3.991

Notes:
This is mostly fixes, notably:
   - All things RBF
   - Unsigned tx creation with a mix of P2SH and P2PKH outputs
   - Some lockbox signing issues

Also, the auto fee GUI has been updated to use the reworked estimatesmartfee method from Core 0.15. People using older nodes won't see that change.

Test away =D

[1715142440]

1715142440

[1715142440]

1715142440

[PhoenixFire]

Thanks, Goatpig. Grabbed the installer for Win64.

Got an error about write permissions for a log file in Armory's install dir, then ran as admin to allow that to work.
Got a fatal error at that point:

Code:

Traceback (most recent call last):
  File "ArmoryQt.py", line 38, in <module>
  File "psutil\__init__.pyc", line 139, in <module>
  File "psutil\_pswindows.pyc", line 16, in <module>
  File "psutil\_psutil_windows.pyc", line 12, in <module>
  File "psutil\_psutil_windows.pyc", line 10, in __load
ImportError: DLL load failed: The specified procedure could not be found.

I do have a (new?) file named "psutil._psutil_windows.pyd" - no similar problem with RC1.

[goatpig]

I have no issues running this on my machine. I'll to investigate on another setup. I'm for the new year's weekend so that may have to wait till 2018 =O

[droark]

Thanks, Goatpig. Grabbed the installer for Win64.

Got an error about write permissions for a log file in Armory's install dir, then ran as admin to allow that to work.
Got a fatal error at that point:

Code:

Traceback (most recent call last):
  File "ArmoryQt.py", line 38, in <module>
  File "psutil\__init__.pyc", line 139, in <module>
  File "psutil\_pswindows.pyc", line 16, in <module>
  File "psutil\_psutil_windows.pyc", line 12, in <module>
  File "psutil\_psutil_windows.pyc", line 10, in __load
ImportError: DLL load failed: The specified procedure could not be found.

I do have a (new?) file named "psutil._psutil_windows.pyd" - no similar problem with RC1.

Interesting. I took a quick peek at the commits between RC1 & RC2. Nothing jumped out at me immediately; I can't imagine why importing psutil would cause problems. I have a Windows VM and will try to install the binary a little later.

[PhoenixFire]

Strange... I've rolled back to RC1 for now which is still fine, so not the end of the world.
Did some digging, this could be relevant: https://github.com/giampaolo/psutil/issues/811 (I'm running Win7 so it shouldn't be the outdated OS side of the issue)
If I get desperate I'll try getting a Windows build env setup and giving that a whirl.

Have a happy new year, both of you!

[goatpig]

I can't sleep so ima setup a Win7 VM and see for myself.

[goatpig]

Fixed the Windows builds, should work now.

[idoB]

Armory 0.96.3.991(RC2)  hangs on splashscreen under Windows 10.

Reverting to 0.96.3.99 (RC1) - runs fine.

[goatpig]

Armory 0.96.3.991(RC2)  hangs on splashscreen under Windows 10.

Reverting to 0.96.3.99 (RC1) - runs fine.

Delete crypt32.dll and psapi.dll from the install folder and try to run it again.

[idoB]

Armory 0.96.3.991(RC2)  hangs on splashscreen under Windows 10.

Reverting to 0.96.3.99 (RC1) - runs fine.

Delete crypt32.dll and psapi.dll from the install folder and try to run it again.

Deleted - same result. Also no hint in log files that I could find.

[goatpig]

Did it create an ArmoryQt.exe.log? If not, run it with admin privilege, you should get the file.

[PhoenixFire]

Meant to report back on this.
I think Armory is hanging when starting the db process with with popen.

Code:

2017-12-29 19:09:36 (WARNING) -- SDM.pyc:396 - Spawning DB with command: ./ArmoryDB.exe --db-type="DB_FULL" --cookie --satoshi-datadir="L:\BC\blocks" --datadir="C:\Users\PhoenixFire\AppData\Roaming\Armory\" --dbdir="L:\ArmoryBC\databases"
2017-12-29 19:09:36 (INFO) -- ArmoryUtils.pyc:679 - Executing popen: ['./ArmoryDB.exe', '--db-type="DB_FULL"', '--cookie', u'--satoshi-datadir="L:\\BC\\blocks"', '--datadir="C:\\Users\\PhoenixFire\\AppData\\Roaming\\Armory\\"', u'--dbdir="L:\\ArmoryBC\\databases"']

Logs stops there and no DB process starts at all.

That said, I can spawn ArmoryDB manually like so:

Code:

start ArmoryDB.exe --db-type=\"DB_FULL\" --cookie --satoshi-datadir=\"L:\BC\blocks\" --datadir=\"C:\Users\PhoenixFire\AppData\Roaming\Armory\\\" --dbdir=\"L:\ArmoryBC\databases\"

And then run ArmoryQt and everything works fine. "start" not required, just a preference.


Edit: Got it to create the log in the install dir:

Code:

(ERROR) ArmoryUtils.pyc:3723 - Unsupported language  specified. Defaulting to English (en)
(WARNING) SDM.pyc:396 - Spawning DB with command: ./ArmoryDB.exe --db-type="DB_FULL" --cookie --satoshi-datadir="L:\BC\blocks" --datadir="C:\Users\PhoenixFire\AppData\Roaming\Armory\" --dbdir="L:\ArmoryBC\databases"
Exception WindowsError: (6, 'The handle is invalid') in <bound method Popen.__del__ of <subprocess_win.Popen object at 0x0000000004A5FEB8>> ignored

Edit2: I can start Qt, let it hang, then start ArmoryDB manually. Qt then wakes up and loads the wallets just fine.

[idoB]

Did it create an ArmoryQt.exe.log? If not, run it with admin privilege, you should get the file.

Yes, got the error in the install dir ArmoryQT.exe.log:

Code:

Exception WindowsError: (6, 'The handle is invalid') in <bound method Popen.__del__ of <subprocess_win.Popen object at 0x00000000044C8EF0>> ignored

[idoB]

Armory 0.96.3.991(RC2)  hangs on splashscreen under Windows 10.

Reverting to 0.96.3.99 (RC1) - runs fine.

Delete crypt32.dll and psapi.dll from the install folder and try to run it again.

Deleted - same result. Also no hint in log files that I could find.

Also verified that there is no need to delete the above two dlls.
To get RC2 running under windows 10, only need to run armorydb separately from the command prompt with the switches in the install-dir armoryqt.exe.log, and then run armoryqt RC2.

[alomar]

did you do something to make Coin Control work more reliably?  i still see that ccDlgGeometry line in the settings file but everything seems to work fine with this version!

[alomar]

sure enough, spoke too soon.  CoinControl freezing problem still prominent.  seems to always occur after first use.  ccDLGeometry keeps coming back too after deletion.

[goatpig]

Meant to report back on this.
I think Armory is hanging when starting the db process with with popen.

Also verified that there is no need to delete the above two dlls.
To get RC2 running under windows 10, only need to run armorydb separately from the command prompt with the switches in the install-dir armoryqt.exe.log, and then run armoryqt RC2.

Thanks for figuring it out, I'll look into it.

sure enough, spoke too soon.  CoinControl freezing problem still prominent.  seems to always occur after first use.  ccDLGeometry keeps coming back too after deletion.

What are the values in that field when you have to delete them?

[alomar]

Meant to report back on this.
I think Armory is hanging when starting the db process with with popen.

Also verified that there is no need to delete the above two dlls.
To get RC2 running under windows 10, only need to run armorydb separately from the command prompt with the switches in the install-dir armoryqt.exe.log, and then run armoryqt RC2.

Thanks for figuring it out, I'll look into it.

sure enough, spoke too soon.  CoinControl freezing problem still prominent.  seems to always occur after first use.  ccDLGeometry keeps coming back too after deletion.

What are the values in that field when you have to delete them?

01d9d0cb000100000000004100000018000004ff0000031f0000000000000000fffffffefffffff e000000000200

[dictatethepace]

Just a quick note to say i've had success with 0.96.4 RC2 on multiple platforms.

Compiled from source with armory_0.96.3.991_src.tar.gz on Ubuntu 16.04.3 LTS. Installed onto a clean machine with a full and updated Core node behind it.

Installed from pre-package armory_0.96.3.991-gcc4.7_amd64.deb on Ubuntu 14.04 LTS. An install onto a persistent USB over the top of the existing 0.95.1. Wallet conversion successful - running Offline, no Core database. Created some new Segwit addresses.

Historically I had been unable to move past 0.95.1 on MacOS (for TX Broadcast) and kept my offline signers at 0.95.1 to match. I used a standalone copy of Bitcoin-ABC / 0.96.1 to securely claim BCH back in August.

I wanted to create some Segwit addresses to transfer the main BTC holdings. I made various attempts at getting the latest versions working on MacOS (used for watch-wallets and to broadcast offline signed transactions). None of the pre-compiled OSX versions would work with the two Mac High Sierra versions I had locally - 10.12.6 and 10.13.2.

I tried rolling my own version on Mac without initial success.
Eventually it came down to uninstalling Xcode 8 completely, removing the brew installed python and then installing Xcode 7.3.1 from the Apple Developer Site, Python 2.7.14 from python.org. Downloaded armory_0.96.3.991_src and compiled the osxbuild, running smoothly and synced to a full Core node.

Happy to offer logs or advice to anyone else needing a hand with setup/compiling.
Probably about time I offer my thanks to goatpig and droark for continued work on the project (I've been using it since 2014!).

[goatpig]

Just a quick note to say i've had success with 0.96.4 RC2 on multiple platforms.

Compiled from source with armory_0.96.3.991_src.tar.gz on Ubuntu 16.04.3 LTS. Installed onto a clean machine with a full and updated Core node behind it.

Installed from pre-package armory_0.96.3.991-gcc4.7_amd64.deb on Ubuntu 14.04 LTS. An install onto a persistent USB over the top of the existing 0.95.1. Wallet conversion successful - running Offline, no Core database. Created some new Segwit addresses.

Historically I had been unable to move past 0.95.1 on MacOS (for TX Broadcast) and kept my offline signers at 0.95.1 to match. I used a standalone copy of Bitcoin-ABC / 0.96.1 to securely claim BCH back in August.

I wanted to create some Segwit addresses to transfer the main BTC holdings. I made various attempts at getting the latest versions working on MacOS (used for watch-wallets and to broadcast offline signed transactions). None of the pre-compiled OSX versions would work with the two Mac High Sierra versions I had locally - 10.12.6 and 10.13.2.

I tried rolling my own version on Mac without initial success.
Eventually it came down to uninstalling Xcode 8 completely, removing the brew installed python and then installing Xcode 7.3.1 from the Apple Developer Site, Python 2.7.14 from python.org. Downloaded armory_0.96.3.991_src and compiled the osxbuild, running smoothly and synced to a full Core node.

Happy to offer logs or advice to anyone else needing a hand with setup/compiling.
Probably about time I offer my thanks to goatpig and droark for continued work on the project (I've been using it since 2014!).

Maybe consider contributing to this PR, if anything, testing the new OSX build setup (once it congeals):

https://github.com/goatpig/BitcoinArmory/pull/403